scriptoriumadmin/Roo-Code
1
0
Fork 0
mirror of https://github.com/RooVetGit/Roo-Code.git synced 2026-10-07 02:58:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

fix: update manager.spec.ts mocks to include createEmbedder method

Browse source 
The PR changed _recreateServices() to call createEmbedder() separately
before createServices(), but existing test mocks did not include the
createEmbedder method, causing 5 test failures with
"this._serviceFactory.createEmbedder is not a function".
This commit is contained in:
Roo Code 2026-02-20 09:37:23 +00:00
parent b1b8bf3b92
commit 3b1f356757
1 changed files with 10 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
src/services/code-index/__tests__/manager.spec.ts
View file

@ -307,6 +307,7 @@ describe("CodeIndexManager - handleSettingsChange regression", () => {
// Mock service factory instance
mockServiceFactoryInstance = {
createEmbedder: vi.fn().mockReturnValue(mockEmbedder),
createServices: vi.fn().mockReturnValue({
embedder: mockEmbedder,
vectorStore: mockVectorStore,
@ -349,9 +350,9 @@ describe("CodeIndexManager - handleSettingsChange regression", () => {
await (manager as any)._recreateServices()
// Assert
expect(mockServiceFactoryInstance.createEmbedder).toHaveBeenCalled()
expect(mockServiceFactoryInstance.validateEmbedder).toHaveBeenCalledWith(mockEmbedder)
expect(mockServiceFactoryInstance.createServices).toHaveBeenCalled()
const createdEmbedder = mockServiceFactoryInstance.createServices.mock.results[0].value.embedder
expect(mockServiceFactoryInstance.validateEmbedder).toHaveBeenCalledWith(createdEmbedder)
expect(mockStateManager.setSystemState).not.toHaveBeenCalledWith("Error", expect.any(String))
})
@ -368,9 +369,8 @@ describe("CodeIndexManager - handleSettingsChange regression", () => {
)
// Assert other expectations
expect(mockServiceFactoryInstance.createServices).toHaveBeenCalled()
const createdEmbedder = mockServiceFactoryInstance.createServices.mock.results[0].value.embedder
expect(mockServiceFactoryInstance.validateEmbedder).toHaveBeenCalledWith(createdEmbedder)
expect(mockServiceFactoryInstance.createEmbedder).toHaveBeenCalled()
expect(mockServiceFactoryInstance.validateEmbedder).toHaveBeenCalledWith(mockEmbedder)
expect(mockStateManager.setSystemState).toHaveBeenCalledWith(
"Error",
"embeddings:validation.authenticationFailed",
@ -391,9 +391,8 @@ describe("CodeIndexManager - handleSettingsChange regression", () => {
)
// Assert other expectations
expect(mockServiceFactoryInstance.createServices).toHaveBeenCalled()
const createdEmbedder = mockServiceFactoryInstance.createServices.mock.results[0].value.embedder
expect(mockServiceFactoryInstance.validateEmbedder).toHaveBeenCalledWith(createdEmbedder)
expect(mockServiceFactoryInstance.createEmbedder).toHaveBeenCalled()
expect(mockServiceFactoryInstance.validateEmbedder).toHaveBeenCalledWith(mockEmbedder)
expect(mockStateManager.setSystemState).toHaveBeenCalledWith(
"Error",
"embeddings:validation.configurationError",
@ -401,8 +400,8 @@ describe("CodeIndexManager - handleSettingsChange regression", () => {
})
it("should handle embedder creation failure", async () => {
// Arrange
mockServiceFactoryInstance.createServices.mockImplementation(() => {
// Arrange - createEmbedder is now called before createServices
mockServiceFactoryInstance.createEmbedder.mockImplementation(() => {
throw new Error("Invalid configuration")
})
@ -500,6 +499,7 @@ describe("CodeIndexManager - handleSettingsChange regression", () => {
it("should allow re-initialization after recovery", async () => {
// Setup mock for re-initialization
const mockServiceFactoryInstance = {
createEmbedder: vi.fn().mockReturnValue({ embedderInfo: { name: "openai" } }),
createServices: vi.fn().mockReturnValue({
embedder: { embedderInfo: { name: "openai" } },
vectorStore: {},