scriptoriumadmin/Roo-Code
1
0
Fork 0
mirror of https://github.com/RooVetGit/Roo-Code.git synced 2026-09-07 08:26:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: ensure XML parser state matches tool protocol on config update (#9535)

Browse source
This commit is contained in:
Daniel 2025-11-24 10:01:29 -05:00 • committed by GitHub
parent becdb1ac1c
commit 3ac5bec3fc
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 11 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
src/core/task/Task.ts
View file

@ -1164,38 +1164,29 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
* @param newApiConfiguration - The new API configuration to use
*/
public async updateApiConfiguration(newApiConfiguration: ProviderSettings): Promise<void> {
// Determine the previous protocol before updating
const prevModelInfo = this.api.getModel().info
const previousProtocol = this.apiConfiguration
? resolveToolProtocol(this.apiConfiguration, prevModelInfo)
: undefined
// Update the configuration and rebuild the API handler
this.apiConfiguration = newApiConfiguration
this.api = buildApiHandler(newApiConfiguration)
// Determine the new tool protocol
const newModelInfo = this.api.getModel().info
const newProtocol = resolveToolProtocol(this.apiConfiguration, newModelInfo)
const shouldUseXmlParser = newProtocol === "xml"
// Determine what the tool protocol should be
const modelInfo = this.api.getModel().info
const protocol = resolveToolProtocol(this.apiConfiguration, modelInfo)
const shouldUseXmlParser = protocol === "xml"
// Only make changes if the protocol actually changed
if (previousProtocol === newProtocol) {
console.log(
`[Task#${this.taskId}.${this.instanceId}] Tool protocol unchanged (${newProtocol}), no parser update needed`,
)
// Ensure parser state matches protocol requirement
const parserStateCorrect =
(shouldUseXmlParser && this.assistantMessageParser) || (!shouldUseXmlParser && !this.assistantMessageParser)
if (parserStateCorrect) {
return
}
// Handle protocol transitions
// Fix parser state
if (shouldUseXmlParser && !this.assistantMessageParser) {
// Switching from native → XML: create parser
this.assistantMessageParser = new AssistantMessageParser()
console.log(`[Task#${this.taskId}.${this.instanceId}] Switched native → xml: initialized XML parser`)
} else if (!shouldUseXmlParser && this.assistantMessageParser) {
// Switching from XML → native: remove parser
this.assistantMessageParser.reset()
this.assistantMessageParser = undefined
console.log(`[Task#${this.taskId}.${this.instanceId}] Switched xml → native: removed XML parser`)
}
}