scriptoriumadmin/Roo-Code
1
0
Fork 0
mirror of https://github.com/RooVetGit/Roo-Code.git synced 2026-09-05 08:10:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

test: ensure Mistral tests always assert tool message existence

Browse source
This commit is contained in:
Roo Code 2026-01-22 23:34:27 +00:00
parent 916263396b
commit 367ec5f00d
1 changed files with 23 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

47
src/api/providers/__tests__/openai.spec.ts
View file

@ -1193,18 +1193,17 @@ describe("OpenAiHandler", () => {
const messages = callArgs.messages
const toolMessageIndex = messages.findIndex((m: any) => m.role === "tool")
if (toolMessageIndex !== -1) {
// The message after tool should be the next user message from a new request,
// not a user message with environment_details (which should be merged)
const nextMessage = messages[toolMessageIndex + 1]
// If there's a next message, it should not be a user message containing environment_details
if (nextMessage && nextMessage.role === "user") {
const content =
typeof nextMessage.content === "string"
? nextMessage.content
: JSON.stringify(nextMessage.content)
expect(content).not.toContain("environment_details")
}
// Assert tool message exists - test setup should always produce a tool message
expect(toolMessageIndex).not.toBe(-1)
// The message after tool should be the next user message from a new request,
// not a user message with environment_details (which should be merged)
const nextMessage = messages[toolMessageIndex + 1]
// If there's a next message, it should not be a user message containing environment_details
if (nextMessage && nextMessage.role === "user") {
const content =
typeof nextMessage.content === "string" ? nextMessage.content : JSON.stringify(nextMessage.content)
expect(content).not.toContain("environment_details")
}
})
@ -1242,10 +1241,10 @@ describe("OpenAiHandler", () => {
// Find the tool message and verify the tool_call_id is normalized
const toolMessage = callArgs.messages.find((m: any) => m.role === "tool")
if (toolMessage) {
// The ID should be normalized to 9 alphanumeric characters
expect(toolMessage.tool_call_id).toMatch(/^[a-zA-Z0-9]{9}$/)
}
// Assert tool message exists - test setup should always produce a tool message
expect(toolMessage).toBeDefined()
// The ID should be normalized to 9 alphanumeric characters
expect(toolMessage.tool_call_id).toMatch(/^[a-zA-Z0-9]{9}$/)
})
it("should NOT apply Mistral-specific handling for non-Mistral models", async () => {
@ -1264,10 +1263,10 @@ describe("OpenAiHandler", () => {
// For non-Mistral models, tool_call_id should retain original format
const toolMessage = callArgs.messages.find((m: any) => m.role === "tool")
if (toolMessage) {
// The original ID format should be preserved (not normalized)
expect(toolMessage.tool_call_id).toBe("call_test_123456789")
}
// Assert tool message exists - test setup should always produce a tool message
expect(toolMessage).toBeDefined()
// The original ID format should be preserved (not normalized)
expect(toolMessage.tool_call_id).toBe("call_test_123456789")
})
it("should handle case-insensitive model detection", async () => {
@ -1286,10 +1285,10 @@ describe("OpenAiHandler", () => {
// Verify model detection worked despite mixed case
const toolMessage = callArgs.messages.find((m: any) => m.role === "tool")
if (toolMessage) {
// The ID should be normalized (indicating Mistral detection worked)
expect(toolMessage.tool_call_id).toMatch(/^[a-zA-Z0-9]{9}$/)
}
// Assert tool message exists - test setup should always produce a tool message
expect(toolMessage).toBeDefined()
// The ID should be normalized (indicating Mistral detection worked)
expect(toolMessage.tool_call_id).toMatch(/^[a-zA-Z0-9]{9}$/)
})
})
})