From 33c22f774584ac2b83525017b04d2965722a5961 Mon Sep 17 00:00:00 2001
From: Daniel Riccio <ricciodaniel98@gmail.com>
Date: Thu, 31 Jul 2025 12:30:52 -0500
Subject: [PATCH] fix: remove configurable memory optimization settings as
 requested

- Remove useOnDiskStorage, memoryMapThreshold, and hnswEfSearch from CodeIndexConfig
- Remove same fields from PreviousConfigSnapshot type
- Remove unused QdrantMemoryOptimizationConfig import and interface
- Update comment in service-factory.ts for clarity
- Add documentation to clarify QDRANT_QUANTIZATION_CONFIG_DEFAULTS is for search operations

Memory optimizations are now always enabled via constants as originally requested.
---
 packages/types/src/qdrant.ts                 | 23 ++------------------
 src/services/code-index/interfaces/config.ts |  9 --------
 src/services/code-index/service-factory.ts   |  2 +-
 3 files changed, 3 insertions(+), 31 deletions(-)

diff --git a/packages/types/src/qdrant.ts b/packages/types/src/qdrant.ts
index f2b7b65629..8bfb79aa03 100644
--- a/packages/types/src/qdrant.ts
+++ b/packages/types/src/qdrant.ts
@@ -101,7 +101,8 @@ export const QDRANT_OPTIMIZER_CONFIG_DEFAULTS = {
 } as const
 
 /**
- * Quantization configuration for additional memory efficiency
+ * Quantization configuration for search operations
+ * These settings are applied during vector search queries to balance memory efficiency and search quality
  */
 export const QDRANT_QUANTIZATION_CONFIG_DEFAULTS = {
 	/**
@@ -119,23 +120,3 @@ export const QDRANT_QUANTIZATION_CONFIG_DEFAULTS = {
 	 */
 	OVERSAMPLING: 2.0,
 } as const
-
-/**
- * Memory optimization configuration interface
- */
-export interface QdrantMemoryOptimizationConfig {
-	/**
-	 * Enable on-disk storage for vectors and indexes
-	 */
-	useOnDiskStorage?: boolean
-
-	/**
-	 * Number of vectors before using memory-mapped files
-	 */
-	memoryMapThreshold?: number
-
-	/**
-	 * HNSW search parameter (ef) - controls search quality vs memory usage
-	 */
-	hnswEfSearch?: number
-}
diff --git a/src/services/code-index/interfaces/config.ts b/src/services/code-index/interfaces/config.ts
index 790ca215db..9098a60091 100644
--- a/src/services/code-index/interfaces/config.ts
+++ b/src/services/code-index/interfaces/config.ts
@@ -1,6 +1,5 @@
 import { ApiHandlerOptions } from "../../../shared/api" // Adjust path if needed
 import { EmbedderProvider } from "./manager"
-import { QdrantMemoryOptimizationConfig } from "@roo-code/types"
 
 /**
  * Configuration state for the code indexing feature
@@ -19,10 +18,6 @@ export interface CodeIndexConfig {
 	qdrantApiKey?: string
 	searchMinScore?: number
 	searchMaxResults?: number
-	// Memory optimization settings
-	useOnDiskStorage?: boolean
-	memoryMapThreshold?: number
-	hnswEfSearch?: number
 }
 
 /**
@@ -42,8 +37,4 @@ export type PreviousConfigSnapshot = {
 	mistralApiKey?: string
 	qdrantUrl?: string
 	qdrantApiKey?: string
-	// Memory optimization settings
-	useOnDiskStorage?: boolean
-	memoryMapThreshold?: number
-	hnswEfSearch?: number
 }
diff --git a/src/services/code-index/service-factory.ts b/src/services/code-index/service-factory.ts
index cf9e6cd75e..f30d905e03 100644
--- a/src/services/code-index/service-factory.ts
+++ b/src/services/code-index/service-factory.ts
@@ -136,7 +136,7 @@ export class CodeIndexServiceFactory {
 			throw new Error(t("embeddings:serviceFactory.qdrantUrlMissing"))
 		}
 
-		// Create QdrantVectorStore with memory optimization always enabled
+		// Create QdrantVectorStore (memory optimization is always enabled via constants)
 		return new QdrantVectorStore(this.workspacePath, config.qdrantUrl, vectorSize, config.qdrantApiKey)
 	}