scriptoriumadmin/Roo-Code
1
0
Fork 0
mirror of https://github.com/RooVetGit/Roo-Code.git synced 2026-08-28 05:27:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

test: fix timeout tests after PR changes

Browse source 
Add missing lastUsedTerminal property to mock tasks and reset it between tests.
Also add taskId to the second mock task which is required by TerminalRegistry.

These properties were introduced by the PR for terminal directory tracking.
This commit is contained in:
Daniel Riccio 2025-09-03 14:20:55 -05:00
parent 44006a2d50
commit 33affa5c43
No known key found for this signature in database
GPG key ID: B3CDA0E073DD9856
1 changed files with 17 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
src/core/tools/__tests__/executeCommandTimeout.integration.spec.ts
View file

@ -47,6 +47,7 @@ describe("Command Execution Timeout Integration", () => {
mockTask = {
cwd: "/test/directory",
terminalProcess: undefined,
lastUsedTerminal: undefined, // Add this property introduced by the PR
providerRef: {
deref: vitest.fn().mockResolvedValue({
postMessageToWebview: vitest.fn(),
@ -231,7 +232,9 @@ describe("Command Execution Timeout Integration", () => {
// Mock task with additional properties needed by executeCommandTool
mockTask = {
cwd: "/test/directory",
taskId: "test-task-id", // Add taskId which is used by TerminalRegistry
terminalProcess: undefined,
lastUsedTerminal: undefined, // Add this property introduced by the PR
providerRef: {
deref: vitest.fn().mockResolvedValue({
postMessageToWebview: vitest.fn(),
@ -365,14 +368,13 @@ describe("Command Execution Timeout Integration", () => {
})
;(vscode.workspace.getConfiguration as any).mockReturnValue(mockGetConfiguration())
// Test exact prefix match - should not timeout
mockBlock.params.command = "git log --oneline"
// Create a process that completes successfully after 2 seconds
const longRunningProcess = new Promise((resolve) => {
setTimeout(resolve, 2000) // 2 seconds
})
const neverResolvingProcess = new Promise(() => {})
;(neverResolvingProcess as any).abort = vitest.fn()
// Test exact prefix match - should not timeout
mockBlock.params.command = "git log --oneline"
mockTerminal.runCommand.mockReturnValueOnce(longRunningProcess)
await executeCommandTool(
@ -390,10 +392,19 @@ describe("Command Execution Timeout Integration", () => {
// Reset mocks for second test
mockPushToolResult.mockClear()
mockAskApproval.mockClear()
// Reset task's lastUsedTerminal to avoid interference from first test
mockTask.lastUsedTerminal = undefined
// Test partial prefix match (should not match) - should timeout
mockBlock.params.command = "git status" // "git" alone is not in allowlist, only "git log"
mockTerminal.runCommand.mockReturnValueOnce(neverResolvingProcess)
// Create a process that never resolves with abort method
const neverResolvingProcess = new Promise(() => {})
;(neverResolvingProcess as any).abort = vitest.fn()
mockTerminal.runCommand.mockReturnValue(neverResolvingProcess)
await executeCommandTool(
mockTask as Task,