From 31042b0df5c63cfb50f043798509317168567359 Mon Sep 17 00:00:00 2001 From: Roo Code Date: Mon, 9 Feb 2026 23:02:51 +0000 Subject: [PATCH] fix: remove orphaned taskHeaderHighlight setting from UISettings The taskHeaderHighlight feature was reverted on main (#11349), but the setting toggle was re-introduced during merge without the needed translation keys. Remove the setting block, handler, and prop since the feature no longer exists and the toggle was not wired into the save payload. --- .../src/components/settings/SettingsView.tsx | 2 -- .../src/components/settings/UISettings.tsx | 24 ------------------- .../settings/__tests__/UISettings.spec.tsx | 1 - 3 files changed, 27 deletions(-) diff --git a/webview-ui/src/components/settings/SettingsView.tsx b/webview-ui/src/components/settings/SettingsView.tsx index dbac92538c..49878e9aac 100644 --- a/webview-ui/src/components/settings/SettingsView.tsx +++ b/webview-ui/src/components/settings/SettingsView.tsx @@ -213,7 +213,6 @@ const SettingsView = forwardRef(({ onDone, t includeCurrentCost, maxGitStatusFiles, showQuestionsOneByOne, - taskHeaderHighlightEnabled, } = cachedState const apiConfiguration = useMemo(() => cachedState.apiConfiguration ?? {}, [cachedState.apiConfiguration]) @@ -925,7 +924,6 @@ const SettingsView = forwardRef(({ onDone, t reasoningBlockCollapsed={reasoningBlockCollapsed ?? true} enterBehavior={enterBehavior ?? "send"} showQuestionsOneByOne={showQuestionsOneByOne ?? false} - taskHeaderHighlightEnabled={taskHeaderHighlightEnabled ?? false} setCachedStateField={setCachedStateField} /> )} diff --git a/webview-ui/src/components/settings/UISettings.tsx b/webview-ui/src/components/settings/UISettings.tsx index 9f65c350c6..51c197db47 100644 --- a/webview-ui/src/components/settings/UISettings.tsx +++ b/webview-ui/src/components/settings/UISettings.tsx @@ -13,7 +13,6 @@ interface UISettingsProps extends HTMLAttributes { reasoningBlockCollapsed: boolean enterBehavior: "send" | "newline" showQuestionsOneByOne: boolean - taskHeaderHighlightEnabled: boolean setCachedStateField: SetCachedStateField } @@ -21,7 +20,6 @@ export const UISettings = ({ reasoningBlockCollapsed, enterBehavior, showQuestionsOneByOne, - taskHeaderHighlightEnabled, setCachedStateField, ...props }: UISettingsProps) => { @@ -61,10 +59,6 @@ export const UISettings = ({ }) } - const handleTaskHeaderHighlightChange = (enabled: boolean) => { - setCachedStateField("taskHeaderHighlightEnabled", enabled) - } - return (
{t("settings:sections.ui")} @@ -126,24 +120,6 @@ export const UISettings = ({
- - {/* Task Header Highlight Setting */} - -
- handleTaskHeaderHighlightChange(e.target.checked)} - data-testid="task-header-highlight-checkbox"> - {t("settings:ui.taskHeaderHighlight.label")} - -
- {t("settings:ui.taskHeaderHighlight.description")} -
-
-
diff --git a/webview-ui/src/components/settings/__tests__/UISettings.spec.tsx b/webview-ui/src/components/settings/__tests__/UISettings.spec.tsx index 90d1ae5d23..f8f3eed5c6 100644 --- a/webview-ui/src/components/settings/__tests__/UISettings.spec.tsx +++ b/webview-ui/src/components/settings/__tests__/UISettings.spec.tsx @@ -7,7 +7,6 @@ describe("UISettings", () => { reasoningBlockCollapsed: false, enterBehavior: "send" as const, showQuestionsOneByOne: false, - taskHeaderHighlightEnabled: false, setCachedStateField: vi.fn(), }