scriptoriumadmin/Roo-Code
1
0
Fork 0
mirror of https://github.com/RooVetGit/Roo-Code.git synced 2026-10-08 03:07:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

fix: handle Ask mode responses without tool usage for Google Gemini grounding

Browse source 
- Skip tool validation in Ask mode to allow direct answers
- Prevents infinite loop when using Google Gemini with grounding/search
- Ask mode is designed to provide answers without requiring tool usage

Fixes #6671
This commit is contained in:
Roo Code 2025-08-04 17:43:28 +00:00
parent 4e8b17486b
commit 2e410899ab
1 changed files with 18 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
src/core/task/Task.ts
View file

@ -1346,8 +1346,18 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
// the user hits max requests and denies resetting the count.
break
} else {
nextUserContent = [{ type: "text", text: formatResponse.noToolsUsed() }]
this.consecutiveMistakeCount++
// In Ask mode, we allow responses without tool usage since it's designed
// to provide direct answers, especially when using features like Google Gemini's grounding
const currentMode = await this.getTaskMode()
const isAskMode = currentMode === "ask"
if (!isAskMode) {
nextUserContent = [{ type: "text", text: formatResponse.noToolsUsed() }]
this.consecutiveMistakeCount++
} else {
// For Ask mode, end the loop gracefully without error
break
}
}
}
}
@ -1781,7 +1791,12 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
// either use a tool or attempt_completion.
const didToolUse = this.assistantMessageContent.some((block) => block.type === "tool_use")
if (!didToolUse) {
// In Ask mode, we allow responses without tool usage since it's designed
// to provide direct answers, especially when using features like Google Gemini's grounding
const currentMode = await this.getTaskMode()
const isAskMode = currentMode === "ask"
if (!didToolUse && !isAskMode) {
this.userMessageContent.push({ type: "text", text: formatResponse.noToolsUsed() })
this.consecutiveMistakeCount++
}