From 1f0890919acffc49badcce481b5fbc8a213e0d47 Mon Sep 17 00:00:00 2001 From: daniel-lxs Date: Fri, 15 Aug 2025 15:07:21 -0500 Subject: [PATCH] fix: address PR review comments - Remove unused _isNetworkError variable in PostHogTelemetryClient - Add TelemetryQueueManager.resetInstance() call in extension deactivation to prevent memory leaks and stale data when switching workspaces --- packages/telemetry/src/PostHogTelemetryClient.ts | 8 -------- src/extension.ts | 6 ++++++ 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/packages/telemetry/src/PostHogTelemetryClient.ts b/packages/telemetry/src/PostHogTelemetryClient.ts index 60e5283f52..81d6fe0e6f 100644 --- a/packages/telemetry/src/PostHogTelemetryClient.ts +++ b/packages/telemetry/src/PostHogTelemetryClient.ts @@ -97,14 +97,6 @@ export class PostHogTelemetryClient extends QueuedTelemetryClient { // Differentiate between different types of errors const errorMessage = error instanceof Error ? error.message : String(error) - // Check if it's a network error or other transient issue - const _isNetworkError = - errorMessage.toLowerCase().includes("network") || - errorMessage.toLowerCase().includes("timeout") || - errorMessage.toLowerCase().includes("econnrefused") || - errorMessage.toLowerCase().includes("enotfound") || - errorMessage.toLowerCase().includes("fetch") - // Check if it's a configuration error that won't be fixed by retrying const isConfigError = errorMessage.toLowerCase().includes("api key") || diff --git a/src/extension.ts b/src/extension.ts index 12628191f7..a6b3c06d53 100644 --- a/src/extension.ts +++ b/src/extension.ts @@ -290,5 +290,11 @@ export async function deactivate() { await McpServerManager.cleanup(extensionContext) TelemetryService.instance.shutdown() + + // Clean up the telemetry queue manager singleton to prevent memory leaks + // and stale data when switching workspaces + const { TelemetryQueueManager } = await import("@roo-code/telemetry") + TelemetryQueueManager.resetInstance() + TerminalRegistry.cleanup() }