From 1051bb684f20192a3b3c49b588c567d7c7173766 Mon Sep 17 00:00:00 2001 From: Roo Code Date: Tue, 8 Jul 2025 11:53:31 +0000 Subject: [PATCH] Fix TypeScript type checking errors in authentication tests - Replace vi.MockedFunction with any for simpler typing - Add optional chaining for potentially undefined array access - Ensure tests pass TypeScript strict checking --- .../analytics/__tests__/events-auth.test.ts | 18 +++++++++--------- .../analytics/__tests__/messages-auth.test.ts | 18 +++++++++--------- 2 files changed, 18 insertions(+), 18 deletions(-) diff --git a/apps/web/src/actions/analytics/__tests__/events-auth.test.ts b/apps/web/src/actions/analytics/__tests__/events-auth.test.ts index 712321a867..981f90232c 100644 --- a/apps/web/src/actions/analytics/__tests__/events-auth.test.ts +++ b/apps/web/src/actions/analytics/__tests__/events-auth.test.ts @@ -40,13 +40,13 @@ vi.mock('@/types', () => ({ })); describe('Share Token Authorization in Events', () => { - let mockAnalytics: vi.MockedFunction; - let mockAuthorizeAnalytics: vi.MockedFunction; - let mockGetUsersById: vi.MockedFunction; - let mockDb: vi.MockedFunction; - let mockIsValidShareToken: vi.MockedFunction; - let mockIsShareExpired: vi.MockedFunction; - let mockAuth: vi.MockedFunction; + let mockAnalytics: any; + let mockAuthorizeAnalytics: any; + let mockGetUsersById: any; + let mockDb: any; + let mockIsValidShareToken: any; + let mockIsShareExpired: any; + let mockAuth: any; beforeEach(async () => { vi.clearAllMocks(); @@ -228,7 +228,7 @@ describe('Share Token Authorization in Events', () => { }); expect(result.tasks).toHaveLength(1); - expect(result.tasks[0].taskId).toBe('task-123'); + expect(result.tasks?.[0]?.taskId).toBe('task-123'); }); it('should allow access for valid public share', async () => { @@ -257,7 +257,7 @@ describe('Share Token Authorization in Events', () => { }); expect(result.tasks).toHaveLength(1); - expect(result.tasks[0].taskId).toBe('task-123'); + expect(result.tasks?.[0]?.taskId).toBe('task-123'); // Should not call auth for public shares expect(mockAuth).not.toHaveBeenCalled(); }); diff --git a/apps/web/src/actions/analytics/__tests__/messages-auth.test.ts b/apps/web/src/actions/analytics/__tests__/messages-auth.test.ts index 5b51bdc23c..be811a06c0 100644 --- a/apps/web/src/actions/analytics/__tests__/messages-auth.test.ts +++ b/apps/web/src/actions/analytics/__tests__/messages-auth.test.ts @@ -39,12 +39,12 @@ vi.mock('@/types', () => ({ })); describe('Share Token Authorization in Messages', () => { - let mockAnalytics: vi.MockedFunction; - let mockAuthorizeAnalytics: vi.MockedFunction; - let mockDb: vi.MockedFunction; - let mockIsValidShareToken: vi.MockedFunction; - let mockIsShareExpired: vi.MockedFunction; - let mockAuth: vi.MockedFunction; + let mockAnalytics: any; + let mockAuthorizeAnalytics: any; + let mockDb: any; + let mockIsValidShareToken: any; + let mockIsShareExpired: any; + let mockAuth: any; beforeEach(async () => { vi.clearAllMocks(); @@ -242,8 +242,8 @@ describe('Share Token Authorization in Messages', () => { ); expect(result).toHaveLength(2); - expect(result[0].taskId).toBe('task-123'); - expect(result[1].taskId).toBe('task-123'); + expect(result?.[0]?.taskId).toBe('task-123'); + expect(result?.[1]?.taskId).toBe('task-123'); }); it('should allow access for valid public share', async () => { @@ -274,7 +274,7 @@ describe('Share Token Authorization in Messages', () => { ); expect(result).toHaveLength(2); - expect(result[0].taskId).toBe('task-123'); + expect(result?.[0]?.taskId).toBe('task-123'); // Should not call auth for public shares expect(mockAuth).not.toHaveBeenCalled(); });