From 0872b8b0443fae622b395691748d032f7730d8d3 Mon Sep 17 00:00:00 2001 From: Will Li Date: Sun, 13 Jul 2025 10:36:45 -0700 Subject: [PATCH] cleaner code --- webview-ui/src/components/chat/ChatView.tsx | 25 ++++++++++----------- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/webview-ui/src/components/chat/ChatView.tsx b/webview-ui/src/components/chat/ChatView.tsx index bd71021305..1de8c096d9 100644 --- a/webview-ui/src/components/chat/ChatView.tsx +++ b/webview-ui/src/components/chat/ChatView.tsx @@ -783,21 +783,20 @@ const ChatViewComponent: React.ForwardRefRenderFunction { - // First, collect all checkpoint hashes that are associated with user_feedback messages - const userMessageCheckpointHashes = new Set() - modifiedMessages.forEach((message) => { - if (message.say === "user_feedback" && message.checkpoint) { - const checkpoint = message.checkpoint as any - if (checkpoint.type === "user_message" && checkpoint.hash) { - userMessageCheckpointHashes.add(checkpoint.hash) - } - } - }) - const newVisibleMessages = modifiedMessages.filter((message) => { // Filter out checkpoint_saved messages that are associated with user messages - if (message.say === "checkpoint_saved" && message.text && userMessageCheckpointHashes.has(message.text)) { - return false + if (message.say === "checkpoint_saved" && message.text) { + // Check if there's a user_feedback message with a checkpoint that has this hash + const hasAssociatedUserMessage = modifiedMessages.some( + (msg) => + msg.say === "user_feedback" && + msg.checkpoint && + (msg.checkpoint as any).type === "user_message" && + (msg.checkpoint as any).hash === message.text, + ) + if (hasAssociatedUserMessage) { + return false + } } if (everVisibleMessagesTsRef.current.has(message.ts)) {