scriptoriumadmin/Roo-Code
1
0
Fork 0
mirror of https://github.com/RooVetGit/Roo-Code.git synced 2026-09-07 08:26:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(task): address review feedback — move visibility check into flush, atomic batch swap, drop/log deltas when hidden

Browse source
This commit is contained in:
Hannes Rudolph 2025-10-10 18:33:10 -06:00
parent 1f7e78ea2c
commit 03d28f90f1
1 changed files with 27 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

39
src/core/task/Task.ts
View file

@ -654,9 +654,7 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
this.emit(RooCodeEventName.Message, { action: "updated", message })
// Telemetry capture remains unchanged below
const shouldCaptureMessage = message.partial !== true && CloudService.isEnabled()
if (shouldCaptureMessage) {
CloudService.instance.captureEvent({
event: TelemetryEventName.TASK_MESSAGE,
@ -664,18 +662,16 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
})
}
// If provider is unavailable, or panel is hidden, skip UI delta updates.
// The UI will resync on next visibility or full state push.
if (!provider || (typeof (provider as any).isVisible === "function" && !(provider as any).isVisible())) {
return
}
// Batch UI updates within a short window to avoid overwhelming the webview
const ts = (message as any)?.ts as number | undefined
if (typeof ts === "number") {
this.messageUpdateBuffer.set(ts, message)
} else {
// Fallback: no timestamp, just send immediately
// Fallback: no timestamp - only send if panel is visible and provider exists
if (!provider || !provider.isVisible()) {
// Drop non-essential delta; UI will resync on next visibility/state push
return
}
await provider.postMessageToWebview({ type: "messageUpdated", clineMessage: message })
return
}
@ -683,11 +679,30 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
if (!this.messageUpdateTimer) {
this.messageUpdateTimer = setTimeout(async () => {
try {
const batch = Array.from(this.messageUpdateBuffer.values())
this.messageUpdateBuffer.clear()
// Atomically swap buffers so new arrivals during flush aren't lost
const batchMap = this.messageUpdateBuffer
this.messageUpdateBuffer = new Map()
this.messageUpdateTimer = undefined
const batch = Array.from(batchMap.values())
const providerNow = this.providerRef.deref()
if (!providerNow) {
console.warn(
`[Task#updateClineMessage] Dropping ${batch.length} messageUpdated deltas: provider unavailable`,
)
return
}
if (!providerNow.isVisible()) {
// Drop deltas while hidden; UI will receive a full state sync on visibility
console.debug(
`[Task#updateClineMessage] Dropping ${batch.length} messageUpdated deltas while hidden`,
)
return
}
for (const m of batch) {
await provider.postMessageToWebview({ type: "messageUpdated", clineMessage: m })
await providerNow.postMessageToWebview({ type: "messageUpdated", clineMessage: m })
}
} catch (e) {
console.error("[Task#updateClineMessage] Failed to flush message updates:", e)