mirror of
https://github.com/agentscope-ai/ReMe.git
synced 2026-09-29 01:41:38 +00:00
* refactor(components): extract shared component state into mixin - Introduce ComponentMixin class with shared state for components and steps - Move identity, config, and vault path functionality to ComponentMixin - Update BaseComponent to inherit from ComponentMixin - Update BaseStep to inherit from ComponentMixin - Consolidate vault path helper methods in ComponentMixin - Remove duplicate vault path implementations from BaseComponent and BaseStep - Add ComponentMixin to components module exports * refactor(file_io): implement path locks cache eviction mechanism - Add _PATH_LOCKS_MAX constant set to 1024 for cache size limit - Implement cache eviction logic when locks exceed maximum capacity - Remove half of unlocked entries when cache limit is reached - Use list comprehension to identify unlocked locks for removal - Maintain existing path normalization and locking behavior fix(edit): correct method call from public to private fail method - Change self.fail to self._fail for internal error handling - Maintain consistent private method usage within class fix(mcp_client): change pop to get for optional command and args - Replace kwargs.pop with kwargs.get to avoid removing keys - Preserve original kwargs dictionary contents - Maintain default empty string and list values feat(reme): add client backend validation with error raising - Check if client_cls is None before instantiation - Raise ValueError with descriptive message for unknown backends - Provide clear error feedback for invalid backend configurations * fix(components): move directory creation to start method - Moved component_metadata_path.mkdir call from __init__ to _start in base_keyword_index - Moved component_metadata_path.mkdir call from __init__ to _start in local_file_graph - Moved component_metadata_path.mkdir call from __init__ to _start in local_file_store - Ensures directory creation happens after component initialization - Prevents potential issues with path creation during object construction * fix(steps): replace assertions with runtime errors for app_context validation - Replace assert statements with explicit RuntimeError exceptions when app_context is None - Add descriptive error messages for better debugging when resolving components - Replace assert in resolve_component method with proper exception handling - Replace assert in get_file_parser method with proper exception handling - Maintain same functionality while improving error reporting clarity * refactor(file_io): split file IO utilities into modular components - Move daily note helpers to separate _daily_index module - Extract path validation and resolution to new _path module - Remove unused code and imports from _file_io module - Update import statements across affected modules - Introduce WikilinkHandler utility for link parsing - Replace regex-based link extraction with WikilinkHandler - Add integration JSONL files to gitignore - Consolidate file locking mechanism in _file_io module * style(formatter): fix spacing issues in file IO and chunked file parser - Fixed whitespace around colon in slice notation in file_io.py - Corrected spacing around colon in slice notation in chunked_file_parser.py - Applied consistent formatting for array slicing operations - Improved code readability by standardizing space placement in ranges * refactor(steps): replace property-based component resolution with Ref descriptor - Introduce Ref descriptor class for lazy component dependency resolution - Replace _resolve method and individual properties with Ref descriptors - Add as_llm, as_llm_formatter, as_token_counter, file_store, and embedding Ref attributes - Remove legacy property methods and resolve logic from BaseStep - Add cache clearing mechanism for Ref values during step calls - Update UpdateCatalogStep to use Ref instead of property-based resolution
476 lines
17 KiB
Python
476 lines
17 KiB
Python
"""Tests for ChunkedFileParser."""
|
|
|
|
import asyncio
|
|
import os
|
|
import tempfile
|
|
|
|
from reme4.components.file_parser import ChunkedFileParser
|
|
from reme4.utils.wikilink_handler import WikilinkHandler
|
|
|
|
|
|
# Add parent path for import
|
|
|
|
|
|
def test_parse_empty_file():
|
|
"""Test parsing an empty file."""
|
|
|
|
async def run():
|
|
with tempfile.NamedTemporaryFile(mode="w", delete=False, suffix=".txt") as f:
|
|
temp_path = f.name
|
|
|
|
try:
|
|
parser = ChunkedFileParser()
|
|
file_node, chunks = await parser.parse(temp_path)
|
|
assert file_node.path == temp_path
|
|
assert len(chunks) == 0
|
|
print("✓ test_parse_empty_file passed")
|
|
finally:
|
|
os.unlink(temp_path)
|
|
|
|
asyncio.run(run())
|
|
|
|
|
|
def test_parse_small_file():
|
|
"""Test parsing a file smaller than chunk size."""
|
|
|
|
async def run():
|
|
content = "Hello World\nThis is a test\nLine 3"
|
|
with tempfile.NamedTemporaryFile(mode="w", delete=False, suffix=".txt") as f:
|
|
f.write(content)
|
|
temp_path = f.name
|
|
|
|
try:
|
|
parser = ChunkedFileParser(chunk_byte_size=10000)
|
|
_, chunks = await parser.parse(temp_path)
|
|
assert len(chunks) == 1
|
|
assert chunks[0].start_line == 1
|
|
assert chunks[0].end_line == 3
|
|
assert chunks[0].text == content
|
|
print("✓ test_parse_small_file passed")
|
|
finally:
|
|
os.unlink(temp_path)
|
|
|
|
asyncio.run(run())
|
|
|
|
|
|
def test_parse_multiline_file():
|
|
"""Test parsing a file with multiple lines."""
|
|
|
|
async def run():
|
|
lines = ["Line 1", "Line 2", "Line 3", "Line 4", "Line 5"]
|
|
content = "\n".join(lines)
|
|
with tempfile.NamedTemporaryFile(mode="w", delete=False, suffix=".txt") as f:
|
|
f.write(content)
|
|
temp_path = f.name
|
|
|
|
try:
|
|
parser = ChunkedFileParser(chunk_byte_size=10000)
|
|
_, chunks = await parser.parse(temp_path)
|
|
assert len(chunks) == 1
|
|
assert chunks[0].start_line == 1
|
|
assert chunks[0].end_line == 5
|
|
print("✓ test_parse_multiline_file passed")
|
|
finally:
|
|
os.unlink(temp_path)
|
|
|
|
asyncio.run(run())
|
|
|
|
|
|
def test_parse_chunked_file():
|
|
"""Test parsing a file that requires multiple chunks."""
|
|
|
|
async def run():
|
|
# Create content larger than chunk size
|
|
lines = ["A" * 100 for _ in range(200)] # ~20200 bytes
|
|
content = "\n".join(lines)
|
|
with tempfile.NamedTemporaryFile(mode="w", delete=False, suffix=".txt") as f:
|
|
f.write(content)
|
|
temp_path = f.name
|
|
|
|
try:
|
|
parser = ChunkedFileParser(chunk_byte_size=5000, overlap_byte_size=100)
|
|
_, chunks = await parser.parse(temp_path)
|
|
assert len(chunks) > 1, f"Expected multiple chunks, got {len(chunks)}"
|
|
# Verify overlap by checking that consecutive chunks share some content
|
|
print(f" Created {len(chunks)} chunks")
|
|
print("✓ test_parse_chunked_file passed")
|
|
finally:
|
|
os.unlink(temp_path)
|
|
|
|
asyncio.run(run())
|
|
|
|
|
|
def test_parse_with_custom_encoding():
|
|
"""Test parsing a file with different encodings."""
|
|
|
|
async def run():
|
|
content = "你好世界\n测试内容"
|
|
with tempfile.NamedTemporaryFile(mode="w", delete=False, suffix=".txt", encoding="utf-8") as f:
|
|
f.write(content)
|
|
temp_path = f.name
|
|
|
|
try:
|
|
parser = ChunkedFileParser(encoding="utf-8")
|
|
_, chunks = await parser.parse(temp_path)
|
|
assert len(chunks) >= 1
|
|
assert "你好世界" in chunks[0].text
|
|
print("✓ test_parse_with_custom_encoding passed")
|
|
finally:
|
|
os.unlink(temp_path)
|
|
|
|
asyncio.run(run())
|
|
|
|
|
|
def test_file_node_properties():
|
|
"""Test FileNode has correct properties."""
|
|
|
|
async def run():
|
|
content = "test content"
|
|
with tempfile.NamedTemporaryFile(mode="w", delete=False, suffix=".txt") as f:
|
|
f.write(content)
|
|
temp_path = f.name
|
|
|
|
try:
|
|
parser = ChunkedFileParser()
|
|
file_node, _ = await parser.parse(temp_path)
|
|
assert hasattr(file_node, "path")
|
|
assert hasattr(file_node, "st_mtime")
|
|
assert file_node.st_mtime > 0
|
|
print("✓ test_file_node_properties passed")
|
|
finally:
|
|
os.unlink(temp_path)
|
|
|
|
asyncio.run(run())
|
|
|
|
|
|
def test_file_chunk_properties():
|
|
"""Test FileChunk has correct properties."""
|
|
|
|
async def run():
|
|
content = "test content for chunk"
|
|
with tempfile.NamedTemporaryFile(mode="w", delete=False, suffix=".txt") as f:
|
|
f.write(content)
|
|
temp_path = f.name
|
|
|
|
try:
|
|
parser = ChunkedFileParser()
|
|
_, chunks = await parser.parse(temp_path)
|
|
chunk = chunks[0]
|
|
assert hasattr(chunk, "path")
|
|
assert hasattr(chunk, "start_line")
|
|
assert hasattr(chunk, "end_line")
|
|
assert hasattr(chunk, "text")
|
|
assert hasattr(chunk, "id")
|
|
assert chunk.start_line >= 1
|
|
assert chunk.end_line >= chunk.start_line
|
|
print("✓ test_file_chunk_properties passed")
|
|
finally:
|
|
os.unlink(temp_path)
|
|
|
|
asyncio.run(run())
|
|
|
|
|
|
def test_parse_links_bare():
|
|
"""Bare wikilink: [[target]]."""
|
|
links = WikilinkHandler.extract_links("see [[note]]", "src.md")
|
|
assert len(links) == 1
|
|
link = links[0]
|
|
assert link.source_path == "src.md"
|
|
assert link.target_path == "note"
|
|
assert link.target_anchor is None
|
|
assert link.predicate is None
|
|
print("✓ test_parse_links_bare passed")
|
|
|
|
|
|
def test_parse_links_with_anchor():
|
|
"""Wikilink with anchor: [[target#anchor]]."""
|
|
links = WikilinkHandler.extract_links("see [[note#section A]]", "src.md")
|
|
assert len(links) == 1
|
|
assert links[0].target_path == "note"
|
|
assert links[0].target_anchor == "section A"
|
|
assert links[0].predicate is None
|
|
print("✓ test_parse_links_with_anchor passed")
|
|
|
|
|
|
def test_parse_links_alias_dropped():
|
|
"""Alias after '|' is consumed but not captured as anchor."""
|
|
links = WikilinkHandler.extract_links("see [[note|display text]]", "src.md")
|
|
assert len(links) == 1
|
|
assert links[0].target_path == "note"
|
|
assert links[0].target_anchor is None
|
|
print("✓ test_parse_links_alias_dropped passed")
|
|
|
|
|
|
def test_parse_links_anchor_and_alias():
|
|
"""[[target#anchor|alias]] — anchor captured, alias dropped."""
|
|
links = WikilinkHandler.extract_links("see [[note#sec|disp]]", "src.md")
|
|
assert len(links) == 1
|
|
assert links[0].target_path == "note"
|
|
assert links[0].target_anchor == "sec"
|
|
print("✓ test_parse_links_anchor_and_alias passed")
|
|
|
|
|
|
def test_parse_links_predicate_simple():
|
|
"""Dataview inline: predicate:: [[target]]."""
|
|
links = WikilinkHandler.extract_links("author:: [[Alice]]", "src.md")
|
|
assert len(links) == 1
|
|
assert links[0].predicate == "author"
|
|
assert links[0].target_path == "Alice"
|
|
assert links[0].target_anchor is None
|
|
print("✓ test_parse_links_predicate_simple passed")
|
|
|
|
|
|
def test_parse_links_predicate_bracketed():
|
|
"""Dataview inline-bracket: [predicate:: [[target]]]."""
|
|
links = WikilinkHandler.extract_links("text [author:: [[Alice]]] more", "src.md")
|
|
assert len(links) == 1
|
|
assert links[0].predicate == "author"
|
|
assert links[0].target_path == "Alice"
|
|
print("✓ test_parse_links_predicate_bracketed passed")
|
|
|
|
|
|
def test_parse_links_predicate_bracketed_with_anchor():
|
|
"""[predicate:: [[target_path#target_anchor]]] — combined form."""
|
|
links = WikilinkHandler.extract_links(
|
|
"[predicate:: [[target_path#target_anchor]]]",
|
|
"src.md",
|
|
)
|
|
assert len(links) == 1
|
|
link = links[0]
|
|
assert link.source_path == "src.md"
|
|
assert link.predicate == "predicate"
|
|
assert link.target_path == "target_path"
|
|
assert link.target_anchor == "target_anchor"
|
|
print("✓ test_parse_links_predicate_bracketed_with_anchor passed")
|
|
|
|
|
|
def test_parse_links_predicate_sticks_to_first():
|
|
"""Line-level predicate covers all wikilinks in its value portion."""
|
|
links = WikilinkHandler.extract_links("pred:: [[a]] and bare [[b]]", "src.md")
|
|
assert len(links) == 2
|
|
assert links[0].predicate == "pred" and links[0].target_path == "a"
|
|
assert links[1].predicate == "pred" and links[1].target_path == "b"
|
|
print("✓ test_parse_links_predicate_sticks_to_first passed")
|
|
|
|
|
|
def test_parse_links_multiple_on_one_line():
|
|
"""Multiple bare wikilinks on the same line are all captured."""
|
|
links = WikilinkHandler.extract_links("see [[x]] and [[y#h]]", "src.md")
|
|
assert [(link.target_path, link.target_anchor) for link in links] == [
|
|
("x", None),
|
|
("y", "h"),
|
|
]
|
|
print("✓ test_parse_links_multiple_on_one_line passed")
|
|
|
|
|
|
def test_parse_links_no_match():
|
|
"""Strings without [[]] yield no links, even if '::' appears."""
|
|
assert len(WikilinkHandler.extract_links("no link here :: foo", "src.md")) == 0
|
|
assert len(WikilinkHandler.extract_links("plain text without brackets", "src.md")) == 0
|
|
assert len(WikilinkHandler.extract_links("", "src.md")) == 0
|
|
print("✓ test_parse_links_no_match passed")
|
|
|
|
|
|
def test_parse_links_predicate_with_underscore_and_digits():
|
|
"""Predicate identifier accepts letters, digits, underscore (no dash per Dataview spec)."""
|
|
links = WikilinkHandler.extract_links("see_also2:: [[target]]", "src.md")
|
|
assert len(links) == 1
|
|
assert links[0].predicate == "see_also2"
|
|
assert links[0].target_path == "target"
|
|
print("✓ test_parse_links_predicate_with_underscore_and_digits passed")
|
|
|
|
|
|
def test_parse_links_in_file():
|
|
"""Integration: parse() populates FileNode.links from file content."""
|
|
|
|
async def run():
|
|
content = (
|
|
"---\n"
|
|
"name: demo\n"
|
|
"---\n"
|
|
"\n"
|
|
"Intro paragraph with [[alpha]] and [[beta#h2]].\n"
|
|
"author:: [[Alice]]\n"
|
|
"[ref:: [[paper#chapter 1]]]\n"
|
|
)
|
|
with tempfile.NamedTemporaryFile(mode="w", delete=False, suffix=".md") as f:
|
|
f.write(content)
|
|
temp_path = f.name
|
|
|
|
try:
|
|
parser = ChunkedFileParser()
|
|
file_node, _ = await parser.parse(temp_path)
|
|
triples = {(link.predicate, link.target_path, link.target_anchor) for link in file_node.links}
|
|
assert (None, "alpha", None) in triples
|
|
assert (None, "beta", "h2") in triples
|
|
assert ("author", "Alice", None) in triples
|
|
assert ("ref", "paper", "chapter 1") in triples
|
|
assert all(link.source_path == file_node.path for link in file_node.links)
|
|
print("✓ test_parse_links_in_file passed")
|
|
finally:
|
|
os.unlink(temp_path)
|
|
|
|
asyncio.run(run())
|
|
|
|
|
|
def test_parse_links_empty_when_no_content():
|
|
"""Empty file and front-matter-only file both yield no links."""
|
|
|
|
async def run():
|
|
# Empty file
|
|
with tempfile.NamedTemporaryFile(mode="w", delete=False, suffix=".md") as f:
|
|
empty_path = f.name
|
|
# Front-matter-only file
|
|
with tempfile.NamedTemporaryFile(mode="w", delete=False, suffix=".md") as f:
|
|
f.write("---\nname: x\n---\n")
|
|
fm_only_path = f.name
|
|
|
|
try:
|
|
parser = ChunkedFileParser()
|
|
node1, _ = await parser.parse(empty_path)
|
|
node2, _ = await parser.parse(fm_only_path)
|
|
assert node1.links == []
|
|
assert node2.links == []
|
|
print("✓ test_parse_links_empty_when_no_content passed")
|
|
finally:
|
|
os.unlink(empty_path)
|
|
os.unlink(fm_only_path)
|
|
|
|
asyncio.run(run())
|
|
|
|
|
|
def test_chunk_does_not_split_wikilink_at_boundary():
|
|
"""A wikilink straddling the chunk_byte_size boundary should be retreated to its start."""
|
|
|
|
async def run():
|
|
# Pre-link filler is 90 bytes, link itself is 19 bytes ("[[a-very-long-target]]"=22).
|
|
# With chunk_byte_size=100, the boundary lands inside the link.
|
|
prefix = "x" * 90
|
|
link = "[[a-very-long-target]]" # 22 bytes
|
|
suffix = "y" * 90
|
|
content = f"{prefix}{link}{suffix}"
|
|
with tempfile.NamedTemporaryFile(mode="w", delete=False, suffix=".md") as f:
|
|
f.write(content)
|
|
temp_path = f.name
|
|
|
|
try:
|
|
parser = ChunkedFileParser(chunk_byte_size=100, overlap_byte_size=10)
|
|
_, chunks = await parser.parse(temp_path)
|
|
# The first chunk must NOT contain a partial link.
|
|
first = chunks[0].text
|
|
assert "[[" not in first or "]]" in first, f"first chunk has dangling '[[': {first!r}"
|
|
# And the link should appear intact in some chunk.
|
|
assert any(link in c.text for c in chunks), "link was split across all chunks"
|
|
print("✓ test_chunk_does_not_split_wikilink_at_boundary passed")
|
|
finally:
|
|
os.unlink(temp_path)
|
|
|
|
asyncio.run(run())
|
|
|
|
|
|
def test_chunk_does_not_split_wikilink_in_overlap():
|
|
"""A wikilink landing inside the overlap region should be advanced past."""
|
|
|
|
async def run():
|
|
# 200-byte content, chunk=100, overlap=20. First chunk ends near byte 100,
|
|
# next start = 80. Place a link straddling byte 80 to land in the overlap.
|
|
prefix = "a" * 75
|
|
link = "[[overlap-target]]" # 18 bytes; spans bytes 75..93
|
|
suffix = "b" * 110
|
|
content = f"{prefix}{link}{suffix}"
|
|
with tempfile.NamedTemporaryFile(mode="w", delete=False, suffix=".md") as f:
|
|
f.write(content)
|
|
temp_path = f.name
|
|
|
|
try:
|
|
parser = ChunkedFileParser(chunk_byte_size=100, overlap_byte_size=20)
|
|
_, chunks = await parser.parse(temp_path)
|
|
# No chunk should start mid-link.
|
|
for c in chunks:
|
|
t = c.text
|
|
if "]]" in t and "[[" not in t.split("]]", 1)[0]:
|
|
raise AssertionError(f"chunk starts mid-link: {t[:40]!r}")
|
|
assert any(link in c.text for c in chunks)
|
|
print("✓ test_chunk_does_not_split_wikilink_in_overlap passed")
|
|
finally:
|
|
os.unlink(temp_path)
|
|
|
|
asyncio.run(run())
|
|
|
|
|
|
def test_chunk_falls_back_for_oversize_link():
|
|
"""If a single link exceeds half the chunk size, the parser hard-cuts to make progress."""
|
|
|
|
async def run():
|
|
# chunk=100, link is 80 bytes, surrounded by short filler.
|
|
# Retreating would leave a tiny chunk (< 50), so the fallback kicks in.
|
|
prefix = "x" * 30
|
|
link = "[[" + ("L" * 76) + "]]" # 80 bytes total
|
|
suffix = "y" * 200
|
|
content = f"{prefix}{link}{suffix}"
|
|
with tempfile.NamedTemporaryFile(mode="w", delete=False, suffix=".md") as f:
|
|
f.write(content)
|
|
temp_path = f.name
|
|
|
|
try:
|
|
parser = ChunkedFileParser(chunk_byte_size=100, overlap_byte_size=10)
|
|
_, chunks = await parser.parse(temp_path)
|
|
# Must terminate (not hang) and cover the whole file.
|
|
assert len(chunks) >= 2
|
|
print("✓ test_chunk_falls_back_for_oversize_link passed")
|
|
finally:
|
|
os.unlink(temp_path)
|
|
|
|
asyncio.run(run())
|
|
|
|
|
|
def test_min_chunk_and_overlap_size():
|
|
"""Test that minimum chunk and overlap sizes are enforced."""
|
|
|
|
async def run():
|
|
# These values should be clamped to minimums
|
|
parser = ChunkedFileParser(chunk_byte_size=1, overlap_byte_size=0)
|
|
assert parser.chunk_byte_size == 100 # minimum
|
|
assert parser.overlap_byte_size == 4 # minimum
|
|
|
|
content = "test"
|
|
with tempfile.NamedTemporaryFile(mode="w", delete=False, suffix=".txt") as f:
|
|
f.write(content)
|
|
temp_path = f.name
|
|
|
|
try:
|
|
_, chunks = await parser.parse(temp_path)
|
|
assert len(chunks) == 1
|
|
print("✓ test_min_chunk_and_overlap_size passed")
|
|
finally:
|
|
os.unlink(temp_path)
|
|
|
|
asyncio.run(run())
|
|
|
|
|
|
if __name__ == "__main__":
|
|
test_parse_empty_file()
|
|
test_parse_small_file()
|
|
test_parse_multiline_file()
|
|
test_parse_chunked_file()
|
|
test_parse_with_custom_encoding()
|
|
test_file_node_properties()
|
|
test_file_chunk_properties()
|
|
test_parse_links_bare()
|
|
test_parse_links_with_anchor()
|
|
test_parse_links_alias_dropped()
|
|
test_parse_links_anchor_and_alias()
|
|
test_parse_links_predicate_simple()
|
|
test_parse_links_predicate_bracketed()
|
|
test_parse_links_predicate_bracketed_with_anchor()
|
|
test_parse_links_predicate_sticks_to_first()
|
|
test_parse_links_multiple_on_one_line()
|
|
test_parse_links_no_match()
|
|
test_parse_links_predicate_with_underscore_and_digits()
|
|
test_parse_links_in_file()
|
|
test_parse_links_empty_when_no_content()
|
|
test_chunk_does_not_split_wikilink_at_boundary()
|
|
test_chunk_does_not_split_wikilink_in_overlap()
|
|
test_chunk_falls_back_for_oversize_link()
|
|
test_min_chunk_and_overlap_size()
|
|
print("\n所有测试通过!")
|