fix(codex): require final phase for mismatched capture fallback

Do not persist phase-less progress when the transcript settle window expires. Preserve exact Stop-text matching and cover incomplete final JSON at EOF through capture().

integrations/codex/plugins/reme/hooks/auto_memory.py

@@ -79,6 +79,7 @@ def transcript_messages(path: Path, *, root_only: bool = True):
                 "id": str(index),
                 "turn_id": payload.get("turn_id"),
                 "time": record.get("timestamp"),
+                "phase": item.get("phase"),
             }
 
 
@@ -89,7 +90,7 @@ def _completed_turn(
     root_only: bool,
     allow_fallback: bool,
 ) -> list[dict]:
-    """Build a turn, optionally falling back after the caller's bounded retry window."""
+    """Build a turn, allowing only explicitly final mismatched replies after the retry window."""
     final, transcript, turn_id = (
         payload.get("last_assistant_message"),
         payload.get("transcript_path"),
@@ -119,7 +120,7 @@ def _completed_turn(
         for message in turn_messages:
             if message["role"] == "user":
                 user = message
-            elif user and message["role"] == "assistant":
+            elif user and message["role"] == "assistant" and message["phase"] == "final_answer":
                 pair = [user, message]
     return [
         {

tests/unit/test_codex_capture_recovery.py

@@ -48,14 +48,16 @@ def test_accepts_unterminated_final_transcript_line(codex_hook, tmp_path):
     assert [message["content"][0]["text"] for message in pair] == ["question", "answer"]
 
 
-def test_uses_last_same_turn_assistant_when_stop_text_differs(codex_hook, tmp_path):
-    """Fall back only after the retry window when completed Stop text differs."""
+def test_uses_last_same_turn_final_answer_when_stop_text_differs(codex_hook, tmp_path):
+    """Fall back to an explicitly final item after the retry window when Stop text differs."""
     path = tmp_path / "rollout.jsonl"
     rows = [
         completed("turn-one", "UserMessage", "question"),
         completed("turn-one", "AgentMessage", "progress"),
         completed("turn-one", "AgentMessage", "final answer"),
     ]
+    rows[-1]["payload"]["item"]["phase"] = "final_answer"
+    rows.append(completed("turn-one", "AgentMessage", "later phase-less progress"))
     path.write_text("".join(json.dumps(row) + "\n" for row in rows), encoding="utf-8")
     payload = {
         "transcript_path": str(path),
@@ -69,6 +71,63 @@ def test_uses_last_same_turn_assistant_when_stop_text_differs(codex_hook, tmp_pa
     assert codex_hook.completed_turn_with_retry(payload, "session", timeout=0) == []
 
 
+@pytest.mark.parametrize("final_turn", ["turn-one", "other-turn"])
+def test_capture_rejects_mismatched_phase_less_reply(codex_hook, tmp_path, final_turn):
+    """A complete phase-less row or another turn's final phase cannot authorize a fallback."""
+    path = tmp_path / "rollout.jsonl"
+    rows = [
+        completed("turn-one", "UserMessage", "question"),
+        completed("turn-one", "AgentMessage", "progress"),
+        completed(final_turn, "AgentMessage", "final answer"),
+    ]
+    if final_turn == "other-turn":
+        rows[-1]["payload"]["item"]["phase"] = "final_answer"
+    path.write_text("".join(json.dumps(row) + "\n" for row in rows), encoding="utf-8")
+    payload = {
+        "session_id": "session",
+        "transcript_path": str(path),
+        "last_assistant_message": "rendered final answer",
+        "turn_id": "turn-one",
+    }
+    config = codex_hook.load_config()
+    assert codex_hook.capture(config, payload) is None
+    assert not list(codex_hook.queue_root(config).rglob("*.json"))
+
+
+@pytest.mark.parametrize("progress_phase", [None, "commentary"])
+def test_capture_skips_unfinished_final_record_after_retry_expires(codex_hook, tmp_path, monkeypatch, progress_phase):
+    """An expired retry window must not persist progress while the final JSON is incomplete at EOF."""
+    path = tmp_path / "rollout.jsonl"
+    question = completed("turn-one", "UserMessage", "question")
+    progress = completed("turn-one", "AgentMessage", "progress")
+    if progress_phase is not None:
+        progress["payload"]["item"]["phase"] = progress_phase
+    final = completed("turn-one", "AgentMessage", "final answer")
+    final["payload"]["item"]["phase"] = "final_answer"
+    prefix = "".join(json.dumps(row) + "\n" for row in (question, progress))
+    final_json = json.dumps(final)
+    path.write_text(prefix + final_json[:-2], encoding="utf-8")
+    payload = {
+        "session_id": "session",
+        "transcript_path": str(path),
+        "last_assistant_message": "final answer",
+        "turn_id": "turn-one",
+    }
+    monkeypatch.setattr(codex_hook, "CAPTURE_SETTLE_SECONDS", 3.0)
+    clock = iter([0.0, 3.0, 3.0])
+    monkeypatch.setattr(codex_hook.time, "monotonic", lambda: next(clock))
+    config = codex_hook.load_config()
+
+    assert codex_hook.capture(config, payload) is None
+    assert not list(codex_hook.queue_root(config).rglob("*.json"))
+    assert not list(codex_hook.queue_root(config).rglob("*.done"))
+
+    path.write_text(prefix + final_json, encoding="utf-8")
+    root = codex_hook.capture(config, payload)
+    queued = json.loads(next(root.glob("*.json")).read_text(encoding="utf-8"))
+    assert [message["content"][0]["text"] for message in queued["messages"]] == ["question", "final answer"]
+
+
 def test_does_not_cross_turns_when_turn_id_is_unknown(codex_hook, tmp_path):
     """Never capture messages from another turn."""
     path = tmp_path / "rollout.jsonl"