From 097f6c82706e5220d3c7b52dce6bf36114fdc647 Mon Sep 17 00:00:00 2001 From: "jinli.yl" Date: Thu, 20 Aug 2026 19:47:51 +0800 Subject: [PATCH] fix(embedding_store): ensure is_healthy remains unchanged on cache hits - Updated get_embeddings docstring to clarify cache hits must not alter is_healthy state - Improved code comment for embedding dimension matching method --- reme/components/embedding_store/base_embedding_store.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/reme/components/embedding_store/base_embedding_store.py b/reme/components/embedding_store/base_embedding_store.py index c28670e7..bb7703e2 100644 --- a/reme/components/embedding_store/base_embedding_store.py +++ b/reme/components/embedding_store/base_embedding_store.py @@ -69,7 +69,7 @@ class BaseEmbeddingStore(BaseComponent): @abstractmethod async def get_embeddings(self, input_text: list[str], **kwargs) -> list[np.ndarray | None]: - """Get embeddings for texts.""" + """Get embeddings; cache hits must not change is_healthy.""" def _embedding_dim_matches(self, embedding: np.ndarray | None) -> bool: """Return whether an embedding matches the configured model dimension."""