mirror of
https://github.com/abhigyanpatwari/GitNexus.git
synced 2026-10-17 04:33:45 +00:00
5c3961756b
* fix(ingestion): re-point Go struct member edges when struct is declared in a sibling file (#3558) findEnclosingClassInfo mints a Go method's owner id from the file containing the method (Struct:<methodFile>:<Type>), while the Struct node is keyed by the file declaring the struct (parse-worker uses declFile). Same package, different file => the HAS_METHOD edge's sourceId points at a node that does not exist and the edge is silently dropped at COPY into LadybugDB. Add reconcileGoStructOwnerEdges, run at the end of the parse phase after ALL worker chunks are merged so every package's structs are visible. It rewrites only edges that would otherwise dangle, and only when exactly one Struct node shares the dangling id's package directory and simple name; 0 or >=2 candidates keep the old drop behavior (a wrong owner is worse than a dropped edge). Index build is lazy: dangling Struct sources are rare (struct fields never dangle — they live in the struct's own file), so the common non-Go or fully-same-file case pays two per-type edge scans and no whole-node pass. Regression test: test/integration/go-cross-file-struct-owner.test.ts (fails-before: 1 HAS_METHOD edge; passes-after: 3). * fix(ingestion): scope Go struct-owner reconcile by language and package Address PR #3559 review findings: - Scope the pass to Go: dangling HAS_METHOD/HAS_PROPERTY owner ids whose Struct:<file>:<name> file is not Go source (Rust, Swift, ...) are never re-pointed, and only Struct nodes stamped language 'go' (the marker the worker sets on every declared symbol) are candidates. Negative test pins a Rust-shaped dangling edge staying untouched beside a same-name Go struct. - Key candidate structs by (dir, declared package clause, name) instead of (dir, name): one directory can carry 'package pkg' and external-test 'package pkg_test' files declaring the same type name, which the old key saw as ambiguous and dropped fail-closed. Clauses are read via the shared inferGoPackageName derivation with a call-scoped cache. Integration test covers the 3-file layout (pkg decl, pkg_test decl, pkg_test methods file) and asserts the edge lands on the pkg_test.Widget node. - Keep the direct call in parse-impl with a TODO: the pass needs a graph-level post-merge hook, which no LanguageProvider/ScopeResolver hook provides today. * refactor(ingestion): remove Go graph repair from shared parse phase * fix(ingestion): resolve Go ownership during ingestion (language-provider.ts) * Add resolveDetachedOwnerName function to Go config * Refactor method owner population logic in Go * Refactor receiver binding to handle unnamed receivers * Enhance route handler method resolution logic Refactor route handler to improve ownership resolution and method indexing. * Add emitPostResolutionEdges to scope resolver * fix(ingestion): resolve Go ownership during ingestion (ownership.ts) * fix(ingestion): resolve Go ownership during ingestion (ast-helpers.ts) * Add resolveDetachedOwnerName to provider methods * Update SCHEMA_BUMP to 141 Increment schema version to 141 for new features and fixes. * fix(ingestion): resolve Go ownership during ingestion (decl.go) * fix(ingestion): resolve Go ownership during ingestion (external_decl_test.go) * fix(ingestion): resolve Go ownership during ingestion (external_methods_test.go) * fix(ingestion): resolve Go ownership during ingestion (foreign.rs) * fix(ingestion): resolve Go ownership during ingestion (go.mod) * fix(ingestion): resolve Go ownership during ingestion (local.go) * fix(ingestion): resolve Go ownership during ingestion (methods.go) * fix(ingestion): resolve Go ownership during ingestion (go-cross-file-struct-owner.test.ts) * Refactor comments and method registration in tests Updated comments for clarity and modified method registration to include qualified names and ownership. * fix(ingestion): resolve Go ownership during ingestion (has-method.test.ts) * Update SCHEMA_BUMP to 141 in tests * refactor(ingestion): remove obsolete Go struct owner reconciliation * fix(go): model build constraints for method ownership * test(go): cover build constraint grammar and platform variants * fix(go): resolve method owners across compatible build variants * test(go): verify variant ownership through ingestion pipeline This test verifies that build-variant owners are consistent across different workers, the semantic registry, and the graph. It sets up various scenarios to ensure that ownership is correctly resolved and that there are no dangling edges in the ownership graph. * fix(go): reject impossible known constraints when peer is unknown Address PR #3559 review feedback. Regression coverage follows in this update. * feat(ingestion): allow providers to group incremental resolution files Add the optional language-neutral hook used by the Go ownership writeback fix for PR #3559. * fix(go): group sibling files for incremental ownership resolution Use the existing Go package-directory key for the provider hook. * fix(incremental): collect sibling resolution groups for changed paths Keep group keys local to each provider and include current siblings of deleted files. * fix(analyze): persist ownership changes in unchanged Go siblings Expand changed and deleted resolution groups before importer traversal. Use the same effective file set for deletion and writeback so package-wide ownership changes reach the database. * test(incremental): cover provider-local resolution groups Cover changed, added, deleted and unrelated paths for the new sibling expansion helper. * test(go): compare incremental ownership writes with cold rebuilds Reproduce ownership changes after deleting and restoring a Windows declaration while the shared method file stays unchanged. Verify incremental writes and persisted ownership parity with forced rebuilds. * test(go): exclude impossible owners with unknown method constraints Use real parsing to cover impossible owner edges and valid owners hidden by impossible competitors. * test(go): pin filename rules and unknown constraint overlap Document Go first-dot filename behavior and verify impossible known constraints in both operand orders. * test(go): register incremental ownership coverage across platforms Include the new database-backed Go ownership suite in the cross-platform test list. * test(go): schedule incremental ownership suite with native database tests Complete PR #3559 review fixes. Local validation: 47 focused tests across five suites passed; build and source/test type checks passed. The full suite was interrupted without a result. * refactor(ingestion): centralize worker owner hook forwarding Pass the language provider into the private cached owner lookup instead of repeating four owner hooks at five call sites. Keep qualified-name selection explicit and preserve the exported helper signature. Validation: CLI/shared build and test typecheck pass; repository lint has no errors; 591 tests pass with one skipped across 13 ownership and worker suites. Web typecheck is blocked by uninstalled web dependencies. Graph checks are unavailable because this checkout has no registered index. * test(rename): add Go cross-file fixture module Part of the cross-file method ownership regression for PR #3559. The completed fixture uses real indexing, public rename preview/apply, warm cache replay and post-rename reindexing. All 14 Go rename integration cases pass locally. * test(rename): add cross-file fixture before/types.go * test(rename): add cross-file fixture before/methods.go * test(rename): add cross-file fixture before/callers.go * test(rename): add cross-file fixture after/go.mod * test(rename): add cross-file fixture after/types.go * test(rename): add cross-file fixture after/methods.go * test(rename): add cross-file fixture after/callers.go * Add test case for renaming pointer receiver method Complete the real persisted-index regression fixture for PR #3559. The type, pointer receiver method and callers are in separate Go files. Public rename preview/apply must make exactly four edits across the structural interface family while preserving an unrelated same-name method, comments and strings. The fixture checks six exact ownership, interface and call edges before rename, after warm parse-cache replay and after reindexing the edited sources. All 14 Go rename integration cases pass. Formatting and the CLI typecheck pass. Graph impact/detect-changes could not run because this checkout has no registered index. --------- Co-authored-by: System administrator <root@nixos-infra.home> Co-authored-by: Gergő Magyar <gergomagyar@icloud.com> |
||
|---|---|---|
| .. | ||
| c | ||
| cpp | ||
| csharp | ||
| go | ||
| java | ||
| javascript | ||
| objective-c | ||
| php | ||
| python | ||
| ruby | ||
| rust | ||
| swift | ||
| typescript | ||
| vue | ||
| c3-linearize-strategy.test.ts | ||
| callable-flow-captures.test.ts | ||
| callable-value-flow-env.test.ts | ||
| callable-value-flow-worklist.test.ts | ||
| callable-value-target-index.test.ts | ||
| cobol-import-target-parity.test.ts | ||
| construction-syntax-wiring.test.ts | ||
| def-index.test.ts | ||
| definition-id.test.ts | ||
| emit-references.test.ts | ||
| esm-export-marker.test.ts | ||
| external-import-conformance.test.ts | ||
| finalize-algorithm.test.ts | ||
| finalize-orchestrator.test.ts | ||
| free-call-fallback-guess-taint.test.ts | ||
| function-local-import-chain.test.ts | ||
| generic-instantiation.test.ts | ||
| graph-bridge-label-split.test.ts | ||
| heritage-type-arguments.test.ts | ||
| import-scope-provenance.test.ts | ||
| import-target-adapter.test.ts | ||
| import-target-index-parity.test.ts | ||
| import-target-index-reuse.contract.test.ts | ||
| imported-return-types.test.ts | ||
| imports-to-edges-deferred.test.ts | ||
| imports-to-edges-type-only.test.ts | ||
| lexical-name-claims.test.ts | ||
| method-dispatch-index.test.ts | ||
| module-scope-index.test.ts | ||
| name-fallback-summary.test.ts | ||
| name-fallback-visibility.test.ts | ||
| namespace-channel-lookup.test.ts | ||
| namespace-member-visibility.test.ts | ||
| namespace-target-cache.test.ts | ||
| namespace-targets-import-path.test.ts | ||
| node-lookup-determinism.test.ts | ||
| overload-narrowing.test.ts | ||
| parse-worker-scope-integration.test.ts | ||
| php-import-target-parity.test.ts | ||
| pick-implicit-this-overload.test.ts | ||
| pick-unique-global-callable.test.ts | ||
| pick-unique-global-class.test.ts | ||
| position-index.test.ts | ||
| property-dispatch-fanout-env.test.ts | ||
| property-name-index.test.ts | ||
| qualified-name-index.test.ts | ||
| receiver-chain-fold.test.ts | ||
| receiver-chain-wiring.test.ts | ||
| reconcile-ownership.test.ts | ||
| references-to-edges-call-form.test.ts | ||
| registries.test.ts | ||
| resolve-ambiguous-inheritance-base.test.ts | ||
| resolve-references.test.ts | ||
| resolve-type-ref.test.ts | ||
| resolved-callee-names.test.ts | ||
| run-progress.test.ts | ||
| rust-cargo-targets.test.ts | ||
| scope-extractor.test.ts | ||
| scope-id.test.ts | ||
| scope-source-content-policy.test.ts | ||
| scope-tree.test.ts | ||
| strip-cast-wrappers.test.ts | ||
| swift-extension-owners.test.ts | ||
| swift-target-grouping.test.ts | ||
| type-parameters.test.ts | ||
| type-value-namespaces.test.ts | ||
| undecided-satisfaction.test.ts | ||
| unresolved-receiver-files.test.ts | ||
| unresolved-receivers.test.ts | ||
| validate-bindings-immutability.test.ts | ||
| value-ref-dispatchability.test.ts | ||
| value-ref-namespace-precedence.test.ts | ||
| walkers-augmentations.test.ts | ||
| wildcard-collision-export-evidence.test.ts | ||
| wildcard-topLevelOnly-gate.test.ts | ||
| workspace-index.test.ts | ||