henry201605 eeea46466b fix(group): handle named annotation args in Java Spring route extraction (#1834) ... * fix(group): handle named annotation args in Java Spring route extraction The Java HTTP plugin only matched positional `@RequestMapping("/path")` syntax for class-level prefixes and method-level routes. Named argument forms (`path = "/path"` and `value = "/path"`) produce an `element_value_pair` AST node that the tree-sitter queries did not cover, causing the class prefix to be lost and named-arg method routes to be missed entirely during cross-repo contract extraction. Add a second pattern to both SPRING_CLASS_PREFIX_PATTERNS and SPRING_METHOD_ROUTE_PATTERNS matching the element_value_pair structure. * fix(group): constrain Spring named-arg query to path/value keys + add regression tests Address Claude review on PR #1834. The named-argument patterns added in 8b6fa6e used `value: (string_literal)` (a tree-sitter field selector for the right-hand side of element_value_pair), which matched ANY annotation member with a string value — not just `path`/`value`. Concrete fallout (without this fix): @GetMapping(produces = "application/json") → bogus http::GET::/application/json @GetMapping(name = "listUsers", value = "/users") → extra http::GET::/listUsers @RequestMapping(headers = "X-Foo=bar", path = "/api") → class prefix could be set to "X-Foo=bar" because prefixByClassId.set runs per match in document order, so the LAST element_value_pair wins. The sibling topic-patterns/java.ts already demonstrates the correct shape: constrain the `key:` field to the route member names. This commit: - Adds `key: (identifier) @key (#match? @key "^(path|value)$")` to both SPRING_CLASS_PREFIX_PATTERNS and SPRING_METHOD_ROUTE_PATTERNS named-arg queries. - Adds 9 regression tests under `provider extraction — source-scan fallback (Strategy B)`: * @RequestMapping(path = "/api/v3") class prefix * @RequestMapping(value = "/orders") class prefix * @GetMapping(value = "/users") method route * @PostMapping(path = "/users") method route * mixed: class named-arg + method positional * mixed: class positional + method named-arg * @GetMapping(produces = "application/json") → no provider emitted * @GetMapping(name = "listUsers", value = "/users") → exactly one provider with path "/users", no /listUsers route * @RequestMapping(path = "/api", name = "myApi") → prefix is /api, not myApi (verifies the class-prefix overwrite scenario) Tests: 42/42 pass in http-route-extractor.test.ts; 522/522 pass under test/unit/group; npx tsc --noEmit clean. * test(group): add @GetMapping(path = ...) case to match review checklist verbatim Claude review on PR #1834 explicitly asked for the method-level `@GetMapping(path = "/users")` case. The previous commit covered it indirectly by exercising path= on @PostMapping (the Spring method annotations share the same query, so any verb proves the path= field is matched). Add a dedicated GET+path= test so the reviewer's checklist is satisfied 1:1, and keep the POST+path= case as a bonus verb-coverage test. Tests: 43/43 pass in http-route-extractor.test.ts. --------- Co-authored-by: henry <zhangwei2017@unipus.cn> Co-authored-by: Gergő Magyar <gergomagyar@icloud.com>		2026-05-27 07:35:46 +01:00
..
fixtures	feat(cpp): rank user-defined conversions (#1829)	2026-05-27 06:36:23 +01:00
helpers	fix(test): use retry cleanup in antigravity e2e to prevent ENOTEMPTY flake (#1838)	2026-05-26 15:40:08 +01:00
integration	feat(cpp): rank user-defined conversions (#1829)	2026-05-27 06:36:23 +01:00
unit	fix(group): handle named annotation args in Java Spring route extraction (#1834)	2026-05-27 07:35:46 +01:00
utils	fix: skip Claude augment hook when GitNexus server owns DB (#1493)	2026-05-14 16:39:30 +01:00