mirror of
https://github.com/abhigyanpatwari/GitNexus.git
synced 2026-09-16 23:43:12 +00:00
* fix(lib): add stripWindowsLongPathPrefix for path comparisons (#2667) A caller can hand GitNexus a `\\?\`-prefixed path — the usual MAX_PATH workaround on Windows — and `path.resolve` preserves the prefix, so it reaches every string comparison GitNexus keys paths on. It also poisons relativization: `path.win32.relative` cannot express a relative path between a prefixed and an un-prefixed form of the same directory, so it returns the absolute target instead. That absolute string is the shape reported in #2667. The helper is deliberately scoped to the comparison domain. libuv's `fs__capture_path` does not re-add the prefix for over-MAX_PATH paths, so stripping a filesystem-facing path would break long-path access on hosts that have not opted into LongPathsEnabled. `\\?\Volume{GUID}\…` is left alone because the remainder is not a usable path. The test is fixture-free and takes an explicit `platform`, mirroring `normalizeAnalyzerRootPath`, and is registered on the cross-platform matrix since the whole transform is a POSIX no-op. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0119fkrRFdQDQKh58LY9Tqh2 * fix(storage): normalize the `\\?\` prefix in canonicalizePath (#2667) `canonicalizePath` is the single comparison key for the repo registry, MCP repo resolution and the server repo routes, and `registryPathEquals` compares its output as a plain string. A caller-supplied `\\?\` prefix therefore matched nothing: a repo registered as `D:\repo` was invisible to a caller passing `\\?\D:\repo`, which surfaces as "repo not found" or a duplicate registration from `analyze`, `remove`, `clean`, the MCP `repo` parameter and the server routes. Both branches are normalized. The realpath branch was already safe — libuv's `fs__realpath` strips the prefix itself — but the `catch` fallback returns `path.resolve(p)` untouched, and that is exactly the branch a path which is not on disk takes. Safe despite the CRITICAL blast radius (27 impacted, 12 direct dependents) because the result is only ever compared, never opened: all 23 call sites feed `registryPathEquals` or a string comparison. Both operands are canonicalized, so the equality relation is preserved and behaviour is unchanged for every un-prefixed input. The two regression assertions run only on windows-latest, where the file already runs via the cross-platform matrix. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0119fkrRFdQDQKh58LY9Tqh2 * docs(core): correct two false comments about Windows paths (#2667) Both comments assert the opposite of how the platform and the analyzer actually behave, and both would send the next investigator of #2667 the wrong way. `analyzer-identity.ts` claimed the `\\?\` prefix is one that `realpathSync.native` "can emit for paths over MAX_PATH". libuv's `fs__realpath_handle` strips the prefix unconditionally and rewrites `\\?\UNC\` back to `\\`, erroring if neither is present, so realpath never returns one. The prefix can only arrive from caller-supplied input. The optional group in the regex stays as a labelled defensive no-op, and the function's behaviour is unchanged on purpose: these identity fields are compared between an `analyze` and a later `status` run, so this is not the place to reshape a path. `include-extractor.ts` claimed "gitnexus analyze stores absolute paths in the File.filePath column". A full self-index at89bbdcf5had 0 of 239,070 nodes with an absolute or backslash-bearing filePath: File nodes are built from the walker's repo-relative forward-slash paths. The relativization guard below it stays, now described as what it is — a guard against rows this process did not write. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0119fkrRFdQDQKh58LY9Tqh2 * test(lib): pin that path.resolve preserves the `\\?\` prefix (#2667) The `canonicalizePath` regression tests for the `catch` fallback can only run on windows-latest, so the fact they rest on is invisible in the Ubuntu suite. Pin it here, in the fixture-free file that runs everywhere: `path.win32.resolve` carries the prefix through untouched, which is all the fallback branch used to do before this fix. Also pins the forward-slash spelling (`//?/D:/…`), which the helper deliberately does not match because `resolve` folds it into the backslash form first. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0119fkrRFdQDQKh58LY9Tqh2 * fix(lib): match the `\\?\UNC\` token case-insensitively (#2667) The namespace `\\?\` addresses is the Windows object namespace, which is case-insensitive, so `\\?\unc\server\share` is as valid as the uppercase spelling. Matching only `UNC` left the lowercase form prefixed, which is the same registry mismatch #2667 is about, reached through a network share instead of a drive. The drive branch was already case-insensitive (`[A-Za-z]`), so the two branches disagreed with each other. Probed against the built artifact: `\\?\unc\…`, `\\?\Unc\…` and `\\?\UNC\…` now all yield `\\server\share\…`, and `\\?\Volume{…}` is still left alone. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0119fkrRFdQDQKh58LY9Tqh2 * test(storage): guard the canonicalizePath fix on Linux too (#2667) The two `canonicalizePath` assertions in `repo-manager.test.ts` drive the real `realpathSync.native`, so they are `it.skipIf(win32)` and only run on the windows-latest matrix leg. The Ubuntu gate — the one every PR runs — had no coverage of the behaviour at all. This runs the same wiring anywhere by injecting only the platform primitives: `path` becomes `path.win32` (Node's real Windows path implementation, not a stand-in), `realpathSync.native` gets its two actual behaviours (libuv strips `\\?\` for a path on disk, throws ENOENT for one that is not), and the real `stripWindowsLongPathPrefix` is pinned to win32 rather than defaulting to the host. `canonicalizePath` and `registryPathEquals` run unmodified. Pinning the helper is a module mock rather than an override of `process.platform`, which is shared by every test file in a worker. Verified to discriminate: against the pre-fix tree at89bbdcf5it fails 3 of 5, and reverting just the two strip calls on this branch reproduces the same 3 failures with `expected '\\?\D:\Projects\moved-away' to be 'D:\Projects\moved-away'`. The two that pass either way are the realpath branch and the un-prefixed no-op, neither of which ever leaked. Not registered in scripts/cross-platform-tests.ts: it simulates Windows rather than needing it, so its home is the Ubuntu suite. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0119fkrRFdQDQKh58LY9Tqh2 * fix(lib): require the component that makes a stripped path usable (#2667) Both regexes were under-anchored, so the slice could emit something worse than the input it was handed. `\\?\UNC` has no share to keep and became the bare root `\\`; `\\?\D:foo` is drive-relative and became `D:foo`, which is not absolute and would resolve against the process cwd if a future caller ever passed it to `fs`. `canonicalizePath` previously always returned an absolute path and had stopped doing so. Each pattern now requires the part that makes the remainder a real path — a share name after `UNC\`, a separator after the drive colon. Malformed extended paths are left untouched and simply fail to match a registry entry, which is the safe direction. Also from review: document `\\.\` as a deliberate non-goal alongside `\\?\Volume{GUID}\` (most of what it addresses is not a filesystem path), correct the canonicalizePath docblock, which still claimed entries are canonicalised at write time — `registerRepo` stores `path.resolve` and the paragraph added two lines above says compare-only — and reword the cross-platform registration comment, which claimed the test is only meaningful on windows-latest when every assertion passes an explicit 'win32' and runs identically on Ubuntu. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0119fkrRFdQDQKh58LY9Tqh2 * fix(group): keep repo-relative rows in the graph provider strategy (#2667) `extractProvidersGraph` relativised every row with `path.relative(normalizedRepoPath, absolute)`. The rows analyze actually writes are repo-relative — which is exactly what the comment corrected earlier in this branch establishes — and `path.relative` resolves a relative second argument against the PROCESS CWD. So from any cwd other than the repo root, every row came back `..`-prefixed, the containment guard dropped it, and the strategy silently returned [] and fell through to the filesystem fallback. Only absolute rows go through `path.relative` now. The containment guard is unchanged, so foreign and escaping rows are still rejected. Found by three independent reviewers reading the comment this branch corrected and following it to its consequence. The regression test fails without the guard (`expected false to be true`) and passes with it; vitest runs from `gitnexus/`, never the fixture dir, so it exercises the cwd mismatch by construction. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0119fkrRFdQDQKh58LY9Tqh2 * test: close the coverage gaps the review surfaced (#2667) Adds the assertions the reviewers named as missing, and corrects one more comment that gave the right conclusion for the wrong reason. analyzer-identity: the comment said the `\\?\` prefix is preserved so the identity fields keep a stable compare shape. That is true but secondary. The load-bearing reason is that these roots are READ FROM — resolveBuildRoot joins package.json onto packageRoot, collectBuildEntries walks buildRoot, and the lockfile lookup walks packageRoot's ancestors — so stripping here would break analyzer identity on a deep checkout for exactly the reason the ingress strip was withdrawn. Helper: near-miss spellings (`\\??\`, `\\?\\`, single-backslash, GLOBALROOT) and forward-slash/mixed-separator forms are pinned as untouched, plus degenerate and empty input. canonicalizePath: volume-GUID and `\\.\` are asserted unmatched through canonicalizePath itself, not just the helper, so the deliberate branch asymmetry is pinned where it is consumed. assertSafeStoragePath: prefixed path + prefixed storagePath passes, mixed form throws. This guard fronts fs.rm(recursive) and deliberately does NOT canonicalize; "complete the fix by stripping here too" is the tempting follow-up and would widen what the recursive delete accepts. resolveRegisteredRepoEntry: the consumer surface the fix exists for — an MCP `repo` argument or `?repo=` value in the prefixed spelling now resolves its un-prefixed entry, and a prefixed path naming no entry still fails closed. Verified to discriminate: reverting the strip fails this test along with the three catch-branch ones. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0119fkrRFdQDQKh58LY9Tqh2 --------- Co-authored-by: Gergo Magyar <gergomagyar0@gmail.com> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
236 lines
12 KiB
TypeScript
236 lines
12 KiB
TypeScript
/**
|
|
* Cross-platform test subset runner.
|
|
*
|
|
* Runs only the tests that exercise platform-sensitive behavior on
|
|
* Windows and macOS. The full suite runs on Ubuntu; this narrows the
|
|
* cross-platform matrix to tests that actually vary across OSes.
|
|
*
|
|
* Categories included:
|
|
* - Platform-specific logic (path.sep, process.platform guards)
|
|
* - Native addon loading (LadybugDB, tree-sitter)
|
|
* - Process spawning and shell behavior
|
|
* - Filesystem locking and temp-dir behavior
|
|
* - Worker threads (real, not mocked)
|
|
* - CLI end-to-end tests
|
|
*
|
|
* When adding a new test that uses platform-varying APIs (native addons,
|
|
* child_process with real spawning, filesystem locking, path.sep), add
|
|
* it to the appropriate section below.
|
|
*
|
|
* Usage:
|
|
* npx vitest run $(npx tsx scripts/cross-platform-tests.ts)
|
|
* # or via the package script:
|
|
* npm run test:cross-platform
|
|
*/
|
|
|
|
// Platform-specific logic tests — contain explicit process.platform guards
|
|
// or test behavior that differs across operating systems
|
|
const PLATFORM_LOGIC = [
|
|
'test/unit/setup.test.ts',
|
|
'test/unit/setup-jsonc.test.ts',
|
|
'test/unit/setup-codex.test.ts',
|
|
'test/unit/setup-antigravity.test.ts',
|
|
'test/integration/setup-uninstall-roundtrip.test.ts',
|
|
'test/unit/resolve-invocation.test.ts',
|
|
// CLI-spawn entry-point resolution; its path-separator assertion (cli[/\\]index)
|
|
// must exercise the Windows backslash branch, so run it on the OS matrix (#2394).
|
|
'test/unit/cli-entry.test.ts',
|
|
'test/unit/platform-capabilities.test.ts',
|
|
// Windows drive-letter case variance in the analyzer runner-identity path
|
|
// fields (#2668): normalizeAnalyzerRootPath is a POSIX no-op, so the
|
|
// "identity path fields are normalizer-stable" fixpoint guard only bites on
|
|
// the windows-latest matrix — it must run there, not just in the Ubuntu
|
|
// full-suite where it's trivially green. Deliberately the split-out
|
|
// normalization file, NOT analyzer-identity.test.ts: the latter's fixture
|
|
// tests compare identity fields against raw temp-dir paths and fail on macOS,
|
|
// where /var/... realpaths to /private/var/....
|
|
'test/unit/analyzer-identity-path-normalization.test.ts',
|
|
// `isInside` containment guard vs Windows cross-drive paths: path.relative
|
|
// returns the absolute target across drives, so the guard needs isAbsolute.
|
|
// Fixture-free and pathApi-injectable, so it is portable to every runner.
|
|
'test/unit/analyzer-identity-is-inside.test.ts',
|
|
// `\\?\` extended-length prefix normalization (#2667): fixture-free and
|
|
// platform-injectable (every assertion passes an explicit 'win32'), so like the
|
|
// is-inside guard above it is portable to every runner and its assertions run
|
|
// identically here and on Ubuntu. Registered alongside its two siblings so the
|
|
// Windows path-handling guards stay discoverable as one group. Same
|
|
// mixed-prefix relativize hazard as is-inside, reached through a
|
|
// caller-supplied path.
|
|
'test/unit/windows-long-path-prefix.test.ts',
|
|
// getconf page-size probe: explicit process.platform gate (win32 short-circuit)
|
|
// plus a live-probe test whose only real non-4K coverage is macos-arm64's
|
|
// 16 KiB pages — the exact hardware class #1231 targets (#2424 review).
|
|
'test/unit/lbug-config-pagesize.test.ts',
|
|
'test/unit/worker-pool-windows-quarantine.test.ts',
|
|
'test/unit/lbug-pool-fts-load.test.ts',
|
|
'test/unit/repo-manager.test.ts',
|
|
'test/unit/repo-manager-finalize-invariant.test.ts',
|
|
'test/unit/git-utils.test.ts',
|
|
'test/unit/hooks.test.ts',
|
|
'test/unit/hook-db-lock-probe.test.ts',
|
|
'test/unit/cursor-hook.test.ts',
|
|
'test/unit/sidecar-recovery.test.ts',
|
|
'test/unit/pool-wal-recovery.test.ts',
|
|
'test/unit/lbug-adapter-wal-schema.test.ts',
|
|
'test/unit/detect-changes-worktree.test.ts',
|
|
'test/unit/eval-server-bind-restriction.test.ts',
|
|
'test/unit/ignore-service.test.ts',
|
|
'test/unit/group/bridge-db.test.ts',
|
|
'test/unit/group/bridge-db-edge.test.ts',
|
|
'test/unit/onnxruntime-node-resolver.test.ts',
|
|
// Windows cmd.exe arg-quoting + compose-and-spawn for the npm install (#2372):
|
|
// the quoting rules and win32 single-string spawn shape are OS-sensitive, so
|
|
// exercise them on real windows-latest. The spawn-shape/path tests force their
|
|
// platform branch and derive expected paths via the real fns, so they pass on
|
|
// any host (see the platform stubs + resolve() in the test file).
|
|
'test/unit/embedding-runtime-install.test.ts',
|
|
// Real-spawn arg-delivery round-trip: proves the install spawn delivers args
|
|
// to the child intact on each platform — win32 via the cmd.exe -> .cmd %* ->
|
|
// node chain (real cmd.exe, not just our model), macos/linux via the no-shell
|
|
// array form. Runs on every platform (the ubuntu suite covers Linux; this
|
|
// registration adds windows + macos).
|
|
'test/unit/embedding-install-arg-delivery.test.ts',
|
|
// Structural FTS-extension classifier against REAL binaries (#2374): on this
|
|
// matrix `process.execPath` / `lbugjs.node` are a real PE (windows) and Mach-O
|
|
// (macos), so the header parsing is proven on genuine binaries, not synthetic
|
|
// buffers (the ubuntu suite covers the ELF path).
|
|
'test/integration/extension-binary-real.test.ts',
|
|
// Server repo resolver branches on path shape (path.isAbsolute, backslash
|
|
// detection) and canonicalizePath/realpathSync, all of which differ between
|
|
// POSIX and Windows — the fail-closed path-claim semantics must hold on the
|
|
// real windows-latest path implementation (#2419/#2420).
|
|
'test/unit/server-api-repo-resolution.test.ts',
|
|
// The index write-lock (#2658) selects its backend by process.platform — the
|
|
// OS socket lock (Windows named pipe / Linux abstract socket) vs the file
|
|
// fallback — and its socket-backend describe block is gated to linux/win32.
|
|
// The Ubuntu suite only proves the Linux abstract-socket path, so run it here
|
|
// to exercise the Windows named-pipe backend and the macOS file fallback on
|
|
// their real platforms (#2658 review H3).
|
|
'test/unit/index-lock.test.ts',
|
|
];
|
|
|
|
// Native LadybugDB integration tests — exercise the @ladybugdb/core
|
|
// N-API addon which has known platform-specific behavior (Windows
|
|
// file-lock lag after close, macOS N-API destructor segfaults)
|
|
const LBUG_NATIVE = [
|
|
'test/integration/lbug-core-adapter.test.ts',
|
|
'test/integration/lbug-vector-extension.test.ts',
|
|
'test/integration/lbug-pool.test.ts',
|
|
'test/integration/lbug-pool-stability.test.ts',
|
|
'test/integration/lbug-lock-retry.test.ts',
|
|
'test/integration/lbug-open-retry.test.ts',
|
|
'test/integration/lbug-close-handle-release.test.ts',
|
|
'test/integration/lbug-orphan-sidecar-recovery.test.ts',
|
|
'test/integration/lbug-readonly-init.test.ts',
|
|
'test/integration/lbug-non-ascii-path.test.ts',
|
|
// Cross-repo trace e2e: builds two real lbug indexes + a real bridge and
|
|
// opens them through the pool adapter (native addon + bridge file locking).
|
|
// Windows is skipped in-file (describeReopen) due to the bridge reopen lock.
|
|
'test/integration/group/cross-trace-e2e.test.ts',
|
|
'test/integration/local-backend.test.ts',
|
|
'test/integration/local-backend-calltool.test.ts',
|
|
'test/integration/search-core.test.ts',
|
|
'test/integration/search-pool.test.ts',
|
|
'test/integration/fts-description-search.test.ts',
|
|
'test/integration/staleness-and-stability.test.ts',
|
|
'test/integration/analyze-wal-checkpoint-failure.test.ts',
|
|
'test/integration/fts-stemmer-sweep.test.ts',
|
|
'test/integration/lbug-multiwriter-deadlock.test.ts',
|
|
// #2409 batched incremental writeback: chunked IN-list DETACH DELETEs +
|
|
// backslash quote escaping against the REAL native engine — the failing
|
|
// environment for #2409 was Windows, so the write pattern must be proven
|
|
// on the windows-latest native addon, not just Ubuntu.
|
|
'test/integration/lbug-delete-nodes-for-files.test.ts',
|
|
// #2409 defect 2: dirty-flag recovery parks lbug.wal/.shadow (rename next
|
|
// to a live native DB, rm-then-rename over an existing parked copy) before
|
|
// any open — rename semantics are exactly what differs on Windows.
|
|
'test/unit/incremental-dirty-recovery.test.ts',
|
|
// #2623: the incremental writeback must load VECTOR before the CodeEmbedding
|
|
// join-delete, and the blocked path must escalate instead of crashing. The
|
|
// win32 VECTOR gate was removed in the same PR, so this ordering must be
|
|
// proven on the windows-latest native addon, not just Ubuntu. Budget: ~25s
|
|
// on Linux → expect ~2min on the slowest Windows shard.
|
|
'test/unit/incremental-vector-extension-ordering.test.ts',
|
|
];
|
|
|
|
// Process spawning and CLI tests — exercise child_process with real
|
|
// process spawning, which behaves differently across platforms (shell
|
|
// quoting, path resolution, signal handling)
|
|
const SPAWN_CLI = [
|
|
'test/integration/cli-e2e.test.ts',
|
|
'test/integration/cli-limit-e2e.test.ts',
|
|
'test/integration/hooks-e2e.test.ts',
|
|
'test/integration/skills-e2e.test.ts',
|
|
// Spawns the real CLI across hermetic HOME/USERPROFILE homes to exercise the
|
|
// FTS extension lifecycle — the #2374 bug was Windows-reported, so this must
|
|
// run on the Windows/macOS matrix, not just the Ubuntu full suite.
|
|
'test/integration/fts-extension-e2e.test.ts',
|
|
'test/integration/server-http-startup.test.ts',
|
|
'test/integration/mcp/server-startup.test.ts',
|
|
'test/integration/analyze-heap-oom-e2e.test.ts',
|
|
'test/integration/group/group-cli.test.ts',
|
|
'test/integration/cli/tool-no-index-stderr.test.ts',
|
|
'test/integration/setup-skills.test.ts',
|
|
'test/integration/setup-antigravity.test.ts',
|
|
'test/integration/antigravity-hook-e2e.test.ts',
|
|
'test/unit/local-cli-subprocess.test.ts',
|
|
'test/unit/runner-exec-tail.test.ts',
|
|
// Real cross-process single-writer lock coordination (#2658): child processes
|
|
// contend for the lock and race to reclaim a dead holder. Process spawning,
|
|
// kernel socket auto-release (Win named pipe / Linux abstract socket), and the
|
|
// FILE-backend rename-steal reclaim (macOS/BSD default) all vary across OSes —
|
|
// the exact behaviors the Windows/macOS matrix must prove. macOS timing first
|
|
// exposed a file-backend double-admit race here (#2658 review); the reclaim is
|
|
// now judgment-verified so a live holder is never displaced.
|
|
'test/integration/analyze-index-lock-concurrency.test.ts',
|
|
];
|
|
|
|
// Worker threads tests — exercise real worker_threads which have
|
|
// platform-specific behavior (thread spawning, IPC, exit handling)
|
|
const WORKER_THREADS = [
|
|
'test/integration/worker-pool.test.ts',
|
|
'test/integration/parse-impl-quarantine-cache-skip.test.ts',
|
|
];
|
|
|
|
// Tree-sitter native addon smoke tests — verify that native grammars
|
|
// load correctly on each platform (binary compatibility, .node loading)
|
|
const NATIVE_ADDON_SMOKE = [
|
|
'test/integration/tree-sitter-languages.test.ts',
|
|
'test/integration/parsing.test.ts',
|
|
'test/integration/pipeline.test.ts',
|
|
'test/integration/pipeline-graph-golden.test.ts',
|
|
'test/unit/parser-loader.test.ts',
|
|
'test/unit/parser-loader-abi.test.ts',
|
|
];
|
|
|
|
// Filesystem behavior tests — exercise operations that vary across
|
|
// platforms (CRLF, symlinks, permissions, temp dirs)
|
|
const FILESYSTEM = [
|
|
'test/integration/filesystem-walker.test.ts',
|
|
'test/integration/markdown-processor-crlf.test.ts',
|
|
'test/integration/ignore-and-skip-e2e.test.ts',
|
|
];
|
|
|
|
const ALL_CROSS_PLATFORM = [
|
|
...PLATFORM_LOGIC,
|
|
...LBUG_NATIVE,
|
|
...SPAWN_CLI,
|
|
...WORKER_THREADS,
|
|
...NATIVE_ADDON_SMOKE,
|
|
...FILESYSTEM,
|
|
];
|
|
|
|
// When invoked directly, print the file list for vitest consumption
|
|
if (process.argv[1]?.endsWith('cross-platform-tests.ts')) {
|
|
console.log(ALL_CROSS_PLATFORM.join('\n'));
|
|
}
|
|
|
|
export {
|
|
ALL_CROSS_PLATFORM,
|
|
PLATFORM_LOGIC,
|
|
LBUG_NATIVE,
|
|
SPAWN_CLI,
|
|
WORKER_THREADS,
|
|
NATIVE_ADDON_SMOKE,
|
|
FILESYSTEM,
|
|
};
|