mirror of
https://github.com/abhigyanpatwari/GitNexus.git
synced 2026-08-28 05:25:25 +00:00
84b4402cd1
* fix: remove hardcoded 300-flows cap for large repositories The dynamicMaxProcesses was capped at 300 via Math.min(300, ...), causing large repositories (280K+ nodes) to lose execution flows. Change: Remove the Math.min(300, ...) cap, keep dynamic calculation. Effect: 280K-node repo: 300 → 1617 flows. * test: add regression for dynamic maxProcesses sizing (#2198) Verify that processProcesses honours maxProcesses > 300 without truncation. Addresses the optional follow-up suggested by @koriyoshi2041. * test: exercise computeDynamicMaxProcesses at the phase layer (#2198) Extract from the inline expression in so the regression test can exercise the function that actually contained the removed cap. The previous test called directly with , which passes regardless of whether the phase-level cap is present — never had the cap. The new test suite covers: - floor (20) for tiny repos - linear scaling in the 0–3000 range - growth past 300 for large repos (the actual regression) - explicit assertion that reintroducing Math.min(300, …) would fail Addresses review feedback from @azizur100389. --------- Co-authored-by: Ubuntu <ubuntu@localhost.localdomain> Co-authored-by: Gergő Magyar <gergomagyar@icloud.com>
562 lines
17 KiB
TypeScript
562 lines
17 KiB
TypeScript
import { describe, it, expect, vi } from 'vitest';
|
||
import {
|
||
processProcesses,
|
||
type ProcessDetectionConfig,
|
||
} from '../../src/core/ingestion/process-processor.js';
|
||
import { computeDynamicMaxProcesses } from '../../src/core/ingestion/pipeline-phases/processes.js';
|
||
import { createKnowledgeGraph } from '../../src/core/graph/graph.js';
|
||
import type { CommunityMembership } from '../../src/core/ingestion/community-processor.js';
|
||
|
||
describe('processProcesses', () => {
|
||
it('detects no processes in empty graph', async () => {
|
||
const graph = createKnowledgeGraph();
|
||
const result = await processProcesses(graph, []);
|
||
expect(result.processes).toHaveLength(0);
|
||
expect(result.steps).toHaveLength(0);
|
||
expect(result.stats.totalProcesses).toBe(0);
|
||
expect(result.stats.entryPointsFound).toBe(0);
|
||
expect(result.stats.avgStepCount).toBe(0);
|
||
});
|
||
|
||
it('detects no processes when there are no CALLS relationships', async () => {
|
||
const graph = createKnowledgeGraph();
|
||
graph.addNode({
|
||
id: 'func:main',
|
||
label: 'Function',
|
||
properties: {
|
||
name: 'main',
|
||
filePath: 'src/index.ts',
|
||
startLine: 1,
|
||
endLine: 10,
|
||
isExported: true,
|
||
},
|
||
});
|
||
|
||
const result = await processProcesses(graph, []);
|
||
expect(result.processes).toHaveLength(0);
|
||
});
|
||
|
||
it('detects a simple 3-step process with correct structure', async () => {
|
||
const graph = createKnowledgeGraph();
|
||
|
||
// Create 3 functions in a chain
|
||
graph.addNode({
|
||
id: 'func:handleRequest',
|
||
label: 'Function',
|
||
properties: {
|
||
name: 'handleRequest',
|
||
filePath: 'src/handler.ts',
|
||
startLine: 1,
|
||
endLine: 10,
|
||
isExported: true,
|
||
},
|
||
});
|
||
graph.addNode({
|
||
id: 'func:validateInput',
|
||
label: 'Function',
|
||
properties: {
|
||
name: 'validateInput',
|
||
filePath: 'src/validator.ts',
|
||
startLine: 1,
|
||
endLine: 5,
|
||
isExported: true,
|
||
},
|
||
});
|
||
graph.addNode({
|
||
id: 'func:saveToDb',
|
||
label: 'Function',
|
||
properties: {
|
||
name: 'saveToDb',
|
||
filePath: 'src/db.ts',
|
||
startLine: 1,
|
||
endLine: 8,
|
||
isExported: true,
|
||
},
|
||
});
|
||
|
||
// handleRequest -> validateInput -> saveToDb
|
||
graph.addRelationship({
|
||
id: 'call:1',
|
||
sourceId: 'func:handleRequest',
|
||
targetId: 'func:validateInput',
|
||
type: 'CALLS',
|
||
confidence: 0.9,
|
||
reason: 'import-resolved',
|
||
});
|
||
graph.addRelationship({
|
||
id: 'call:2',
|
||
sourceId: 'func:validateInput',
|
||
targetId: 'func:saveToDb',
|
||
type: 'CALLS',
|
||
confidence: 0.9,
|
||
reason: 'import-resolved',
|
||
});
|
||
|
||
const memberships: CommunityMembership[] = [
|
||
{ nodeId: 'func:handleRequest', communityId: 'community:0' },
|
||
{ nodeId: 'func:validateInput', communityId: 'community:0' },
|
||
{ nodeId: 'func:saveToDb', communityId: 'community:0' },
|
||
];
|
||
|
||
const result = await processProcesses(graph, memberships);
|
||
|
||
// Must detect at least one process
|
||
expect(result.processes.length).toBeGreaterThan(0);
|
||
|
||
// Find the process starting from handleRequest
|
||
const process = result.processes.find((p) => p.entryPointId === 'func:handleRequest');
|
||
expect(process).toBeDefined();
|
||
expect(process!.stepCount).toBe(3);
|
||
expect(process!.entryPointId).toBe('func:handleRequest');
|
||
expect(process!.terminalId).toBe('func:saveToDb');
|
||
expect(process!.processType).toBe('intra_community');
|
||
expect(process!.communities).toEqual(['community:0']);
|
||
|
||
// Verify trace order: entry -> middle -> terminal
|
||
expect(process!.trace).toEqual(['func:handleRequest', 'func:validateInput', 'func:saveToDb']);
|
||
|
||
// Verify steps are 1-indexed and in correct order
|
||
const processSteps = result.steps.filter((s) => s.processId === process!.id);
|
||
expect(processSteps).toHaveLength(3);
|
||
expect(processSteps[0]).toEqual(
|
||
expect.objectContaining({ nodeId: 'func:handleRequest', step: 1 }),
|
||
);
|
||
expect(processSteps[1]).toEqual(
|
||
expect.objectContaining({ nodeId: 'func:validateInput', step: 2 }),
|
||
);
|
||
expect(processSteps[2]).toEqual(expect.objectContaining({ nodeId: 'func:saveToDb', step: 3 }));
|
||
|
||
// Verify label is generated from entry and terminal names
|
||
expect(process!.heuristicLabel).toContain('HandleRequest');
|
||
expect(process!.heuristicLabel).toContain('SaveToDb');
|
||
|
||
// Stats should reflect the detected processes
|
||
expect(result.stats.totalProcesses).toBe(result.processes.length);
|
||
expect(result.stats.entryPointsFound).toBeGreaterThan(0);
|
||
});
|
||
|
||
it('respects maxTraceDepth config', async () => {
|
||
const graph = createKnowledgeGraph();
|
||
|
||
// Create a long chain: f0 -> f1 -> f2 -> f3 -> f4
|
||
for (let i = 0; i < 5; i++) {
|
||
graph.addNode({
|
||
id: `func:f${i}`,
|
||
label: 'Function',
|
||
properties: {
|
||
name: `f${i}`,
|
||
filePath: `src/f${i}.ts`,
|
||
startLine: 1,
|
||
endLine: 5,
|
||
isExported: true,
|
||
},
|
||
});
|
||
}
|
||
for (let i = 0; i < 4; i++) {
|
||
graph.addRelationship({
|
||
id: `call:${i}`,
|
||
sourceId: `func:f${i}`,
|
||
targetId: `func:f${i + 1}`,
|
||
type: 'CALLS',
|
||
confidence: 0.9,
|
||
reason: '',
|
||
});
|
||
}
|
||
|
||
const memberships: CommunityMembership[] = Array.from({ length: 5 }, (_, i) => ({
|
||
nodeId: `func:f${i}`,
|
||
communityId: 'community:0',
|
||
}));
|
||
|
||
// Limit to 3 steps max depth
|
||
const config: Partial<ProcessDetectionConfig> = { maxTraceDepth: 3 };
|
||
const result = await processProcesses(graph, memberships, undefined, config);
|
||
|
||
// Should still find processes, but each trace should be at most maxTraceDepth steps
|
||
expect(result.processes.length).toBeGreaterThan(0);
|
||
for (const process of result.processes) {
|
||
expect(process.stepCount).toBeLessThanOrEqual(3);
|
||
}
|
||
});
|
||
|
||
it('detects cross_community processes', async () => {
|
||
const graph = createKnowledgeGraph();
|
||
|
||
graph.addNode({
|
||
id: 'func:apiHandler',
|
||
label: 'Function',
|
||
properties: {
|
||
name: 'apiHandler',
|
||
filePath: 'src/api/handler.ts',
|
||
startLine: 1,
|
||
endLine: 10,
|
||
isExported: true,
|
||
},
|
||
});
|
||
graph.addNode({
|
||
id: 'func:dbQuery',
|
||
label: 'Function',
|
||
properties: {
|
||
name: 'dbQuery',
|
||
filePath: 'src/db/query.ts',
|
||
startLine: 1,
|
||
endLine: 5,
|
||
isExported: true,
|
||
},
|
||
});
|
||
graph.addNode({
|
||
id: 'func:formatResponse',
|
||
label: 'Function',
|
||
properties: {
|
||
name: 'formatResponse',
|
||
filePath: 'src/api/format.ts',
|
||
startLine: 1,
|
||
endLine: 5,
|
||
isExported: true,
|
||
},
|
||
});
|
||
|
||
// apiHandler -> dbQuery (cross community), apiHandler -> formatResponse (same community)
|
||
graph.addRelationship({
|
||
id: 'call:1',
|
||
sourceId: 'func:apiHandler',
|
||
targetId: 'func:dbQuery',
|
||
type: 'CALLS',
|
||
confidence: 0.9,
|
||
reason: '',
|
||
});
|
||
graph.addRelationship({
|
||
id: 'call:2',
|
||
sourceId: 'func:dbQuery',
|
||
targetId: 'func:formatResponse',
|
||
type: 'CALLS',
|
||
confidence: 0.9,
|
||
reason: '',
|
||
});
|
||
|
||
// Put them in different communities
|
||
const memberships: CommunityMembership[] = [
|
||
{ nodeId: 'func:apiHandler', communityId: 'community:api' },
|
||
{ nodeId: 'func:dbQuery', communityId: 'community:db' },
|
||
{ nodeId: 'func:formatResponse', communityId: 'community:api' },
|
||
];
|
||
|
||
const result = await processProcesses(graph, memberships);
|
||
|
||
// Must find at least one process
|
||
expect(result.processes.length).toBeGreaterThan(0);
|
||
|
||
// The process from apiHandler should be cross_community (touches api + db communities)
|
||
const crossProcess = result.processes.find((p) => p.entryPointId === 'func:apiHandler');
|
||
expect(crossProcess).toBeDefined();
|
||
expect(crossProcess!.processType).toBe('cross_community');
|
||
expect(crossProcess!.communities.length).toBeGreaterThan(1);
|
||
expect(crossProcess!.communities).toContain('community:api');
|
||
expect(crossProcess!.communities).toContain('community:db');
|
||
|
||
// Stats should count cross-community
|
||
expect(result.stats.crossCommunityCount).toBeGreaterThan(0);
|
||
});
|
||
|
||
it('excludes test files from entry points', async () => {
|
||
const graph = createKnowledgeGraph();
|
||
|
||
// Test file function
|
||
graph.addNode({
|
||
id: 'func:testMain',
|
||
label: 'Function',
|
||
properties: {
|
||
name: 'testMain',
|
||
filePath: 'test/unit/main.test.ts',
|
||
startLine: 1,
|
||
endLine: 10,
|
||
isExported: true,
|
||
},
|
||
});
|
||
graph.addNode({
|
||
id: 'func:helper',
|
||
label: 'Function',
|
||
properties: {
|
||
name: 'helper',
|
||
filePath: 'src/helper.ts',
|
||
startLine: 1,
|
||
endLine: 5,
|
||
isExported: true,
|
||
},
|
||
});
|
||
|
||
graph.addRelationship({
|
||
id: 'call:1',
|
||
sourceId: 'func:testMain',
|
||
targetId: 'func:helper',
|
||
type: 'CALLS',
|
||
confidence: 0.9,
|
||
reason: '',
|
||
});
|
||
|
||
const result = await processProcesses(graph, []);
|
||
|
||
// Test files should not be used as entry points
|
||
const testProcess = result.processes.find((p) => p.entryPointId === 'func:testMain');
|
||
expect(testProcess).toBeUndefined();
|
||
});
|
||
|
||
it('filters out low-confidence calls (below 0.5)', async () => {
|
||
const graph = createKnowledgeGraph();
|
||
|
||
graph.addNode({
|
||
id: 'func:a',
|
||
label: 'Function',
|
||
properties: { name: 'a', filePath: 'src/a.ts', startLine: 1, endLine: 5, isExported: true },
|
||
});
|
||
graph.addNode({
|
||
id: 'func:b',
|
||
label: 'Function',
|
||
properties: { name: 'b', filePath: 'src/b.ts', startLine: 1, endLine: 5, isExported: true },
|
||
});
|
||
graph.addNode({
|
||
id: 'func:c',
|
||
label: 'Function',
|
||
properties: { name: 'c', filePath: 'src/c.ts', startLine: 1, endLine: 5, isExported: true },
|
||
});
|
||
|
||
// a -> b with low confidence (fuzzy-global ambiguous), a -> c with high confidence
|
||
graph.addRelationship({
|
||
id: 'call:1',
|
||
sourceId: 'func:a',
|
||
targetId: 'func:b',
|
||
type: 'CALLS',
|
||
confidence: 0.3,
|
||
reason: 'fuzzy-global',
|
||
});
|
||
graph.addRelationship({
|
||
id: 'call:2',
|
||
sourceId: 'func:a',
|
||
targetId: 'func:c',
|
||
type: 'CALLS',
|
||
confidence: 0.9,
|
||
reason: 'import-resolved',
|
||
});
|
||
|
||
const result = await processProcesses(graph, []);
|
||
|
||
// No process should include func:b since the edge has confidence < 0.5 (MIN_TRACE_CONFIDENCE)
|
||
for (const process of result.processes) {
|
||
expect(process.trace).not.toContain('func:b');
|
||
}
|
||
});
|
||
|
||
it('handles cycles without infinite loops', async () => {
|
||
const graph = createKnowledgeGraph();
|
||
|
||
graph.addNode({
|
||
id: 'func:a',
|
||
label: 'Function',
|
||
properties: {
|
||
name: 'processItem',
|
||
filePath: 'src/a.ts',
|
||
startLine: 1,
|
||
endLine: 5,
|
||
isExported: true,
|
||
},
|
||
});
|
||
graph.addNode({
|
||
id: 'func:b',
|
||
label: 'Function',
|
||
properties: {
|
||
name: 'validate',
|
||
filePath: 'src/b.ts',
|
||
startLine: 1,
|
||
endLine: 5,
|
||
isExported: true,
|
||
},
|
||
});
|
||
graph.addNode({
|
||
id: 'func:c',
|
||
label: 'Function',
|
||
properties: {
|
||
name: 'retry',
|
||
filePath: 'src/c.ts',
|
||
startLine: 1,
|
||
endLine: 5,
|
||
isExported: true,
|
||
},
|
||
});
|
||
|
||
// a -> b -> c -> a (cycle)
|
||
graph.addRelationship({
|
||
id: 'call:1',
|
||
sourceId: 'func:a',
|
||
targetId: 'func:b',
|
||
type: 'CALLS',
|
||
confidence: 0.9,
|
||
reason: '',
|
||
});
|
||
graph.addRelationship({
|
||
id: 'call:2',
|
||
sourceId: 'func:b',
|
||
targetId: 'func:c',
|
||
type: 'CALLS',
|
||
confidence: 0.9,
|
||
reason: '',
|
||
});
|
||
graph.addRelationship({
|
||
id: 'call:3',
|
||
sourceId: 'func:c',
|
||
targetId: 'func:a',
|
||
type: 'CALLS',
|
||
confidence: 0.9,
|
||
reason: '',
|
||
});
|
||
|
||
const memberships: CommunityMembership[] = [
|
||
{ nodeId: 'func:a', communityId: 'community:0' },
|
||
{ nodeId: 'func:b', communityId: 'community:0' },
|
||
{ nodeId: 'func:c', communityId: 'community:0' },
|
||
];
|
||
|
||
// Should complete without hanging, and traces should not repeat nodes
|
||
const result = await processProcesses(graph, memberships);
|
||
for (const process of result.processes) {
|
||
const uniqueNodes = new Set(process.trace);
|
||
expect(uniqueNodes.size).toBe(process.trace.length);
|
||
}
|
||
});
|
||
|
||
it('respects minSteps default (3) — rejects 2-step traces', async () => {
|
||
const graph = createKnowledgeGraph();
|
||
|
||
// Only 2 functions: a -> b (2 steps, below default minSteps of 3)
|
||
graph.addNode({
|
||
id: 'func:caller',
|
||
label: 'Function',
|
||
properties: {
|
||
name: 'caller',
|
||
filePath: 'src/caller.ts',
|
||
startLine: 1,
|
||
endLine: 5,
|
||
isExported: true,
|
||
},
|
||
});
|
||
graph.addNode({
|
||
id: 'func:callee',
|
||
label: 'Function',
|
||
properties: {
|
||
name: 'callee',
|
||
filePath: 'src/callee.ts',
|
||
startLine: 1,
|
||
endLine: 5,
|
||
isExported: true,
|
||
},
|
||
});
|
||
|
||
graph.addRelationship({
|
||
id: 'call:1',
|
||
sourceId: 'func:caller',
|
||
targetId: 'func:callee',
|
||
type: 'CALLS',
|
||
confidence: 0.9,
|
||
reason: '',
|
||
});
|
||
|
||
const result = await processProcesses(graph, []);
|
||
|
||
// Default minSteps is 3, so a 2-step trace (caller -> callee) should be rejected
|
||
expect(result.processes).toHaveLength(0);
|
||
});
|
||
|
||
it('calls progress callback with messages', async () => {
|
||
const graph = createKnowledgeGraph();
|
||
const onProgress = vi.fn();
|
||
|
||
await processProcesses(graph, [], onProgress);
|
||
|
||
expect(onProgress).toHaveBeenCalled();
|
||
// Verify callback receives (message: string, progress: number)
|
||
const [message, progress] = onProgress.mock.calls[0];
|
||
expect(typeof message).toBe('string');
|
||
expect(typeof progress).toBe('number');
|
||
expect(progress).toBeGreaterThanOrEqual(0);
|
||
expect(progress).toBeLessThanOrEqual(100);
|
||
});
|
||
|
||
it('limits output to maxProcesses', async () => {
|
||
const graph = createKnowledgeGraph();
|
||
|
||
// Create many independent 3-step chains to generate many processes
|
||
for (let chain = 0; chain < 10; chain++) {
|
||
for (let step = 0; step < 3; step++) {
|
||
graph.addNode({
|
||
id: `func:chain${chain}_f${step}`,
|
||
label: 'Function',
|
||
properties: {
|
||
name: `chain${chain}_f${step}`,
|
||
filePath: `src/chain${chain}/f${step}.ts`,
|
||
startLine: 1,
|
||
endLine: 5,
|
||
isExported: true,
|
||
},
|
||
});
|
||
}
|
||
for (let step = 0; step < 2; step++) {
|
||
graph.addRelationship({
|
||
id: `call:chain${chain}_${step}`,
|
||
sourceId: `func:chain${chain}_f${step}`,
|
||
targetId: `func:chain${chain}_f${step + 1}`,
|
||
type: 'CALLS',
|
||
confidence: 0.9,
|
||
reason: '',
|
||
});
|
||
}
|
||
}
|
||
|
||
const memberships: CommunityMembership[] = [];
|
||
for (let chain = 0; chain < 10; chain++) {
|
||
for (let step = 0; step < 3; step++) {
|
||
memberships.push({ nodeId: `func:chain${chain}_f${step}`, communityId: 'community:0' });
|
||
}
|
||
}
|
||
|
||
const config: Partial<ProcessDetectionConfig> = { maxProcesses: 3 };
|
||
const result = await processProcesses(graph, memberships, undefined, config);
|
||
|
||
expect(result.processes.length).toBeLessThanOrEqual(3);
|
||
expect(result.stats.totalProcesses).toBeLessThanOrEqual(3);
|
||
});
|
||
|
||
// Regression for #2198: the processesPhase dynamic sizing used to cap at
|
||
// Math.min(300, symbolCount/10). On large repos (>3000 symbols) that silently
|
||
// truncated the process index. The cap was removed by extracting
|
||
// computeDynamicMaxProcesses() — this test exercises the helper directly
|
||
// so it fails if someone reintroduces the 300 ceiling.
|
||
describe('computeDynamicMaxProcesses (#2198)', () => {
|
||
it('returns at least the floor of 20 for tiny repos', () => {
|
||
expect(computeDynamicMaxProcesses(0)).toBe(20);
|
||
expect(computeDynamicMaxProcesses(50)).toBe(20); // 50/10 = 5, floored to 20
|
||
expect(computeDynamicMaxProcesses(199)).toBe(20); // 199/10 ≈ 20
|
||
});
|
||
|
||
it('scales linearly within the old 0–3000 range', () => {
|
||
expect(computeDynamicMaxProcesses(500)).toBe(50);
|
||
expect(computeDynamicMaxProcesses(1000)).toBe(100);
|
||
expect(computeDynamicMaxProcesses(2999)).toBe(300);
|
||
});
|
||
|
||
it('grows past 300 for large repos — the regression that #2198 fixes', () => {
|
||
// 3001 symbols → 300 (just at the boundary)
|
||
expect(computeDynamicMaxProcesses(3001)).toBe(300);
|
||
// 3100 symbols → 310 — would have been capped to 300 before the fix
|
||
expect(computeDynamicMaxProcesses(3100)).toBe(310);
|
||
// 5000 symbols → 500
|
||
expect(computeDynamicMaxProcesses(5000)).toBe(500);
|
||
// 28000 symbols (real-world large repo) → 2800
|
||
expect(computeDynamicMaxProcesses(28000)).toBe(2800);
|
||
});
|
||
|
||
it('does NOT cap at 300 — fails if Math.min(300, ...) is reintroduced', () => {
|
||
const largeRepo = computeDynamicMaxProcesses(10000);
|
||
expect(largeRepo).toBe(1000);
|
||
expect(largeRepo).toBeGreaterThan(300);
|
||
});
|
||
});
|
||
});
|