mirror of
https://github.com/abhigyanpatwari/GitNexus.git
synced 2026-10-04 02:31:36 +00:00
b48cfe9894
* fix(impact): return structured error + partial results instead of crashing (#321) - Wrap impact() in try-catch to return structured error JSON instead of process crash (SIGSEGV/exit 139) - Extract core logic to _impactImpl() for clean error boundary - Break out of depth traversal loop on query failure, return partial results collected so far (previously silently swallowed errors) - Add 'partial' flag to response when traversal was interrupted - Add try-catch in CLI impactCommand with structured error output - Improve formatImpactResult to show suggestion text and partial warning - Add 3 new unit tests for error/suggestion/partial scenarios Fixes #321 * fix: address review feedback — 4 bugs from @claude review Per @claude's review (requested by @magyargergo): - [BUG 1] Consistent target field shape: error responses now return {name: string} instead of raw string, matching success response schema - [BUG 2] Remove misleading partial:true from total-failure responses (partial is only meaningful when some depth levels succeeded) - [BUG 3] Move getBackend() inside try-catch in impactCommand so backend init failures return structured JSON instead of crashing - [BUG 4] Safe error message extraction: use instanceof Error check to handle thrown strings correctly (err?.message is undefined for non-Error thrown values) - [MINOR] Add radix argument to parseInt (10) * test: add integration tests for impact error handling (#321) Per @claude's recommendation (requested by @magyargergo): - impact: structured error for unknown symbol (no crash) - impact: error response has consistent {name: string} target shape - impact: partial:true only set when some results were collected Tests use existing withTestLbugDB + seeded graph fixture. |
||
|---|---|---|
| .. | ||
| resolvers | ||
| augmentation.test.ts | ||
| cli-e2e.test.ts | ||
| csv-pipeline.test.ts | ||
| enrichment.test.ts | ||
| filesystem-walker.test.ts | ||
| has-method.test.ts | ||
| hooks-e2e.test.ts | ||
| ignore-and-skip-e2e.test.ts | ||
| lbug-core-adapter.test.ts | ||
| lbug-pool.test.ts | ||
| local-backend-calltool.test.ts | ||
| local-backend.test.ts | ||
| parsing.test.ts | ||
| pipeline.test.ts | ||
| query-compilation.test.ts | ||
| search-core.test.ts | ||
| search-pool.test.ts | ||
| setup-skills.test.ts | ||
| skills-e2e.test.ts | ||
| tree-sitter-languages.test.ts | ||
| worker-pool.test.ts | ||