mirror of
https://github.com/abhigyanpatwari/GitNexus.git
synced 2026-09-22 00:31:17 +00:00
952350801c
Tighten three type boundaries that were previously papered over with
`as unknown as` casts:
* `CsharpResolveContext.allFilePaths`: `Set<string>` → `ReadonlySet<string>`.
The orchestrator only hands out a read-only view; drop the widening
cast at the resolver-adapter site.
* `resolveCsharpImportTarget`: call passes the narrow context directly.
`WorkspaceIndex` is `unknown` in the shared contract, so the
`as unknown as WorkspaceIndex` cast was gratuitous — structural
assignability covers it.
* `csharpMergeBindings`: drop unused `_scope: Scope` parameter. The
implementation never read it; the cast chain in `scope-resolver.ts`
existed only to satisfy an unused slot. LanguageProvider.mergeBindings
now wraps with a tiny arrow adapter; ScopeResolver.mergeBindings
passes through directly.
No runtime behavior change. `grep 'as unknown as' csharp/scope-resolver.ts`
returns zero matches.
Verified:
- npx tsc --noEmit clean
- C# unit + integration 462/462 passing (incl. Python integration)
|
||
|---|---|---|
| .. | ||
| csharp | ||
| python | ||
| def-index.test.ts | ||
| emit-references.test.ts | ||
| finalize-algorithm.test.ts | ||
| finalize-orchestrator.test.ts | ||
| import-target-adapter.test.ts | ||
| method-dispatch-index.test.ts | ||
| module-scope-index.test.ts | ||
| parse-worker-scope-integration.test.ts | ||
| position-index.test.ts | ||
| qualified-name-index.test.ts | ||
| registries.test.ts | ||
| resolve-type-ref.test.ts | ||
| scope-extractor.test.ts | ||
| scope-id.test.ts | ||
| scope-tree.test.ts | ||
| shadow-harness.test.ts | ||
| workspace-index.test.ts | ||