mirror of
https://github.com/abhigyanpatwari/GitNexus.git
synced 2026-09-15 23:32:49 +00:00
* fix(schema): declare the full scope-resolution relation cross product (#2792) `RELATION_SCHEMA` was hand-listed, and every prior fix added only the FROM/TO pair named in a crash report — `Const→Method` in #2769, the Swift/Rust member pairs before it. So `analyze` kept aborting at `assertDeclaredPair` on the next codebase whose edges happened to land on a different pair; #2792 reports `Class→Variable` on Java. Audit the surface instead of the symptom. `buildGraphNodeLookup` skips any node whose label is not in `isLinkableLabel`, so the lookup holds only linkable-labelled nodes — and both endpoints of every graph-bridge edge resolve through that lookup. The emittable surface is therefore exactly: FROM LINKABLE_LABELS + File (the module-level caller fallback) TO LINKABLE_LABELS + CALL_TARGET_TYPES `isCallerAnchorLabel` is a strict subset of linkable and contributes nothing on top. `CALL_TARGET_TYPES` contributes `Delegate`, which `tryEmitEdgeWithExplicitTargetId` can emit without going through the lookup at all. Generate that 14x14 block into the DDL rather than listing it: 223 -> 322 declared pairs, and no future pair from these sets can be missing by construction. The containment/inheritance/DI/route/cluster/PDG pairs stay hand-declared — no single predicate describes them. Both label sets live in the ingestion layer, which `core/lbug` must not import, so schema.ts carries twin lists. test/unit/schema-pair-coverage.ts derives the requirement from the originals and fails CI when either set grows without the pairs landing here — the piecemeal loop this fix ends. Measured before widening: at 322 pairs the cost is inside noise (1.09s vs 1.12s per 300 anchored queries on a 32-table DB), but the full 32x32 cross product is ~1.8x on untyped-endpoint anchored queries. The audited subset is the right scope, not "declare everything". INCREMENTAL_SCHEMA_VERSION 34 -> 35: LadybugDB fixes endpoint pairs when the rel table is created, so a pre-v35 database physically cannot store these edges. Closes #2792 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix(schema): declare the non-bridge structural pairs COBOL and Vue emit The generated scope-resolution block closed the half of RELATION_SCHEMA a label predicate can describe. The hand-declared half was still stale: with #2791's Function->Variable fix applied, `analyze` continued to abort on this repo's own test/fixtures/lang-resolution with Relationship label pair Module→Property is not declared A full sweep (assertDeclaredPair patched to log-and-skip, run over the whole fixture corpus) found 13 undeclared pairs over 106 edges. This branch already covered 3 of them via the cross product; the remaining 10 come from emitters outside the graph bridge: - cobol-processor.ts mints Module / Namespace / Record / Property / CodeElement and wires them with CONTAINS, CALLS and ACCESSES (9 pairs) - vue-sfc-extractor.ts emits BINDS_EVENT_HANDLER from a handler Function to the child component's File, the only edge whose target is a File (1 pair) CodeElement, Namespace, Record and File are in neither scope-bridge label set, so neither the generated block nor schema-pair-coverage.test.ts can reach them. Adds test/integration/structural-pair-coverage.test.ts, which derives the requirement from a corpus instead of a predicate: it runs the real pipeline over the non-bridge fixtures and requires every FROM/TO pair they produce to be declared. Mutation-checked — dropping `FROM Function TO File` fails it with exactly Function|File. Verified: cobol-app, vue-basic and php-transitive-traits now index instead of aborting; the full lang-resolution corpus completes at 10,876 nodes / 18,517 edges; scrypster/muninndb at 0b7a4272 (the #2789 repro) completes at 20,069 nodes / 71,580 edges, matching #2791 exactly, so this supersedes that PR. * refactor(test): simplify the structural pair coverage guard Cleanup pass over the previous commit. No behaviour change to the schema. - reuse `FIXTURES` and `runPipelineFromRepo` from resolvers/helpers.ts instead of re-deriving the fixture root and importing pipeline.js directly - gate on `distWorkerExists()` like every other integration test that passes `workerUrlForTest`, so a missing dist skips rather than fails - run the three fixtures with `it.concurrent.each`; they share nothing and the cost is almost all worker spawn plus grammar load, which overlaps well (tests phase 21-24s -> 5.6s measured) - replace the sentinel-in-a-Set filter with a plain `.filter()` chain, matching the sibling unit test, and move the declared/table lookups off the per-edge path onto the deduped set - move the pure string pin out of the integration tier into schema-pair-coverage.test.ts, where the identical construct already lives, so it needs no build and survives fixture deletion - trim the schema and test prose that restated the code, and correct the BINDS_EVENT_HANDLER attribution: it is emitted by languages/vue/scope-resolver.ts, not vue-sfc-extractor.ts - amend the v35 comment to mention the 10 structural pairs it now also stamps Still mutation-checked: dropping `FROM Function TO File` now fails both the integration sweep and the unit pin with exactly Function|File. 89 tests green. * fix(schema): generate the attachment pair surface and close four analyze aborts Review of the generated scope-bridge cross product found four `analyze` hard-aborts still live at head, each reproduced end-to-end on the default user path (`analyze --index-only --skip-git`): Method→Annotation Spring `@Bean` + `@ConditionalOnMissingBean` (Java + Kotlin) Method→File Vue Options-API `methods:` handler bound to a child event Namespace→Record COBOL `DECLARATIVES` / `USE AFTER STANDARD ERROR ON <file>` Class→Tool `@mcp.tool()` applied to a class All four are pre-existing on main, and both existing guards were structurally blind to them: the unit guard derives from LINKABLE_LABELS ∪ CALL_TARGET_TYPES (none of Annotation/Tool/Record/File-as-target is a member) and the corpus guard ran three fixtures that exercise none of these emitters. All 16 tests passed while all four crashes were live. The PR's model — "bridge endpoint × structural endpoint" — does not fit: Namespace→Record is structural on both sides. The property that does hold is that the ANCHOR is a lookup result, not a literal at the emit site, so the emitter cannot constrain its label. That gives a second closed-form rule: DEFINITION_ANCHOR_LABELS × ATTACHMENT_TARGET_LABELS DEFINITION_ANCHOR_LABELS is derived from NODE_TABLES by subtraction, so a new node table joins automatically. 332 → 450 declared pairs. Sized against a committed harness (gitnexus/bench/schema-pairs), real @ladybugdb/core, identical data: 450 costs 0.93–1.05× of 332 on untyped-endpoint anchored queries — inside noise — versus 1.22–1.43× at 641 and 2.03–2.34× at 1024. The harness reproduces the known #2792 cliff, which is what makes the 450 figure trustworthy. Also in this change: - Delete the 161 hand-declared pairs the rules already generate (233 → 72). The declared set is byte-identical at 450; those lines were load-bearing shadow, because the generator suppresses anything already declared structurally, so narrowing a rule later would silently keep pairs alive. A new guard fails CI if a hand-declared pair is ever re-added inside a rule. - Import LINKABLE_LABELS / CALL_TARGET_TYPES instead of hand-copying them. The twins' stated justification ("the ingestion layer must not be imported here") is false: csv-generator.ts and lbug-adapter.ts, siblings in the same directory, already do, and no rule in AGENTS.md / ARCHITECTURE.md / CONTRIBUTING.md / GUARDRAILS.md states otherwise. - Resolve `resolveStreamGraphEmit` after the guards that rebind `options.force`, not at function entry. It gates on `force`, and every freshness guard runs ~360 lines later, so the v34→v35 bump would have pushed every existing index down the non-streamed emit path — losing the #2680 memory streaming added for the #2649 kernel-scale OOM, for exactly the population most likely to be memory-constrained. - `UndeclaredRelationPairError` now carries the relationship type, both node ids and the source file, with a matching CLI branch. The old message named only the abstract label pair, which a user could not act on. Found through the cause chain, since pipeline-phases/runner.ts rewraps every phase failure. - Share one classifier (`relPairKeyFor`) across the router, both emit sinks and the corpus guard, which previously hand-mirrored the router's skip rule; one cause-chain walker in lib/utils.ts; one exported pair-matching regex. - Corpus guard: four new fixtures reproducing the aborts, per-fixture sentinel pairs so a fixture that stops emitting fails loudly instead of passing vacuously on an empty graph. The per-edge path stays allocation-free: the failure context is passed positionally and the message is built only inside the throw. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0182jkjQqzACkJKYw4MLDnhX * test(bench): re-baseline the COBOL capture fingerprint for the new fixture `bench/scope-capture` globs `lang-resolution/cobol-*`, so the `cobol-declaratives` fixture added in81daf370e(to reproduce the `Namespace→Record` analyze abort) joined that corpus and shifted the fingerprint — 14 → 15 files. Verified corpus-only, not a capture change: with that one fixture moved aside the fingerprint is byte-identical to the prior baseline (d45bb091…), and81daf370etouches no COBOL capture code. The new value reproduces CI's reported hash exactly. Scaling 0.677 < 1.5 budget. `bench/scope-capture/measure.mjs --check` → PASS (15 languages). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0182jkjQqzACkJKYw4MLDnhX --------- Co-authored-by: Gergo Magyar <gergomagyar0@gmail.com> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
136 lines
4.6 KiB
TypeScript
136 lines
4.6 KiB
TypeScript
/**
|
|
* CLI message helpers — for user-facing banners, error guidance, and
|
|
* recovery hints emitted by `gitnexus` subcommands.
|
|
*
|
|
* These functions write **plain text** directly to `process.stderr` AND
|
|
* tee a structured pino record through the singleton `logger`. Plain text
|
|
* preserves the human-readable contract for users running `gitnexus`
|
|
* interactively, redirecting to a file, or piping to `cat`/`grep`. The
|
|
* structured tee keeps log aggregators happy.
|
|
*
|
|
* **Use these for:**
|
|
* - User-facing banners ("Server listening on http://...:N")
|
|
* - Validation errors ("--worker-timeout must be at least 1 second")
|
|
* - Recovery hints ("Suggestions: 1. Clear the npm cache, 2. ...")
|
|
* - One-line user notices ("No indexed repositories found.")
|
|
*
|
|
* **Do NOT use these for:**
|
|
* - Internal diagnostics (worker progress, retry counts, telemetry)
|
|
* — use `logger.info`/`warn`/`error` directly. Internal logs only
|
|
* need structured fields, not double-output to stderr.
|
|
* - High-volume hot paths — every `cliMessage` call writes twice (raw
|
|
* + structured). Acceptable for user-facing messages, wasteful for
|
|
* ingestion pipeline events.
|
|
*
|
|
* Design note: stderr is the right channel even for non-error messages
|
|
* because GitNexus CLI tools (`query`, `cypher`, `impact`) emit JSON
|
|
* data on stdout for piping (`gitnexus query | jq`). User banners on
|
|
* stdout would corrupt that pipeline.
|
|
*/
|
|
import { logger } from '../core/logger.js';
|
|
import { t, type CliMessageKey, type CliMessageVars } from './i18n/index.js';
|
|
|
|
/**
|
|
* String-literal union of all `recoveryHint` tags emitted by the CLI.
|
|
*
|
|
* Centralized so a new recovery branch added in `analyze.ts` cannot land
|
|
* without updating this union — TypeScript will reject the unknown literal
|
|
* passed via `cliError({ recoveryHint: '...' })`. To add a new hint:
|
|
* 1. Add the tag string to this union.
|
|
* 2. Pass it as the `recoveryHint` field at the relevant `cliError`
|
|
* call site.
|
|
*
|
|
* Consumers can import this type to narrow log-record `recoveryHint`
|
|
* fields without restating the literal list.
|
|
*/
|
|
export type RecoveryHint =
|
|
| 'wal-corruption'
|
|
| 'wal-checkpoint-threshold'
|
|
| 'lbug-wipe-failed'
|
|
| 'lbug-page-size'
|
|
| 'heap-oom-respawn'
|
|
| 'native-worker-abort'
|
|
| 'hf-endpoint-unreachable'
|
|
| 'http-embedding-endpoint-error'
|
|
| 'embedding-dims-invalid'
|
|
| 'local-embedding-unsupported'
|
|
| 'local-embedding-stack-missing'
|
|
| 'large-repo'
|
|
| 'npm-resolution'
|
|
| 'module-not-found'
|
|
| 'gitnexusrc-invalid'
|
|
| 'default-branch-invalid'
|
|
| 'index-lock-timeout'
|
|
| 'undeclared-relation-pair';
|
|
|
|
/**
|
|
* Common shape for the optional structured-field bag passed to
|
|
* `cliError`/`cliWarn`/`cliInfo`. Typed so the `recoveryHint` slot is
|
|
* checked against the {@link RecoveryHint} union.
|
|
*/
|
|
export interface CliMessageFields extends Record<string, unknown> {
|
|
recoveryHint?: RecoveryHint;
|
|
}
|
|
|
|
function writeStderr(msg: string): void {
|
|
// Direct write — bypassing `console.*` so it cannot be intercepted by
|
|
// progress-bar redirection (see `cli/analyze.ts:barLog`) or other
|
|
// routing. The structured tee below still goes through the logger so
|
|
// log aggregation works either way.
|
|
process.stderr.write(msg.endsWith('\n') ? msg : msg + '\n');
|
|
}
|
|
|
|
/**
|
|
* User-facing informational message. Use for banners, listening URLs,
|
|
* and any message the user expects to read in plain text.
|
|
*/
|
|
export function cliInfo(msg: string, fields?: CliMessageFields): void {
|
|
writeStderr(msg);
|
|
logger.info(fields ?? {}, msg);
|
|
}
|
|
|
|
/**
|
|
* Key-based informational message. Keeps the legacy string API intact while
|
|
* allowing commands to opt into localized user-facing stderr output.
|
|
*/
|
|
export function cliInfoKey(
|
|
key: CliMessageKey,
|
|
vars?: CliMessageVars,
|
|
fields?: Record<string, unknown>,
|
|
): void {
|
|
cliInfo(t(key, vars), fields);
|
|
}
|
|
|
|
/**
|
|
* User-facing warning. Operator-actionable but non-fatal — `cliWarn`
|
|
* indicates the command can still proceed in some form.
|
|
*/
|
|
export function cliWarn(msg: string, fields?: CliMessageFields): void {
|
|
writeStderr(msg);
|
|
logger.warn(fields ?? {}, msg);
|
|
}
|
|
|
|
export function cliWarnKey(
|
|
key: CliMessageKey,
|
|
vars?: CliMessageVars,
|
|
fields?: Record<string, unknown>,
|
|
): void {
|
|
cliWarn(t(key, vars), fields);
|
|
}
|
|
|
|
/**
|
|
* User-facing error. Indicates the command cannot proceed; usually
|
|
* paired with a non-zero exit code at the call site.
|
|
*/
|
|
export function cliError(msg: string, fields?: CliMessageFields): void {
|
|
writeStderr(msg);
|
|
logger.error(fields ?? {}, msg);
|
|
}
|
|
|
|
export function cliErrorKey(
|
|
key: CliMessageKey,
|
|
vars?: CliMessageVars,
|
|
fields?: Record<string, unknown>,
|
|
): void {
|
|
cliError(t(key, vars), fields);
|
|
}
|