GitNexus/gitnexus/test/integration/resolvers/python-parsing-coverage.test.ts
Gergő Magyar 083aedbc41
refactor(ingestion): delete legacy call-resolution DAG + heritage processor (RING4-1, #942) (#2023)
* refactor(ingestion): delete legacy call-resolution DAG + heritage processor (#942)

RING4-1: all 16 production languages (incl. Vue #940) are registry-primary, so
the legacy resolution legs only ran under the now-removed CI parity gate. Calls
and inheritance now resolve exclusively through scope-resolution
(Registry.lookup, preEmitInheritanceEdges, emitHeritageEdges, buildMro →
MethodDispatchIndex).

Removed:
- Call-resolution DAG: call-processor.ts legacy body (processCalls,
  processCallsFromExtracted, resolveCallTarget + all resolver/dispatch/chain
  helpers), model/resolve.ts MRO-via-HeritageMap, model/heritage-map.ts,
  type-env DAG types; inferImplicitReceiver/selectDispatch LanguageProvider
  hooks + Ruby impls; DispatchDecision/ImplicitReceiverOverride/ReceiverEnriched.
- Legacy heritage path: heritage-processor.ts, heritage-types.ts,
  heritage-extractors/, @heritage.* tree-sitter queries, heritageExtractor/
  heritageDefaultEdge/interfaceNamePattern wiring, worker + parse-impl heritage
  passes (parse-worker/parsing-processor lockstep), cross-file-impl DAG pass.
- Scope-parity infrastructure entirely (no legacy↔registry parity left to run):
  scripts/run-parity.ts, scripts/ci-list-migrated-languages.ts,
  ci-scope-parity.yml, test:parity, and the scope-parity ci.yml gate. Resolver
  integration tests still run via the normal tests job.

Kept (shared infra, NOT call-DAG-only): type-env.ts buildTypeEnv (field
extraction / structure phase / embeddings), model/resolve.ts c3Linearize +
gatherAncestors (mro-processor mroPhase), route/fetch/exported-type-map helpers
in call-processor.ts, preEmitInheritanceEdges (legacy-edge dedup simplified).

Acceptance: grep for resolveCallTarget/inferImplicitReceiver/selectDispatch/
buildHeritageMap/HeritageMap/processHeritage/heritageExtractor/@heritage. is zero
across src + test. tsc clean (both packages); resolver integration suite green
(bit-compatible EXTENDS/IMPLEMENTS/CALLS); scope-capture fingerprints unchanged
(python re-baselined: removed redundant ignored captures). ARCHITECTURE.md
updated to scope-resolution-only.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(review): apply autofix feedback (#942)

ce-code-review autofix pass on the RING4-1 deletion:
- parse-cache.ts: bump SCHEMA_BUMP 2→3 — ParseWorkerResult lost its `heritage`
  field, so stale on-disk caches must invalidate (prevents a rollback replaying
  a heritage-less cache into legacy code) [api-contract P2].
- parse-impl.ts: drop 3 now-unused type imports (ExtractedCall,
  ExtractedAssignment, FileConstructorBindings) left by the deferred-block
  removal — would fail the eslint CI gate [correctness+maintainability P1].
- AGENTS.md / CLAUDE.md / scope-resolver.ts contract doc: fix stale pointers to
  the deleted "§ Call-Resolution DAG" section + removed hooks; preserve the
  language-neutrality rule [project-standards P1].
- registry-primary-flag.ts / cross-file.ts / parse-impl.ts: refresh stale
  comments referencing deleted symbols (legacy DAG, runCrossFileBindingPropagation).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* refactor(ingestion): remove the vestigial isRegistryPrimary flag (#942)

With the legacy call-resolution DAG deleted, the per-language
`REGISTRY_PRIMARY_<LANG>` / `isRegistryPrimary` / `MIGRATED_LANGUAGES` flag had
only one meaningful state — every production language resolves via
scope-resolution — and an explicit `=0` override could only *disable*
resolution with no fallback (a footgun the review flagged). Removing it.

- Delete `registry-primary-flag.ts` and the now-dead `shadow-harness.ts`
  (legacy↔registry shadow-parity tool) + its test.
- Collapse the three flag gates to their behavior-preserving outcome
  (`SCOPE_RESOLVERS == MIGRATED_LANGUAGES`, so this is a no-op):
  - scope-resolution phase now runs for every registered `SCOPE_RESOLVERS`
    entry (was `∩ MIGRATED_LANGUAGES`).
  - import-processor `addImportGraphEdge` + parse-impl `shouldAccumulate`:
    the legacy emit/accumulate paths were already inert for migrated
    languages (scope-resolution owns IMPORTS via the imports-to-edges bridge);
    drop the flag term.
- Collapse flag-branching tests to the scope-resolution path and delete the
  csharp legacy-`=0`-leg describe blocks; remove the ruby/rust-scope env-forcing
  hooks (no-ops now).
- Refresh docs/comments (ARCHITECTURE.md "one registration", scope-resolver
  cookbook, phase deps) — adding a language is now a single `SCOPE_RESOLVERS`
  registration.

Verified: tsc clean (both packages); resolver integration tests green
(747 assertions across cobol/csharp/ruby/rust/typescript/go, IMPORTS edges
intact); grep for the flag symbols is zero across src + test.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* style(format): prettier formatting on #942 changes

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(ci): drop legacy heritage-capture tests + re-baseline scope-capture fingerprints (#942)

Two CI failures from the #942 cleanup, surfaced by the tri-review + CI:

- tree-sitter-languages.test.ts: two tests asserted `@heritage.*` captures
  (Rust trait-impl, Dart extends/implements/with) that this PR removed. The
  acceptance grep used `@heritage\.` (with `@`); these reference the runtime
  capture name `heritage.trait` (no `@`), so they slipped the earlier sweep.
  Inheritance is now covered by the resolver integration suite. (fixed macos-latest)

- Re-baselined the scope-capture bench fingerprints for csharp/rust/ruby/java/
  javascript/kotlin (baselines.json) + python (python-scope/baseline-fingerprint.txt).
  The earlier test-cleanup reworded comments inside the lang-resolution fixture
  files (Shapes.cs, child.rs, derived.rb, IA.java/Plain.java, Service.js, F.kt,
  app.py) to scrub deleted-symbol references for the acceptance grep; those are
  the bench corpus, so capture node positions shifted. Capture LOGIC is
  unchanged — verified `--check` passes for all 14 langs + python. (fixed benchmarks)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* docs/chore: scrub remaining REGISTRY_PRIMARY + deleted-symbol references (#942)

Tri-review P3 follow-ups (verified):
- TESTING.md: rewrite the "Scope-resolution parity" section — the legacy
  dual-leg (REGISTRY_PRIMARY_<LANG>=0/1) and `npm run test:parity` no longer
  exist; resolver tests run once on the sole scope-resolution path in the
  normal tests job.
- scripts/bench-scope-resolution.ts: drop the inert `REGISTRY_PRIMARY_PYTHON=1`
  env set + usage hint (the flag is gone).
- ruby/scope-resolver.ts, php/captures.ts: re-point doc-comments off the
  deleted heritage-map.ts / heritage-processor.ts to the current behavior.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(ci): prettier format + regenerate scope-capture goldens (#942)

Two more CI failures, same root cause as the bench re-baseline (the
test-cleanup reworded comments in lang-resolution bench/golden-corpus fixtures):

- quality/format: prettier on tree-sitter-languages.test.ts (blank line left by
  the deleted heritage-capture tests) + TESTING.md (the rewritten section).
- tests/ubuntu/coverage: `csharp-captures-golden` (and python/ruby/rust) drifted
  because the edited fixtures feed the per-language capture-golden snapshots too
  (not just the bench). Regenerated via UPDATE_GOLDEN=1. Verified safe: only the
  edited-fixture entries changed; csharp `captureGroups` unchanged (38) — digest
  shifted from comment-position only; capture LOGIC untouched. 1168 scope-
  resolution tests pass.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* test(resolvers): drop createResolverParityIt wrapper, use vitest it directly

The parity-aware `it` wrapper became a no-op when #942 removed the legacy
call-resolution DAG (it just returned vitest's `it`). Remove it entirely so
the resolver tests call vitest's `it` directly instead of shadowing it with a
local `const it` (or `pit`/`rustParityIt`):

- helpers.ts: delete createResolverParityIt + its now-unused vitestIt import
  and VitestIt type.
- 16 files: drop `const it = createResolverParityIt('x')` and import `it`
  from vitest instead.
- ruby.test.ts (pit) + rust.test.ts (rustParityIt): rename calls to `it`.
- Scrub every comment that described the removed wrapper / dual-mode parity
  skip / legacy_skip gate (vue-scope, js/ts/dart/php/python headers, rust x2,
  cpp, swift x4, rust-coverage). Genuine test rationale is kept; only the
  vestigial two-leg framing is dropped. Accurate "legacy DAG (removed in
  #942)" historical notes are retained.

No fixtures touched (no bench/golden re-baseline). tsc clean; rust+ruby
resolver suites green (323 tests, incl. #1992 worker-path parity after a
local dist build).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-04 11:07:37 +01:00

168 lines
6.6 KiB
TypeScript

/**
* Regression tests for Python scope-resolution coverage gaps (issue #1932).
*
* Each fixture FAILS on main and PASSES on the fix branch.
*/
import { describe, it, expect } from 'vitest';
import { emitPythonScopeCaptures } from '../../../src/core/ingestion/languages/python/index.js';
import { extractParsedFile } from '../../../src/core/ingestion/scope-extractor-bridge.js';
import { pythonProvider } from '../../../src/core/ingestion/languages/python.js';
import type { CaptureMatch } from 'gitnexus-shared';
/**
* Count matches whose capture-key set satisfies `predicate`.
*/
function countCaptures(src: string, predicate: (tags: string[]) => boolean): number {
const matches = emitPythonScopeCaptures(src, 'test.py') as CaptureMatch[];
return matches.filter((m) => predicate(Object.keys(m))).length;
}
// ---------------------------------------------------------------------------
// F57 — Heritage: qualified/subscripted bases
// ---------------------------------------------------------------------------
// The legacy heritage-capture leg was removed in #942; the registry-primary
// scope-resolution path now synthesizes @reference.inherits captures (full base
// node) plus @reference.name (the bare normalized lookup name) for each
// superclass. preEmitInheritanceEdges turns these into EXTENDS edges downstream.
describe('F57 — Python heritage (qualified / subscripted bases)', () => {
it('bare identifier base class emits @reference.inherits', () => {
const src = `
class Base:
pass
class Child(Base):
pass
`;
const matches = emitPythonScopeCaptures(src, 'test.py') as CaptureMatch[];
const inheritsMatches = matches.filter((m) => m['@reference.inherits']);
expect(inheritsMatches.length).toBe(1);
expect(inheritsMatches[0]['@reference.inherits'].text).toBe('Base');
expect(inheritsMatches[0]['@reference.name'].text).toBe('Base');
});
it('qualified base (mod.Class) emits @reference.inherits with normalized name', () => {
const src = `
class A(mod.Base):
pass
`;
const matches = emitPythonScopeCaptures(src, 'test.py') as CaptureMatch[];
const inheritsMatches = matches.filter((m) => m['@reference.inherits']);
expect(inheritsMatches.length).toBe(1);
expect(inheritsMatches[0]['@reference.inherits'].text).toBe('mod.Base');
expect(inheritsMatches[0]['@reference.name'].text).toBe('Base');
});
it('subscripted base (Generic[T]) emits @reference.inherits with normalized name', () => {
const src = `
from typing import Generic, TypeVar
T = TypeVar('T')
class B(Generic[T]):
pass
`;
const matches = emitPythonScopeCaptures(src, 'test.py') as CaptureMatch[];
const inheritsMatches = matches.filter((m) => m['@reference.inherits']);
expect(inheritsMatches.length).toBe(1);
expect(inheritsMatches[0]['@reference.inherits'].text).toBe('Generic[T]');
expect(inheritsMatches[0]['@reference.name'].text).toBe('Generic');
});
it('qualified base (types.Type) emits @reference.inherits with normalized name', () => {
const src = `
class C(types.Type):
pass
`;
const matches = emitPythonScopeCaptures(src, 'test.py') as CaptureMatch[];
const inheritsMatches = matches.filter((m) => m['@reference.inherits']);
expect(inheritsMatches.length).toBe(1);
expect(inheritsMatches[0]['@reference.inherits'].text).toBe('types.Type');
expect(inheritsMatches[0]['@reference.name'].text).toBe('Type');
});
});
// ---------------------------------------------------------------------------
// F58 — Decorator captures
// ---------------------------------------------------------------------------
describe('F58 — Python decorator captures', () => {
it('simple @app.route decorator emits @reference.call.member', () => {
const src = `
@app.route("/")
def index():
return "ok"
`;
const matches = emitPythonScopeCaptures(src, 'test.py') as CaptureMatch[];
const decoratorMatches = matches.filter((m) => m['@reference.call.member']);
expect(decoratorMatches.length).toBe(1);
expect(decoratorMatches[0]['@reference.name']?.text).toBe('route');
});
it('nested attribute decorator @api.v1.endpoint emits @reference.call.member', () => {
const src = `
@api.v1.endpoint
def handler():
pass
`;
const matches = emitPythonScopeCaptures(src, 'test.py') as CaptureMatch[];
const decoratorMatches = matches.filter((m) => m['@reference.call.member']);
expect(decoratorMatches.length).toBe(1);
expect(decoratorMatches[0]['@reference.name']?.text).toBe('endpoint');
});
it('simple @decorator (bare identifier) emits @reference.call.free', () => {
const src = `
@login_required
def protected_view():
pass
`;
const matches = emitPythonScopeCaptures(src, 'test.py') as CaptureMatch[];
const decoratorMatches = matches.filter((m) => m['@reference.call.free']);
expect(decoratorMatches.length).toBe(1);
expect(decoratorMatches[0]['@reference.name']?.text).toBe('login_required');
});
});
// ---------------------------------------------------------------------------
// F58 — End-to-end: extractParsedFile produces referenceSites
// ---------------------------------------------------------------------------
describe('F58 — decorator produces referenceSites in extractParsedFile', () => {
it('@login_required produces a referenceSite entry', () => {
const src = `@login_required\ndef foo():\n pass\n`;
const parsedFile = extractParsedFile(pythonProvider, src, 'app.py', () => {});
expect(parsedFile).not.toBeNull();
expect(parsedFile!.referenceSites.length).toBeGreaterThanOrEqual(1);
const hasLoginRef = parsedFile!.referenceSites.some((r) => r.name === 'login_required');
expect(hasLoginRef).toBe(true);
});
});
// ---------------------------------------------------------------------------
// F61 — Lambda scope
// ---------------------------------------------------------------------------
describe('F61 — Python lambda scope', () => {
it('bare lambda emits @scope.function', () => {
const src = `handler = lambda x: x + 1\n`;
const scopeFnCount = countCaptures(src, (tags) => tags.includes('@scope.function'));
expect(scopeFnCount).toBe(1);
});
it('multiple lambdas each get their own @scope.function', () => {
const src = `double = lambda x: x * 2\ntriple = lambda x: x * 3\n`;
const scopeFnCount = countCaptures(src, (tags) => tags.includes('@scope.function'));
expect(scopeFnCount).toBe(2);
});
it('lambda coexists with function_definition scopes', () => {
const src = `
def normal(x):
return x + 1
handler = lambda x: x * 2
`;
const scopeFnCount = countCaptures(src, (tags) => tags.includes('@scope.function'));
expect(scopeFnCount).toBe(2);
});
});