mirror of
https://github.com/abhigyanpatwari/GitNexus.git
synced 2026-08-28 05:25:25 +00:00
* fix(core): ensure path prefix and traversal guards support root directories * chore(autofix): apply prettier + eslint fixes via /autofix command * test(core): add test coverage for root-level and Windows drive-root paths * fix(core): apply separator-aware prefix matching in augmentation engine * chore(autofix): apply prettier + eslint fixes via /autofix command --------- Co-authored-by: Syeda Anshrah Gillani <gillani@cloudment.io> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Gergő Magyar <gergomagyar@icloud.com>
345 lines
15 KiB
TypeScript
345 lines
15 KiB
TypeScript
/**
|
|
* Integration Tests: Augmentation Engine
|
|
*
|
|
* augment() against a real indexed LadybugDB
|
|
* - Matching pattern returns non-empty string with callers/callees
|
|
* - Non-matching pattern returns empty string
|
|
* - Pattern shorter than 3 chars returns empty string
|
|
*/
|
|
import { describe, it, expect, vi } from 'vitest';
|
|
import path from 'path';
|
|
import { withTestLbugDB } from '../helpers/test-indexed-db.js';
|
|
|
|
// ─── Seed data & FTS indexes for augmentation ────────
|
|
|
|
const AUGMENT_SEED_DATA = [
|
|
// File nodes
|
|
`CREATE (n:File {id: 'file:auth.ts', name: 'auth.ts', filePath: 'src/auth.ts', content: 'authentication module for user login'})`,
|
|
`CREATE (n:File {id: 'file:utils.ts', name: 'utils.ts', filePath: 'src/utils.ts', content: 'utility functions for hashing'})`,
|
|
|
|
// Function nodes
|
|
`CREATE (n:Function {id: 'func:login', name: 'login', filePath: 'src/auth.ts', startLine: 1, endLine: 15, isExported: true, content: 'function login authenticates user credentials', description: 'user login'})`,
|
|
`CREATE (n:Function {id: 'func:validate', name: 'validate', filePath: 'src/auth.ts', startLine: 17, endLine: 25, isExported: true, content: 'function validate checks user input', description: 'input validation'})`,
|
|
`CREATE (n:Function {id: 'func:hash', name: 'hash', filePath: 'src/utils.ts', startLine: 1, endLine: 8, isExported: true, content: 'function hash computes bcrypt hash', description: 'password hashing'})`,
|
|
|
|
// Class / Method / Interface nodes
|
|
`CREATE (n:Class {id: 'class:AuthService', name: 'AuthService', filePath: 'src/auth.ts', startLine: 30, endLine: 60, isExported: true, content: 'class AuthService handles authentication', description: 'auth service'})`,
|
|
`CREATE (n:Method {id: 'method:AuthService.login', name: 'loginMethod', filePath: 'src/auth.ts', startLine: 35, endLine: 50, isExported: false, content: 'method login in AuthService', description: 'login method'})`,
|
|
`CREATE (n:Interface {id: 'iface:Creds', name: 'Credentials', filePath: 'src/auth.ts', startLine: 1, endLine: 5, isExported: true, content: 'interface Credentials for login authentication', description: 'credentials type'})`,
|
|
|
|
// Community & Process nodes
|
|
`CREATE (n:Community {id: 'comm:auth', label: 'Auth', heuristicLabel: 'Authentication', keywords: ['auth'], description: 'Auth cluster', enrichedBy: 'heuristic', cohesion: 0.8, symbolCount: 3})`,
|
|
`CREATE (n:Process {id: 'proc:login-flow', label: 'LoginFlow', heuristicLabel: 'User Login', processType: 'intra_community', stepCount: 2, communities: ['auth'], entryPointId: 'func:login', terminalId: 'func:validate'})`,
|
|
|
|
// Relationships
|
|
`MATCH (a:Function), (b:Function) WHERE a.id = 'func:login' AND b.id = 'func:validate'
|
|
CREATE (a)-[:CodeRelation {type: 'CALLS', confidence: 1.0, reason: 'direct', step: 0}]->(b)`,
|
|
`MATCH (a:Function), (b:Function) WHERE a.id = 'func:login' AND b.id = 'func:hash'
|
|
CREATE (a)-[:CodeRelation {type: 'CALLS', confidence: 0.9, reason: 'import-resolved', step: 0}]->(b)`,
|
|
`MATCH (a:Function), (c:Community) WHERE a.id = 'func:login' AND c.id = 'comm:auth'
|
|
CREATE (a)-[:CodeRelation {type: 'MEMBER_OF', confidence: 1.0, reason: '', step: 0}]->(c)`,
|
|
`MATCH (a:Function), (p:Process) WHERE a.id = 'func:login' AND p.id = 'proc:login-flow'
|
|
CREATE (a)-[:CodeRelation {type: 'STEP_IN_PROCESS', confidence: 1.0, reason: '', step: 1}]->(p)`,
|
|
`MATCH (a:Function), (p:Process) WHERE a.id = 'func:validate' AND p.id = 'proc:login-flow'
|
|
CREATE (a)-[:CodeRelation {type: 'STEP_IN_PROCESS', confidence: 1.0, reason: '', step: 2}]->(p)`,
|
|
];
|
|
|
|
const AUGMENT_FTS_INDEXES = [
|
|
{ table: 'File', indexName: 'file_fts', columns: ['name', 'content'] },
|
|
{ table: 'Function', indexName: 'function_fts', columns: ['name', 'content', 'description'] },
|
|
{ table: 'Class', indexName: 'class_fts', columns: ['name', 'content', 'description'] },
|
|
{ table: 'Method', indexName: 'method_fts', columns: ['name', 'content', 'description'] },
|
|
{ table: 'Interface', indexName: 'interface_fts', columns: ['name', 'content', 'description'] },
|
|
];
|
|
|
|
// Mock repo-manager so augment() finds our test DB
|
|
vi.mock('../../src/storage/repo-manager.js', () => ({
|
|
listRegisteredRepos: vi.fn(),
|
|
}));
|
|
|
|
let augment: (pattern: string, cwd?: string) => Promise<string>;
|
|
let augmentNoFts: (pattern: string, cwd?: string) => Promise<string>;
|
|
|
|
withTestLbugDB(
|
|
'augment',
|
|
(handle) => {
|
|
describe('augment()', () => {
|
|
it('returns non-empty string with relationship info for a matching pattern', async () => {
|
|
const result = await augment('login', handle.dbPath);
|
|
|
|
expect(result.length).toBeGreaterThan(0);
|
|
expect(result).toContain('[GitNexus]');
|
|
expect(result).toContain('login');
|
|
});
|
|
|
|
it('returns empty string for a non-matching pattern', async () => {
|
|
const result = await augment('nonexistent_xyz', handle.dbPath);
|
|
expect(result).toBe('');
|
|
});
|
|
|
|
it('returns empty string for patterns shorter than 3 characters', async () => {
|
|
const result = await augment('ab', handle.dbPath);
|
|
expect(result).toBe('');
|
|
});
|
|
|
|
it('returns empty string for empty pattern', async () => {
|
|
const result = await augment('', handle.dbPath);
|
|
expect(result).toBe('');
|
|
});
|
|
|
|
// ─── Unhappy paths ────────────────────────────────────────────────
|
|
|
|
it('returns empty string for whitespace-only pattern', async () => {
|
|
const result = await augment(' ', handle.dbPath);
|
|
expect(result).toBe('');
|
|
});
|
|
|
|
it('handles special regex characters in pattern without throwing', async () => {
|
|
const result = await augment('func()', handle.dbPath);
|
|
expect(typeof result).toBe('string');
|
|
});
|
|
|
|
it('handles very long pattern without throwing', async () => {
|
|
const result = await augment('a'.repeat(500), handle.dbPath);
|
|
expect(typeof result).toBe('string');
|
|
});
|
|
|
|
it('handles unicode pattern without throwing', async () => {
|
|
const result = await augment('日本語テスト', handle.dbPath);
|
|
expect(typeof result).toBe('string');
|
|
});
|
|
|
|
// ─── Negative-safety: fallback must stay gated on !ftsAvailable ───
|
|
//
|
|
// When FTS is available but happens to return zero BM25 hits, the
|
|
// CONTAINS fallback must NOT fire — preserving the original early-return
|
|
// semantics. If anyone later loosens the gate to `symbolMatches.length
|
|
// === 0` alone, this test fails.
|
|
|
|
it('does NOT fire CONTAINS fallback when FTS is available but BM25 returns empty', async () => {
|
|
const bm25 = await import('../../src/core/search/bm25-index.js');
|
|
const spy = vi
|
|
.spyOn(bm25, 'searchFTSFromLbug')
|
|
.mockResolvedValue({ results: [], ftsAvailable: true });
|
|
try {
|
|
// 'login' WOULD match a graph node via CONTAINS, but FTS is available
|
|
// and empty → fallback gate must hold → result must be ''.
|
|
const result = await augment('login', handle.dbPath);
|
|
expect(result).toBe('');
|
|
} finally {
|
|
spy.mockRestore();
|
|
}
|
|
});
|
|
|
|
describe('root path matching', () => {
|
|
it('matches repo at root level and CWD in sub-directory (repo at /, CWD at /src)', async () => {
|
|
const { listRegisteredRepos } = await import('../../src/storage/repo-manager.js');
|
|
const rootPath = path.resolve('/');
|
|
|
|
(listRegisteredRepos as ReturnType<typeof vi.fn>).mockResolvedValue([
|
|
{
|
|
name: handle.repoId,
|
|
path: rootPath,
|
|
storagePath: handle.tmpHandle.dbPath,
|
|
indexedAt: new Date().toISOString(),
|
|
lastCommit: 'abc123',
|
|
},
|
|
]);
|
|
|
|
try {
|
|
const subDir = path.join(rootPath, 'src');
|
|
const result = await augment('login', subDir);
|
|
expect(result.length).toBeGreaterThan(0);
|
|
expect(result).toContain('[GitNexus]');
|
|
} finally {
|
|
(listRegisteredRepos as ReturnType<typeof vi.fn>).mockResolvedValue([
|
|
{
|
|
name: handle.repoId,
|
|
path: handle.dbPath,
|
|
storagePath: handle.tmpHandle.dbPath,
|
|
indexedAt: new Date().toISOString(),
|
|
lastCommit: 'abc123',
|
|
},
|
|
]);
|
|
}
|
|
});
|
|
|
|
it('matches CWD at root level and repo in sub-directory (repo at /src, CWD at /)', async () => {
|
|
const { listRegisteredRepos } = await import('../../src/storage/repo-manager.js');
|
|
const rootPath = path.resolve('/');
|
|
const subDir = path.join(rootPath, 'src');
|
|
|
|
(listRegisteredRepos as ReturnType<typeof vi.fn>).mockResolvedValue([
|
|
{
|
|
name: handle.repoId,
|
|
path: subDir,
|
|
storagePath: handle.tmpHandle.dbPath,
|
|
indexedAt: new Date().toISOString(),
|
|
lastCommit: 'abc123',
|
|
},
|
|
]);
|
|
|
|
try {
|
|
const result = await augment('login', rootPath);
|
|
expect(result.length).toBeGreaterThan(0);
|
|
expect(result).toContain('[GitNexus]');
|
|
} finally {
|
|
(listRegisteredRepos as ReturnType<typeof vi.fn>).mockResolvedValue([
|
|
{
|
|
name: handle.repoId,
|
|
path: handle.dbPath,
|
|
storagePath: handle.tmpHandle.dbPath,
|
|
indexedAt: new Date().toISOString(),
|
|
lastCommit: 'abc123',
|
|
},
|
|
]);
|
|
}
|
|
});
|
|
|
|
if (process.platform === 'win32') {
|
|
it('matches Windows drive-root repo and sub-directory CWD (repo at C:\\, CWD at C:\\src)', async () => {
|
|
const { listRegisteredRepos } = await import('../../src/storage/repo-manager.js');
|
|
|
|
(listRegisteredRepos as ReturnType<typeof vi.fn>).mockResolvedValue([
|
|
{
|
|
name: handle.repoId,
|
|
path: 'C:\\',
|
|
storagePath: handle.tmpHandle.dbPath,
|
|
indexedAt: new Date().toISOString(),
|
|
lastCommit: 'abc123',
|
|
},
|
|
]);
|
|
|
|
try {
|
|
const result = await augment('login', 'C:\\src');
|
|
expect(result.length).toBeGreaterThan(0);
|
|
} finally {
|
|
(listRegisteredRepos as ReturnType<typeof vi.fn>).mockResolvedValue([
|
|
{
|
|
name: handle.repoId,
|
|
path: handle.dbPath,
|
|
storagePath: handle.tmpHandle.dbPath,
|
|
indexedAt: new Date().toISOString(),
|
|
lastCommit: 'abc123',
|
|
},
|
|
]);
|
|
}
|
|
});
|
|
|
|
it('matches Windows sub-directory repo and drive-root CWD (repo at C:\\src, CWD at C:\\)', async () => {
|
|
const { listRegisteredRepos } = await import('../../src/storage/repo-manager.js');
|
|
|
|
(listRegisteredRepos as ReturnType<typeof vi.fn>).mockResolvedValue([
|
|
{
|
|
name: handle.repoId,
|
|
path: 'C:\\src',
|
|
storagePath: handle.tmpHandle.dbPath,
|
|
indexedAt: new Date().toISOString(),
|
|
lastCommit: 'abc123',
|
|
},
|
|
]);
|
|
|
|
try {
|
|
const result = await augment('login', 'C:\\');
|
|
expect(result.length).toBeGreaterThan(0);
|
|
} finally {
|
|
(listRegisteredRepos as ReturnType<typeof vi.fn>).mockResolvedValue([
|
|
{
|
|
name: handle.repoId,
|
|
path: handle.dbPath,
|
|
storagePath: handle.tmpHandle.dbPath,
|
|
indexedAt: new Date().toISOString(),
|
|
lastCommit: 'abc123',
|
|
},
|
|
]);
|
|
}
|
|
});
|
|
}
|
|
});
|
|
});
|
|
},
|
|
{
|
|
seed: AUGMENT_SEED_DATA,
|
|
ftsIndexes: AUGMENT_FTS_INDEXES,
|
|
poolAdapter: true,
|
|
afterSetup: async (handle) => {
|
|
// Configure mock to return our test DB so augment() can find it
|
|
const { listRegisteredRepos } = await import('../../src/storage/repo-manager.js');
|
|
(listRegisteredRepos as ReturnType<typeof vi.fn>).mockResolvedValue([
|
|
{
|
|
name: handle.repoId,
|
|
path: handle.dbPath,
|
|
storagePath: handle.tmpHandle.dbPath,
|
|
indexedAt: new Date().toISOString(),
|
|
lastCommit: 'abc123',
|
|
},
|
|
]);
|
|
|
|
// Dynamically import augment after mocks are in place
|
|
const engine = await import('../../src/core/augmentation/engine.js');
|
|
augment = engine.augment;
|
|
},
|
|
},
|
|
);
|
|
|
|
// ─── FTS-unavailable suite: exercises the CONTAINS fallback branch ────────────
|
|
//
|
|
// No ftsIndexes → searchFTSFromLbug returns ftsAvailable: false → fallback fires.
|
|
// Same seed data so 'login' still exists as a graph node.
|
|
|
|
withTestLbugDB(
|
|
'augment-no-fts',
|
|
(handle) => {
|
|
describe('augment() — FTS indexes unavailable (CONTAINS fallback)', () => {
|
|
it('falls back to CONTAINS query and returns enrichment when FTS is unavailable', async () => {
|
|
const result = await augmentNoFts('login', handle.dbPath);
|
|
|
|
expect(result.length).toBeGreaterThan(0);
|
|
expect(result).toContain('[GitNexus]');
|
|
});
|
|
|
|
it("returns empty string for whitespace-only pattern (CONTAINS '' guard)", async () => {
|
|
const result = await augmentNoFts(' ', handle.dbPath);
|
|
expect(result).toBe('');
|
|
});
|
|
|
|
it('returns empty string when no nodes match the CONTAINS query', async () => {
|
|
const result = await augmentNoFts('nxyz_notfound', handle.dbPath);
|
|
expect(result).toBe('');
|
|
});
|
|
|
|
it('returns empty string when fallback CONTAINS query throws', async () => {
|
|
const poolAdapter = await import('../../src/core/lbug/pool-adapter.js');
|
|
const spy = vi
|
|
.spyOn(poolAdapter, 'executeQuery')
|
|
.mockRejectedValue(new Error('simulated DB error'));
|
|
try {
|
|
const result = await augmentNoFts('login', handle.dbPath);
|
|
expect(result).toBe('');
|
|
} finally {
|
|
spy.mockRestore();
|
|
}
|
|
});
|
|
});
|
|
},
|
|
{
|
|
seed: AUGMENT_SEED_DATA,
|
|
// Intentionally no ftsIndexes — forces searchFTSFromLbug to return ftsAvailable: false
|
|
poolAdapter: true,
|
|
afterSetup: async (handle) => {
|
|
const { listRegisteredRepos } = await import('../../src/storage/repo-manager.js');
|
|
(listRegisteredRepos as ReturnType<typeof vi.fn>).mockResolvedValue([
|
|
{
|
|
name: handle.repoId,
|
|
path: handle.dbPath,
|
|
storagePath: handle.tmpHandle.dbPath,
|
|
indexedAt: new Date().toISOString(),
|
|
lastCommit: 'abc123',
|
|
},
|
|
]);
|
|
|
|
const engine = await import('../../src/core/augmentation/engine.js');
|
|
augmentNoFts = engine.augment;
|
|
},
|
|
},
|
|
);
|