mirror of
https://github.com/abhigyanpatwari/GitNexus.git
synced 2026-08-28 05:25:25 +00:00
aed370b931
* Initial plan * Merge C++ ADL and ordinary free-call candidate sets Agent-Logs-Url: https://github.com/abhigyanpatwari/GitNexus/sessions/1aea3511-3471-4ec2-9819-0fb27ac40b89 Co-authored-by: magyargergo <11230420+magyargergo@users.noreply.github.com> * Address review feedback on merged ADL ambiguity suppression Agent-Logs-Url: https://github.com/abhigyanpatwari/GitNexus/sessions/1aea3511-3471-4ec2-9819-0fb27ac40b89 Co-authored-by: magyargergo <11230420+magyargergo@users.noreply.github.com> * fix: apply prettier to C++ ADL resolver fallback files Agent-Logs-Url: https://github.com/abhigyanpatwari/GitNexus/sessions/9b9c1494-bc69-4db5-a89d-69eb816bab82 * docs: update ADL ambiguity comments to merged narrowing flow Agent-Logs-Url: https://github.com/abhigyanpatwari/GitNexus/sessions/9b9c1494-bc69-4db5-a89d-69eb816bab82 * fix: suppress global fallback when merged ADL narrowing yields zero candidates Agent-Logs-Url: https://github.com/abhigyanpatwari/GitNexus/sessions/9b9c1494-bc69-4db5-a89d-69eb816bab82 * docs: clarify free-call fallback comment for ADL merged path Agent-Logs-Url: https://github.com/abhigyanpatwari/GitNexus/sessions/9b9c1494-bc69-4db5-a89d-69eb816bab82 * feat: ADL Gap 2 — enum-typed arguments contribute enclosing namespace ISO C++ [basic.lookup.argdep] §2: "If T is an enumeration type, its associated namespace is the namespace in which it is defined." - Add Enum to findCppClassDefBySimpleName type filter - Map Enum defs to enclosing namespace in populateCppAssociatedNamespaces - Add test fixture cpp-adl-enum-arg with color::Channel enum Agent-Logs-Url: https://github.com/abhigyanpatwari/GitNexus/sessions/ca8987b6-365e-4034-af56-ca3f9b439902 Co-authored-by: magyargergo <11230420+magyargergo@users.noreply.github.com> * feat: ADL Gap 6 — inline namespace expansion in associated set ISO C++ inline namespaces are transparent for ADL: if a namespace is in the associated set, candidates declared in its inline-namespace children are also reachable. - Expand pickCppAdlCandidates to scan inline-namespace children of associated namespaces (via isCppInlineNamespaceScope predicate) - Add test fixture cpp-adl-inline-ns-expansion: Event in outer audit, record in inline v1, other::record(int) forces arity disambiguation Agent-Logs-Url: https://github.com/abhigyanpatwari/GitNexus/sessions/ca8987b6-365e-4034-af56-ca3f9b439902 Co-authored-by: magyargergo <11230420+magyargergo@users.noreply.github.com> * feat: ADL Gap 1 — hidden friend functions visible via ADL ISO C++ [basic.lookup.argdep] §2: friend functions declared inside a class body are visible via ADL when the class is an associated class. - Exempt friend_declaration from cppLabelOverride's class-body function suppression (c-cpp.ts) so friend function defs are captured - Scan Function scopes that are direct children of associated Class scopes in pickCppAdlCandidates (adl.ts) to find hidden friends - Add test fixture cpp-adl-hidden-friend: `friend void process(Foo&)` declared inside lib::Foo, resolved via ADL from app::run() Agent-Logs-Url: https://github.com/abhigyanpatwari/GitNexus/sessions/ca8987b6-365e-4034-af56-ca3f9b439902 Co-authored-by: magyargergo <11230420+magyargergo@users.noreply.github.com> * feat: ADL Gap 3 — non-function ordinary lookup suppresses ADL ISO C++ [basic.lookup.unqual] §7: if ordinary unqualified lookup finds a name that is not a function or function template, ADL is not performed. - Add hasNonCallableBindingInScope walker in walkers.ts - In free-call-fallback, check for non-callable binding before invoking ADL; when found, bypass resolveAdlCandidates entirely - Add test fixture cpp-adl-non-function-blocks: variable `int record` shadows the function name, blocking ADL from finding audit::record Agent-Logs-Url: https://github.com/abhigyanpatwari/GitNexus/sessions/ca8987b6-365e-4034-af56-ca3f9b439902 Co-authored-by: magyargergo <11230420+magyargergo@users.noreply.github.com> * fix: use nearest-scope semantics for ADL non-callable blocker check Finding 1: `hasNonCallableBindingInScope` walked the entire scope chain, which could incorrectly suppress ADL when an inner scope had a callable and an outer scope had a non-callable for the same name. Per ISO C++ `[basic.lookup.unqual]` §7, ADL is blocked only when ordinary lookup itself finds a non-function — if ordinary lookup stops at an inner scope where only callables exist, ADL should still fire. Replace the separate `hasNonCallableBindingInScope` + `findAllCallable BindingsInScope` calls with a combined `findCallableBindingsAndAdlBlocker` walker that stops at the first scope with ANY binding for the name and returns both `{ callables, nonCallableFound }`. One pass, one stop. Fixture: cpp-adl-inner-callable-outer-noncallable — inner scope has callable `swap(int,int)`, outer scope has `int swap = 0`. ADL fires and resolves to `data::swap(Pair&,Pair&)` via argTypes narrowing. Agent-Logs-Url: https://github.com/abhigyanpatwari/GitNexus/sessions/a2f97daf-17fd-4891-8b10-a81e44d32808 Co-authored-by: magyargergo <11230420+magyargergo@users.noreply.github.com> * fix: block-scope function declaration suppresses ADL Finding 2: ISO C++ [basic.lookup.argdep] lists three ADL blockers: 1. class member declaration (handled by pickImplicitThisOverload) 2. block-scope function declaration NOT a using-declaration (NEW) 3. non-function/non-template declaration (handled by nonCallableFound) Extend `findCallableBindingsAndAdlBlocker` to return `blockScopeDeclFound` when a callable is found at a Function or Block scope — indicating a local forward declaration that should suppress ADL per standard. `free-call-fallback.ts` now checks both `nonCallableFound` and `blockScopeDeclFound` to determine ADL suppression. Fixture: cpp-adl-block-scope-decl-blocks — `void record(int);` declared inside function body prevents ADL from discovering audit::record. Agent-Logs-Url: https://github.com/abhigyanpatwari/GitNexus/sessions/a2f97daf-17fd-4891-8b10-a81e44d32808 Co-authored-by: magyargergo <11230420+magyargergo@users.noreply.github.com> * docs: update stale ADL_AMBIGUOUS comment in unqualified-ref-collision fixture Finding 3: The `ADL_AMBIGUOUS` sentinel was removed by this PR (replaced by `isOverloadAmbiguousAfterNormalization` in merged-narrowing). Update the fixture comment to reference the current mechanism. Agent-Logs-Url: https://github.com/abhigyanpatwari/GitNexus/sessions/a2f97daf-17fd-4891-8b10-a81e44d32808 Co-authored-by: magyargergo <11230420+magyargergo@users.noreply.github.com> * test: add legacy-parity expected failures for ADL blocker tests The new ADL nearest-scope blocker and block-scope function declaration tests rely on scope-resolution-only mechanisms not present in the legacy DAG path. Register them in LEGACY_RESOLVER_PARITY_EXPECTED_FAILURES. Agent-Logs-Url: https://github.com/abhigyanpatwari/GitNexus/sessions/a2f97daf-17fd-4891-8b10-a81e44d32808 Co-authored-by: magyargergo <11230420+magyargergo@users.noreply.github.com> * chore: revert unrelated prettier-plugin-tailwindcss devDep addition The `prettier-plugin-tailwindcss` dependency was accidentally added while running local prettier; it is not needed for the C++ ADL changes. Agent-Logs-Url: https://github.com/abhigyanpatwari/GitNexus/sessions/a2f97daf-17fd-4891-8b10-a81e44d32808 Co-authored-by: magyargergo <11230420+magyargergo@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: magyargergo <11230420+magyargergo@users.noreply.github.com>
8 lines
119 B
C++
8 lines
119 B
C++
#include "color.h"
|
|
|
|
namespace app {
|
|
void run() {
|
|
color::Channel ch = color::Channel::R;
|
|
serialize(ch);
|
|
}
|
|
}
|