GitNexus/gitnexus/test/unit/pdg-mode-flip.test.ts

/**
 * Integration coverage for the pdg-mode flip → forced-full-writeback wiring
 * (#2099 F1). Sibling of incremental-orchestration.test.ts: real on-disk git
 * repo, real LadybugDB, real `runFullAnalysis`.
 *
 * The P1 these tests pin: the incremental DB writeback persists only
 * changed-file nodes, so before the fix a `--pdg` run against an
 * already-indexed repo silently persisted ZERO BasicBlock rows
 * (`Incremental: changed=0`), and a plain run after a `--pdg` index left
 * zombie blocks. The primary assertion is a direct count over the BasicBlock
 * table — `meta.stats.nodes` aggregates Community/Process rows that are
 * re-derived nondeterministically every run, so it is only used as a
 * secondary signal here, never with exact equality.
 */

import { describe, it, expect } from 'vitest';
import { getStoragePaths, loadMeta, saveMeta } from '../../src/storage/repo-manager.js';
import { taintModelVersion } from '../../src/core/ingestion/taint/typescript-model.js';
import { setupMiniRepo as setupSharedMiniRepo } from '../helpers/mini-repo.js';

const setupMiniRepo = () => setupSharedMiniRepo('gitnexus-pdg-flip-');

/** Direct count over the BasicBlock table — the primary truth signal. */
async function countBasicBlocks(repoPath: string): Promise<number> {
  const adapter = await import('../../src/core/lbug/lbug-adapter.js');
  const { lbugPath } = getStoragePaths(repoPath);
  await adapter.initLbug(lbugPath);
  try {
    const rows = (await adapter.executeQuery(
      'MATCH (n:BasicBlock) RETURN count(n) AS c',
    )) as Array<{ c: number | bigint }>;
    return Number(rows[0]?.c ?? 0);
  } finally {
    await adapter.closeLbug();
  }
}

describe('pdgModeMismatch — M1→M2 stamp upgrade (#2082 M2, pure)', () => {
  it('an M1-era stamp (no REACHING_DEF cap) mismatches an M2 request — upgrade forces full writeback', async () => {
    const { pdgModeMismatch } = await import('../../src/core/run-analyze.js');
    const m1Stamp = { maxFunctionLines: 2000, maxEdgesPerFunction: 5000 };
    // default M2 request resolves maxReachingDefEdgesPerFunction=4000 ≠ undefined
    expect(pdgModeMismatch(m1Stamp, { pdg: true })).toBe(true);
  });

  it('an identical resolved M2 config compares equal (steady state keeps incremental)', async () => {
    const { pdgModeMismatch, resolvePdgConfig } = await import('../../src/core/run-analyze.js');
    const stamp = resolvePdgConfig({ pdg: true });
    expect(pdgModeMismatch(stamp, { pdg: true })).toBe(false);
  });

  it('a REACHING_DEF cap change alone trips the mismatch', async () => {
    const { pdgModeMismatch, resolvePdgConfig } = await import('../../src/core/run-analyze.js');
    const stamp = resolvePdgConfig({ pdg: true });
    expect(pdgModeMismatch(stamp, { pdg: true, pdgMaxReachingDefEdgesPerFunction: 100 })).toBe(
      true,
    );
    expect(pdgModeMismatch(stamp, { pdg: true, pdgMaxReachingDefEdgesPerFunction: 4000 })).toBe(
      false, // explicit default ≡ default (resolution before comparison)
    );
  });
});

describe('pdgModeMismatch — M2→M3 stamp upgrade (#2083 M3 U5, pure)', () => {
  it('an M2-era stamp (no taint keys) mismatches an M3 request — upgrade forces full writeback', async () => {
    const { pdgModeMismatch } = await import('../../src/core/run-analyze.js');
    // Exactly what an M2 run wrote: the three pre-taint resolved caps, no
    // maxTaintFindingsPerFunction / maxTaintHops / taintModelVersion. The
    // key-union comparator sees e.g. 200 !== undefined and trips the full
    // writeback that populates TAINTED/SANITIZES rows without --force (R7).
    const m2Stamp = {
      maxFunctionLines: 2000,
      maxEdgesPerFunction: 5000,
      maxReachingDefEdgesPerFunction: 4000,
    };
    expect(pdgModeMismatch(m2Stamp, { pdg: true })).toBe(true);
  });

  it('an identical resolved M3 config compares equal (steady state keeps incremental)', async () => {
    const { pdgModeMismatch, resolvePdgConfig } = await import('../../src/core/run-analyze.js');
    const stamp = resolvePdgConfig({ pdg: true });
    expect(pdgModeMismatch(stamp, { pdg: true })).toBe(false);
  });

  it('a taint cap change alone trips the mismatch', async () => {
    const { pdgModeMismatch, resolvePdgConfig } = await import('../../src/core/run-analyze.js');
    const stamp = resolvePdgConfig({ pdg: true });
    expect(pdgModeMismatch(stamp, { pdg: true, pdgMaxTaintFindingsPerFunction: 10 })).toBe(true);
    expect(pdgModeMismatch(stamp, { pdg: true, pdgMaxTaintHops: 4 })).toBe(true);
    expect(pdgModeMismatch(stamp, { pdg: true, pdgMaxTaintFindingsPerFunction: 200 })).toBe(
      false, // explicit default ≡ default (resolution before comparison)
    );
  });

  it('a model-version change ALONE trips the mismatch (the R7 repopulation guarantee)', async () => {
    const { pdgModeMismatch, resolvePdgConfig } = await import('../../src/core/run-analyze.js');
    // A stamp written by a hypothetical older binary whose built-in model
    // differed — every cap identical, only the digest moved. Persisted
    // findings must never outlive the model that produced them.
    const stamp = resolvePdgConfig({ pdg: true });
    const oldModelStamp = { ...stamp, taintModelVersion: '000000000000' };
    expect(stamp?.taintModelVersion).not.toBe('000000000000'); // guard the premise
    expect(pdgModeMismatch(oldModelStamp, { pdg: true })).toBe(true);
  });
});

describe('pdgModeMismatch — M3→M4 interproc-cap stamp upgrade (#2084 review P1-3, pure)', () => {
  it('resolvePdgConfig stamps the three resolved interproc caps', async () => {
    const { resolvePdgConfig } = await import('../../src/core/run-analyze.js');
    const stamp = resolvePdgConfig({ pdg: true });
    expect(stamp?.maxInterprocFindings).toBe(2000);
    expect(stamp?.maxInterprocHops).toBe(32);
    expect(stamp?.maxInterprocEdges).toBe(1000);
  });

  it('an M3-era stamp (no interproc keys) mismatches a post-fix request — upgrade forces full writeback', async () => {
    const { pdgModeMismatch } = await import('../../src/core/run-analyze.js');
    // What an M3 run wrote: every taint cap + model digest, but none of the
    // interproc caps. The key-union comparator sees 2000 !== undefined and
    // trips the full writeback that re-materialises TAINT_PATH within bounds.
    const m3Stamp = {
      maxFunctionLines: 2000,
      maxEdgesPerFunction: 5000,
      maxReachingDefEdgesPerFunction: 4000,
      maxTaintFindingsPerFunction: 200,
      maxTaintHops: 32,
      taintModelVersion: 'deadbeefcafe',
    };
    expect(pdgModeMismatch(m3Stamp, { pdg: true })).toBe(true);
  });

  it('an interproc cap change alone trips the mismatch', async () => {
    const { pdgModeMismatch, resolvePdgConfig } = await import('../../src/core/run-analyze.js');
    const stamp = resolvePdgConfig({ pdg: true });
    expect(pdgModeMismatch(stamp, { pdg: true, pdgMaxInterprocFindings: 10 })).toBe(true);
    expect(pdgModeMismatch(stamp, { pdg: true, pdgMaxInterprocEdges: 50 })).toBe(true);
    expect(pdgModeMismatch(stamp, { pdg: true, pdgMaxInterprocHops: 8 })).toBe(true);
    // explicit default ≡ default (resolution before comparison)
    expect(pdgModeMismatch(stamp, { pdg: true, pdgMaxInterprocFindings: 2000 })).toBe(false);
  });
});

describe('pdgModeMismatch — pre-M5→M5 CDG-cap stamp upgrade (#2085 M5, pure)', () => {
  it('resolvePdgConfig stamps the resolved CDG cap', async () => {
    const { resolvePdgConfig } = await import('../../src/core/run-analyze.js');
    const stamp = resolvePdgConfig({ pdg: true });
    expect(stamp?.maxCdgEdgesPerFunction).toBe(5000);
  });

  it('a pre-M5 stamp (no CDG key) mismatches a CDG-aware request — upgrade forces full writeback', async () => {
    const { pdgModeMismatch } = await import('../../src/core/run-analyze.js');
    // What an M4-era run wrote: every cap through the interproc set + model
    // digest, but NO maxCdgEdgesPerFunction. The key-union comparator sees
    // 5000 !== undefined and trips the full writeback that materialises CDG
    // edges for every file without --force.
    const m4Stamp = {
      maxFunctionLines: 2000,
      maxEdgesPerFunction: 5000,
      maxReachingDefEdgesPerFunction: 4000,
      maxTaintFindingsPerFunction: 200,
      maxTaintHops: 32,
      maxInterprocFindings: 2000,
      maxInterprocHops: 32,
      maxInterprocEdges: 1000,
      taintModelVersion,
    };
    expect(pdgModeMismatch(m4Stamp, { pdg: true })).toBe(true);
  });

  it('a CDG cap change alone trips the mismatch', async () => {
    const { pdgModeMismatch, resolvePdgConfig } = await import('../../src/core/run-analyze.js');
    const stamp = resolvePdgConfig({ pdg: true });
    expect(pdgModeMismatch(stamp, { pdg: true, pdgMaxCdgEdgesPerFunction: 10 })).toBe(true);
    // explicit default ≡ default (resolution before comparison)
    expect(pdgModeMismatch(stamp, { pdg: true, pdgMaxCdgEdgesPerFunction: 5000 })).toBe(false);
  });
});

describe('pdgModeMismatch — pre-#2201→SSA reaching-defs solver upgrade (#2201 review R3, pure)', () => {
  it('resolvePdgConfig stamps the reaching-defs solver identity', async () => {
    const { resolvePdgConfig } = await import('../../src/core/run-analyze.js');
    const stamp = resolvePdgConfig({ pdg: true });
    expect(stamp?.reachingDefSolver).toBe('ssa-sparse-v1');
  });

  it('a pre-#2201 stamp (no solver key) mismatches the SSA request — upgrade recomputes truncated deep-loop facts', async () => {
    const { pdgModeMismatch } = await import('../../src/core/run-analyze.js');
    // What a pre-#2201 (M5-era) run wrote: every cap + model digest, but NO
    // reachingDefSolver. The key-union comparator sees 'ssa-sparse-v1' !==
    // undefined and trips the full writeback that recomputes the now-fuller
    // REACHING_DEF coverage — the deep-loop functions the dense worklist
    // truncated to empty at the blocks×64 ceiling now compute full facts.
    const m5Stamp = {
      maxFunctionLines: 2000,
      maxEdgesPerFunction: 5000,
      maxReachingDefEdgesPerFunction: 4000,
      maxCdgEdgesPerFunction: 5000,
      maxTaintFindingsPerFunction: 200,
      maxTaintHops: 32,
      maxInterprocFindings: 2000,
      maxInterprocHops: 32,
      maxInterprocEdges: 1000,
      taintModelVersion,
    };
    expect(pdgModeMismatch(m5Stamp, { pdg: true })).toBe(true);
  });

  it('an identical post-#2201 stamp compares equal (no spurious re-analysis churn)', async () => {
    const { pdgModeMismatch, resolvePdgConfig } = await import('../../src/core/run-analyze.js');
    const stamp = resolvePdgConfig({ pdg: true });
    expect(pdgModeMismatch(stamp, { pdg: true })).toBe(false);
  });
});

describe('detect_changes BasicBlock exclusion (#2082 U7)', () => {
  it('the symbol-overlap id-prefix filter excludes exactly the BasicBlock rows', async () => {
    const repo = await setupMiniRepo();
    try {
      const { runFullAnalysis } = await import('../../src/core/run-analyze.js');
      const cb = { onProgress: () => {}, onLog: () => {} };
      await runFullAnalysis(repo.dbPath, { skipAgentsMd: true, pdg: true }, cb);

      const adapter = await import('../../src/core/lbug/lbug-adapter.js');
      const { lbugPath } = getStoragePaths(repo.dbPath);
      await adapter.initLbug(lbugPath);
      try {
        // Counterfactual: WITHOUT the U7 filter, line-bearing BasicBlock rows
        // exist on a pdg index (the noise detect_changes used to report).
        const blocks = (await adapter.executeQuery(
          `MATCH (n) WHERE n.id STARTS WITH 'BasicBlock:'
             AND n.startLine IS NOT NULL AND n.endLine IS NOT NULL
           RETURN n.id AS id`,
        )) as Array<{ id: string }>;
        expect(blocks.length).toBeGreaterThan(0);
        // With the U7 filter (the exact predicate detectChanges now runs —
        // also validates STARTS WITH against the real engine): no BasicBlocks,
        // real symbols intact.
        const symbols = (await adapter.executeQuery(
          `MATCH (n) WHERE NOT n.id STARTS WITH 'BasicBlock:'
             AND n.startLine IS NOT NULL AND n.endLine IS NOT NULL
           RETURN n.id AS id`,
        )) as Array<{ id: string }>;
        expect(symbols.length).toBeGreaterThan(0);
        for (const row of symbols) {
          expect(String(row.id)).not.toMatch(/^BasicBlock:/);
        }
        // DB-level smoke for the M2 projection itself: REACHING_DEF rows
        // persisted with the variable name in `reason` (plan Validation).
        const rd = (await adapter.executeQuery(
          `MATCH (:BasicBlock)-[r:CodeRelation {type: 'REACHING_DEF'}]->(:BasicBlock)
           RETURN count(r) AS c`,
        )) as Array<{ c: number | bigint }>;
        expect(Number(rd[0]?.c ?? 0)).toBeGreaterThan(0);
      } finally {
        await adapter.closeLbug();
      }
    } finally {
      await repo.cleanup();
    }
  }, 600_000);
});

describe('runFullAnalysis — pdg-mode flip (#2099 F1)', () => {
  it('off→on flip forces a full writeback that persists the CFG layer; on→off removes it', async () => {
    const repo = await setupMiniRepo();
    try {
      const { runFullAnalysis } = await import('../../src/core/run-analyze.js');
      const { storagePath } = getStoragePaths(repo.dbPath);
      const logs: string[] = [];
      const cb = { onProgress: () => {}, onLog: (m: string) => logs.push(m) };

      // 1. Plain index — no CFG layer, no stamp.
      await runFullAnalysis(repo.dbPath, { skipAgentsMd: true }, cb);
      expect(await countBasicBlocks(repo.dbPath)).toBe(0);
      expect((await loadMeta(storagePath))!.pdg).toBeUndefined();

      // 2. The P1 trigger: --pdg with NO file changes. Pre-fix this hit the
      //    alreadyUpToDate fast path (or the incremental path with changed=0)
      //    and persisted nothing. The flip check must force a full rebuild.
      logs.length = 0;
      const flipOn = await runFullAnalysis(repo.dbPath, { skipAgentsMd: true, pdg: true }, cb);
      expect(flipOn.alreadyUpToDate).toBeUndefined();
      expect(logs.some((m) => m.includes('pdg mode changed'))).toBe(true);
      expect(await countBasicBlocks(repo.dbPath)).toBeGreaterThan(0);
      const stamped = await loadMeta(storagePath);
      expect(stamped!.pdg).toEqual({
        maxFunctionLines: 2000,
        maxEdgesPerFunction: 5000,
        maxReachingDefEdgesPerFunction: 4000,
        maxCdgEdgesPerFunction: 5000,
        maxTaintFindingsPerFunction: 200,
        maxTaintHops: 32,
        maxInterprocFindings: 2000,
        maxInterprocHops: 32,
        maxInterprocEdges: 1000,
        taintModelVersion,
        reachingDefSolver: 'ssa-sparse-v1',
        hasCallSummary: true,
      });
      expect(stamped!.incrementalInProgress).toBeUndefined(); // cleared on success

      // 3. Steady state: a second identical --pdg run takes the fast path —
      //    the flip check must compare equal (KTD5 default resolution).
      logs.length = 0;
      const steady = await runFullAnalysis(repo.dbPath, { skipAgentsMd: true, pdg: true }, cb);
      expect(steady.alreadyUpToDate).toBe(true);
      expect(logs.some((m) => m.includes('pdg mode changed'))).toBe(false);

      // 4. Flip back: a plain run must fully remove the CFG layer (no
      //    zombie BasicBlocks) and clear the stamp.
      logs.length = 0;
      const flipOff = await runFullAnalysis(repo.dbPath, { skipAgentsMd: true }, cb);
      expect(flipOff.alreadyUpToDate).toBeUndefined();
      expect(logs.some((m) => m.includes('pdg mode changed'))).toBe(true);
      expect(await countBasicBlocks(repo.dbPath)).toBe(0);
      expect((await loadMeta(storagePath))!.pdg).toBeUndefined();
    } finally {
      await repo.cleanup();
    }
  }, 600_000);

  it('a cap change while pdg stays on forces a rebuild; matching modes keep incremental eligibility', async () => {
    const repo = await setupMiniRepo();
    try {
      const { runFullAnalysis } = await import('../../src/core/run-analyze.js');
      const { storagePath } = getStoragePaths(repo.dbPath);
      const logs: string[] = [];
      const cb = { onProgress: () => {}, onLog: (m: string) => logs.push(m) };

      await runFullAnalysis(repo.dbPath, { skipAgentsMd: true, pdg: true }, cb);
      const blocks = await countBasicBlocks(repo.dbPath);
      expect(blocks).toBeGreaterThan(0);

      // Cap change with no file changes → mismatch → full rebuild (the
      // emit-time cap shapes the persisted edge set; meta must re-stamp).
      logs.length = 0;
      const capChange = await runFullAnalysis(
        repo.dbPath,
        { skipAgentsMd: true, pdg: true, pdgMaxEdgesPerFunction: 1 },
        cb,
      );
      expect(capChange.alreadyUpToDate).toBeUndefined();
      expect(logs.some((m) => m.includes('different caps'))).toBe(true);
      expect((await loadMeta(storagePath))!.pdg).toEqual({
        maxFunctionLines: 2000,
        maxEdgesPerFunction: 1,
        maxReachingDefEdgesPerFunction: 4000,
        maxCdgEdgesPerFunction: 5000,
        maxTaintFindingsPerFunction: 200,
        maxTaintHops: 32,
        maxInterprocFindings: 2000,
        maxInterprocHops: 32,
        maxInterprocEdges: 1000,
        taintModelVersion,
        reachingDefSolver: 'ssa-sparse-v1',
        hasCallSummary: true,
      });
      // The CFG layer survives a rebuild under a tighter edge cap (blocks are
      // never capped, only edges).
      expect(await countBasicBlocks(repo.dbPath)).toBe(blocks);
    } finally {
      await repo.cleanup();
    }
  }, 600_000);

  it('a dirty flag from a crashed full rebuild composes with the flip check: one rebuild, flag cleared', async () => {
    const repo = await setupMiniRepo();
    try {
      const { runFullAnalysis } = await import('../../src/core/run-analyze.js');
      const { storagePath } = getStoragePaths(repo.dbPath);
      const logs: string[] = [];
      const cb = { onProgress: () => {}, onLog: (m: string) => logs.push(m) };

      await runFullAnalysis(repo.dbPath, { skipAgentsMd: true, pdg: true }, cb);

      // Simulate a full rebuild that died between the pre-wipe dirty-flag
      // write (KTD2b: toWriteCount 0 sentinel) and the end-of-run saveMeta.
      const meta = (await loadMeta(storagePath))!;
      await saveMeta(storagePath, {
        ...meta,
        incrementalInProgress: { startedAt: Date.now(), toWriteCount: 0 },
      });

      // Next plain run: crash recovery fires (force), the flip ALSO logs its
      // notice (decoupled from the force gate), and exactly one rebuild runs.
      logs.length = 0;
      const recovered = await runFullAnalysis(repo.dbPath, { skipAgentsMd: true }, cb);
      expect(recovered.alreadyUpToDate).toBeUndefined();
      expect(logs.some((m) => m.includes('did not complete cleanly'))).toBe(true);
      expect(logs.some((m) => m.includes('pdg mode changed'))).toBe(true);
      const after = await loadMeta(storagePath);
      expect(after!.incrementalInProgress).toBeUndefined();
      expect(after!.pdg).toBeUndefined();
      expect(await countBasicBlocks(repo.dbPath)).toBe(0);
    } finally {
      await repo.cleanup();
    }
  }, 600_000);
});