GitNexus/gitnexus/test/integration/enrichment.test.ts
Gergő Magyar 892e1d6088
test: add integration test coverage and fix KuzuDB fork crashes (#209)
* ci: add macOS to cross-platform test matrix

* ci: run integration tests on all platforms, add macOS to matrix

* ci: add build step before cross-platform integration tests

Worker pool requires compiled parse-worker.js in dist/.
Without build, falls back to sequential parsing which times out
on macOS runners.

* fix(pipeline): resolve worker path to dist/ when running under vitest

import.meta.url points to src/ under vitest where no .js exists.
Fall back to dist/core/ingestion/workers/parse-worker.js so worker
threads spawn correctly on all platforms instead of sequential fallback
that times out on slower macOS CI runners.

* ci: split cross-platform unit and integration tests into parallel jobs

* test: add integration tests for worker pool and hooks e2e

- worker-pool.test.ts: 7 tests verifying dist/ worker spawning,
  multi-file parsing, progress reporting, and clean termination
- hooks-e2e.test.ts: 28 tests with real git repos testing staleness
  detection, embeddings flag, mutation regex, cwd validation,
  and .gitnexus directory discovery

* refactor: extract shared hook test helpers and simplify worker fallback

- Extract runHook/parseHookOutput into test/utils/hook-test-helpers.ts
- Deduplicate fileURLToPath calls in pipeline.ts worker resolution
- Add isDev logging for worker pool creation failures

* fix(test): accept timeout as valid outcome for PreToolUse CLI spawn

The Plugin hook spawns `gitnexus augment` which may hang on macOS
when the CLI is unavailable, causing a 10s timeout (status=null)
instead of a clean exit (status=0). Accept both as non-crash outcomes.

* test: add integration test coverage and fix KuzuDB fork crashes

- Add new integration tests: search, enrichment, CLI e2e (968 total tests)
- Fix KuzuDB native destructor segfault in vitest fork pool by adding
  detachKuzu() that nulls refs without calling .close()
- Merge core adapter test blocks to share one coreHandle (prevents
  multiple coreInitKuzu calls that re-open native DB handles)
- Fix FTS Cypher injection: escape backslashes in bm25-index.ts and
  kuzu-adapter.ts queryFTS
- Add worker script existence check in worker-pool.ts to prevent
  MODULE_NOT_FOUND crashes in worker threads
- Add test/setup.ts global teardown that detaches native refs
- Add test/helpers/test-indexed-db.ts shared KuzuDB test lifecycle helper

* fix(test): update worker-pool test to expect throw on invalid path

The fs.existsSync validation in createWorkerPool now throws
synchronously for missing worker scripts. Update the test assertion
from .not.toThrow() to .toThrow(/Worker script not found/).

* fix(test): use fileParallelism instead of deprecated singleFork

vitest 4.x removed poolOptions.forks.singleFork. The top-level
singleFork was silently ignored, causing multiple forks to spawn
and timeout during KuzuDB native cleanup on CI.

* fix(test): add maxWorkers: 1 to prevent per-file kuzu native addon reload

On Ubuntu CI, vitest forks pool creates a new child process per test
file. Each fork loads the KuzuDB native addon (~40s on Ubuntu runners),
causing 12 files × 40s = 8 minutes of overhead that exceeds the
10-minute CI timeout.

maxWorkers: 1 forces vitest to reuse a single fork process, loading
the native addon once. Combined with fileParallelism: false, all test
files run sequentially in that single fork.

* fix(test): prevent KuzuDB native destructor hangs on fork worker exit

- setup.ts: closeKuzu() first (marks native handles closed so destructors
  are no-ops), then detachKuzu() as safety net
- test-indexed-db.ts: use detachKuzu() in per-test cleanup instead of
  closeKuzu() which could hang during teardown

* refactor(test): add withTestKuzuDB lifecycle wrapper with declarative options

withTestKuzuDB now manages the full KuzuDB test lifecycle so test files
never call initKuzu/closeCoreKuzu/poolInitKuzu/loadFTSExtension directly.

Options: seed, ftsIndexes, poolAdapter, afterSetup, timeout.
Each call is wrapped in its own describe block to isolate lifecycle hooks.

Migrated search.test.ts, enrichment-and-augmentation.test.ts, and
kuzu-pool.test.ts core adapter block to use the wrapper.

* refactor(test): migrate all integration tests to withTestKuzuDB

- Split enrichment-and-augmentation.test.ts into enrichment.test.ts
  and augmentation.test.ts for focused test isolation
- Migrate kuzu-pool.test.ts pool lifecycle tests to withTestKuzuDB
- Migrate local-backend.test.ts to two withTestKuzuDB blocks
  (pool queries + callTool dispatch)
- Zero direct kuzu.Database/Connection usage remains in test files

* refactor(test): enforce one describe per test file

- Split search.test.ts → search-core.test.ts + search-pool.test.ts
- Split kuzu-pool.test.ts → kuzu-pool.test.ts + kuzu-core-adapter.test.ts
- Split local-backend.test.ts → local-backend.test.ts + local-backend-calltool.test.ts
- Wrap enrichment.test.ts in single top-level describe
- Wrap parsing.test.ts in single top-level describe
- Every integration test file now has exactly 1 top-level block

* refactor(test): extract shared seed data into fixture files

- Create test/fixtures/search-seed.ts with SEARCH_SEED_DATA and SEARCH_FTS_INDEXES
- Create test/fixtures/local-backend-seed.ts with LOCAL_BACKEND_SEED_DATA and LOCAL_BACKEND_FTS_INDEXES
- Remove duplicated constants from split test files
- Remove dead vi.mock from local-backend.test.ts
- Prefix unused handle param with underscore in search-core.test.ts

* fix(test): prevent KuzuDB C++ destructor hang on Ubuntu CI

Add process.on('beforeExit', () => process.exit(0)) to force
immediate exit before GC can trigger native C++ destructors on
orphaned KuzuDB Database/Connection objects.

Root cause: detachKuzu() nulls JS refs but native C++ objects
remain in V8 heap. During fork worker exit, GC runs finalizers
that invoke C++ destructors on a torn-down runtime — hangs on
Ubuntu, segfaults on Windows.

The beforeExit event fires when the event loop has drained
(test results already sent via IPC), so process.exit(0) is safe.

Also simplifies afterAll: removes closeKuzu() calls (always
no-ops since withTestKuzuDB detaches first) — only detachKuzu().

* perf(test): share single KuzuDB instance across integration tests

Create schema once in globalSetup instead of per-file, eliminating
29 DDL queries × 7 test files. Each file now only clears and reseeds
data via DETACH DELETE, reducing DB open/close cycles significantly.

* fix(test): improve KuzuDB cleanup to prevent C++ destructor hangs on exit

* fix(test): replace async close calls with synchronous counterparts to prevent potential hangs

* feat(ci): enhance integration test matrix with detailed test groups and improved reporting

* test: add diagnostic output to analyze CLI e2e assertion for CI debugging

* fix: pass NODE_OPTIONS in runCli to prevent ensureHeap re-exec in tests

* update gitnexus analysis md files

* feat(ci): modular workflow architecture with artifact reporting

Refactor monolithic ci.yml into orchestrator calling three reusable
workflows (quality, unit-tests, integration) via workflow_call.

- Add composite action for shared Node.js 20 setup and npm ci
- Add ci-quality.yml for TypeScript typecheck
- Add ci-unit-tests.yml with coverage reporting, JSON test results,
  and artifact upload for PR summary comments
- Add ci-integration.yml with 4 test groups x 3 OS matrix (12 jobs)
- Add PR report job with sticky comment showing coverage metrics
- Add unified CI Gate status check for branch protection
- Add explicit permissions blocks to all child workflows

* test: add comprehensive unhappy path coverage across all 16 integration test files

Add 80+ error handling, edge case, and unhappy path tests covering:
- KuzuDB core adapter: invalid Cypher, duplicate FTS index, empty queries, missing paths
- CLI e2e: non-git dirs, non-indexed repos, unknown commands, help flag
- Local backend callTool: missing params, invalid Cypher, nonexistent symbols
- Tree-sitter: unsupported languages, malformed code, empty content, binary files
- Worker pool: dispatch after terminate, double terminate, empty content, zero-size pool
- Pipeline: empty content parsing, flexible file count assertions
- Search, enrichment, augmentation, CSV, hooks, filesystem: various edge cases

Also fixes pre-existing test issues:
- isWriteQuery CREATED test (CYPHER_WRITE_RE uses \b word boundaries)
- KuzuDB throws Binder exception for unknown tables (not empty result)
- runPipelineFromRepo requires onProgress callback

All 1,086 tests pass (53 files).

* fix: prevent KuzuDB worker hang with handle unref strategy and safety-net timer

Replace beforeExit force-exit with per-file handle unref + safety-net timer
that doesn't leak across files in single-fork mode.

* refactor: improve KuzuDB test isolation and cleanup strategy

* fix: prevent KuzuDB N-API destructor hang on Linux/macOS

Pool adapter closeOne() now just deletes the pool entry without calling
native close methods — read-only DBs have no WAL to flush, so GC/process
exit safely reclaims native resources without triggering the C++ destructor
segfault.

withTestKuzuDB wrapper handles core adapter close platform-conditionally:
Windows needs explicit closeKuzu() due to file locks, Linux/macOS skips
it to avoid deadlock. kuzu-pool.test.ts now uses poolAdapter: true instead
of manual afterSetup. pipeline.test.ts assertion fixed to match actual
behavior (resolves with empty result, not rejects).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* fix: restore vitest safety nets and skip globalSetup close on Linux

- Restore dangerouslyIgnoreUnhandledErrors and teardownTimeout in
  vitest.config.ts — KuzuDB N-API destructor segfaults on fork exit
  are not real test failures (all 839 unit tests pass).
- Skip conn.close()/db.close() in globalSetup on Linux/macOS to
  prevent N-API destructor crash that kills the vitest process before
  fork workers can start (fixes search-core.test.ts EPIPE on Ubuntu CI).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* feat: enable coverage auto-ratcheting with bumped thresholds

- Bump vitest coverage thresholds to match actual CI values (26/23/28/27)
- Enable thresholds.autoUpdate for automatic local ratcheting

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* feat(ci): rich PR report with coverage bars, test counts, and threshold tracking

- Fix coverage N/A bug: use find instead of hardcoded artifact path
- Add emoji status icons and overall pass/fail banner
- Show covered/total counts alongside percentages
- Add visual progress bars with green/red threshold indicators
- Show test suite count and duration
- Add collapsible auto-ratchet explainer
- Graceful fallback when coverage data is unavailable

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* chore: bump version to 1.3.11, update CHANGELOG, add release.yml

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-08 18:00:45 +00:00

235 lines
8.4 KiB
TypeScript

/**
* Integration Tests: Cluster Enricher
*
* enrichClusters / enrichClustersBatch with mock LLM
* - Valid JSON response populates enrichments
* - Invalid JSON response falls back to heuristic label
* - Batch processing with enrichClustersBatch
* - Empty members use heuristicLabel fallback
*/
import { describe, it, expect, vi } from 'vitest';
import {
enrichClusters,
enrichClustersBatch,
type LLMClient,
type ClusterMemberInfo,
} from '../../src/core/ingestion/cluster-enricher.js';
import type { CommunityNode } from '../../src/core/ingestion/community-processor.js';
describe('enrichment', () => {
describe('enrichClusters', () => {
const communities: CommunityNode[] = [
{
id: 'comm_0',
label: 'Auth',
heuristicLabel: 'Authentication',
cohesion: 0.8,
symbolCount: 3,
},
{
id: 'comm_1',
label: 'Utils',
heuristicLabel: 'Utilities',
cohesion: 0.5,
symbolCount: 2,
},
];
const memberMap = new Map<string, ClusterMemberInfo[]>([
[
'comm_0',
[
{ name: 'login', filePath: 'src/auth.ts', type: 'Function' },
{ name: 'validate', filePath: 'src/auth.ts', type: 'Function' },
{ name: 'AuthService', filePath: 'src/auth.ts', type: 'Class' },
],
],
[
'comm_1',
[
{ name: 'hash', filePath: 'src/utils.ts', type: 'Function' },
{ name: 'format', filePath: 'src/utils.ts', type: 'Function' },
],
],
]);
it('populates enrichments when LLM returns valid JSON', async () => {
const mockLLM: LLMClient = {
generate: vi.fn()
.mockResolvedValueOnce('{"name": "Auth Module", "description": "Handles authentication"}')
.mockResolvedValueOnce('{"name": "Utility Helpers", "description": "Common utilities"}'),
};
const result = await enrichClusters(communities, memberMap, mockLLM);
expect(result.enrichments.size).toBe(2);
const auth = result.enrichments.get('comm_0')!;
expect(auth.name).toBe('Auth Module');
expect(auth.description).toBe('Handles authentication');
const utils = result.enrichments.get('comm_1')!;
expect(utils.name).toBe('Utility Helpers');
expect(utils.description).toBe('Common utilities');
expect(result.tokensUsed).toBeGreaterThan(0);
expect(mockLLM.generate).toHaveBeenCalledTimes(2);
});
it('falls back to heuristic label when LLM returns invalid JSON', async () => {
const badLLM: LLMClient = {
generate: vi.fn().mockResolvedValue('this is not json at all'),
};
const result = await enrichClusters(communities, memberMap, badLLM);
expect(result.enrichments.size).toBe(2);
// Invalid JSON -> parseEnrichmentResponse falls back to heuristicLabel
const auth = result.enrichments.get('comm_0')!;
expect(auth.name).toBe('Authentication');
expect(auth.keywords).toEqual([]);
expect(auth.description).toBe('');
const utils = result.enrichments.get('comm_1')!;
expect(utils.name).toBe('Utilities');
});
it('uses heuristicLabel fallback for clusters with empty members', async () => {
const emptyMemberMap = new Map<string, ClusterMemberInfo[]>([
['comm_0', []],
['comm_1', []],
]);
const mockLLM: LLMClient = {
generate: vi.fn().mockResolvedValue('{"name": "Should Not Appear", "description": "nope"}'),
};
const result = await enrichClusters(communities, emptyMemberMap, mockLLM);
expect(result.enrichments.size).toBe(2);
// Empty members -> skip LLM, use heuristic directly
const auth = result.enrichments.get('comm_0')!;
expect(auth.name).toBe('Authentication');
expect(auth.keywords).toEqual([]);
expect(auth.description).toBe('');
// LLM should never be called for empty members
expect(mockLLM.generate).not.toHaveBeenCalled();
});
it('calls onProgress callback with correct current/total', async () => {
const mockLLM: LLMClient = {
generate: vi.fn().mockResolvedValue('{"name": "X", "description": "Y"}'),
};
const progress: Array<[number, number]> = [];
await enrichClusters(communities, memberMap, mockLLM, (current, total) => {
progress.push([current, total]);
});
expect(progress).toEqual([
[1, 2],
[2, 2],
]);
});
// ─── Unhappy paths ────────────────────────────────────────────────
it('falls back to heuristic when LLM returns empty string', async () => {
const emptyLLM: LLMClient = {
generate: vi.fn().mockResolvedValue(''),
};
const result = await enrichClusters(communities, memberMap, emptyLLM);
expect(result.enrichments.size).toBe(2);
expect(result.enrichments.get('comm_0')!.name).toBe('Authentication');
expect(result.enrichments.get('comm_1')!.name).toBe('Utilities');
});
it('handles zero communities gracefully', async () => {
const mockLLM: LLMClient = {
generate: vi.fn(),
};
const result = await enrichClusters([], new Map(), mockLLM);
expect(result.enrichments.size).toBe(0);
expect(mockLLM.generate).not.toHaveBeenCalled();
});
it('handles LLM returning JSON with missing description field', async () => {
const partialLLM: LLMClient = {
generate: vi.fn().mockResolvedValue('{"name": "Auth Only"}'),
};
const result = await enrichClusters(communities, memberMap, partialLLM);
expect(result.enrichments.size).toBe(2);
const auth = result.enrichments.get('comm_0')!;
expect(auth.name).toBe('Auth Only');
});
});
describe('enrichClustersBatch', () => {
const communities: CommunityNode[] = [
{ id: 'comm_0', label: 'Auth', heuristicLabel: 'Authentication', cohesion: 0.8, symbolCount: 3 },
{ id: 'comm_1', label: 'Utils', heuristicLabel: 'Utilities', cohesion: 0.5, symbolCount: 2 },
{ id: 'comm_2', label: 'Router', heuristicLabel: 'Routing', cohesion: 0.6, symbolCount: 2 },
];
const memberMap = new Map<string, ClusterMemberInfo[]>([
['comm_0', [{ name: 'login', filePath: 'src/auth.ts', type: 'Function' }]],
['comm_1', [{ name: 'hash', filePath: 'src/utils.ts', type: 'Function' }]],
['comm_2', [{ name: 'route', filePath: 'src/router.ts', type: 'Function' }]],
]);
it('processes all clusters in batches and returns enrichments', async () => {
const batchResponse = JSON.stringify([
{ id: 'comm_0', name: 'Auth Module', keywords: ['auth', 'login'], description: 'Authentication logic' },
{ id: 'comm_1', name: 'Utility Helpers', keywords: ['utils'], description: 'Common utilities' },
]);
const batchResponse2 = JSON.stringify([
{ id: 'comm_2', name: 'HTTP Router', keywords: ['routing'], description: 'Request routing' },
]);
const mockLLM: LLMClient = {
generate: vi.fn()
.mockResolvedValueOnce(batchResponse)
.mockResolvedValueOnce(batchResponse2),
};
const result = await enrichClustersBatch(communities, memberMap, mockLLM, 2);
expect(result.enrichments.size).toBe(3);
const auth = result.enrichments.get('comm_0')!;
expect(auth.name).toBe('Auth Module');
expect(auth.keywords).toEqual(['auth', 'login']);
expect(auth.description).toBe('Authentication logic');
const utils = result.enrichments.get('comm_1')!;
expect(utils.name).toBe('Utility Helpers');
const router = result.enrichments.get('comm_2')!;
expect(router.name).toBe('HTTP Router');
expect(result.tokensUsed).toBeGreaterThan(0);
// 3 communities with batchSize=2 -> 2 LLM calls
expect(mockLLM.generate).toHaveBeenCalledTimes(2);
});
it('falls back to heuristic labels on batch parse failure', async () => {
const mockLLM: LLMClient = {
generate: vi.fn().mockRejectedValue(new Error('LLM unavailable')),
};
const result = await enrichClustersBatch(communities, memberMap, mockLLM, 5);
// All communities should get heuristic fallback
expect(result.enrichments.size).toBe(3);
expect(result.enrichments.get('comm_0')!.name).toBe('Authentication');
expect(result.enrichments.get('comm_1')!.name).toBe('Utilities');
expect(result.enrichments.get('comm_2')!.name).toBe('Routing');
});
});
});