GitNexus/gitnexus/test/unit/leading-doc-comment.test.ts
Gergő Magyar 999cc9f913
fix(deps): upgrade native tree-sitter to 0.25.1 (#3531)
* fix(deps): upgrade native tree-sitter to 0.25.1

* fix(tree-sitter): preserve sync loading and update verified capture baselines

Route C# scope queries through the synchronous native grammar loader so the compiled analyze module remains require-compatible on Node 22.18. Refresh only the audited empty-Python-module and renamed-PHP-fixture captures, and pin the runtime assertion to 0.25.1.

Validated 479 targeted tests, all 16 scope-capture benchmark cases, Python capture/import guards, compiled C# worker parsing, build, typecheck and formatting. Performance budgets are unchanged.

* fix(tree-sitter): refresh upstream vendors and preserve parser semantics

* fix(ci): refresh prebuilds and support Windows ARM

Refresh macOS, Linux ARM, and Windows x64 grammar binaries from the successful native CI builds. Pin node-gyp 12.4.0 so the Windows ARM jobs recognize Visual Studio 2026.

Use local Git filtering for E2E to avoid PR-files API timeouts on generated parser diffs.

Validation: 143 focused tests, Actionlint, and all 16 scope-capture benchmark checks passed. Full npm test run started; native database suites still running.

* fix(ci): refresh Windows ARM grammar prebuilds

Import all seven Windows ARM grammar artifacts from successful native build run 37965761760. Artifact filenames and SHA-256 hashes verified; all 42 native build jobs passed.

Validation: 31 prebuild coverage tests passed.

* fix(bench): stabilize scope capture timing guard

Warm each input size seven times and use 21 median samples while retaining isolated timing blocks. Yield between languages so native finalizers release allocations outside the measured sections. Keep all fixture sizes, fingerprints, scaling formulas, and budgets unchanged.

Validation: all 16 language guards passed with a 2 GB heap limit (1.38 deep-chain ratio; 1518 MB peak RSS). Linear and quadratic controls passed their expected guard outcomes. Formatting and graph change analysis passed. Full npm test is running without failures so far.

* fix(parser): reduce TypeScript capture traversal cost

* fix(test): await parser worker readiness before teardown

* fix(parser): load C# synchronously in workers

* fix(grpc): resolve native proto detections against their own file

With the native proto grammar active, sibling .proto files that declare
the same short service name under different packages tied in the
directory-based resolveProtoConflict heuristic and both providers were
dropped. A proto-origin detection already knows its defining file, so
use that file's entry before falling back to the heuristic.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* ci(packaging): assert native grammars load from the installed tarball

The packaged-install smoke only ran `gitnexus --version`, so a grammar
that failed to load from the published package (bundled runtime, patched
peer manifests, vendored prebuilds, C# sync loader, Protobuf wrapper)
would ship silently; the dev-tree ABI smoke also accepts vendored
grammars that report unavailable. Parse a sample for every registered
grammar plus the native Protobuf plugin from the installed package, on
the main thread and in a worker thread.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* ci(tree-sitter): track compatibility workarounds instead of 0.25 readiness

The daily readiness report still targeted tree-sitter@0.25.0, so after the
upgrade it would keep reporting "Blocked" and never close its tracking issue.
Repurpose it to track what we carry for the bundled runtime: derive the target
from the package.json pin, list each pack-time peer patch from
prepare-tree-sitter-bundle.cjs with its drop condition (bump, wait for an
upstream release, transitive, or intentionally pinned), and reword the
buckets. The workflow adopts the issue opened under the old title.

Also update the grammar-update-monitor header and auto-PR text, which still
described the 0.21.1 runtime and a tree-sitter-c hold.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* test(dart): assert both nested labels target the loop; fix Zig call-shape doc

The nested-label CFG test only jumped to `outer` and checked reachability,
which still passes when a jump is retargeted to the inner loop (its exit
reaches the outer header). Jump to both labels and assert the exact
`continue` edges; dropping the inner label now fails the test.

Update the Zig callable-flow comment: call_expression now wraps actuals in a
required `arguments:` field.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Gergo Magyar <gergomagyar0@gmail.com>
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-10 13:07:59 +03:00

167 lines
6 KiB
TypeScript

/**
* Unit tests for `extractLeadingDocComment` (issue #2270, U1).
*
* Verifies the shared helper that pulls a `/** ... *\/` leading doc comment
* (Javadoc / KDoc) off the definition node's preceding named sibling. The
* helper is grammar-agnostic: it matches on the `/**` text prefix, so it works
* for both tree-sitter-java (`block_comment`) and tree-sitter-kotlin
* (`multiline_comment`).
*/
import { describe, it, expect } from 'vitest';
import Parser from 'tree-sitter';
import Java from 'tree-sitter-java';
import { requireVendoredGrammar } from '../../src/core/tree-sitter/vendored-grammars.js';
import {
extractLeadingDocComment,
type SyntaxNode,
} from '../../src/core/ingestion/utils/ast-helpers.js';
// Vendored grammar — loaded from vendor/ by absolute path, never node_modules (#2111).
const Kotlin = requireVendoredGrammar('tree-sitter-kotlin');
function firstNode(language: Parser.Language, src: string, type: string): SyntaxNode {
const parser = new Parser();
parser.setLanguage(language);
const node = parser.parse(src).rootNode.descendantsOfType(type)[0];
expect(node, `expected a ${type} node in source`).toBeDefined();
return node;
}
describe('extractLeadingDocComment', () => {
it('extracts a multi-line Javadoc including tag content (issue #2270 repro)', () => {
const src = `package demo;
public class Probe {
/**
* Computes the running balance across all user accounts.
* @param userId the unique user identifier
* @deprecated since 2.0, use computeBalanceV2
*/
public java.math.BigDecimal computeBalance(Long userId) { return null; }
}`;
const method = firstNode(Java, src, 'method_declaration');
const doc = extractLeadingDocComment(method);
expect(doc).toContain('Computes the running balance');
expect(doc).toContain('userId');
expect(doc).toContain('computeBalanceV2');
});
it('extracts a class-level Javadoc', () => {
const cls = firstNode(
Java,
`/**\n * A probe class.\n */\npublic class Probe {}`,
'class_declaration',
);
expect(extractLeadingDocComment(cls)).toBe('A probe class.');
});
it('returns undefined when there is no preceding comment', () => {
const method = firstNode(Java, `class P { void m() {} }`, 'method_declaration');
expect(extractLeadingDocComment(method)).toBeUndefined();
});
it('returns undefined for a non-doc block comment (license header style)', () => {
const method = firstNode(
Java,
`class P {\n/* not a doc comment */\nvoid m() {}\n}`,
'method_declaration',
);
expect(extractLeadingDocComment(method)).toBeUndefined();
});
it('returns undefined for a // line comment', () => {
const method = firstNode(
Java,
`class P {\n// just a line comment\nvoid m() {}\n}`,
'method_declaration',
);
expect(extractLeadingDocComment(method)).toBeUndefined();
});
it('returns undefined for an empty doc comment', () => {
const method = firstNode(Java, `class P {\n/** */\nvoid m() {}\n}`, 'method_declaration');
expect(extractLeadingDocComment(method)).toBeUndefined();
});
it('returns undefined for the degenerate empty comment /**/ (no spurious slash)', () => {
const method = firstNode(Java, `class P {\n/**/\nvoid m() {}\n}`, 'method_declaration');
expect(extractLeadingDocComment(method)).toBeUndefined();
});
it('strips the */ delimiters and per-line * gutter markers', () => {
const cls = firstNode(
Java,
`/**\n * Line one.\n * Line two.\n */\nclass P {}`,
'class_declaration',
);
const doc = extractLeadingDocComment(cls);
expect(doc).toBe('Line one. Line two.');
expect(doc).not.toContain('*');
expect(doc).not.toContain('/');
});
it('skips a file-top SPDX license header (no package/import shield)', () => {
const cls = firstNode(
Java,
`/** SPDX-License-Identifier: MIT */\npublic class Foo {}`,
'class_declaration',
);
expect(extractLeadingDocComment(cls)).toBeUndefined();
});
it('skips a file-top copyright header block', () => {
const cls = firstNode(
Java,
`/**\n * Copyright (c) 2026 Acme Corp. All rights reserved.\n * Licensed under the Apache License 2.0.\n */\npublic class Foo {}`,
'class_declaration',
);
expect(extractLeadingDocComment(cls)).toBeUndefined();
});
it('does NOT over-fire: a real doc that merely mentions copyright is preserved', () => {
const method = firstNode(
Java,
`class P {\n/** Returns the copyright owner name, marker KEEPME. */\nString owner() { return null; }\n}`,
'method_declaration',
);
const doc = extractLeadingDocComment(method);
expect(doc).toContain('KEEPME');
expect(doc).toContain('copyright owner');
});
it('strips bidi-override and zero-width controls from the description', () => {
const rlo = String.fromCharCode(0x202e); // right-to-left override
const zwsp = String.fromCharCode(0x200b); // zero-width space
const cls = firstNode(
Java,
`/** Doc ${rlo}with${zwsp} hidden controls, marker BIDIMARK. */\npublic class Foo {}`,
'class_declaration',
);
const doc = extractLeadingDocComment(cls);
expect(doc).toContain('BIDIMARK');
expect(doc).not.toContain(rlo);
expect(doc).not.toContain(zwsp);
});
it('leaves a plain ASCII doc comment unchanged', () => {
const cls = firstNode(
Java,
`/** Plain doc, marker ASCIIMARK. */\nclass Foo {}`,
'class_declaration',
);
expect(extractLeadingDocComment(cls)).toBe('Plain doc, marker ASCIIMARK.');
});
it('extracts a Kotlin KDoc (grammar-agnostic prefix match, multiline_comment)', () => {
const src = `package demo
class Probe {
/**
* Computes the running balance, use computeBalanceV2
*/
fun computeBalance(userId: Long): String? { return null }
}`;
const fn = firstNode(Kotlin, src, 'function_declaration');
const doc = extractLeadingDocComment(fn);
expect(doc).toContain('Computes the running balance');
expect(doc).toContain('computeBalanceV2');
});
});