mirror of
https://github.com/abhigyanpatwari/GitNexus.git
synced 2026-10-29 06:32:28 +00:00
* docs(scope): clarify lexical binding ownership and wrapper provenance Checkpoint for #3630. Publishing the implemented source, regression tests, and benchmark harness as a draft PR; full-suite and final scaling validation remain in progress. * fix(scope): publish #3630 docs/plans * fix(scope): publish #3630 gitnexus/bench/lexical-binding-provenance * fix(scope): publish #3630 gitnexus/bench/lexical-binding-provenance/fixtures * fix(scope): publish #3630 gitnexus/bench/lexical-binding-provenance/results * fix(scope): publish #3630 gitnexus/src/core/ingestion * fix(scope): publish #3630 gitnexus/src/core/ingestion/languages/typescript * fix(scope): publish #3630 gitnexus/src/core/ingestion/languages * fix(scope): publish #3630 gitnexus/src/core/ingestion/pipeline-phases * fix(scope): publish #3630 gitnexus/src/core/ingestion/route-extractors * fix(scope): publish #3630 gitnexus/src/core/ingestion/workers * fix(scope): publish #3630 gitnexus/test/fixtures/lang-resolution/fetch-wrapper-target-identity/lib * fix(scope): publish #3630 gitnexus/test/fixtures/lang-resolution/fetch-wrapper-target-identity * fix(scope): publish #3630 gitnexus/test/fixtures/lang-resolution/fetch-wrapper-target-identity/packages/http * fix(scope): publish #3630 gitnexus/test/fixtures/lang-resolution/fetch-wrapper-target-identity/packages/http/src * fix(scope): publish #3630 gitnexus/test/fixtures/lang-resolution/fetch-wrapper-target-identity/server * fix(scope): publish #3630 gitnexus/test/fixtures/lang-resolution/fetch-wrapper-target-identity/web * fix(scope): publish #3630 gitnexus/test/integration/resolvers * fix(scope): publish #3630 gitnexus/test/unit * fix(scope): publish #3630 gitnexus/test/unit/group * fix(scope): publish #3630 gitnexus/test/unit/scope-resolution * fix(scope): publish #3630 gitnexus/test/unit/scope-resolution/typescript * fix(scope): publish #3630 gitnexus-shared/src/scope-resolution * fix(scope): treat wrapped assignment targets as writes `(app) = new Map()`, `(app as T) = x` and `app! = x` assign the same binding as `app = x`, but route-fact invalidation and the shared pattern walker stopped at the wrapper, so Express provenance survived the write and produced a false route. Recurse through parenthesized, as/satisfies and non-null targets. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(routes): resolve wrappers through overloads, declarator lists and barrels Three wrapper shapes lost their identity: - Bodyless overload signatures were indexed as separate definitions sharing the implementation's binding, so the binding looked ambiguous and both local and imported calls were rejected. Signatures now declare no callable. - Facts for `const base = 0, request = (url) => fetch(url)` followed the first declarator. The captured name now selects its own declarator. - An import resolved to a workspace barrel stopped at index.ts. Workers now record named, star and imported-then-exported re-exports, and resolution follows them to the declaring module: local and named exports shadow `export *`, star exports never carry `default`, and conflicting star exports block the name. No repository-wide name fallback is restored. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(scope): assert closure ownership against the declaration The closure-write assertion compared one lookup with itself, which also passes when both are undefined. Compare it with the outer declaration and the shadowing parameter, and keep the memoization check explicit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * refactor(routes): share lexical helpers and release per-file HTTP contexts - Share binding keys, parameter patterns and transparent expression wrappers from lexical-bindings instead of four local copies; drop the unused moduleStem export; name the inferred-source predicates in lookup. - Key the per-file HTTP context by its tree rather than its ParsedFile. Workers retain ParsedFiles for the whole chunk, which kept every file's AST and traversal maps alive until the chunk flushed. - Index re-exports by name, memoize barrel walks per starting export, and keep facts without import targets as-is instead of copying them. - Move TS-only wrapper cases into the TS describe.each instead of branching inside the per-language loop. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(routes): keep wrapper identity for HOCs, CommonJS, object keys and fetch packages Four definition shapes that main linked by name lost their wrapper identity: - `const load = useCallback((url) => fetch(url))` and curried HOCs produced no facts because definition lookup stopped at the call; it now follows the callable argument, as the structural definition capture does. - `module.exports = { request }`, `exports.x = …` and `module.exports.x = …` were not exports, so destructured `require` callers missed the wrapper. CommonJS export assignments are recorded when `module`/`exports` are the unshadowed globals, including functions defined inline in the export object. - An object-literal key or method name was resolved as a lexical binding and collided with a same-named module wrapper. Only binding identifiers now name a definition's binding. - `import fetch from 'node-fetch'` no longer counted as fetch. Imports of known fetch implementations (node-fetch, cross-fetch, isomorphic-fetch, the fetch member of undici and whatwg-fetch) are fetch evidence again; parameters and other local names still are not. Reference identifiers are also resolved only when their name is bound to a callable or class region; other identifiers cannot add a reachability edge. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(routes): drive the forwarding fallback case from data and cover re-export merges Replace the boolean-switched forwarding fallback case with table rows instead of branching inside the test, and assert that barrel re-export facts survive worker sub-batch merges. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(bench): reject stale or dirty call-graph exports The committed comparison named a candidate revision that is not on this branch, and nothing stopped it. Comparison now requires both exports to come from clean checkouts and the candidate export to come from the checkout running the comparison. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(bench): regenerate the call-graph comparison on the reviewed head Clean baseline565e50276and clean candidate8a5f7b738on the frozen 432-file corpus (fingerprint 88be1faf...): exactly one CALLS target changes, the annotated closure probe `declaredOwner.writeAndRead` now calls `Base.m` instead of `Foo.m`. The other 431 CALLS and all 11 METHOD_OVERRIDES edges are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(bench): emit export provenance and review notes from the comparison The comparison report carried export provenance and the expected-change explanation only as hand-added fields, which a regeneration dropped. Emit both exports' revisions, dirty flags and fingerprints, the unchanged CALLS and METHOD_OVERRIDES counts, and an optional `--note` explanation directly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(bench): record calibrated scaling reports and the regenerated comparison Duration-calibrated-v2 runs (5 warmups, 15 measured batches, 500 ms pilot target) pinned to the same CPU, baseline then candidate back to back: - Baseline565e50276exceeds the 1.8 normalized ceiling on six arms at 4x input: position-index 7.92, position-deep-completed 4.65, nested-helpers 4.82, nested-helper-chain 14.05, reverse-chain 4.31, name-collisions 2.61 (medians). - Candidate94f1a055bpasses --check: every arm stays at or below 1.32 at 4x for both minimum and median, with correct semantic guards on every arm. The comparison is regenerated from clean exports with its provenance and review note emitted by the tool: one expected CALLS target change, 431 CALLS and 11 METHOD_OVERRIDES unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * refactor(scope): replace recursion with explicit stacks in new traversals The binding work added five recursive traversals whose depth follows input shape: region summaries (callable nesting), barrel resolution (re-export chain length), pattern binding names (destructuring depth), route-fact write invalidation (pattern depth), and the position index's max-end tree. Each now uses an explicit stack with the same visiting order and results. Regression cases cover the inputs the recursive versions could not handle: a 20,000-deep destructuring pattern and a 50,000-module re-export chain both threw RangeError before this change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * perf(routes): avoid a full-tree script walk when building lexical bindings Route-fact extraction ran 1.78x slower than main on a 512-function file (87 ms vs 49 ms) because createLexicalBindings walked every AST node in script to detect collapsed parameter/body environments, which only functions with parameter defaults or computed keys can have. - Find functions with the native type search, skip plain parameter lists without any subtree search, and walk only the formals and bodies of the rest. Detection is unchanged, except that functions inside syntax-error regions are now also checked, which can only add fail-closed ambiguity. - Read each node's id and start position once per lookup instead of repeatedly crossing into native getters. The same extraction now takes about 56 ms against 51 ms on main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * perf(routes): walk wrapper evidence with a tree cursor The wrapper context visited every node through namedChildren, which materializes each child as a SyntaxNode and records a parent edge by node id. A tree cursor reads node types and offsets natively, so only the node types the handlers inspect become SyntaxNodes. Declared identifiers are keyed by start offset, and the walk records the ancestor facts later queries need (stored binding, default export, declarator of a name) instead of a parent map. On the 512-wrapper scaling input, context construction drops from about 58 ms to 48 ms. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(bench): regenerate the call-graph comparison on the cursor walk The candidate export at6061ca71bhas the same fingerprint as the previous candidate: the traversal rewrite changes no edge. The one expected target change and the 431 unchanged CALLS and 11 METHOD_OVERRIDES remain. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(bench): record final scaling reports on the cursor walk Baseline565e50276and candidate61de364ffran back to back on CPU 23 with the duration-calibrated-v2 protocol. Every candidate check stays at or below a 1.32 normalized factor against the 1.8 ceiling; the baseline fails six of nine arms. Workload fingerprints agree except the documented name-collision false positive in the baseline. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(plan): checkpoint the final review, scaling and suite results for #3630 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(routes): treat export aliases of one wrapper as one star-export target Star-export candidates were deduplicated by the resolved export name, so `export { request, request as send }` reached through two barrels counted as two targets and blocked the import, dropping the consumer's FETCHES edge. Candidates are now keyed by the declaration each export name names, matching ECMAScript ResolveExport's binding comparison; distinct declarations exported under the same name stay ambiguous. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(bench): regenerate scaling and call-graph reports on the alias fix Baseline565e50276and candidate4d62bd045ran back to back on CPU 23. Every candidate check stays at or below 1.22 against the 1.8 ceiling; the baseline still fails six of nine arms. The CALLS/METHOD_OVERRIDES export is unchanged (fingerprint 4db24f57), so the comparison only records the new candidate revision. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(plan): record the export-alias fix and the regenerated reports for #3630 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(scope): keep the type a write gives an undeclared name A constructor write to a name no scope declares (`client = new ApiClient()` in sloppy JavaScript) declares nothing, so the lookup stays absent. The carried constructor fact was dropped on that exit, which lost the receiver type main had inferred for later reads in the writing scope. The absent result now carries it, and findReceiverTypeBinding uses it before the namespace fallbacks. Only complete-claim providers carry such a fact. Tests pin the carried type per inferred source, the undeclared write, and preservePosition across a module redirect. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(routes): close the wrapper identity gaps found in review - CommonJS wrappers captured as their assignment (`exports.x = function`, `module.exports.x = () =>`) produce facts again: findFunction follows the assignment's right side. - Name-only fallback considers only definitions that can be the target: an unresolvable import names a module-level export, an undeclared global a top-level function. Nested and unexported helpers no longer erase a wrapper's edges. - Only possible wrappers and module-level functions are emitted, and the routes phase builds the index only when routes and candidate calls exist. - A rebound binding (later assignment, `var` initializer over a function declaration, reassigned export) proves no wrapper across files. - `(<T>x) = ...` is a write; transparent wrappers skip type arguments. - Calls inside recovered syntax are still collected; instance-field initializers resolve after the module body, so a later declaration is visible. - Local exports are always recorded, so a star export conflicting with a non-callable export is ambiguous, and fully resolved barrel frames are shared across walks. - HTTP hooks run per file under a guard; a failing file or one without a ParsedFile still records its function names so fallback declines. - namesFetch is iterative, large patterns no longer spread into push, the facts cache is keyed by the name node, and the provider context cache checks its ParsedFile. Tests cover each case; the behavior rows fail on the previous source. The TS-only call cases no longer branch inside the test file, call targets are asserted exactly, the function-type list is drift-checked, and the persistence test joins the cross-platform worker list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(routes): describe wrapper fallback, barrel and recall boundaries Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(bench): count the new CommonJS fixture's dropped write site `lib/cjs-member.js` in the fetch-wrapper target-identity fixture writes `module.exports.arrowRequest`, a member write whose receiver is not typed. That adds one `receiver-unresolved` write (190 -> 191 all-kind drops, 19 -> 20 writes). Call drops and shape-arm states are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(bench): regenerate scaling and call-graph reports on the review fixes Baseline565e50276and candidate528ea1478ran back to back on CPU 23. Every candidate check stays at or below 1.27 against the 1.8 ceiling; the baseline still fails six of nine arms. The CALLS/METHOD_OVERRIDES export is unchanged (fingerprint 4db24f57), so the comparison only records the new candidate revision. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(plan): checkpoint the review fixes and regenerated reports for #3630 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * refactor(routes): share CommonJS checks and trim per-node work - `isCommonJsGlobal`/`isModuleExports` in lexical-bindings replace the two copies in fetch-wrapper and framework-route-facts (both resolve the same scope from the same start position). - LEXICAL_FUNCTION_TYPES is derived from the TypeScript FUNCTION_NODE_TYPES instead of a third hand-kept copy; the drift test still pins it. - `unwrap` reads UNWRAPPED_TYPES, the set the cursor walk mirrors, and the class-body region is no longer shadowed under the name `deferred`. - framework-route-facts reads each node's type once per loop iteration. - The position index returns the latest-starting scope when it already contains the point, before the max-end tree search; that entry is the search's rightmost match. - carried() returns a shared empty set for argument forms that cannot carry a value, the resolution file set is built without intermediate arrays, and the routes phase reads the call list once. No behavior change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(bench): regenerate scaling and call-graph reports on the refactor Baseline565e50276and candidate3db8657baran back to back on CPU 23. Every candidate check stays at or below 1.32 against the 1.8 ceiling; the baseline still fails six of nine arms. The CALLS/METHOD_OVERRIDES export is unchanged (fingerprint 4db24f57). The later main merge (e2a92dab8) touches no measured file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(plan): checkpoint the simplification pass and its reports for #3630 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Address PR review feedback (#3632) - Destructuring defaults (`{ fetch = globalThis.fetch } = {}`, renamed, array and local forms) are alias evidence for their leaf binding and no longer count a second initialization, which also invalidated bindings like `[send = other] = values`. - `export default (request)` records the default export: the value is unwrapped before the identifier check. - The HTTP fallback records and the collapsed-environment test row now say what they stand for. Regression rows cover each form in JS, TS and TSX and fail on the previous source; two fixture consumers cover imported wrappers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(bench): refresh lexical binding reports after review fixes Regenerate clean baseline and candidate measurements atc263c4f72. All candidate scaling checks pass, the semantic delta remains one CALLS target, and receiver-resolution counts match the existing baseline. * docs(plan): checkpoint refreshed review-fix measurements Recordc263c4f72review fixes, the regenerated scaling and semantic results, and the passing receiver and CI checks. --------- Co-authored-by: Gergo Magyar <gergomagyar0@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
660 lines
27 KiB
TypeScript
660 lines
27 KiB
TypeScript
import { describe, expect, it } from 'vitest';
|
|
import Parser from 'tree-sitter';
|
|
import TypeScript from 'tree-sitter-typescript';
|
|
import JavaScript from 'tree-sitter-javascript';
|
|
import path from 'node:path';
|
|
import {
|
|
typescriptProvider,
|
|
javascriptProvider,
|
|
} from '../../src/core/ingestion/languages/typescript.js';
|
|
import { extractParsedFile } from '../../src/core/ingestion/scope-extractor-bridge.js';
|
|
import { extractFrameworkRouteFacts } from '../../src/core/ingestion/route-extractors/framework-route-facts.js';
|
|
import { resolveFrameworkRouteFacts } from '../../src/core/ingestion/route-extractors/framework-route-resolver.js';
|
|
import { composeFrameworkRoutePaths } from '../../src/core/ingestion/route-extractors/framework-route-paths.js';
|
|
|
|
function facts(source: string, filePath = 'server.ts') {
|
|
const parser = new Parser();
|
|
parser.setLanguage(
|
|
filePath.endsWith('.js')
|
|
? JavaScript
|
|
: filePath.endsWith('.tsx')
|
|
? TypeScript.tsx
|
|
: TypeScript.typescript,
|
|
);
|
|
const tree = parser.parse(source);
|
|
const parsed = extractParsedFile(
|
|
filePath.endsWith('.js') ? javascriptProvider : typescriptProvider,
|
|
source,
|
|
filePath,
|
|
undefined,
|
|
tree,
|
|
);
|
|
expect(parsed).toBeDefined();
|
|
return extractFrameworkRouteFacts(tree, parsed!);
|
|
}
|
|
function resolve(sources: Record<string, string>) {
|
|
const files = Object.entries(sources).map(([file, source]) => facts(source, file));
|
|
const output = resolveFrameworkRouteFacts(files, (from, specifier) => {
|
|
const base = path.posix.join(path.posix.dirname(from), specifier);
|
|
return Object.keys(sources).filter(
|
|
(file) =>
|
|
file === base ||
|
|
file === `${base}.ts` ||
|
|
file === `${base}.js` ||
|
|
file === `${base}/index.ts`,
|
|
);
|
|
});
|
|
return output;
|
|
}
|
|
const routes = (source: string) =>
|
|
resolve({ 'server.ts': source }).registrations.map((registration) => registration.route);
|
|
const urls = (source: string) =>
|
|
routes(source).map((route) => `${route.httpMethod} ${route.routePath}`);
|
|
|
|
describe('framework receiver provenance', () => {
|
|
it('accepts imported Express allocations and stable aliases, not receiver names', () => {
|
|
expect(
|
|
urls(`
|
|
import web from 'express';
|
|
const service = web(); const stable = service;
|
|
stable.get('/real', handler);
|
|
const storage = new Map(); storage.get('/not-http', 'fallback');
|
|
app.post('/undeclared', handler); router.get('/undeclared-router', handler);
|
|
`),
|
|
).toEqual(['GET /real']);
|
|
});
|
|
|
|
it.each([
|
|
`import { Router as Build } from 'express'; const r = Build();`,
|
|
`import * as web from 'express'; const r = web.Router();`,
|
|
`const web = require('express'); const r = web.Router();`,
|
|
`const { Router: Build } = require('express'); const r = Build();`,
|
|
`const Build = require('express').Router; const r = new Build();`,
|
|
`const r = require('express')();`,
|
|
`const r = require('express').Router();`,
|
|
])('recognizes factory provenance: %s', (setup) => {
|
|
expect(urls(`${setup} r.get('/ok', handler);`)).toEqual(['GET /ok']);
|
|
});
|
|
|
|
it('preserves builders, chains, all, handler evidence, and argument comments', () => {
|
|
const result = routes(`import express from 'express';
|
|
const router = express.Router();
|
|
router.route('/bare');
|
|
router.get('/setting');
|
|
router.use('/middleware', middleware);
|
|
router.route('/chain').get(/* comment */ handler).post(other);
|
|
const builder = router.route('/assigned');
|
|
const alias = builder;
|
|
alias.all(handler);
|
|
builder.delete(/* no handler */);
|
|
router.get('/direct', middleware, handler).put('/continued', other);
|
|
function handler() {} function other() {}`);
|
|
expect(result.map((route) => `${route.httpMethod} ${route.routePath}`)).toEqual([
|
|
'POST /chain',
|
|
'GET /chain',
|
|
'* /assigned',
|
|
'PUT /continued',
|
|
'GET /direct',
|
|
]);
|
|
expect(result.find((route) => route.routePath === '/assigned')).toMatchObject({
|
|
filePath: 'server.ts',
|
|
lineNumber: 8,
|
|
handlerName: 'handler',
|
|
decoratorName: 'express.all',
|
|
});
|
|
});
|
|
|
|
it.each([13, 24])(
|
|
'resolves all %i fluent registrations without exhausting the work budget',
|
|
(count) => {
|
|
const paths = Array.from({ length: count }, (_, index) => `/route-${index}`);
|
|
const chain = paths.map((route) => `.get('${route}', () => {})`).join('');
|
|
const extracted = facts(`import express from 'express'; const app = express(); app${chain};`);
|
|
expect(extracted.calls).toHaveLength(count);
|
|
const resolved = resolveFrameworkRouteFacts([extracted], () => []);
|
|
expect(resolved.registrations.map(({ route }) => route.routePath).sort()).toEqual(
|
|
[...paths].sort(),
|
|
);
|
|
},
|
|
);
|
|
|
|
it('withholds handler evidence for mutated callable bindings', () => {
|
|
const result = routes(`import express from 'express'; const app = express();
|
|
let handler = () => {}; handler = replacement; app.get('/real', handler);`);
|
|
expect(result).toHaveLength(1);
|
|
expect(result[0].handlerName).toBeUndefined();
|
|
});
|
|
|
|
it('respects parameter, block, catch, destructuring, and require shadows', () => {
|
|
expect(
|
|
urls(`
|
|
import express from 'express'; const router = express.Router();
|
|
function f(router) { router.get('/parameter', handler); }
|
|
{ const router = storage; router.get('/block', handler); }
|
|
try {} catch(router) { router.get('/catch', handler); }
|
|
function nested({ router }) { router.get('/destructured', handler); }
|
|
function wrong(require) { const r = require('express').Router(); r.get('/require', handler); }
|
|
router.get('/real', handler);
|
|
`),
|
|
).toEqual(['GET /real']);
|
|
});
|
|
|
|
it.each([
|
|
`import type express from 'express'; const r = express();`,
|
|
`import { type Router } from 'express'; const r = Router();`,
|
|
`import type * as express from 'express'; const r = express.Router();`,
|
|
`import express from 'express'; let r = express.Router(); r = storage;`,
|
|
`import express from 'express'; let r = express.Router(); function mutate() { r = storage; }`,
|
|
`import express from 'express'; let r = express.Router(); ({ r } = storage);`,
|
|
`import express from 'express'; const r = express.Router(); const alias = r; alias.get = other;`,
|
|
`import express from 'express'; express.Router = custom; const r = express.Router();`,
|
|
`import express, { Router } from 'express'; Router.custom = other; const r = express.Router();`,
|
|
`import express from 'express'; const r = express.Router(); delete r.get;`,
|
|
`import express from 'express'; let r = express.Router(); for (r of replacements) {}`,
|
|
])('declines erased or conflicting provenance: %s', (setup) => {
|
|
expect(urls(`${setup} r.get('/unsafe', handler);`)).toEqual([]);
|
|
});
|
|
|
|
// GitNexus's own server registers through helpers that receive the app and,
|
|
// for SSE progress, the path (#3487): one call-site hop, never two.
|
|
it('forwards a proven receiver and literal path through one helper call', () => {
|
|
const result = resolve({
|
|
'sse.ts': `
|
|
import type express from 'express';
|
|
export const mountSSEProgress = (app: express.Express, routePath: string, jm: unknown) => {
|
|
app.get(routePath, (req, res) => {});
|
|
};`,
|
|
'mcp.ts': `
|
|
export async function mountMCPEndpoints(app, backend) {
|
|
app.all('/api/mcp', handler);
|
|
app.use('/api/mcp', auth);
|
|
return () => {};
|
|
}`,
|
|
'server.ts': `
|
|
import express from 'express';
|
|
import { mountSSEProgress } from './sse';
|
|
import { mountMCPEndpoints } from './mcp';
|
|
export const registerWebUI = (app: express.Express, dir: string | null): void => {
|
|
app.get('/', handler);
|
|
};
|
|
const app = express();
|
|
const cleanup = await mountMCPEndpoints(app, backend);
|
|
mountSSEProgress(app, '/api/analyze/:jobId/progress', jobs);
|
|
mountSSEProgress(app, '/api/embed/:jobId/progress', jobs);
|
|
registerWebUI(app, null);`,
|
|
});
|
|
expect(
|
|
result.registrations
|
|
.map(({ route }) => `${route.httpMethod} ${route.routePath} ${route.filePath}`)
|
|
.sort(),
|
|
).toEqual([
|
|
'* /api/mcp mcp.ts',
|
|
'GET / server.ts',
|
|
'GET /api/analyze/:jobId/progress sse.ts',
|
|
'GET /api/embed/:jobId/progress sse.ts',
|
|
]);
|
|
});
|
|
|
|
it('follows a helper exported under another name', () => {
|
|
const result = resolve({
|
|
'routes.ts': `function mountRoutes(app) { app.get('/api/renamed', handler); }
|
|
export { mountRoutes as setup };`,
|
|
'server.ts': `import express from 'express';
|
|
import { setup } from './routes';
|
|
setup(express());`,
|
|
});
|
|
expect(
|
|
result.registrations.map(
|
|
({ route }) => `${route.httpMethod} ${route.routePath} ${route.filePath}`,
|
|
),
|
|
).toEqual(['GET /api/renamed routes.ts']);
|
|
});
|
|
|
|
it('follows a helper called through an aliased import', () => {
|
|
const result = resolve({
|
|
'sse.ts': `export const mountSSEProgress = (app, routePath) => { app.get(routePath, handler); };`,
|
|
'server.ts': `import express from 'express';
|
|
import { mountSSEProgress as mountProgress } from './sse';
|
|
const app = express();
|
|
mountProgress(app, '/api/progress');`,
|
|
});
|
|
expect(
|
|
result.registrations.map(
|
|
({ route }) => `${route.httpMethod} ${route.routePath} ${route.filePath}`,
|
|
),
|
|
).toEqual(['GET /api/progress sse.ts']);
|
|
});
|
|
|
|
it('declines forwarding through two hops, unproven arguments, and reassigned parameters', () => {
|
|
expect(
|
|
urls(`
|
|
import express from 'express';
|
|
function inner(app) { app.get('/two-hop', handler); }
|
|
function outer(app) { inner(app); }
|
|
outer(express());
|
|
function unproven(app) { app.get('/unproven', handler); }
|
|
unproven(storage);
|
|
function reassigned(app) { app = storage; app.get('/reassigned', handler); }
|
|
reassigned(express());
|
|
function runtime(app, path) { app.get(path, handler); }
|
|
runtime(express(), runtimePath);
|
|
function direct(app, path) { app.post(path, handler); }
|
|
direct(express(), '/direct');
|
|
`),
|
|
).toEqual(['POST /direct']);
|
|
});
|
|
|
|
it('invalidates a module binding written by a constructor assignment in a closure', () => {
|
|
expect(
|
|
urls(`import express from 'express';
|
|
let app = express(); function replace() { app = new Map(); }
|
|
app.get('/let-closure', handler);`),
|
|
).toEqual([]);
|
|
});
|
|
|
|
it.each([
|
|
['a default expression', '[target = app] = values;', ['GET /retained']],
|
|
['a computed key', '({ [app]: target } = values);', ['GET /retained']],
|
|
['a destructured property write', '({ get: app.get } = values);', []],
|
|
])('invalidates only assignment targets in %s', (_shape, write, expected) => {
|
|
expect(
|
|
urls(`import express from 'express'; const app = express(); let target;
|
|
${write} app.get('/retained', handler);`),
|
|
).toEqual(expected);
|
|
});
|
|
|
|
it.each([
|
|
['parenthesized', '(app) = new Map();'],
|
|
['asserted', '(app as unknown) = new Map();'],
|
|
['angle-bracket asserted', '(<any>app) = new Map();'],
|
|
['non-null asserted', 'app! = new Map();'],
|
|
])('invalidates a wrapped assignment target: %s', (_shape, write) => {
|
|
expect(
|
|
urls(`import express from 'express'; let app = express();
|
|
${write} app.get('/not-http', handler);`),
|
|
).toEqual([]);
|
|
});
|
|
|
|
it.each([
|
|
['initialized var', 'app', 'var app = storage;', []],
|
|
['initialized var with another default', 'app, other = 1', 'var app = storage;', []],
|
|
['uninitialized var', 'app', 'var app;', ['GET /forwarded']],
|
|
[
|
|
'nested parameter write',
|
|
'app',
|
|
'function inner(app) { app = new Map(); }',
|
|
['GET /forwarded'],
|
|
],
|
|
// A parameter expression gives the body its own variable environment, which
|
|
// the scope model collapses, so inference declines a parameter that a body
|
|
// `var` redeclares (the documented boundary); runtime would keep its value.
|
|
['nested destructuring default', 'app, { value = 1 }', 'var app;', []],
|
|
['computed pattern key', 'app, { [key]: value }', 'var app;', []],
|
|
['rest parameter alone', 'app, ...rest', 'var app;', ['GET /forwarded']],
|
|
['loop var over the parameter', 'app', 'for (var app of values) {}', []],
|
|
['body function overwrites parameter', 'app', 'function app() {}', []],
|
|
['body function with default', 'app, other = 1', 'function app() {}', []],
|
|
[
|
|
'nested body declaration',
|
|
'app, other = 1',
|
|
'function inner() { var app = storage; }',
|
|
['GET /forwarded'],
|
|
],
|
|
])('uses binding identity for helper forwarding: %s', (_shape, parameters, body, expected) => {
|
|
expect(
|
|
urls(`import express from 'express';
|
|
function mount(${parameters}) { ${body} app.get('/forwarded', handler); }
|
|
mount(express());`),
|
|
).toEqual(expected);
|
|
});
|
|
|
|
it.each([
|
|
{
|
|
shape: 'a literal mount path forwarded to a helper',
|
|
calls: `function mountApi(prefix) { app.use(prefix, router); }
|
|
mountApi('/api');`,
|
|
routes: ['GET /api/users'],
|
|
},
|
|
{
|
|
shape: 'a runtime mount path forwarded to a helper',
|
|
calls: `function mountApi(prefix) { app.use(prefix, router); }
|
|
mountApi(process.env.API_PREFIX);`,
|
|
routes: [],
|
|
},
|
|
{
|
|
shape: 'a helper whose mount path no call proves',
|
|
calls: 'function mountApi(prefix) { app.use(prefix, router); }',
|
|
routes: [],
|
|
},
|
|
{
|
|
shape: 'a router forwarded as the mounted child',
|
|
calls: `function mountApi(target, child) { target.use('/api', child); }
|
|
mountApi(app, router);`,
|
|
routes: ['GET /api/users'],
|
|
},
|
|
{
|
|
shape: 'a TypeScript this parameter',
|
|
calls: `function wire(this: void, target, prefix) { target.use(prefix, router); }
|
|
wire(app, '/v1');`,
|
|
routes: ['GET /v1/users'],
|
|
},
|
|
{
|
|
shape: 'an argument after a spread',
|
|
calls: `function wire(target, prefix) { target.use(prefix, router); }
|
|
wire(...targets, '/spread');`,
|
|
// Unproven receiver: the router keeps its standalone paths, as without
|
|
// any helper, rather than borrowing '/spread' from the wrong position.
|
|
routes: ['GET /users'],
|
|
},
|
|
{
|
|
shape: 'a parameter reassigned in a nested closure',
|
|
calls: `function wire(target) { const swap = () => { target = other; }; swap(); target.use('/api', router); }
|
|
wire(app);`,
|
|
routes: ['GET /users'],
|
|
},
|
|
{
|
|
shape: 'a helper forwarding only its mounted child',
|
|
calls: `function mountChild(child) { app.use('/api', child); }
|
|
mountChild(router);`,
|
|
routes: ['GET /api/users'],
|
|
},
|
|
{
|
|
shape: 'a parameter reassigned by destructuring',
|
|
calls: `function wire(target) { [target] = [other]; target.use('/api', router); }
|
|
wire(app);`,
|
|
routes: ['GET /users'],
|
|
},
|
|
{
|
|
shape: 'a write to a same-named local in a nested block',
|
|
calls: `function wire(target) { { let target; target = other; } target.use('/api', router); }
|
|
wire(app);`,
|
|
routes: ['GET /api/users'],
|
|
},
|
|
{
|
|
shape: 'a property write on another function',
|
|
calls: `function Button() {} Button.displayName = 'Button';
|
|
function mountApi(prefix) { app.use(prefix, router); }
|
|
mountApi('/api');`,
|
|
routes: ['GET /api/users'],
|
|
},
|
|
])('composes mounts through helper parameters: $shape', ({ calls, routes }) => {
|
|
const result = resolve({
|
|
'server.ts': `import express from 'express';
|
|
const app = express(); const router = express.Router();
|
|
router.get('/users', handler);
|
|
${calls}`,
|
|
});
|
|
expect(
|
|
composeFrameworkRoutePaths(result).map((route) => `${route.httpMethod} ${route.routePath}`),
|
|
).toEqual(routes);
|
|
});
|
|
|
|
it('does not lend later allocations to calls in a temporal dead zone', () => {
|
|
expect(
|
|
urls(`
|
|
import express from 'express';
|
|
api.get('/before', h); const api = express();
|
|
const router = express.Router();
|
|
{ router.get('/block-before', h); const router = storage; }
|
|
function install() { later.get('/closure', h); }
|
|
const later = express.Router();
|
|
api.get('/after', h);
|
|
`),
|
|
).toEqual(['GET /closure', 'GET /after']);
|
|
});
|
|
|
|
it('keeps directly proven Hono registrations separate from Express builders and mounts', () => {
|
|
const result = resolve({
|
|
'server.ts': `
|
|
import { Hono as Web } from 'hono';
|
|
const api = new Web();
|
|
api.get('/hono', handler); api.route('/builder').get(handler);
|
|
const router = api.route('/assigned'); router.post(handler);
|
|
api.use('/mount', api);
|
|
`,
|
|
});
|
|
expect(result.registrations).toMatchObject([
|
|
{ framework: 'hono', route: { routePath: '/hono', decoratorName: 'hono.get' } },
|
|
]);
|
|
expect(result.registrations).toHaveLength(1);
|
|
expect(result.mounts).toEqual([]);
|
|
});
|
|
|
|
it('records literal, root, middleware and unknown mounts without emitting endpoints', () => {
|
|
const result = resolve({
|
|
'server.ts': `
|
|
import express from 'express';
|
|
const app = express(); const router = express.Router();
|
|
function auth() {}
|
|
app.use(['/v1', '/v2'], auth, router, auth);
|
|
app.use(router); app.use(auth, router); app.use(runtimePrefix, auth, router);
|
|
app.use('/array', [auth, [router]]); app.use([auth, router]);
|
|
`,
|
|
});
|
|
expect(result.registrations).toEqual([]);
|
|
expect(result.mounts.map((mount) => mount.prefixes)).toEqual([
|
|
['/v1', '/v2'],
|
|
[''],
|
|
[''],
|
|
null,
|
|
['/array'],
|
|
[''],
|
|
]);
|
|
expect(result.allocations.map((allocation) => allocation.kind).sort()).toEqual([
|
|
'app',
|
|
'router',
|
|
]);
|
|
});
|
|
|
|
it('follows explicit ESM named/default exports and transitive barrels across JS/TS/TSX', () => {
|
|
const result = resolve({
|
|
'router.js': `const { Router } = require('express'); const r = Router(); export { r as users }; export default r;`,
|
|
'barrel.ts': `export { users as endpoints, default } from './router';`,
|
|
'index.ts': `export * from './barrel'; export { default } from './barrel';`,
|
|
'server.tsx': `import byDefault, { endpoints } from './index'; endpoints.get('/named', handler); byDefault.post('/default', handler);`,
|
|
});
|
|
expect(result.registrations.map((registration) => registration.route.routePath)).toEqual([
|
|
'/named',
|
|
'/default',
|
|
]);
|
|
expect(new Set(result.registrations.map((registration) => registration.receiverId)).size).toBe(
|
|
1,
|
|
);
|
|
});
|
|
|
|
it.each([
|
|
[`module.exports = r;`, `const api = require('./router');`],
|
|
[`exports.api = r;`, `const {api} = require('./router');`],
|
|
[`module.exports.api = r;`, `const api = require('./router').api;`],
|
|
[`module.exports = { api: r };`, `const {api} = require('./router');`],
|
|
])('follows explicit CommonJS exports: %s', (publish, consume) => {
|
|
const result = resolve({
|
|
'router.js': `const express = require('express'); const r = express.Router(); ${publish}`,
|
|
'server.js': `${consume} api.get('/ok', handler);`,
|
|
});
|
|
expect(result.registrations.map((registration) => registration.route.routePath)).toEqual([
|
|
'/ok',
|
|
]);
|
|
});
|
|
|
|
it('does not infer default from a unique named export or accept conflicting stars', () => {
|
|
const result = resolve({
|
|
'one.ts': `import {Router} from 'express'; export const api = Router();`,
|
|
'two.ts': `export const api = storage;`,
|
|
'barrel.ts': `export * from './one'; export * from './two';`,
|
|
'server.ts': `import guessed from './one'; import {api} from './barrel'; guessed.get('/default-guess', handler); api.get('/ambiguous', handler);`,
|
|
});
|
|
expect(result.registrations).toEqual([]);
|
|
});
|
|
|
|
it('declines conflicting CJS writes, shadowed module exports, and detached exports aliases', () => {
|
|
const result = resolve({
|
|
'conflict.js': `const r = require('express').Router(); exports.api = r; exports.api = storage;`,
|
|
'shadow.js': `const r = require('express').Router(); function f(module) { module.exports = r; }`,
|
|
'detached.js': `const r = require('express').Router(); module.exports = storage; exports.api = r;`,
|
|
'replaced.js': `const r = require('express').Router(); module.exports.api = r; module.exports = storage;`,
|
|
'computed.js': `const r = require('express').Router(); module.exports = r; module.exports[key] = other;`,
|
|
'server.js': `const e = require('./computed'); e.get('/computed', h); const d = require('./replaced').api; d.get('/replaced', h); const a = require('./conflict').api; a.get('/conflict', h); const b = require('./shadow'); b.get('/shadow', h); const c = require('./detached').api; c.get('/detached', h);`,
|
|
});
|
|
expect(result.registrations).toEqual([]);
|
|
});
|
|
|
|
it.each([
|
|
`exports.router = router; delete exports.router;`,
|
|
`exports.router = router; exports.router += 1;`,
|
|
`exports.router = router; exports.router++;`,
|
|
`module.exports.router = router; delete module.exports.router;`,
|
|
`module.exports.router = router; module.exports.router--;`,
|
|
`module.exports = { router }; delete module.exports;`,
|
|
`module.exports = { router, ...overrides };`,
|
|
`module.exports = { router, [key]: replacement };`,
|
|
])('declines invalidated or dynamically overwritten CommonJS exports: %s', (publish) => {
|
|
const result = resolve({
|
|
'router.js': `const { Router } = require('express'); const router = Router(); ${publish}`,
|
|
'server.js': `const { router } = require('./router'); router.get('/phantom', () => {});`,
|
|
});
|
|
expect(result.registrations).toEqual([]);
|
|
});
|
|
|
|
it.each([
|
|
[`exports = {}; exports.router = router;`, `const { router } = require('./router');`],
|
|
[
|
|
`module.exports = router; module.exports.get = replacement;`,
|
|
`const router = require('./router');`,
|
|
],
|
|
])('declines detached or mutated CommonJS export values: %s', (publish, consume) => {
|
|
const result = resolve({
|
|
'router.js': `const { Router } = require('express'); const router = Router(); ${publish}`,
|
|
'server.js': `${consume} router.get('/phantom', () => {});`,
|
|
});
|
|
expect(result.registrations).toEqual([]);
|
|
});
|
|
|
|
it('declines unresolved stars that could conflict with a proven named export', () => {
|
|
const result = resolve({
|
|
'router.ts': `import {Router} from 'express'; export const api = Router();`,
|
|
'barrel.ts': `export * from './router'; export * from './unavailable';`,
|
|
'server.ts': `import {api} from './barrel'; api.get('/uncertain', h);`,
|
|
});
|
|
expect(result.registrations).toEqual([]);
|
|
});
|
|
|
|
it('terminates seedless export cycles but retains an explicit seeded export', () => {
|
|
const result = resolve({
|
|
'one.ts': `export * from './two'; import {Router} from 'express'; export const api = Router();`,
|
|
'two.ts': `export * from './one'; export {missing} from './three';`,
|
|
'three.ts': `export {missing} from './two';`,
|
|
'server.ts': `import {api, missing} from './two'; api.get('/seed', h); missing.get('/cycle', h);`,
|
|
});
|
|
expect(result.registrations.map((registration) => registration.route.routePath)).toEqual([
|
|
'/seed',
|
|
]);
|
|
});
|
|
|
|
it('invalidates imported values when another file writes through an alias', () => {
|
|
const result = resolve({
|
|
'router.ts': `import {Router} from 'express'; export const api = Router(); api.get('/unsafe', h);`,
|
|
'mutation.ts': `import {api as alias} from './router'; alias.get = replacement;`,
|
|
});
|
|
expect(result.registrations).toEqual([]);
|
|
});
|
|
|
|
it.each([
|
|
[
|
|
`import {Router} from 'express'; export const api = Router(), other = Router();`,
|
|
`import * as routes from './router';`,
|
|
`import {api, other} from './router';`,
|
|
],
|
|
[
|
|
`const {Router} = require('express'); exports.api = Router(); exports.other = Router();`,
|
|
`const routes = require('./router');`,
|
|
`const {api, other} = require('./router');`,
|
|
],
|
|
])('invalidates Routers mutated through a module object: %#', (publish, namespace, consume) => {
|
|
const result = resolve({
|
|
'router.js': publish,
|
|
'mutation.js': `${namespace} routes.api.get = () => {}; routes.other.post = () => {};`,
|
|
'server.js': `${consume} api.get('/phantom', () => {}); other.post('/also-phantom', () => {});`,
|
|
});
|
|
expect(composeFrameworkRoutePaths(result)).toEqual([]);
|
|
});
|
|
|
|
it.each([`app.locals.title = 'demo';`, `app.use = () => {};`, `delete app.use;`])(
|
|
'does not revive local paths when a mount parent is mutated: %s',
|
|
(mutation) => {
|
|
const result = resolve({
|
|
'server.ts': `import express from 'express';
|
|
const app = express(), router = express.Router();
|
|
${mutation}
|
|
app.use('/api', [router]);
|
|
router.get('/users', () => {});`,
|
|
});
|
|
expect(composeFrameworkRoutePaths(result)).toEqual([]);
|
|
},
|
|
);
|
|
|
|
it('preserves an independent valid mount when another parent is mutated', () => {
|
|
const result = resolve({
|
|
'server.ts': `import express from 'express';
|
|
const app = express(), safe = express(), router = express.Router();
|
|
app.locals.title = 'demo';
|
|
app.use('/uncertain', router); safe.use('/safe', router);
|
|
router.get('/users', () => {});`,
|
|
});
|
|
expect(composeFrameworkRoutePaths(result).map((route) => route.routePath)).toEqual([
|
|
'/safe/users',
|
|
]);
|
|
});
|
|
|
|
it.each([false, true])('retains uncertain array mounts alongside safe mount=%s', (safeMount) => {
|
|
const result = resolve({
|
|
'server.ts': `import express from 'express';
|
|
const app = express(), safe = express(), router = express.Router();
|
|
const list = [router]; list.push = other;
|
|
app.use('/api', list);
|
|
${safeMount ? "safe.use('/safe', router);" : ''}
|
|
router.get('/users', () => {});`,
|
|
});
|
|
expect(composeFrameworkRoutePaths(result).map((route) => route.routePath)).toEqual(
|
|
safeMount ? ['/safe/users'] : [],
|
|
);
|
|
});
|
|
|
|
it('does not suppress standalone routes for an unproven mount receiver', () => {
|
|
const result = resolve({
|
|
'server.ts': `import express from 'express';
|
|
const router = express.Router(); storage.use('/unknown', router);
|
|
router.get('/users', () => {});`,
|
|
});
|
|
expect(composeFrameworkRoutePaths(result).map((route) => route.routePath)).toEqual(['/users']);
|
|
});
|
|
|
|
it('bounds repeated star-barrel exploration while preserving unrelated routes', () => {
|
|
const sources: Record<string, string> = {
|
|
'base.ts': `export const other = 1;`,
|
|
'server.ts': `import {missing} from './a24'; import express from 'express'; missing.get('/unknown', h); const app = express(); app.get('/safe', h);`,
|
|
};
|
|
for (let level = 0; level < 25; level++) {
|
|
const exports =
|
|
level === 0
|
|
? `export * from './base';`
|
|
: `export * from './a${level - 1}'; export * from './b${level - 1}';`;
|
|
sources[`a${level}.ts`] = exports;
|
|
sources[`b${level}.ts`] = exports;
|
|
}
|
|
expect(
|
|
resolve(sources).registrations.map((registration) => registration.route.routePath),
|
|
).toEqual(['/safe']);
|
|
});
|
|
|
|
it('round-trips compact facts through JSON with identical resolved output', () => {
|
|
const file = facts(
|
|
`import express from 'express'; const app = express(); const r = express.Router(); r.get('/x', handler); app.use('/api', r);`,
|
|
);
|
|
const original = resolveFrameworkRouteFacts([file], () => []);
|
|
expect(resolveFrameworkRouteFacts(JSON.parse(JSON.stringify([file])), () => [])).toEqual(
|
|
original,
|
|
);
|
|
expect(JSON.stringify(file)).not.toContain('namedChildren');
|
|
});
|
|
});
|