mirror of
https://github.com/abhigyanpatwari/GitNexus.git
synced 2026-10-28 06:22:22 +00:00
* docs(scope): clarify lexical binding ownership and wrapper provenance Checkpoint for #3630. Publishing the implemented source, regression tests, and benchmark harness as a draft PR; full-suite and final scaling validation remain in progress. * fix(scope): publish #3630 docs/plans * fix(scope): publish #3630 gitnexus/bench/lexical-binding-provenance * fix(scope): publish #3630 gitnexus/bench/lexical-binding-provenance/fixtures * fix(scope): publish #3630 gitnexus/bench/lexical-binding-provenance/results * fix(scope): publish #3630 gitnexus/src/core/ingestion * fix(scope): publish #3630 gitnexus/src/core/ingestion/languages/typescript * fix(scope): publish #3630 gitnexus/src/core/ingestion/languages * fix(scope): publish #3630 gitnexus/src/core/ingestion/pipeline-phases * fix(scope): publish #3630 gitnexus/src/core/ingestion/route-extractors * fix(scope): publish #3630 gitnexus/src/core/ingestion/workers * fix(scope): publish #3630 gitnexus/test/fixtures/lang-resolution/fetch-wrapper-target-identity/lib * fix(scope): publish #3630 gitnexus/test/fixtures/lang-resolution/fetch-wrapper-target-identity * fix(scope): publish #3630 gitnexus/test/fixtures/lang-resolution/fetch-wrapper-target-identity/packages/http * fix(scope): publish #3630 gitnexus/test/fixtures/lang-resolution/fetch-wrapper-target-identity/packages/http/src * fix(scope): publish #3630 gitnexus/test/fixtures/lang-resolution/fetch-wrapper-target-identity/server * fix(scope): publish #3630 gitnexus/test/fixtures/lang-resolution/fetch-wrapper-target-identity/web * fix(scope): publish #3630 gitnexus/test/integration/resolvers * fix(scope): publish #3630 gitnexus/test/unit * fix(scope): publish #3630 gitnexus/test/unit/group * fix(scope): publish #3630 gitnexus/test/unit/scope-resolution * fix(scope): publish #3630 gitnexus/test/unit/scope-resolution/typescript * fix(scope): publish #3630 gitnexus-shared/src/scope-resolution * fix(scope): treat wrapped assignment targets as writes `(app) = new Map()`, `(app as T) = x` and `app! = x` assign the same binding as `app = x`, but route-fact invalidation and the shared pattern walker stopped at the wrapper, so Express provenance survived the write and produced a false route. Recurse through parenthesized, as/satisfies and non-null targets. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(routes): resolve wrappers through overloads, declarator lists and barrels Three wrapper shapes lost their identity: - Bodyless overload signatures were indexed as separate definitions sharing the implementation's binding, so the binding looked ambiguous and both local and imported calls were rejected. Signatures now declare no callable. - Facts for `const base = 0, request = (url) => fetch(url)` followed the first declarator. The captured name now selects its own declarator. - An import resolved to a workspace barrel stopped at index.ts. Workers now record named, star and imported-then-exported re-exports, and resolution follows them to the declaring module: local and named exports shadow `export *`, star exports never carry `default`, and conflicting star exports block the name. No repository-wide name fallback is restored. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(scope): assert closure ownership against the declaration The closure-write assertion compared one lookup with itself, which also passes when both are undefined. Compare it with the outer declaration and the shadowing parameter, and keep the memoization check explicit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * refactor(routes): share lexical helpers and release per-file HTTP contexts - Share binding keys, parameter patterns and transparent expression wrappers from lexical-bindings instead of four local copies; drop the unused moduleStem export; name the inferred-source predicates in lookup. - Key the per-file HTTP context by its tree rather than its ParsedFile. Workers retain ParsedFiles for the whole chunk, which kept every file's AST and traversal maps alive until the chunk flushed. - Index re-exports by name, memoize barrel walks per starting export, and keep facts without import targets as-is instead of copying them. - Move TS-only wrapper cases into the TS describe.each instead of branching inside the per-language loop. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(routes): keep wrapper identity for HOCs, CommonJS, object keys and fetch packages Four definition shapes that main linked by name lost their wrapper identity: - `const load = useCallback((url) => fetch(url))` and curried HOCs produced no facts because definition lookup stopped at the call; it now follows the callable argument, as the structural definition capture does. - `module.exports = { request }`, `exports.x = …` and `module.exports.x = …` were not exports, so destructured `require` callers missed the wrapper. CommonJS export assignments are recorded when `module`/`exports` are the unshadowed globals, including functions defined inline in the export object. - An object-literal key or method name was resolved as a lexical binding and collided with a same-named module wrapper. Only binding identifiers now name a definition's binding. - `import fetch from 'node-fetch'` no longer counted as fetch. Imports of known fetch implementations (node-fetch, cross-fetch, isomorphic-fetch, the fetch member of undici and whatwg-fetch) are fetch evidence again; parameters and other local names still are not. Reference identifiers are also resolved only when their name is bound to a callable or class region; other identifiers cannot add a reachability edge. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(routes): drive the forwarding fallback case from data and cover re-export merges Replace the boolean-switched forwarding fallback case with table rows instead of branching inside the test, and assert that barrel re-export facts survive worker sub-batch merges. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(bench): reject stale or dirty call-graph exports The committed comparison named a candidate revision that is not on this branch, and nothing stopped it. Comparison now requires both exports to come from clean checkouts and the candidate export to come from the checkout running the comparison. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(bench): regenerate the call-graph comparison on the reviewed head Clean baseline565e50276and clean candidate8a5f7b738on the frozen 432-file corpus (fingerprint 88be1faf...): exactly one CALLS target changes, the annotated closure probe `declaredOwner.writeAndRead` now calls `Base.m` instead of `Foo.m`. The other 431 CALLS and all 11 METHOD_OVERRIDES edges are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(bench): emit export provenance and review notes from the comparison The comparison report carried export provenance and the expected-change explanation only as hand-added fields, which a regeneration dropped. Emit both exports' revisions, dirty flags and fingerprints, the unchanged CALLS and METHOD_OVERRIDES counts, and an optional `--note` explanation directly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(bench): record calibrated scaling reports and the regenerated comparison Duration-calibrated-v2 runs (5 warmups, 15 measured batches, 500 ms pilot target) pinned to the same CPU, baseline then candidate back to back: - Baseline565e50276exceeds the 1.8 normalized ceiling on six arms at 4x input: position-index 7.92, position-deep-completed 4.65, nested-helpers 4.82, nested-helper-chain 14.05, reverse-chain 4.31, name-collisions 2.61 (medians). - Candidate94f1a055bpasses --check: every arm stays at or below 1.32 at 4x for both minimum and median, with correct semantic guards on every arm. The comparison is regenerated from clean exports with its provenance and review note emitted by the tool: one expected CALLS target change, 431 CALLS and 11 METHOD_OVERRIDES unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * refactor(scope): replace recursion with explicit stacks in new traversals The binding work added five recursive traversals whose depth follows input shape: region summaries (callable nesting), barrel resolution (re-export chain length), pattern binding names (destructuring depth), route-fact write invalidation (pattern depth), and the position index's max-end tree. Each now uses an explicit stack with the same visiting order and results. Regression cases cover the inputs the recursive versions could not handle: a 20,000-deep destructuring pattern and a 50,000-module re-export chain both threw RangeError before this change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * perf(routes): avoid a full-tree script walk when building lexical bindings Route-fact extraction ran 1.78x slower than main on a 512-function file (87 ms vs 49 ms) because createLexicalBindings walked every AST node in script to detect collapsed parameter/body environments, which only functions with parameter defaults or computed keys can have. - Find functions with the native type search, skip plain parameter lists without any subtree search, and walk only the formals and bodies of the rest. Detection is unchanged, except that functions inside syntax-error regions are now also checked, which can only add fail-closed ambiguity. - Read each node's id and start position once per lookup instead of repeatedly crossing into native getters. The same extraction now takes about 56 ms against 51 ms on main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * perf(routes): walk wrapper evidence with a tree cursor The wrapper context visited every node through namedChildren, which materializes each child as a SyntaxNode and records a parent edge by node id. A tree cursor reads node types and offsets natively, so only the node types the handlers inspect become SyntaxNodes. Declared identifiers are keyed by start offset, and the walk records the ancestor facts later queries need (stored binding, default export, declarator of a name) instead of a parent map. On the 512-wrapper scaling input, context construction drops from about 58 ms to 48 ms. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(bench): regenerate the call-graph comparison on the cursor walk The candidate export at6061ca71bhas the same fingerprint as the previous candidate: the traversal rewrite changes no edge. The one expected target change and the 431 unchanged CALLS and 11 METHOD_OVERRIDES remain. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(bench): record final scaling reports on the cursor walk Baseline565e50276and candidate61de364ffran back to back on CPU 23 with the duration-calibrated-v2 protocol. Every candidate check stays at or below a 1.32 normalized factor against the 1.8 ceiling; the baseline fails six of nine arms. Workload fingerprints agree except the documented name-collision false positive in the baseline. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(plan): checkpoint the final review, scaling and suite results for #3630 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(routes): treat export aliases of one wrapper as one star-export target Star-export candidates were deduplicated by the resolved export name, so `export { request, request as send }` reached through two barrels counted as two targets and blocked the import, dropping the consumer's FETCHES edge. Candidates are now keyed by the declaration each export name names, matching ECMAScript ResolveExport's binding comparison; distinct declarations exported under the same name stay ambiguous. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(bench): regenerate scaling and call-graph reports on the alias fix Baseline565e50276and candidate4d62bd045ran back to back on CPU 23. Every candidate check stays at or below 1.22 against the 1.8 ceiling; the baseline still fails six of nine arms. The CALLS/METHOD_OVERRIDES export is unchanged (fingerprint 4db24f57), so the comparison only records the new candidate revision. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(plan): record the export-alias fix and the regenerated reports for #3630 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(scope): keep the type a write gives an undeclared name A constructor write to a name no scope declares (`client = new ApiClient()` in sloppy JavaScript) declares nothing, so the lookup stays absent. The carried constructor fact was dropped on that exit, which lost the receiver type main had inferred for later reads in the writing scope. The absent result now carries it, and findReceiverTypeBinding uses it before the namespace fallbacks. Only complete-claim providers carry such a fact. Tests pin the carried type per inferred source, the undeclared write, and preservePosition across a module redirect. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(routes): close the wrapper identity gaps found in review - CommonJS wrappers captured as their assignment (`exports.x = function`, `module.exports.x = () =>`) produce facts again: findFunction follows the assignment's right side. - Name-only fallback considers only definitions that can be the target: an unresolvable import names a module-level export, an undeclared global a top-level function. Nested and unexported helpers no longer erase a wrapper's edges. - Only possible wrappers and module-level functions are emitted, and the routes phase builds the index only when routes and candidate calls exist. - A rebound binding (later assignment, `var` initializer over a function declaration, reassigned export) proves no wrapper across files. - `(<T>x) = ...` is a write; transparent wrappers skip type arguments. - Calls inside recovered syntax are still collected; instance-field initializers resolve after the module body, so a later declaration is visible. - Local exports are always recorded, so a star export conflicting with a non-callable export is ambiguous, and fully resolved barrel frames are shared across walks. - HTTP hooks run per file under a guard; a failing file or one without a ParsedFile still records its function names so fallback declines. - namesFetch is iterative, large patterns no longer spread into push, the facts cache is keyed by the name node, and the provider context cache checks its ParsedFile. Tests cover each case; the behavior rows fail on the previous source. The TS-only call cases no longer branch inside the test file, call targets are asserted exactly, the function-type list is drift-checked, and the persistence test joins the cross-platform worker list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(routes): describe wrapper fallback, barrel and recall boundaries Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(bench): count the new CommonJS fixture's dropped write site `lib/cjs-member.js` in the fetch-wrapper target-identity fixture writes `module.exports.arrowRequest`, a member write whose receiver is not typed. That adds one `receiver-unresolved` write (190 -> 191 all-kind drops, 19 -> 20 writes). Call drops and shape-arm states are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(bench): regenerate scaling and call-graph reports on the review fixes Baseline565e50276and candidate528ea1478ran back to back on CPU 23. Every candidate check stays at or below 1.27 against the 1.8 ceiling; the baseline still fails six of nine arms. The CALLS/METHOD_OVERRIDES export is unchanged (fingerprint 4db24f57), so the comparison only records the new candidate revision. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(plan): checkpoint the review fixes and regenerated reports for #3630 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * refactor(routes): share CommonJS checks and trim per-node work - `isCommonJsGlobal`/`isModuleExports` in lexical-bindings replace the two copies in fetch-wrapper and framework-route-facts (both resolve the same scope from the same start position). - LEXICAL_FUNCTION_TYPES is derived from the TypeScript FUNCTION_NODE_TYPES instead of a third hand-kept copy; the drift test still pins it. - `unwrap` reads UNWRAPPED_TYPES, the set the cursor walk mirrors, and the class-body region is no longer shadowed under the name `deferred`. - framework-route-facts reads each node's type once per loop iteration. - The position index returns the latest-starting scope when it already contains the point, before the max-end tree search; that entry is the search's rightmost match. - carried() returns a shared empty set for argument forms that cannot carry a value, the resolution file set is built without intermediate arrays, and the routes phase reads the call list once. No behavior change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(bench): regenerate scaling and call-graph reports on the refactor Baseline565e50276and candidate3db8657baran back to back on CPU 23. Every candidate check stays at or below 1.32 against the 1.8 ceiling; the baseline still fails six of nine arms. The CALLS/METHOD_OVERRIDES export is unchanged (fingerprint 4db24f57). The later main merge (e2a92dab8) touches no measured file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(plan): checkpoint the simplification pass and its reports for #3630 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Address PR review feedback (#3632) - Destructuring defaults (`{ fetch = globalThis.fetch } = {}`, renamed, array and local forms) are alias evidence for their leaf binding and no longer count a second initialization, which also invalidated bindings like `[send = other] = values`. - `export default (request)` records the default export: the value is unwrapped before the identifier check. - The HTTP fallback records and the collapsed-environment test row now say what they stand for. Regression rows cover each form in JS, TS and TSX and fail on the previous source; two fixture consumers cover imported wrappers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(bench): refresh lexical binding reports after review fixes Regenerate clean baseline and candidate measurements atc263c4f72. All candidate scaling checks pass, the semantic delta remains one CALLS target, and receiver-resolution counts match the existing baseline. * docs(plan): checkpoint refreshed review-fix measurements Recordc263c4f72review fixes, the regenerated scaling and semantic results, and the passing receiver and CI checks. --------- Co-authored-by: Gergo Magyar <gergomagyar0@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
373 lines
13 KiB
TypeScript
373 lines
13 KiB
TypeScript
import { describe, expect, it } from 'vitest';
|
|
import Parser from 'tree-sitter';
|
|
import JavaScript from 'tree-sitter-javascript';
|
|
import TypeScript from 'tree-sitter-typescript';
|
|
import { createFetchWrapperContext } from '../../src/core/ingestion/route-extractors/fetch-wrapper.js';
|
|
|
|
import { extractParsedFile } from '../../src/core/ingestion/scope-extractor-bridge.js';
|
|
import {
|
|
typescriptProvider,
|
|
javascriptProvider,
|
|
} from '../../src/core/ingestion/languages/typescript.js';
|
|
|
|
const grammars = [
|
|
['JavaScript', JavaScript, javascriptProvider],
|
|
['TypeScript', TypeScript.typescript, typescriptProvider],
|
|
['TSX', TypeScript.tsx, typescriptProvider],
|
|
] as const;
|
|
|
|
function harness(grammar: (typeof grammars)[number][1], provider: (typeof grammars)[number][2]) {
|
|
const parser = new Parser();
|
|
parser.setLanguage(grammar);
|
|
const context = (source: string, filePath = 'consumer.ts', lineOffset = 0) => {
|
|
const fullSource = '\n'.repeat(lineOffset) + source;
|
|
const tree = parser.parse(source);
|
|
const parsedFile = extractParsedFile(
|
|
provider,
|
|
fullSource,
|
|
filePath,
|
|
undefined,
|
|
parser.parse(fullSource),
|
|
)!;
|
|
return {
|
|
root: tree.rootNode,
|
|
context: createFetchWrapperContext(tree, parsedFile, lineOffset),
|
|
};
|
|
};
|
|
const extract = (source: string, lineOffset = 0) =>
|
|
context(source, 'consumer.ts', lineOffset).context.calls();
|
|
return { context, extract };
|
|
}
|
|
|
|
for (const [name, grammar, provider] of grammars) {
|
|
describe(`${name} fetch wrapper calls`, () => {
|
|
const { context, extract } = harness(grammar, provider);
|
|
|
|
it('preserves exact callee names and source lines, including comments and optional calls', () => {
|
|
expect(
|
|
extract(
|
|
`
|
|
doRequest('/api/one');
|
|
client /* receiver */ . doRequest(/* url */ '/api/two');
|
|
api.client?.doRequest?.('/api/three');
|
|
cafédoRequest('/api/four');
|
|
`,
|
|
10,
|
|
),
|
|
).toEqual([
|
|
{
|
|
filePath: 'consumer.ts',
|
|
functionName: 'doRequest',
|
|
fetchURL: '/api/one',
|
|
lineNumber: 12,
|
|
target: { kind: 'unresolved' },
|
|
},
|
|
{
|
|
filePath: 'consumer.ts',
|
|
functionName: 'client.doRequest',
|
|
fetchURL: '/api/two',
|
|
lineNumber: 13,
|
|
target: { kind: 'member' },
|
|
},
|
|
{
|
|
filePath: 'consumer.ts',
|
|
functionName: 'api.client.doRequest',
|
|
fetchURL: '/api/three',
|
|
lineNumber: 14,
|
|
target: { kind: 'member' },
|
|
},
|
|
{
|
|
filePath: 'consumer.ts',
|
|
functionName: 'cafédoRequest',
|
|
fetchURL: '/api/four',
|
|
lineNumber: 15,
|
|
target: { kind: 'unresolved' },
|
|
},
|
|
]);
|
|
});
|
|
|
|
// A wrapper calls fetch itself, through a global object or a local alias;
|
|
// it carries a URL when its first parameter reaches fetch's URL argument,
|
|
// directly or through a callee it forwards that parameter to (#1852, #3488).
|
|
it.each([
|
|
{
|
|
shape: 'a direct call nested deeper than the old depth limit',
|
|
source: `async function load(url) {
|
|
try { for (;;) { if (url) { const r = await fetch(url); return r; } } } catch (e) {}
|
|
}`,
|
|
facts: {
|
|
seed: true,
|
|
forwardsUrl: true,
|
|
forwardsTo: [{ callee: 'fetch', kind: 'unresolved' }],
|
|
},
|
|
},
|
|
{
|
|
shape: 'an exported arrow const',
|
|
source: 'export const load = async (url) => { const r = await fetch(url); return r; };',
|
|
facts: {
|
|
seed: true,
|
|
forwardsUrl: true,
|
|
forwardsTo: [{ callee: 'fetch', kind: 'unresolved' }],
|
|
},
|
|
},
|
|
{
|
|
shape: 'an alias of globalThis.fetch',
|
|
source: `async function resilientFetch(input, init, opts = {}) {
|
|
const fetchImpl = opts.fetchImpl ?? globalThis.fetch;
|
|
try { return await fetchImpl(input, init); } catch (e) { throw e; }
|
|
}`,
|
|
facts: {
|
|
seed: true,
|
|
forwardsUrl: true,
|
|
forwardsTo: [{ callee: 'fetchImpl', kind: 'binding' }],
|
|
},
|
|
},
|
|
{
|
|
shape: 'window.fetch',
|
|
source: 'function load(url = "/x") { return window.fetch(url); }',
|
|
facts: {
|
|
seed: true,
|
|
forwardsUrl: true,
|
|
forwardsTo: [{ callee: 'window.fetch', kind: 'member' }],
|
|
},
|
|
},
|
|
{
|
|
shape: 'a URL built from the parameter',
|
|
source: 'function apiFetch(path, opts) { return fetch(`${API_BASE}${path}`, opts); }',
|
|
facts: { seed: true, forwardsUrl: true, forwardsTo: [] },
|
|
},
|
|
{
|
|
shape: 'a fetch whose URL is not the parameter',
|
|
source: `function track(event) {
|
|
return fetch('/api/events', { method: 'POST', body: JSON.stringify(event) });
|
|
}`,
|
|
facts: {
|
|
seed: true,
|
|
forwardsUrl: false,
|
|
forwardsTo: [{ callee: 'JSON.stringify', kind: 'member' }],
|
|
},
|
|
},
|
|
{
|
|
shape: 'a forwarder to another wrapper',
|
|
source: `const fetchWithTimeout = async (url, init = {}) => {
|
|
try { return await resilientFetch(url, { ...init }, {}); } finally { done(); }
|
|
};`,
|
|
facts: {
|
|
seed: false,
|
|
forwardsUrl: false,
|
|
forwardsTo: [{ callee: 'resilientFetch', kind: 'unresolved' }],
|
|
},
|
|
},
|
|
{
|
|
shape: 'fetch named only in a string, a comment, and an unrelated property',
|
|
source: `function goTo(path) {
|
|
const fail = (e) => console.warn('Failed to fetch route data', e);
|
|
/* we never fetch here */
|
|
const mode = node.kind === 'fetch';
|
|
try { history.pushState(null, '', path); } catch (e) { fail(e); }
|
|
}`,
|
|
facts: { seed: false, forwardsUrl: false, forwardsTo: [] },
|
|
},
|
|
{
|
|
shape: 'an unrelated function',
|
|
source: 'function log(message) { console.log("x", message); }',
|
|
facts: { seed: false, forwardsUrl: false, forwardsTo: [] },
|
|
},
|
|
{
|
|
shape: 'an alias declared only in a nested helper',
|
|
source: `function run(url, fetchImpl) {
|
|
function setup() { const fetchImpl = globalThis.fetch; return fetchImpl; }
|
|
return fetchImpl(url);
|
|
}`,
|
|
facts: {
|
|
seed: false,
|
|
forwardsUrl: false,
|
|
forwardsTo: [{ callee: 'fetchImpl', kind: 'binding' }],
|
|
},
|
|
},
|
|
{
|
|
shape: 'a nested helper that never runs, beside a retry callback that does',
|
|
source: `function defer(url) {
|
|
const later = () => resilientFetch(url);
|
|
return withRetry(() => send(url));
|
|
}`,
|
|
facts: {
|
|
seed: false,
|
|
forwardsUrl: false,
|
|
forwardsTo: [{ callee: 'send', kind: 'unresolved' }],
|
|
},
|
|
},
|
|
{
|
|
shape: 'an alias shadowed by a nested function parameter',
|
|
source: `function track(event) {
|
|
const fetchImpl = globalThis.fetch;
|
|
function send(fetchImpl) { return fetchImpl(event); }
|
|
return send(log);
|
|
}`,
|
|
facts: {
|
|
seed: false,
|
|
forwardsUrl: false,
|
|
forwardsTo: [{ callee: 'fetchImpl', kind: 'binding' }],
|
|
},
|
|
},
|
|
{
|
|
shape: 'an alias shadowed by a block-scoped redeclaration',
|
|
source: `function f() {
|
|
const fetchImpl = globalThis.fetch;
|
|
{ const fetchImpl = other; fetchImpl('/api/x'); }
|
|
}`,
|
|
facts: { seed: false, forwardsUrl: false, forwardsTo: [] },
|
|
},
|
|
{
|
|
shape: 'a window parameter rather than the browser global',
|
|
source: 'function wrapper(url, window) { return window.fetch(url); }',
|
|
facts: {
|
|
seed: false,
|
|
forwardsUrl: false,
|
|
forwardsTo: [{ callee: 'window.fetch', kind: 'member' }],
|
|
},
|
|
},
|
|
{
|
|
shape: 'an uncalled nested function declaration',
|
|
source: `function setup(path) {
|
|
function helper() { return fetch('/api/x'); }
|
|
return register(path);
|
|
}`,
|
|
facts: {
|
|
seed: false,
|
|
forwardsUrl: false,
|
|
forwardsTo: [{ callee: 'register', kind: 'unresolved' }],
|
|
},
|
|
},
|
|
{
|
|
shape: 'a parameter shadowed by a local',
|
|
source: `function fixed(url) { { const url = '/health'; return fetch(url); } }`,
|
|
facts: { seed: true, forwardsUrl: false, forwardsTo: [] },
|
|
},
|
|
{
|
|
shape: 'a forwarder to a relative named import',
|
|
source: `import { request as send } from '../desktop/ipc.js';
|
|
export function openPage(path) { return send(path); }`,
|
|
facts: {
|
|
seed: false,
|
|
forwardsUrl: false,
|
|
forwardsTo: [{ callee: 'send', kind: 'import' }],
|
|
},
|
|
},
|
|
{
|
|
shape: 'a forwarder to a same-file function',
|
|
source: `function request(channel) { return ipc.invoke(channel); }
|
|
export const openPage = (path) => request(path);`,
|
|
facts: {
|
|
seed: false,
|
|
forwardsUrl: false,
|
|
forwardsTo: [{ callee: 'request', kind: 'binding' }],
|
|
},
|
|
},
|
|
])('reads wrapper facts from $shape', ({ source, facts }) => {
|
|
const { root, context: wrapper } = context(source, 'src/web/client.ts');
|
|
const actual = wrapper.facts(root.namedChildren[root.namedChildren.length - 1]);
|
|
// Exact facts, with each forwarded callee's target kind.
|
|
expect({
|
|
seed: actual?.seed,
|
|
forwardsUrl: actual?.forwardsUrl,
|
|
forwardsTo: actual?.forwardsTo.map(({ callee, target }) => ({ callee, kind: target.kind })),
|
|
}).toEqual(facts);
|
|
});
|
|
|
|
it('records lexical and import identity of bare callees', () => {
|
|
const source = `import { request as send } from './api';
|
|
send('/api/one'); local('/api/two'); api.request('/api/three'); function local(u) {}`;
|
|
const calls = context(source, 'src/web/page.ts').context.calls();
|
|
expect(calls.map(({ functionName, target }) => ({ functionName, target }))).toEqual([
|
|
{
|
|
functionName: 'send',
|
|
target: { kind: 'import', specifier: './api', importedName: 'request' },
|
|
},
|
|
{ functionName: 'local', target: { kind: 'binding', bindingId: expect.any(String) } },
|
|
{ functionName: 'api.request', target: { kind: 'member' } },
|
|
]);
|
|
});
|
|
|
|
it('preserves configured instance and inherited wrappers', () => {
|
|
expect(
|
|
extract(`class Client extends Base {
|
|
load() {
|
|
this.doRequest('/api/one');
|
|
this.http.doRequest('/api/two');
|
|
super.doRequest('/api/three');
|
|
}
|
|
}`).map((call) => call.functionName),
|
|
).toEqual(['this.doRequest', 'this.http.doRequest', 'super.doRequest']);
|
|
});
|
|
|
|
it('keeps template substitutions for route normalization', () => {
|
|
expect(extract('doRequest(`/api/users/${id}`)')).toMatchObject([
|
|
{ functionName: 'doRequest', fetchURL: '/api/users/${id}' },
|
|
]);
|
|
});
|
|
|
|
it('keeps a base-URL template whose remainder is a path (#3488)', () => {
|
|
expect(extract('doRequest(`${base}/api/users/${id}`)')).toMatchObject([
|
|
{ functionName: 'doRequest', fetchURL: '${base}/api/users/${id}' },
|
|
]);
|
|
});
|
|
|
|
it.each([
|
|
'// doRequest("/api/things")',
|
|
'/* doRequest("/api/things") */',
|
|
'`doRequest("/api/things")`',
|
|
'doRequest("/api/things" + suffix)',
|
|
'doRequest(url, "/api/things")',
|
|
'doRequest(...["/api/things"])',
|
|
'new doRequest("/api/things")',
|
|
'client["doRequest"]("/api/things")',
|
|
'getClient().doRequest("/api/things")',
|
|
'doRequest("https://example.com/api/things")',
|
|
'doRequest(`${base}api/things`)',
|
|
'doRequest(`${scheme}://${host}/api/things`)',
|
|
])('does not invent a candidate for %s', (source) => {
|
|
expect(extract(source)).toEqual([]);
|
|
});
|
|
});
|
|
}
|
|
|
|
// Type arguments exist only in the TypeScript grammars.
|
|
for (const [name, grammar, provider] of grammars.slice(1)) {
|
|
describe(`${name} typed fetch wrapper calls`, () => {
|
|
const { extract } = harness(grammar, provider);
|
|
|
|
it.each([
|
|
'Array<{ result: Promise<string> }>',
|
|
'(value: string) => Promise<{ kind: "thing" }>',
|
|
'{ compare: ">"; callback: () => void }',
|
|
'[string, number]',
|
|
'T extends string ? Array<T> : never',
|
|
])('accepts type arguments %s', (types) => {
|
|
expect(extract(`doRequest<${types}>('/api/things')`)).toMatchObject([
|
|
{ functionName: 'doRequest', fetchURL: '/api/things' },
|
|
]);
|
|
});
|
|
|
|
it('handles awaited generic calls in the installed grammar', () => {
|
|
expect(
|
|
extract(`async function load() {
|
|
await /* request */ doRequest<string[]>('/api/one');
|
|
await client.doRequest<() => void>('/api/two');
|
|
}`).map((call) => [call.functionName, call.fetchURL]),
|
|
).toEqual([
|
|
['doRequest', '/api/one'],
|
|
['client.doRequest', '/api/two'],
|
|
]);
|
|
});
|
|
|
|
it('captures only the actual callee after generic references', () => {
|
|
expect(
|
|
extract(`
|
|
const typed = doRequest<string>;
|
|
const load: typeof doRequest<string> = makeLoader<string>('/api/things');
|
|
`).map((call) => call.functionName),
|
|
).toEqual(['makeLoader']);
|
|
});
|
|
});
|
|
}
|