mirror of
https://github.com/abhigyanpatwari/GitNexus.git
synced 2026-08-28 05:25:25 +00:00
Some checks are pending
CodeQL / Analyze (python) (push) Waiting to run
CodeQL / Analyze (javascript-typescript) (push) Waiting to run
Gitleaks / gitleaks (push) Waiting to run
Publish / Classify release event (push) Waiting to run
Publish / RC guard (marker + release-PR skip) (push) Blocked by required conditions
Publish / ci (push) Blocked by required conditions
Publish / Publish to npm (push) Blocked by required conditions
Publish / Build & Push RC Docker images (push) Blocked by required conditions
Scorecard / Scorecard analysis (push) Waiting to run
Trivy Image Scan / Trivy (gitnexus-cli) (push) Waiting to run
Trivy Image Scan / Trivy (gitnexus-web) (push) Waiting to run
* docs(plans): add provider-hook value-refs plan (#2437) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs(plans): deepen #2437 plan to USES + property-dispatch design Design revised after prior-art research (Kythe ref vs ref/call, Joern METHOD_REF, Feldthaus field-based call graphs, CodeQL impliedReceiverStep): registration sites emit reference-class USES, invocation is recovered by a field-based property-dispatch pass synthesizing CALLS at member-call sites. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(scope-resolution): model provider-hook value references (#2437) Functions referenced as object-literal property values (provider hooks like emitScopeCaptures: emitCppScopeCaptures) previously produced no edge at all, so impact/context reported a false-safe 0 upstream dependents. Two coordinated halves, per prior art (Kythe ref vs ref/call, Joern METHOD_REF, Feldthaus ICSE'13 field-based call graphs, CodeQL impliedReceiverStep): - Registration -> USES: new ReferenceKind 'value-ref'; TS/JS queries capture pair values and shorthand properties (with @reference.property-key); emitted as a reference-class USES edge, reason 'scope-resolution: value-ref'. Resolution is callable-gated so plain values emit nothing. - Dispatch -> CALLS: new shared pass emitPropertyDispatchCalls synthesizes CALLS (reason 'property-dispatch', confidence 0.7, per-key fan-out cap 32 calibrated on this repo's 16-provider hook tables) from member-call sites to every function registered under the same property key. Deviation from plan: the pass owns value-ref resolution entirely via the post-finalize findCallableBindingInScope walker — the shared registries only see pre-finalize local bindings, so imported hooks (the c-cpp.ts case) were unresolvable through lookupForSite; Reference.propertyKey passthrough dropped as unnecessary. SCHEMA_BUMP 13 -> 14: ParsedFile gains value-ref sites + propertyKey. Verified end-to-end: impact(emitCppScopeCaptures, upstream) now reports 8 impacted / HIGH with extractParsedFile (true dispatch caller) at d=1 via property-dispatch and the c-cpp.ts registration via USES. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * test(scope-resolution): cover value-ref registration and property dispatch (#2437) Integration: same-file/cross-file/aliased/shorthand registrations emit USES; non-callable and destructuring values emit nothing; dispatch sites gain property-dispatch CALLS (incl. JS twins and per-language partitioning); fan-out-capped keys are dropped entirely; factory-call values unchanged. Unit: capture-shape pins for @reference.value-ref + @reference.property-key. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(scope-resolution): surface dropped property-dispatch keys in stats (#2437) Review finding: skippedKeys was returned but discarded — a hook table larger than the fan-out cap silently reopened the #2437 gap for those keys. Log dropped keys and fold value-ref USES + dispatch CALLS into referenceEdgesEmitted. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs(plans): add callable reference-flow implementation plan * fix(scope-resolution): close property-dispatch review gaps * feat(scope-resolution): add callable flow facts * feat(scope-resolution): resolve callable value flow * feat(scope-resolution): resolve callable references across providers * fix: harden callable reference flow resolution * fix(scope-resolution): preserve callable binding semantics * docs(plans): add pr-2522-review-fixes plan Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(storage): bump INCREMENTAL_SCHEMA_VERSION for callable-value-flow edges Callable-value-flow CALLS/USES edges (#2437) can connect two files whose content did not change, but the incremental write set only covers changed files — a top-up against a pre-v7 index would silently omit the new edges for every unchanged file pair, indefinitely. Force the one-time full re-analyze (review finding 1, #2522). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(storage): sanitize callable-flow sites per-site at load, log drops The load-time validator rejected the WHOLE ParsedFile when one site was malformed or over-bound, with no logging — and C++ legitimately emits empty-string parameterTypes entries ('' = unknown, the ReferenceSite.argumentTypes convention) for cv-only/ERROR-recovered types, so real repos fell into a permanent, silent warm-cache-miss reparse loop through the #1983-sensitive main-thread path (review finding 7, #2522). Now: '' entries are valid in type arrays; a malformed/over-bound site drops only itself (counted, warned once per load); only non-array garbage — evidence the serialization itself is untrustworthy — rejects the file. Deviation from plan §6 wording: validator-side tolerance replaces emit-side clamps — smaller diff, same asymmetry closed at the single chokepoint. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(scope-resolution): keep declarations in the union for reassigned callable cells The binding-lookup suppression for fact-constrained cells was wholesale: reassigning a declared function through its own name (greet = other; greet()) deferred the call to the solver, which then refused the lexical lookup that resolves the declaration — an unresolvable RHS yielded zero CALLS for a call that resolved pre-flow (review finding 8, #2522). Suppression now applies only to cells bound by FORMAL facts — its actual purpose (a parameter whose grammar emits no declaration binding must not adopt a same-named outer function). Copy/alias/store/load destinations keep their declaration as an inclusion seed (Andersen-style union). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(scope-resolution): count forfeited deferred sites in the budget-bailout warning On work-budget exhaustion the deferred invoke sites end the run with zero CALLS — free-call fallback and reference emission already skipped them — but the warning said 'ordinary graph emission remains untouched', which is false for exactly those sites. The warning context now carries the unresolved deferred-site count and the comment states the real cost (review finding: budget-bailout honesty, #2522). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(scope-resolution): surface dropped property-dispatch keys in stats and warn payload The over-cap warning carried only a count; the dropped key NAMES were discarded and RunScopeResolutionStats had no field, so the PR-body claim 'includes them in resolver statistics' was unimplemented (review finding, #2522; reviewer ask on the fan-out cap). The warn payload now names up to 20 dropped keys and the stats carry propertyDispatchSkippedKeys. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * refactor(scope-resolution): drop producer-less ownerQualifiedName from formal sites No capture emitter anywhere produces @callable-flow.owner-qualified-name — the solver branch consuming it was unreachable in production, yet the field was typed, parsed, validated, and unit-tested with hand-built input (review finding 16, #2522; YAGNI). Re-add with a real producer if C++ qualified member declarators ever need it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * refactor(scope-resolution): drop dead callable-flow knobs CallableFlowPassingMode 'callable-object' had no producer and no consumer distinguishing it, and CallableFlowCaptureOptions.extractCallArguments had no language providing it (unlike its live sibling extractCallCallee) — review finding 17, #2522 (YAGNI). The invocation-kind 'callable-object' is a different, live concept and stays. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(ingestion): bind subscripted callable cells to the container, not the index terminalIdentifier iterates children in reverse, so tbl[i] = handler seeded the INDEX variable's cell (polluting a same-named formal) and tbl[i](7) looked up the callee under i in a different scope — no join, no CALLS edge for the classic function-pointer-array dispatch (review finding 12, #2522). Subscript nodes now recurse into their container field only, in both bindingIdentifier and terminalIdentifier, across the fielded grammars (C/C++/JS/TS/Python/Go/Java). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(ingestion): make cross-function file-scope callable bindings resolvable Two stacked gaps killed the canonical C callback-registration pattern (fp assigned in init(), called in run()) — the exact #2437 false-safe this PR exists to fix (review finding H1, #2522): 1. isVisibleValueBinding only consulted assignment regions and formals, so a call in a function OTHER than the assigning one emitted no invoke fact. A declared callable-typed binding is now a value binding wherever its declaration is visible (visibleCallableSignature). 2. The C scope query had no @declaration.variable pattern for function- pointer declarators — void (*fp)(int); created no scope-tree binding, so the seed (init) and invoke (run) cells canonicalized to different keys and never joined. Both bare and initialized forms now bind. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(c): detect variadic parameters via the named variadic_parameter node tree-sitter-c materializes '...' as a named variadic_parameter node; the anonymous-token checks never matched, so variadic function-pointer signatures were emitted with a wrong fixed arity and no '...' sentinel (review finding, #2522). C++ is unaffected ('...' stays an anonymous token there); the token checks remain for such grammars. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(ingestion): emit invoke facts for field-stored callable member calls The C ops-vtable pattern (o->run = handler; o->run(1)) captured the store but never the call — the member path in emitCallFacts bailed for languages without protocol methods, and the value-binding index recorded the member store under the OBJECT's name ('o'), not the member's ('run') (review finding 11/M3, #2522). Member destinations now also record their terminal member name, and a member call whose name-cell has a visible store emits an indirect invoke — gated on the store so plain accessor calls (map.get) stay inert. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(cpp): disambiguate (obj->*ptr)() ERROR recovery by token order tree-sitter-cpp groups the recovered '->*' two ways depending on error-recovery cost (identifier lengths): [identifier, ERROR '->*m'] or [ERROR 'obj->*', identifier]. The recovery assumed the first shape, so the second silently swapped receiver/member and dropped the call site — the committed test passed only by name luck (review finding H2, #2522). The identifier's position relative to '->*' inside the ERROR now decides roles. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(cpp): class members are never file-local in hasFileLocalCallableLinkage The name-keyed file-local set is populated from every static declaration, so an in-class 'static void make();' (external linkage — in-class static means no-instance) and any member sharing a name with a static free function were over-marked, refusing legitimate cross-file declaration/definition joins (review finding 13/M2, #2522). Method and Constructor defs now bypass the name-set, per the hook's own linkage-only contract. Deviation from plan step 13: the regression is a unit-level contract pin rather than an end-to-end join test — C++ merges out-of-line member definitions onto the member node by qualified identity, so the graph shape cannot discriminate the join refusal for members. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(cpp): classify parameter passing mode from the declarator chain only A whole-subtree scan for reference_declarator inverted copy vs alias: void reg(void (*cb)(int& out)) marked the by-value pointer cb as 'reference' because of the NESTED parameter's int&, making the solver back-propagate formal targets into every caller's argument cell — alias semantics for a copy (review finding 14/M5, #2522). The chain walk never descends into nested parameter lists; a reference anywhere ON the chain (int& x, void (*&cb)(int)) still aliases. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(ruby): bare identifiers are calls, not callable references Ruby parses a receiver-less zero-arg method call identically to a variable read, so 'action = process' — which CALLS process and stores its return — seeded action with the callable and minted a wrong CALLS edge from any dispatch through it, confirmed end-to-end (review finding 15/HIGH, #2522). New provider knob bareNamesAreCalls: a bare name that is not a provably local value binding and not an explicit reference form (method(:x), lambda/proc) emits no flow fact, on both the assignment and argument paths. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(go): pair multi-value := positionally instead of cross-wiring The shared field fallback took the FIRST LHS identifier and the LAST RHS identifier of Go's expression_list pair, cross-wiring 'a, b := f, g' and synthesizing a garbage comma-joined qualified name — the real relationships were silently dropped (review finding 16, #2522). extractAssignment may now return multiple pairs; Go pairs list entries positionally and emits nothing for a length mismatch (multi-return call RHS). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(java): drop get/test from callableProtocolMethods 'get' and 'test' collide with ubiquitous non-functional-interface APIs (Map/List/Optional/Future.get), so every ordinary container access emitted a spurious callable-object invoke fact — high-volume misleading graph facts with a cross-wiring risk on receiver-name reuse (review finding 17, #2522). Supplier.get/Predicate.test dispatch is deliberately traded away until the check can gate on the receiver's declared type. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(rust): pin the qualified-name no-degrade guard as a hard invariant Rust's scoped_identifier callable-reference capture over-includes unit enum variants and associated constants (Shape::Square seeds as if callable); they stay edge-free only because resolveSeedCandidates refuses to degrade an unresolved qualified name to a simple-name lookup (review finding 18, #2522). Capture-side type filtering would false-negative on tuple-variant constructors, so the guard IS the contract: documented as a hard invariant (Go's mis-shaped multi-value forms also rely on it) and pinned end-to-end. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(php): remove nonexistent optional_parameter node type tree-sitter-php has no 'optional_parameter' — defaults ride on simple_parameter — so the entry was dead weight the #1920 literal gate does not cover for capture-option Sets (review finding 19, #2522). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(cobol): detect procedure pointers on fixed-format sources Two stacked defects made the feature a no-op on classic sequence-numbered fixed format (review finding 20/H3, #2522): 1. parseDataItemClauses' USAGE alternation knew POINTER but not PROCEDURE-POINTER/FUNCTION-POINTER, so the dataItems filter was dead. 2. The raw-line fallback scanned UNCLEANED text, where the sequence number satisfied the leading digits and the LEVEL NUMBER got captured as the pointer name. It now scans preprocessed lines and requires a letter- initial name (COBOL data names must contain a letter). 161 COBOL preprocessor/copy-expander tests stay green; free-format matrix case unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(cobol): skip comment lines in SET seed/copy scans A commented-out SET (indicator-column '*'/'/' or free-format '*>') produced a live seed and a false CALLS edge from dead code (review finding 21/M1, #2522). The scan now skips indicator-column comment lines and strips inline '*>' tails before matching. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs(architecture): document callable-flow-only mode and skipped-key reporting The Callable-value flow section omitted scopeResolutionEdgeMode: 'callable-flow-only' — a real emit-pipeline branch that suppresses all ordinary emission for standalone providers (review finding 22, #2522) — and predated the skipped-key names/stats surfacing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs(scope-resolution): correct value-ref resolution attribution and stale pdg-gating comments The value-ref contract comment claimed MethodRegistry resolution — the mechanism is the post-finalize findCallableBindingInScope walker owned by emitPropertyDispatchCalls (resolveReferenceSites skips these sites). Three 'only under --pdg' calleeIdSink comments were falsified by the #2437 gating change (callee-id-sink.ts's header was updated; these copies were missed). Review finding 23, #2522. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * test(ingestion): direct unit coverage for synthesizeCallableFlowCaptures The 1,100-line shared synthesizer had no test naming it — only downstream consumers were covered (review finding 24, #2522). Pins seed/invoke/ formal/argument emission, subscript container binding, store-gated member invokes, produced-value guards, and the bareNamesAreCalls knob over a minimal options object so assertions target the synthesizer's own semantics. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * test(resolvers): deepen shallow-language coverage; fix Kotlin/Swift reassignment gaps it exposed Adds the COBOL SET x TO y copy-branch scenario and conditional-assignment scenarios for Kotlin, C#, Swift, and Dart (10 languages previously had one generic case each — review finding 25, #2522). The new scenarios exposed two real capture gaps, fixed here: - tree-sitter-kotlin's 'assignment' node is fieldless, so nested reassignments (chosen = ::target inside a block) produced no flow facts; Kotlin's extractAssignment now decomposes it positionally. - tree-sitter-swift fields its assignment as target:/result:, neither in the shared fallback's field lists; both added. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * test(infra): literal-validation gate for callable-capture option Sets The #1920 gate validates query literals and exported configs but not the module-private *_CALLABLE_CAPTURE_OPTIONS Sets consumed by the shared synthesizer — a typo'd node type silently captures nothing (PHP shipped a dead 'optional_parameter'; review finding 26, #2522). Every <key>NodeTypes Set literal is now validated against its language's grammar; name-carrying sets (callableProtocolMethods, memberPointerOperators) are deliberately outside the contract. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * test(storage): centralize corrupt-fixture casts into makeStoreEntry The callable-flow store tests scattered 'as unknown as' double-casts per fixture (review finding 27, #2522; standing no-as-any rule). One typed helper now owns the single controlled escape hatch for building malformed serialization-boundary payloads. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * chore(bench): refresh capture fingerprints after review fixes python-scope: the committed baseline (8d5c3699) never matched this branch's code — CI's benchmarks arm was red on the PR head (review finding 2/HIGH, #2522); regenerated (a99e69ab), scaling 1.04 in budget. scope-capture: ruby/cpp/swift/java/kotlin drifted from the review-fix commits (bare-name suppression, passing modes + ->* recovery, assignment fields, protocol narrowing, positional assignment); all 14 languages re-verified PASS with ratios <= 1.18 against the 1.5 budget. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * chore(docs): untrack docs/plans working documents docs/ is gitignored (local working docs); the plan files were force-added past the ignore. Untracked from the index only — they stay on disk. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * test(golden): regenerate captures goldens after callable-flow review fixes The per-language digest guards (csharp/go/php/python/ruby/rust/swift) locked the pre-fix capture output; the review-fix series intentionally changed it — store-gated member invokes, subscript container binding, Ruby bare-name suppression, Swift assignment fields, positional pairing. Regenerated with UPDATE_GOLDEN=1; clean verification run 59/59; all other parity/golden guards (pipeline-graph, spring-route, python parity) pass untouched at 33/33. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(ingestion): prototypes are callees, not callable value cells The cross-function visibility fix indexed EVERY signature-bearing declaration as a value binding — including plain function/method prototypes (void f(int);). Every call to a declared function then became an indirect invoke, and with emitCanonicalInvokeReference (C/C++) minted a free-call reference that resolved through the registry, bypassing the precise passes' two-phase/ambiguity/subobject suppression — eight phantom CALLS edges in the cpp resolver suite on CI. Only declarations whose binding identifier sits under a pointer/ parenthesized declarator (callable-typed variables like void (*fp)(int);) create value cells now. cpp resolver suite 331/331; callable-value-flow + C/C++ suites 181/181 (the cross-function fp regression still passes); cpp fingerprint rebaselined, both bench gates PASS. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
562 lines
22 KiB
TypeScript
562 lines
22 KiB
TypeScript
/**
|
|
* Unit tests for C++ scope query + captures orchestrator.
|
|
*
|
|
* Pins the capture-tag vocabulary + range shape for every construct
|
|
* the scope-resolution pipeline reads. Runs against tree-sitter-cpp.
|
|
*/
|
|
|
|
import { describe, it, expect, beforeEach } from 'vitest';
|
|
import { emitCppScopeCaptures } from '../../../../src/core/ingestion/languages/cpp/captures.js';
|
|
import { cppProvider } from '../../../../src/core/ingestion/languages/c-cpp.js';
|
|
import { extractParsedFile } from '../../../../src/core/ingestion/scope-extractor-bridge.js';
|
|
import {
|
|
clearFileLocalNames,
|
|
isFileLocal,
|
|
} from '../../../../src/core/ingestion/languages/cpp/file-local-linkage.js';
|
|
|
|
function tagsFor(src: string, filePath = 'test.cpp'): string[][] {
|
|
const matches = emitCppScopeCaptures(src, filePath);
|
|
return matches.map((m) => Object.keys(m).sort());
|
|
}
|
|
|
|
function findMatch(src: string, predicate: (tags: string[]) => boolean, filePath = 'test.cpp') {
|
|
const matches = emitCppScopeCaptures(src, filePath);
|
|
return matches.find((m) => predicate(Object.keys(m)));
|
|
}
|
|
|
|
function allMatches(src: string, predicate: (tags: string[]) => boolean, filePath = 'test.cpp') {
|
|
const matches = emitCppScopeCaptures(src, filePath);
|
|
return matches.filter((m) => predicate(Object.keys(m)));
|
|
}
|
|
|
|
// ── Scopes ──────────────────────────────────────────────────────────────────
|
|
|
|
describe('emitCppScopeCaptures — scopes', () => {
|
|
it('captures translation_unit as @scope.module', () => {
|
|
const all = tagsFor('int x = 1;');
|
|
expect(all.some((t) => t.includes('@scope.module'))).toBe(true);
|
|
});
|
|
|
|
it('captures class_specifier as @scope.class', () => {
|
|
const all = tagsFor('class Foo { int x; };');
|
|
expect(all.some((t) => t.includes('@scope.class'))).toBe(true);
|
|
});
|
|
|
|
it('captures struct_specifier as @scope.class', () => {
|
|
const all = tagsFor('struct Point { int x; int y; };');
|
|
expect(all.some((t) => t.includes('@scope.class'))).toBe(true);
|
|
});
|
|
|
|
it('captures namespace_definition as @scope.namespace', () => {
|
|
const all = tagsFor('namespace foo { int x; }');
|
|
expect(all.some((t) => t.includes('@scope.namespace'))).toBe(true);
|
|
});
|
|
|
|
it('captures function_definition as @scope.function', () => {
|
|
const all = tagsFor('void foo() { }');
|
|
expect(all.some((t) => t.includes('@scope.function'))).toBe(true);
|
|
});
|
|
|
|
it('captures lambda_expression as @scope.function', () => {
|
|
const all = tagsFor('auto f = [](int x) { return x; };');
|
|
expect(all.some((t) => t.includes('@scope.function'))).toBe(true);
|
|
});
|
|
|
|
it('captures block-level scopes (if, for, while, do, switch, case, try, catch)', () => {
|
|
const src = `
|
|
void f() {
|
|
if (true) { }
|
|
for (int i = 0; i < 10; i++) { }
|
|
while (true) { }
|
|
do { } while (false);
|
|
switch (0) { case 0: break; }
|
|
try { } catch (...) { }
|
|
}
|
|
`;
|
|
const all = tagsFor(src);
|
|
const blocks = all.filter((t) => t.includes('@scope.block'));
|
|
expect(blocks.length).toBeGreaterThanOrEqual(6);
|
|
});
|
|
|
|
it('captures for_range_loop as @scope.block', () => {
|
|
const src = `
|
|
#include <vector>
|
|
void f() {
|
|
std::vector<int> v;
|
|
for (auto& x : v) { }
|
|
}
|
|
`;
|
|
const all = tagsFor(src);
|
|
const blocks = all.filter((t) => t.includes('@scope.block'));
|
|
expect(blocks.length).toBeGreaterThanOrEqual(1);
|
|
});
|
|
});
|
|
|
|
// ── Declarations — classes / structs ────────────────────────────────────────
|
|
|
|
describe('emitCppScopeCaptures — class declarations', () => {
|
|
it('captures named class with @declaration.class', () => {
|
|
const m = findMatch('class Foo { int x; };', (t) => t.includes('@declaration.class'));
|
|
expect(m).toBeDefined();
|
|
expect(m!['@declaration.name'].text).toBe('Foo');
|
|
});
|
|
|
|
it('captures named struct with @declaration.struct', () => {
|
|
const m = findMatch('struct Point { int x; int y; };', (t) =>
|
|
t.includes('@declaration.struct'),
|
|
);
|
|
expect(m).toBeDefined();
|
|
expect(m!['@declaration.name'].text).toBe('Point');
|
|
});
|
|
|
|
it('captures typedef anonymous struct with @declaration.struct (not typedef)', () => {
|
|
const src = 'typedef struct { int x; int y; } Point;';
|
|
const m = findMatch(src, (t) => t.includes('@declaration.struct'));
|
|
expect(m).toBeDefined();
|
|
expect(m!['@declaration.name'].text).toBe('Point');
|
|
|
|
const typedefs = allMatches(src, (t) => t.includes('@declaration.typedef'));
|
|
expect(typedefs).toHaveLength(0);
|
|
});
|
|
|
|
it('captures template class with @declaration.class', () => {
|
|
const m = findMatch('template <typename T> class Container { T val; };', (t) =>
|
|
t.includes('@declaration.class'),
|
|
);
|
|
expect(m).toBeDefined();
|
|
expect(m!['@declaration.name'].text).toBe('Container');
|
|
});
|
|
});
|
|
|
|
// ── Declarations — namespaces ───────────────────────────────────────────────
|
|
|
|
describe('emitCppScopeCaptures — namespace declarations', () => {
|
|
it('captures named namespace with @declaration.namespace', () => {
|
|
const m = findMatch('namespace foo { int x; }', (t) => t.includes('@declaration.namespace'));
|
|
expect(m).toBeDefined();
|
|
expect(m!['@declaration.name'].text).toBe('foo');
|
|
});
|
|
|
|
it('anonymous namespace has no @declaration.namespace (only @scope.namespace)', () => {
|
|
const matches = allMatches('namespace { int x; }', (t) => t.includes('@declaration.namespace'));
|
|
// Anonymous namespace should NOT produce a @declaration.namespace
|
|
expect(matches.length).toBe(0);
|
|
});
|
|
});
|
|
|
|
// ── Declarations — functions / methods ──────────────────────────────────────
|
|
|
|
describe('emitCppScopeCaptures — function declarations', () => {
|
|
it('captures function definition with @declaration.function', () => {
|
|
const m = findMatch('void foo() {}', (t) => t.includes('@declaration.function'));
|
|
expect(m).toBeDefined();
|
|
expect(m!['@declaration.name'].text).toBe('foo');
|
|
});
|
|
|
|
it('captures function with pointer return as @declaration.function', () => {
|
|
const m = findMatch('int* create() {}', (t) => t.includes('@declaration.function'));
|
|
expect(m).toBeDefined();
|
|
expect(m!['@declaration.name'].text).toBe('create');
|
|
});
|
|
|
|
it('captures out-of-class method (qualified_identifier) as @declaration.method', () => {
|
|
const m = findMatch('void Foo::bar() {}', (t) => t.includes('@declaration.method'));
|
|
expect(m).toBeDefined();
|
|
expect(m!['@declaration.name'].text).toBe('bar');
|
|
});
|
|
|
|
it('captures destructor as @declaration.method', () => {
|
|
const m = findMatch('void Foo::~Foo() {}', (t) => t.includes('@declaration.method'));
|
|
expect(m).toBeDefined();
|
|
// destructor_name includes the ~
|
|
expect(m!['@declaration.name'].text).toContain('~');
|
|
});
|
|
|
|
it('captures inline method (field_identifier) as @declaration.method', () => {
|
|
const src = 'class Foo { void bar() {} };';
|
|
const m = findMatch(src, (t) => t.includes('@declaration.method'));
|
|
expect(m).toBeDefined();
|
|
expect(m!['@declaration.name'].text).toBe('bar');
|
|
});
|
|
|
|
it('captures function prototype as @declaration.function', () => {
|
|
const m = findMatch('void foo();', (t) => t.includes('@declaration.function'));
|
|
expect(m).toBeDefined();
|
|
expect(m!['@declaration.name'].text).toBe('foo');
|
|
});
|
|
|
|
it('captures template function as @declaration.function', () => {
|
|
const m = findMatch('template <typename T> void foo(T x) {}', (t) =>
|
|
t.includes('@declaration.function'),
|
|
);
|
|
expect(m).toBeDefined();
|
|
expect(m!['@declaration.name'].text).toBe('foo');
|
|
});
|
|
});
|
|
|
|
// ── Declarations — fields ───────────────────────────────────────────────────
|
|
|
|
describe('emitCppScopeCaptures — field declarations', () => {
|
|
it('captures plain field', () => {
|
|
const m = findMatch('class Foo { int val; };', (t) => t.includes('@declaration.field'));
|
|
expect(m).toBeDefined();
|
|
expect(m!['@declaration.name'].text).toBe('val');
|
|
});
|
|
|
|
it('captures pointer field', () => {
|
|
const m = findMatch('class Foo { int* ptr; };', (t) => t.includes('@declaration.field'));
|
|
expect(m).toBeDefined();
|
|
expect(m!['@declaration.name'].text).toBe('ptr');
|
|
});
|
|
|
|
it('captures reference field', () => {
|
|
const m = findMatch('class Foo { int& ref; };', (t) => t.includes('@declaration.field'));
|
|
expect(m).toBeDefined();
|
|
expect(m!['@declaration.name'].text).toBe('ref');
|
|
});
|
|
});
|
|
|
|
// ── Declarations — variables ────────────────────────────────────────────────
|
|
|
|
describe('emitCppScopeCaptures — variable declarations', () => {
|
|
it('captures variable with initializer', () => {
|
|
const m = findMatch('int x = 42;', (t) => t.includes('@declaration.variable'));
|
|
expect(m).toBeDefined();
|
|
expect(m!['@declaration.name'].text).toBe('x');
|
|
});
|
|
|
|
it('captures all names in mixed initialized and uninitialized declarations', () => {
|
|
const matches = allMatches('void f() { int a = 1, b, *p, c = 3, d; }', (t) =>
|
|
t.includes('@declaration.variable'),
|
|
);
|
|
const names = matches.map((m) => m['@declaration.name'].text).sort();
|
|
expect(names).toEqual(['a', 'b', 'c', 'd', 'p']);
|
|
});
|
|
|
|
it('captures qualified-type multi-declarator variables', () => {
|
|
const src = 'namespace data { struct Pair {}; } void f() { data::Pair a, b; }';
|
|
const matches = allMatches(src, (t) => t.includes('@declaration.variable'));
|
|
const names = matches.map((m) => m['@declaration.name'].text).sort();
|
|
expect(names).toEqual(['a', 'b']);
|
|
});
|
|
});
|
|
|
|
// ── Declarations — enums ────────────────────────────────────────────────────
|
|
|
|
describe('emitCppScopeCaptures — enum declarations', () => {
|
|
it('captures enum with @declaration.enum', () => {
|
|
const m = findMatch('enum Color { Red, Green, Blue };', (t) => t.includes('@declaration.enum'));
|
|
expect(m).toBeDefined();
|
|
expect(m!['@declaration.name'].text).toBe('Color');
|
|
});
|
|
|
|
it('captures enum constants with @declaration.const', () => {
|
|
const matches = allMatches('enum Color { Red, Green, Blue };', (t) =>
|
|
t.includes('@declaration.const'),
|
|
);
|
|
expect(matches.length).toBe(3);
|
|
const names = matches.map((m) => m['@declaration.name'].text).sort();
|
|
expect(names).toEqual(['Blue', 'Green', 'Red']);
|
|
});
|
|
|
|
it('captures typedef anonymous enum with @declaration.enum (not typedef)', () => {
|
|
const src = 'typedef enum { Red, Green, Blue } Color;';
|
|
const m = findMatch(src, (t) => t.includes('@declaration.enum'));
|
|
expect(m).toBeDefined();
|
|
expect(m!['@declaration.name'].text).toBe('Color');
|
|
|
|
const typedefs = allMatches(src, (t) => t.includes('@declaration.typedef'));
|
|
expect(typedefs).toHaveLength(0);
|
|
});
|
|
});
|
|
|
|
// ── Declarations — typedef / alias ──────────────────────────────────────────
|
|
|
|
describe('emitCppScopeCaptures — typedef/alias declarations', () => {
|
|
it('captures typedef as @declaration.typedef', () => {
|
|
const m = findMatch('typedef int MyInt;', (t) => t.includes('@declaration.typedef'));
|
|
expect(m).toBeDefined();
|
|
expect(m!['@declaration.name'].text).toBe('MyInt');
|
|
});
|
|
|
|
it('captures using alias as @declaration.typedef', () => {
|
|
const m = findMatch('using MyInt = int;', (t) => t.includes('@declaration.typedef'));
|
|
expect(m).toBeDefined();
|
|
expect(m!['@declaration.name'].text).toBe('MyInt');
|
|
});
|
|
});
|
|
|
|
// ── Declarations — macros ───────────────────────────────────────────────────
|
|
|
|
describe('emitCppScopeCaptures — macro declarations', () => {
|
|
it('captures #define as @declaration.macro', () => {
|
|
const m = findMatch('#define MAX 100', (t) => t.includes('@declaration.macro'));
|
|
expect(m).toBeDefined();
|
|
expect(m!['@declaration.name'].text).toBe('MAX');
|
|
});
|
|
|
|
it('captures #define function as @declaration.macro', () => {
|
|
const m = findMatch('#define ADD(a,b) ((a)+(b))', (t) => t.includes('@declaration.macro'));
|
|
expect(m).toBeDefined();
|
|
expect(m!['@declaration.name'].text).toBe('ADD');
|
|
});
|
|
});
|
|
|
|
// ── Imports ─────────────────────────────────────────────────────────────────
|
|
|
|
describe('emitCppScopeCaptures — imports', () => {
|
|
it('captures #include local as wildcard import', () => {
|
|
const m = findMatch('#include "foo.h"', (t) => t.includes('@import.source'));
|
|
expect(m).toBeDefined();
|
|
expect(m!['@import.source'].text).toBe('foo.h');
|
|
expect(m!['@import.kind'].text).toBe('wildcard');
|
|
expect(m!['@import.system']).toBeUndefined();
|
|
});
|
|
|
|
it('captures #include system with system marker', () => {
|
|
const m = findMatch('#include <iostream>', (t) => t.includes('@import.source'));
|
|
expect(m).toBeDefined();
|
|
expect(m!['@import.source'].text).toBe('iostream');
|
|
expect(m!['@import.system']).toBeDefined();
|
|
});
|
|
|
|
it('captures using namespace as wildcard import', () => {
|
|
const m = findMatch('using namespace std;', (t) => t.includes('@import.using-namespace'));
|
|
expect(m).toBeDefined();
|
|
expect(m!['@import.source'].text).toBe('std');
|
|
expect(m!['@import.kind'].text).toBe('wildcard');
|
|
});
|
|
|
|
it('captures using declaration as named import', () => {
|
|
const m = findMatch('using std::vector;', (t) => t.includes('@import.name'));
|
|
expect(m).toBeDefined();
|
|
expect(m!['@import.source'].text).toBe('std');
|
|
expect(m!['@import.name'].text).toBe('vector');
|
|
expect(m!['@import.kind'].text).toBe('named');
|
|
});
|
|
});
|
|
|
|
// ── References ──────────────────────────────────────────────────────────────
|
|
|
|
describe('emitCppScopeCaptures — references', () => {
|
|
it('captures free call', () => {
|
|
const src = 'void f() { foo(); }';
|
|
const m = findMatch(src, (t) => t.includes('@reference.call.free'));
|
|
expect(m).toBeDefined();
|
|
expect(m!['@reference.name'].text).toBe('foo');
|
|
});
|
|
|
|
it('captures member call (obj.method())', () => {
|
|
const src = 'void f() { obj.method(); }';
|
|
const m = findMatch(src, (t) => t.includes('@reference.call.member'));
|
|
expect(m).toBeDefined();
|
|
expect(m!['@reference.name'].text).toBe('method');
|
|
});
|
|
|
|
it('captures member call (ptr->method())', () => {
|
|
const src = 'void f() { ptr->method(); }';
|
|
const m = findMatch(src, (t) => t.includes('@reference.call.member'));
|
|
expect(m).toBeDefined();
|
|
expect(m!['@reference.name'].text).toBe('method');
|
|
});
|
|
|
|
it('captures qualified call (Namespace::func())', () => {
|
|
const src = 'void f() { Foo::bar(); }';
|
|
const m = findMatch(src, (t) => t.includes('@reference.call.qualified'));
|
|
expect(m).toBeDefined();
|
|
expect(m!['@reference.name'].text).toBe('bar');
|
|
});
|
|
|
|
it('captures field read', () => {
|
|
const src = 'void f() { int x = obj.val; }';
|
|
const m = findMatch(src, (t) => t.includes('@reference.read'));
|
|
expect(m).toBeDefined();
|
|
expect(m!['@reference.name'].text).toBe('val');
|
|
});
|
|
|
|
it('captures field write', () => {
|
|
const src = 'void f() { obj.val = 42; }';
|
|
const m = findMatch(src, (t) => t.includes('@reference.write'));
|
|
expect(m).toBeDefined();
|
|
expect(m!['@reference.name'].text).toBe('val');
|
|
});
|
|
});
|
|
|
|
// ── Type bindings ───────────────────────────────────────────────────────────
|
|
|
|
describe('emitCppScopeCaptures — type bindings', () => {
|
|
it('captures parameter type binding', () => {
|
|
const src = 'void foo(int x) {}';
|
|
const m = findMatch(src, (t) => t.includes('@type-binding.parameter'));
|
|
expect(m).toBeDefined();
|
|
expect(m!['@type-binding.name'].text).toBe('x');
|
|
});
|
|
|
|
it('captures variable type binding', () => {
|
|
const src = 'int x = 42;';
|
|
const m = findMatch(src, (t) => t.includes('@type-binding.assignment'));
|
|
expect(m).toBeDefined();
|
|
expect(m!['@type-binding.name'].text).toBe('x');
|
|
});
|
|
});
|
|
|
|
// ── Arity enrichment ────────────────────────────────────────────────────────
|
|
|
|
describe('emitCppScopeCaptures — arity enrichment', () => {
|
|
it('enriches function declaration with parameter count', () => {
|
|
const m = findMatch('void foo(int x, int y) {}', (t) =>
|
|
t.includes('@declaration.parameter-count'),
|
|
);
|
|
expect(m).toBeDefined();
|
|
expect(m!['@declaration.parameter-count'].text).toBe('2');
|
|
});
|
|
|
|
it('enriches zero-parameter function', () => {
|
|
const m = findMatch('void foo() {}', (t) => t.includes('@declaration.parameter-count'));
|
|
expect(m).toBeDefined();
|
|
expect(m!['@declaration.parameter-count'].text).toBe('0');
|
|
});
|
|
|
|
it('detects default parameters (required < total)', () => {
|
|
const m = findMatch('void foo(int x, int y = 5) {}', (t) =>
|
|
t.includes('@declaration.required-parameter-count'),
|
|
);
|
|
expect(m).toBeDefined();
|
|
expect(m!['@declaration.required-parameter-count'].text).toBe('1');
|
|
expect(m!['@declaration.parameter-count'].text).toBe('2');
|
|
});
|
|
|
|
it('tags deleted declarations but not defaulted declarations', () => {
|
|
const deleted = findMatch('void foo(int) = delete;', (tags) =>
|
|
tags.includes('@declaration.is-deleted'),
|
|
);
|
|
const defaulted = emitCppScopeCaptures('struct S { S() = default; };', 'test.cpp').find(
|
|
(match) => Object.values(match).some((capture) => capture.text.includes('= default')),
|
|
);
|
|
|
|
expect(deleted?.['@declaration.is-deleted'].text).toBe('true');
|
|
expect(defaulted).toBeDefined();
|
|
expect(defaulted?.['@declaration.is-deleted']).toBeUndefined();
|
|
});
|
|
|
|
it('tags deleted free operators', () => {
|
|
const deleted = findMatch(
|
|
'struct S {}; bool operator==(const S&, const S&) = delete;',
|
|
(tags) => tags.includes('@declaration.is-deleted'),
|
|
);
|
|
|
|
expect(deleted?.['@declaration.name'].text).toBe('operator==');
|
|
expect(deleted?.['@declaration.is-deleted'].text).toBe('true');
|
|
});
|
|
|
|
it('tags deleted pointer-return free functions', () => {
|
|
const deleted = findMatch('int* lookup(int) = delete;', (tags) =>
|
|
tags.includes('@declaration.is-deleted'),
|
|
);
|
|
|
|
expect(deleted?.['@declaration.name'].text).toBe('lookup');
|
|
expect(deleted?.['@declaration.is-deleted'].text).toBe('true');
|
|
});
|
|
|
|
it('does not borrow a deleted initializer from another declarator', () => {
|
|
const declarations = allMatches('void f(int), g = delete(new int);', (tags) =>
|
|
tags.includes('@declaration.function'),
|
|
);
|
|
const f = declarations.find((match) => match['@declaration.name']?.text === 'f');
|
|
|
|
expect(f).toBeDefined();
|
|
expect(f?.['@declaration.is-deleted']).toBeUndefined();
|
|
});
|
|
|
|
it('preserves deleted-callable metadata in parsed local definitions', () => {
|
|
const parsed = extractParsedFile(
|
|
cppProvider,
|
|
`
|
|
void choose(int) = delete;
|
|
struct S {
|
|
S() = default;
|
|
void touch(double) = delete;
|
|
};
|
|
`,
|
|
'test.cpp',
|
|
);
|
|
|
|
const choose = parsed?.localDefs.find((def) => def.qualifiedName === 'choose');
|
|
const touch = parsed?.localDefs.find((def) => def.qualifiedName === 'touch');
|
|
const constructor = parsed?.localDefs.find(
|
|
(def) => def.type === 'Constructor' && def.qualifiedName === 'S',
|
|
);
|
|
|
|
expect(choose?.isDeleted).toBe(true);
|
|
expect(touch?.isDeleted).toBe(true);
|
|
expect(constructor?.isDeleted).not.toBe(true);
|
|
});
|
|
|
|
it('enriches call reference with arity', () => {
|
|
const src = 'void f() { foo(1, 2, 3); }';
|
|
const m = findMatch(src, (t) => t.includes('@reference.arity'));
|
|
expect(m).toBeDefined();
|
|
expect(m!['@reference.arity'].text).toBe('3');
|
|
});
|
|
});
|
|
|
|
// ── Static / anonymous namespace detection ──────────────────────────────────
|
|
|
|
describe('emitCppScopeCaptures — file-local linkage', () => {
|
|
beforeEach(() => {
|
|
clearFileLocalNames();
|
|
});
|
|
|
|
it('detects static function as file-local', () => {
|
|
emitCppScopeCaptures('static void helper() {}', 'test.cpp');
|
|
expect(isFileLocal('test.cpp', 'helper')).toBe(true);
|
|
});
|
|
|
|
it('does not mark non-static function as file-local', () => {
|
|
emitCppScopeCaptures('void helper() {}', 'test.cpp');
|
|
expect(isFileLocal('test.cpp', 'helper')).toBe(false);
|
|
});
|
|
|
|
it('detects function in anonymous namespace as file-local', () => {
|
|
emitCppScopeCaptures('namespace { void helper() {} }', 'test.cpp');
|
|
expect(isFileLocal('test.cpp', 'helper')).toBe(true);
|
|
});
|
|
|
|
it('does not mark function in named namespace as file-local', () => {
|
|
emitCppScopeCaptures('namespace foo { void helper() {} }', 'test.cpp');
|
|
expect(isFileLocal('test.cpp', 'helper')).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe('emitCppScopeCaptures — callable-flow passing modes (#2522 review, M5)', () => {
|
|
function modesFor(src: string): Record<string, string | undefined> {
|
|
const out: Record<string, string | undefined> = {};
|
|
for (const m of emitCppScopeCaptures(src, 'modes.cpp')) {
|
|
const binding = m['@callable-flow.binding']?.text;
|
|
if (m['@callable-flow.formal'] === undefined || binding === undefined) continue;
|
|
out[`${m['@callable-flow.owner']?.text}.${binding}`] = m['@callable-flow.passing-mode']?.text;
|
|
}
|
|
return out;
|
|
}
|
|
|
|
it('classifies by the outermost declarator chain, never nested parameter lists', () => {
|
|
const modes = modesFor(
|
|
[
|
|
'void reg(void (*cb)(int& out)) {}',
|
|
'void take(int& v) {}',
|
|
'void raw(int* p) {}',
|
|
'void val(int v) {}',
|
|
'void refptr(void (*&cb)(int)) {}',
|
|
].join('\n'),
|
|
);
|
|
expect(modes).toMatchObject({
|
|
// by-value pointer copy — the nested `int&` must not make it an alias
|
|
'reg.cb': 'pointer',
|
|
'take.v': 'reference',
|
|
'raw.p': 'pointer',
|
|
'val.v': 'value',
|
|
// reference-to-pointer IS an alias
|
|
'refptr.cb': 'reference',
|
|
});
|
|
});
|
|
});
|