mirror of
https://github.com/abhigyanpatwari/GitNexus.git
synced 2026-08-28 05:25:25 +00:00
aefb162280
Two findings, both negative, both worth recording so they are not re-litigated. NO RATCHET. The plan's R10 set a ZERO supported-shape drop target, and review correctly found it contradicts R12: a site whose normalized name matches more than one class MUST decline, a decline records a drop, and names like Service/Handler/Client collide routinely in large Go and Java codebases. The proposed repair was a ratchet — the count may not rise above the last measured value. Neither is needed. `measure.mjs --check` already asserts EXACT MATCH against the committed baseline, which is strictly stronger: the count cannot rise or fall without a deliberate `--update-baseline`, and that path prints an instruction to explain the movement. A ratchet would be a weakening, not a fix. The gate now also covers `callDropsByShape`, since the shape census joined the gated projection. STALE CI CLAIM. The gate's comment named `repos[0]` as a shape that "emits no edge AND no drop". That stopped being true in this series: Case 0's gate now accepts a minted receiver chain instead of testing the receiver's punctuation, so subscript receivers record a drop and are countable — 13 shapes moved INVISIBLE -> VISIBLE. `?.` and explicit type args are still invisible on some languages, so the shape arm still earns its keep, but the example was wrong and a wrong example in a gate comment is how the next person mis-reasons about what the gate covers. DEFERRED, explicitly: the `impact` risk-cutoff recalibration. Added edges push symbols toward the absolute cutoffs (`directCount >= 30`, `impacted.length >= 200`), so edits read HIGHER risk without being more dangerous. Real, but measuring it honestly needs a corpus large enough for those thresholds to bind, and the committed fixtures are nowhere near 200 impacted symbols. Recorded as owed rather than inventing a number from fixtures that cannot exercise it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| actions | ||
| claude-canary-runtime | ||
| gitnexus-review-runtime | ||
| ISSUE_TEMPLATE | ||
| prompts | ||
| scripts | ||
| workflows | ||
| actionlint.yaml | ||
| CODEOWNERS | ||
| dependabot.yml | ||
| FUNDING.yml | ||
| PULL_REQUEST_TEMPLATE.md | ||
| release-drafter.yml | ||
| release.yml | ||
| vendored-grammars.json | ||
| zizmor.yml | ||