mirror of
https://github.com/abhigyanpatwari/GitNexus.git
synced 2026-10-01 02:01:24 +00:00
* feat(storage): add configurable index storage and content retention tiers Rebase #3060 onto current origin/main. Keep GITNEXUS_STORAGE_PATH, GITNEXUS_STORAGE_ROOT, and GITNEXUS_CONTENT_RETENTION, and fold in main's FTS skip, embed-session, and help-text updates. Co-authored-by: Cursor <cursoragent@cursor.com> * Address PR review feedback (#3060) Keep legacy registry rows on the local storage fallback, resolve symlinks before the destructive-path guard, and align hook lookup with CLI branch slugs, branch-slot metadata, and longest-path match. Co-authored-by: Cursor <cursoragent@cursor.com> * Address PR review feedback (#3060) Only list swept upload directories after a successful removal so callers cannot treat a permission or transient rm failure as gone. Co-authored-by: Cursor <cursoragent@cursor.com> * Address PR review feedback (#3060) Document that getStoragePath may consult registered storage while this module still does not mutate the global registry. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(storage): close review findings for external indexes and retention Re-inspect ownership under the analyze lock, fail-closed when the registry file is missing, and keep skip-git hook discovery plus retention fields on HTTP/MCP list surfaces. /api/file stays 410 unless contentRetention is full. Co-authored-by: Cursor <cursoragent@cursor.com> * chore(autofix): apply prettier + eslint fixes via /autofix command * Address PR review feedback (#3060) Treat lock-only index dirs as empty, honor HTTP --force storage policy, and prefer registered plus branch-aware slots in hooks and augment. Co-authored-by: Cursor <cursoragent@cursor.com> * Address PR review feedback (#3060) Keep hook fallbacks inside the current worktree, compare foreign-local slots canonically, and make storage fixtures survive ownership validation. Co-authored-by: Cursor <cursoragent@cursor.com> * Fix macOS hook test expecting realpath'd registry paths. resolveHookRepo returns the written registry path, not a filesystem realpath, so the assertion must match that. * Address gitnexus-check warnings on hook install docs and slot tests. The Cursor troubleshooting list omitted registry-query.cjs, and the writable-slot test only checked that isDirectory exists instead of that the path is a directory. * Align the HTTP catalog source-scan with skippable resolveRepo validation. resolveRepo lists fresh repos with validate: options.validateStorage !== false so DELETE can skip prune; the test still required a literal validate: true. * Harden storage path sinks so CodeQL path-injection and ReDoS alerts clear. Contain every filesystem probe inside the resolved storage slot with the inline path.relative idiom, reject filesystem-root slots, and trim slot basenames in linear time. * Settle bridge stamps before writing so CI size/mtime matches stay stable. LadybugDB can still flush into bridge.lbug after close+rename; persist whole-millisecond mtimes and wait for consecutive stats to agree so a freshly written pair matches. * Type the settled bridge stat as fs.Stats so tsc does not see bigint. Awaited<ReturnType<typeof fsp.stat>> collapsed the bigint overload and broke prepare/typecheck on CI. * Keep the bridge mtime stamp exact so same-size swaps still fail the pair check. Co-authored-by: Cursor <cursoragent@cursor.com> * Wrap the bridge stamp predicate so prettier --check stays green. Co-authored-by: Cursor <cursoragent@cursor.com> * Require a quiet interval before stamping a settled bridge file. Co-authored-by: Cursor <cursoragent@cursor.com> * Reuse shared storage and settle helpers instead of local copies. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Gergo Magyar <gergomagyar0@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
150 lines
5.2 KiB
TypeScript
150 lines
5.2 KiB
TypeScript
import { afterEach, describe, expect, it } from 'vitest';
|
|
import {
|
|
applyContentRetention,
|
|
contentRetentionFromEnvironment,
|
|
contentRetentionFromMeta,
|
|
contentRetentionMismatch,
|
|
ftsProfileForContentRetention,
|
|
} from '../../src/core/content-retention.js';
|
|
import { getFtsIndexes } from '../../src/core/search/fts-schema.js';
|
|
import { buildTestGraph } from '../helpers/test-graph.js';
|
|
|
|
const savedRetention = process.env.GITNEXUS_CONTENT_RETENTION;
|
|
|
|
afterEach(() => {
|
|
if (savedRetention === undefined) delete process.env.GITNEXUS_CONTENT_RETENTION;
|
|
else process.env.GITNEXUS_CONTENT_RETENTION = savedRetention;
|
|
});
|
|
|
|
const contentGraph = () =>
|
|
buildTestGraph([
|
|
{
|
|
id: 'File:src/index.ts',
|
|
label: 'File',
|
|
name: 'index.ts',
|
|
filePath: 'src/index.ts',
|
|
extra: { content: 'const retainedFileText = true;' },
|
|
},
|
|
{
|
|
id: 'Function:src/index.ts:run:1',
|
|
label: 'Function',
|
|
name: 'run',
|
|
filePath: 'src/index.ts',
|
|
startLine: 1,
|
|
endLine: 3,
|
|
extra: {
|
|
content: 'function run() { return retainedSymbolText; }',
|
|
description: 'source comment',
|
|
},
|
|
},
|
|
{
|
|
id: 'BasicBlock:src/index.ts:run:1:0',
|
|
label: 'BasicBlock',
|
|
name: 'block',
|
|
filePath: 'src/index.ts',
|
|
startLine: 1,
|
|
endLine: 1,
|
|
extra: { text: 'return retainedBlockText;', description: 'block annotation' },
|
|
},
|
|
]);
|
|
|
|
describe('content retention profiles', () => {
|
|
it('uses full when the environment is absent or blank and rejects explicit invalid values', () => {
|
|
delete process.env.GITNEXUS_CONTENT_RETENTION;
|
|
expect(contentRetentionFromEnvironment()).toBe('full');
|
|
process.env.GITNEXUS_CONTENT_RETENTION = ' ';
|
|
expect(contentRetentionFromEnvironment()).toBe('full');
|
|
process.env.GITNEXUS_CONTENT_RETENTION = 'archive';
|
|
expect(() => contentRetentionFromEnvironment()).toThrow(/GITNEXUS_CONTENT_RETENTION/);
|
|
});
|
|
|
|
it('keeps every existing text field in the full profile', () => {
|
|
const graph = contentGraph();
|
|
applyContentRetention(graph, 'full');
|
|
|
|
expect(graph.getNode('File:src/index.ts')?.properties.content).toContain('retainedFileText');
|
|
expect(graph.getNode('Function:src/index.ts:run:1')?.properties.content).toContain(
|
|
'retainedSymbolText',
|
|
);
|
|
expect(graph.getNode('BasicBlock:src/index.ts:run:1:0')?.properties.text).toContain(
|
|
'retainedBlockText',
|
|
);
|
|
});
|
|
|
|
it('removes file text but preserves symbol spans in the symbol profile', () => {
|
|
const graph = contentGraph();
|
|
applyContentRetention(graph, 'symbol');
|
|
|
|
expect(graph.getNode('File:src/index.ts')?.properties.content).toBeUndefined();
|
|
expect(graph.getNode('Function:src/index.ts:run:1')?.properties.content).toContain(
|
|
'retainedSymbolText',
|
|
);
|
|
expect(graph.getNode('Function:src/index.ts:run:1')?.properties.description).toBe(
|
|
'source comment',
|
|
);
|
|
expect(graph.getNode('BasicBlock:src/index.ts:run:1:0')?.properties.text).toBeUndefined();
|
|
});
|
|
|
|
it('removes every source-derived text field in the none profile', () => {
|
|
const graph = contentGraph();
|
|
applyContentRetention(graph, 'none');
|
|
|
|
for (const node of graph.nodes) {
|
|
expect(node.properties.content).toBeUndefined();
|
|
expect(node.properties.description).toBeUndefined();
|
|
}
|
|
expect(graph.getNode('BasicBlock:src/index.ts:run:1:0')?.properties.text).toBeUndefined();
|
|
});
|
|
|
|
it('treats legacy metadata as full and forces a rebuild for changed retention metadata', () => {
|
|
expect(contentRetentionFromMeta({})).toBe('full');
|
|
expect(contentRetentionFromMeta({ contentRetention: 'corrupt' } as never)).toBe('none');
|
|
expect(contentRetentionMismatch({}, 'full')).toBe(false);
|
|
expect(contentRetentionMismatch({}, 'symbol')).toBe(true);
|
|
expect(contentRetentionMismatch({ contentRetention: 'full' }, 'full')).toBe(true);
|
|
expect(contentRetentionMismatch({ contentRetention: 'symbol' }, 'symbol')).toBe(true);
|
|
expect(
|
|
contentRetentionMismatch(
|
|
{
|
|
contentRetention: 'symbol',
|
|
contentRetentionSchemaVersion: 1,
|
|
ftsProfile: 'symbol-no-file-content',
|
|
},
|
|
'symbol',
|
|
),
|
|
).toBe(false);
|
|
expect(
|
|
contentRetentionMismatch(
|
|
{
|
|
contentRetention: 'symbol',
|
|
contentRetentionSchemaVersion: 2,
|
|
ftsProfile: 'symbol-no-file-content',
|
|
},
|
|
'symbol',
|
|
),
|
|
).toBe(true);
|
|
expect(
|
|
contentRetentionMismatch(
|
|
{
|
|
contentRetention: 'symbol',
|
|
contentRetentionSchemaVersion: 1,
|
|
},
|
|
'symbol',
|
|
),
|
|
).toBe(true);
|
|
});
|
|
|
|
it('selects FTS columns that never require discarded text', () => {
|
|
expect(ftsProfileForContentRetention('full')).toBe('full');
|
|
expect(ftsProfileForContentRetention('symbol')).toBe('symbol-no-file-content');
|
|
expect(ftsProfileForContentRetention('none')).toBe('name-only');
|
|
expect(getFtsIndexes('full').find((index) => index.table === 'File')?.properties).toEqual([
|
|
'name',
|
|
'content',
|
|
]);
|
|
expect(
|
|
getFtsIndexes('symbol-no-file-content').find((index) => index.table === 'File')?.properties,
|
|
).toEqual(['name']);
|
|
expect(getFtsIndexes('name-only').every((index) => index.properties.length === 1)).toBe(true);
|
|
});
|
|
});
|