mirror of
https://github.com/abhigyanpatwari/GitNexus.git
synced 2026-10-03 02:21:44 +00:00
* chore: ignore local Vercel link artifacts
Keep .vercel and env files out of the repo after a local preview link.
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix(web): repair citation chips, code panel line math, stale agent state
Audit findings in the web client, each verified against the source:
- RightPanel: citation chips ([[path:10-20]], [[Class:Foo]]) were wired to a
stub resolver that always returned null, so clicking any citation did
nothing. Expose resolveFilePath from useAppState and use it.
- CodeReferencesPanel: graph startLine/endLine are 1-based but were treated
as 0-based, so the highlighted range and scroll target were off by one
line; AI citation cards always rendered "code not available" because the
snippet loader was a stub. Fetch per-citation snippets via /api/file.
- useAppState: sendChatMessage read llmSettings.activeProvider outside its
deps (stale provider capabilities after switching provider);
initializeAgent trapped projectName at '' for callers without an override
(system prompt labelled the codebase "project"); the embeddings 409 dedup
matched a message the server never sends for same-repo jobs.
- tools.ts impact: for path targets every symbol defined in the file shares
the filePath, so the disambiguation always picked the first row and could
analyze an arbitrary symbol while reporting a file impact. Prefer the File
node.
- useSigma: the layout timeout called stop() but never kill(), leaking one
ForceAtlas2 Web Worker plus four graph listeners per completed layout.
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix(server): release repo lock on cancel, IPC-first worker cancel, route hardening
Audit findings in gitnexus/src, each verified against the source:
- analyze-launch: cancelJob marks the job failed before the worker exits,
so the exit handler's terminal early-return skipped releaseLockOnce and
the repo stayed locked ("Another job is already active") until restart.
Release on terminal exit and when forkWorker bails on a terminal job.
- analyze-job: cancellation now sends { type: 'cancel' } over IPC first and
signals only after a 15s grace. On Windows child.kill('SIGTERM') is a
forceful termination, so leading with it could kill the worker inside a
LadybugDB write. Mirrors core/auto-sync/analysis-worker-launch.
- api resolveRepo: a job that FAILED during the hold-queue wait fell through
to the { __timedOut } sentinel ("taking longer than expected") instead of
404; only /api/repo checked the sentinel, so graph/query/search/file/grep/
embed/delete crashed on entry.storagePath with a 500 after a 5 minute hang.
Return null on failed jobs and check the sentinel in every consumer.
- api processes/process/clusters/cluster: resolve ?repo= through the HTTP
resolver (documented policy on resolveRegisteredRepoEntry) and pass the
registered absolute path to the backend; add the standard rate limiter.
The raw param previously reached the MCP resolver, which runs a
cwd-relative realpathSync probe + registry refresh on a bare-name miss
and accepts unambiguous partial names.
- api body handling: Express 5 leaves req.body undefined without a JSON
content type, turning "Missing X" 400s into TypeError 500s; body-parser
4xx errors (malformed JSON, over-limit) were also reported as 500.
- /api/file: the lexical path.relative check cannot see symlinks; re-check
containment on realpath so a cloned repo containing evil -> /etc/passwd
cannot read outside the root.
- repo-manager unregisterRepo: used the lenient reader, so a transient read
error (EBUSY/EPERM racing another process's atomic rename) turned into
writing [] and deregistering every repo. Use the strict-if-present reader.
- clean --branch: compared registry paths with raw path.resolve instead of
the canonical registryPathEquals used everywhere else (macOS /private/var,
Windows short names / drive-letter case) and reported indexed branches as
not indexed.
Tests: cancelJob IPC-before-signal contract; /api/file symlink escape (403)
and in-repo symlink (200), skipped where the host cannot create symlinks.
Co-authored-by: Cursor <cursoragent@cursor.com>
* chore: keep example env files visible and ignore local Cursor config
.env* also hid gitnexus/.env.example and eval/.env.example. .vercel was already ignored. The web app's .cursor/ stays local, including its MCP file.
Co-authored-by: Cursor <cursoragent@cursor.com>
* Add realtime execution ops dashboard for Vercel monitoring.
Expose /api/ops snapshots over the local serve process and a ?view=ops SPA panel so analyze/embed jobs can be watched live from the hosted web UI.
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix: address gitnexus-check review on cite/embed/resolve paths
Pass req into resolveRepo for process/cluster routes, tighten same-repo embed 409 handling, guard empty citation paths, fix snippet retry races, and drop the lone-File ambiguity fallback.
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix(ops): harden CORS, redact paths, and bound ops streams
Restrict Vercel CORS to exact production hosts, omit raw repo paths/URLs from the unauthenticated ops feed, rate-limit and cap SSE connections, and fix dashboard SSE/poll edge cases.
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix(web): stabilize citation fetches and file impact matching
Retry cancelled snippet loads without duplicate in-flight reads, cap range-less citation downloads, and make impact file matching unique-suffix-aware with a synthetic File target when LIMIT drops the File node.
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix(web/ops): close gitnexus-check review threads on SSE and redaction
Cap citation reads, reconnect ops on applied server URL, skip SSE onError after abort, and strip URL query/fragment from public repoName.
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix(ops): abort SSE on poll fallback and harden repoName parsing
Prevent dual SSE+poll after a failed safety snapshot, skip overlapping poll ticks, ignore aborted streamSSE onError, and basename Windows drive-letter URLs so ops never leaks path segments.
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix(ops/web): close gitnexus-check threads on SSE budget and credential leak
Keep finite SSE retries across short 200s, strip backend URL userinfo before ?server=, and redact progress messages on the public ops feed.
Co-authored-by: Cursor <cursoragent@cursor.com>
* Address PR review feedback (#3348)
Restore 0-based GraphNode line math, redact public job poll/error fields, fix omit-?repo= 400, hold the analyze lock across cancel-during-settle, and restore the Vercel shared compile.
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix(cli): contain leftover-slot reclaim to the slot and keep --stale status honest
Preview and force now share one branches/ containment rule, nested junctions cannot walk a sibling index, and a mid-loop git failure no longer claims leftovers were not deleted after a successful rm.
Co-authored-by: Cursor <cursoragent@cursor.com>
* refactor(cli): share leftover-slot helpers without changing reclaim behavior
Pull the rolling I/O pool and owned-cwd storage lookup into one place so clean --stale/--branch and leftover listing stop restating the same ownership and concurrency paths.
Co-authored-by: Cursor <cursoragent@cursor.com>
* chore(autofix): apply prettier + eslint fixes via /autofix command
* Address PR review feedback (#3348)
Keep the omitted-repo snapshot instead of re-listing, stop citation and ops races, redact full public repo URLs, and restore fake timers in teardown.
Co-authored-by: Cursor <cursoragent@cursor.com>
* Address remaining PR review feedback (#3348)
Store graph node citation lines as 0-based offsets and correct the default-port origin comment.
Co-authored-by: Cursor <cursoragent@cursor.com>
* Address remaining PR review feedback (#3348)
Redact public SSE progress text, stop citation append retries from
cancelling in-flight reads, and keep the ops dashboard from showing a
stale snapshot or clearing a failed Connect.
Note: pre-existing failure in incremental-index-extension-dml-gate and other lbug/env unit tests not addressed by this PR.
Co-authored-by: Cursor <cursoragent@cursor.com>
* Address remaining PR review feedback (#3348)
Prune citation snippets when AI refs are cleared, and poll /api/ops at 2s so the fallback stays under the 60/min limit.
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix(ci): apply prettier class order for format check (#3348)
CI quality/format runs root-only npm ci, so prettier-plugin-tailwindcss
sorts scrollbar-thin without the web Tailwind catalog.
Co-authored-by: Cursor <cursoragent@cursor.com>
* Address PR review feedback (#3348)
- Require a unique suffix match for graph-backed citation paths so
ambiguous names like index.ts no longer open the first graph file.
Co-authored-by: Cursor <cursoragent@cursor.com>
* Address PR review feedback (#3348)
- Require a path-component boundary so unique citation suffixes cannot match filename substrings like myindex.ts
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix(server): redact filesystem paths in ops text
Unauthenticated /api/ops and poll replay worker errors. URLs were
scrubbed but home-directory and Windows paths still leaked.
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix(server): omit repoPath from public SSE frames
/api/ops lists job ids, so the unauthenticated progress stream
must not replay the analyzed filesystem path.
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix(web): treat embed lock 409 as a busy error
Analyze and embed share the same lock string. Mapping that 409 to
embedding hid an in-flight analyze as a successful embed start.
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix(web): bound impact File path suffix matches
Unbounded endsWith let lib/foo.ts select src/mylib/foo.ts. Require
an exact path or a unique /suffix, matching resolveUniqueIndexedPath.
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix(server): keep canceled analyze slot until exit
Marking failed before the worker exited let a second POST start
cloneOrPull against a LadybugDB file still being written.
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix(server): skip Windows SIGTERM on job dispose
child.kill('SIGTERM') is TerminateProcess there. Ask over IPC first
and leave the 15s grace timer to SIGKILL.
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix(server): let process routes skip the analyze hold
GET /api/processes and /api/clusters always waited up to 300s.
?awaitAnalysis=false fails fast; default still waits like /api/repo.
Co-authored-by: Cursor <cursoragent@cursor.com>
* test(web): cover public ops and analyze SSE user flows
Lock the unauthenticated dashboard and analyze complete/fail/cancel paths so a leaked repoPath, token, or home path cannot ship unnoticed.
Co-authored-by: Cursor <cursoragent@cursor.com>
* Address PR review feedback (#3348)
Keep caller cancel reasons over the worker's generic IPC, skip publish while cancel is pending, and redact scp-style remotes on the public ops feed.
Co-authored-by: Cursor <cursoragent@cursor.com>
* Address remaining PR review feedback (#3348)
Release the analyze slot when a worker fails to spawn, and omit branch refs from the unauthenticated ops feed.
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix(server): do not reuse an analyze job that is pending cancel
A dying same-repo job still occupies the single slot; 202-reuse would
attach a new client to a cancel in flight.
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix(server): hold the analyze lock until the worker exits after cancel
Cancel error IPC used to drop the repo lock while the child was still
checkpointing. Abort settle immediately on pending cancel so the slot
is not held for a 60s disk poll.
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix(server): redact known repo paths with spaces in public ops text
Known repoPath/repoUrl literals are replaced first so a clone dir with
spaces cannot leak past the whitespace-bounded path regex.
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix(server): return the live job on analyze and embed DELETE
Hard-coding failed made clients retry immediately and 409 while the
child still occupied the slot. resolveRepo now returns not-found as
soon as that job fails instead of waiting out the hold timeout.
Co-authored-by: Cursor <cursoragent@cursor.com>
* test(web): drive public analyze and ops through a live gitnexus serve
Spawn the real backend and observe requests instead of intercepting
them, so slot occupancy, redaction, and reconnect stay honest.
Co-authored-by: Cursor <cursoragent@cursor.com>
* refactor(web): reuse code-panel helpers and drop dead UI aliases
Citation fetches already had selectedNodeFileRange and snippetRepoKey;
the impact File suffix filter already handled exact paths.
Co-authored-by: Cursor <cursoragent@cursor.com>
* chore(autofix): apply prettier + eslint fixes via /autofix command
* Address PR review feedback (#3348)
- Skip createJob reuse after cancel IPC is consumed while the child remains
- Hold the repo lock until exit when complete IPC races a pending cancel
- Scrub full remote URLs before known repoUrl prefixes in public ops text
- Reject unique impact File suffix matches from a truncated LIMIT 10 page
- Make live e2e helpers bound probes, clean up failed startups, and wait out the cancel slot
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix(web): open live e2e pages on the Vite host CI actually bound
Absolute 127.0.0.1:5173 navigation refused on Actions because wait-on
and Vite use localhost (often ::1). Honor FRONTEND_URL when set, else
pick the first of localhost / 127.0.0.1 that answers.
Co-authored-by: Cursor <cursoragent@cursor.com>
* Address PR review feedback (#3348)
Hold the analyze lock until worker exit when cancel aborts settle, and assert GitLab failure chrome does not leak host or path.
Co-authored-by: Cursor <cursoragent@cursor.com>
* fix(web): keep live analyze e2e under the analyze rate limit
POST /api/analyze allows 10 requests per minute per IP. The slot-free
helper re-POSTed every 400ms while a cancelled worker was exiting, spent
that budget, and the lock test's hold request got 429 instead of 202.
- postAnalyze waits out a 429 using the RateLimit reset and retries
- slot polling backs off to 2s and leaves a small POST budget for callers
- the slot probe is a clone that fails before any worker fork, so the
probe itself no longer holds the slot after reporting failed
- the lock test holds the slot with a real local analyze
- token and GitLab tests wait for a free slot before posting from the UI
- request fetches carry a timeout; teardown signals the serve process group
- an empty FRONTEND_URL falls back to the default base URL
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* Address PR review feedback (#3348)
- ops view: a `?server=` link no longer auto-connects to another origin
while a deploy token is held; it prefills and waits for Connect
- analyze completion: a local-path run reconnects by the path this client
submitted, so duplicate basenames stay collision-safe without repoPath
on the public SSE frame
- stale slot cleanup: revalidate each nested directory (lstat + realpath)
right before readdir, so a mid-cleanup junction swap aborts instead of
walking an outside tree; list phases run sequentially so the slot-I/O
cap is global
- e2e: 429 backoff honours the caller deadline; the unreachable-backend
ops test navigates through the resolved frontend URL
- drop the unused `repo` member from the clean integration helper
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* feat(server): reconnect after analyze by an opaque repo id
Public job views and the SSE terminal frame no longer carry repoPath, and
repoName is not unique, so a post-analyze reconnect by name could load a
same-named sibling. The server now issues `repoId`: an HMAC of the
canonical registry path under a per-process random key. It is set on
complete jobs (ops view, analyze poll, SSE terminal frame) and matches
the new `id` on `GET /api/repos` entries. The web client resolves it to
the exact entry path on completion; unknown ids fall back to the name.
This covers URL clones and folder uploads, and replaces the local-path
only fallback.
With reconnect off the label, public `repoName` for a branch-pinned URL
clone is the repository name, not the `<repo>__<branch slug>` registry
name, so the requested branch stays off the unauthenticated feed.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* Address PR review feedback (#3348)
- stale slot cleanup: a descendant that vanishes before its unlink is
treated as removed instead of aborting the reclaim
- e2e teardown: escalate to SIGKILL on the process group when the live
backend ignores SIGTERM for 5s
- ops view: drop the dead initial value CodeQL flagged
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* Address PR review feedback (#3348)
- public redaction: a known repoPath now also consumes its descendant
tail, so `<repoPath>/src/secret.ts` becomes `[path]` instead of
`[path]/src/secret.ts`; a same-prefix sibling is left to the path scrub
- e2e: the cancel test waits for the analyze slot the previous failed
local-path job still holds; `fetchOps` carries the request timeout
- docs: SSE terminal payload and RepoAnalyzer `onComplete` describe
`repoId` resolution
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* Address PR review feedback (#3348)
- RepoAnalyzer: drop a completion that resolves after unmount, so a slow
/api/repos lookup cannot switch repos after the sheet was dismissed
- e2e: select the local-path input by test id (the placeholder differs on
Windows); the slot probe's job wait honours the caller's deadline
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* test(server): assert the public SSE terminal frame in analyze-api
The #2790 terminality tests still expected `repoPath` on the terminal
frame. This PR replaced it with the opaque `repoId`, so assert that shape
and that the analyzed path never appears in the stream.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* test(web): wait for the analyze slot between duplicate-repo setup runs
The server now keeps the single analyze slot until the worker exits, even
after its job reports complete. repo-path-identity posted the second
duplicate's analyze immediately and got 409 in CI. Use the shared
slot-aware POST, which also waits out a 429.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Gergő Magyar <gergomagyar@icloud.com>
Co-authored-by: Gergo Magyar <gergomagyar0@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
396 lines
14 KiB
TypeScript
396 lines
14 KiB
TypeScript
import { expect, type Page, type TestInfo } from '@playwright/test';
|
||
import { spawn, spawnSync, type ChildProcess } from 'node:child_process';
|
||
import fs from 'node:fs';
|
||
import net from 'node:net';
|
||
import os from 'node:os';
|
||
import path from 'node:path';
|
||
import { fileURLToPath } from 'node:url';
|
||
|
||
export const FRONTEND_URL = process.env.FRONTEND_URL || 'http://localhost:5173';
|
||
export const TOKEN_LEAK = 'ghs_secret_e2e_token';
|
||
export const MISSING_GITHUB = 'https://github.com/gitnexus-e2e-missing/no-such-repo';
|
||
|
||
const GALLERY_DIR = path.join(path.dirname(fileURLToPath(import.meta.url)), '..', 'screenshots');
|
||
const GITNEXUS_DIR = path.resolve(process.cwd(), '..', 'gitnexus');
|
||
const TSX_BIN = path.join(GITNEXUS_DIR, 'node_modules', '.bin', 'tsx');
|
||
const CLI_TS = path.join(GITNEXUS_DIR, 'src', 'cli', 'index.ts');
|
||
const CLI_DIST = path.join(GITNEXUS_DIR, 'dist', 'cli', 'index.js');
|
||
/** Per-request bound so a stalled connection cannot outlive a helper's deadline. */
|
||
const REQUEST_TIMEOUT_MS = 30_000;
|
||
/** POST /api/analyze allows 10/min per IP; 409 polling must not burn that budget. */
|
||
const SLOT_POLL_MS = 2_000;
|
||
|
||
const sleep = (ms: number) => new Promise((r) => setTimeout(r, ms));
|
||
|
||
export interface LiveBackend {
|
||
url: string;
|
||
port: number;
|
||
home: string;
|
||
fixtures: string;
|
||
child: ChildProcess;
|
||
log: string;
|
||
}
|
||
|
||
async function freePort(): Promise<number> {
|
||
return new Promise((resolve, reject) => {
|
||
const server = net.createServer();
|
||
server.listen(0, '127.0.0.1', () => {
|
||
const addr = server.address();
|
||
if (!addr || typeof addr === 'string') {
|
||
server.close();
|
||
reject(new Error('could not bind an ephemeral port'));
|
||
return;
|
||
}
|
||
const { port } = addr;
|
||
server.close((err) => (err ? reject(err) : resolve(port)));
|
||
});
|
||
server.on('error', reject);
|
||
});
|
||
}
|
||
|
||
function serveArgs(port: number): { cmd: string; args: string[] } {
|
||
if (fs.existsSync(TSX_BIN) && fs.existsSync(CLI_TS)) {
|
||
return { cmd: TSX_BIN, args: [CLI_TS, 'serve', '--port', String(port), '--host', '127.0.0.1'] };
|
||
}
|
||
if (fs.existsSync(CLI_DIST)) {
|
||
return {
|
||
cmd: process.execPath,
|
||
args: [CLI_DIST, 'serve', '--port', String(port), '--host', '127.0.0.1'],
|
||
};
|
||
}
|
||
throw new Error(`neither ${TSX_BIN} nor ${CLI_DIST} is available`);
|
||
}
|
||
|
||
/** Spawn an isolated `gitnexus serve` on 127.0.0.1. */
|
||
export async function startLiveBackend(): Promise<LiveBackend> {
|
||
const port = await freePort();
|
||
const home = fs.mkdtempSync(path.join(os.tmpdir(), 'gn-e2e-home-'));
|
||
const fixtures = fs.realpathSync(fs.mkdtempSync(path.join(os.tmpdir(), 'gn-e2e-fx-')));
|
||
const { cmd, args } = serveArgs(port);
|
||
const child = spawn(cmd, args, {
|
||
cwd: GITNEXUS_DIR,
|
||
env: {
|
||
...process.env,
|
||
GITNEXUS_HOME: home,
|
||
// Real parse workers — same override the CLI integration suite uses on
|
||
// a loaded host. A 5s default ready budget dies when two live specs
|
||
// cold-start worker pools at once.
|
||
GITNEXUS_WORKER_READY_TIMEOUT_MS: process.env.GITNEXUS_WORKER_READY_TIMEOUT_MS ?? '60000',
|
||
// Still a real pool; size 1 matches a two-file fixture and keeps two
|
||
// parallel live servers from spawning cores-1 workers each.
|
||
GITNEXUS_WORKER_POOL_SIZE: process.env.GITNEXUS_WORKER_POOL_SIZE ?? '1',
|
||
// Serve forks analyze with min(8192, 0.75×RAM) MB. Two parallel specs
|
||
// both getting an 8GB child is what produced `Worker crashed (code null)`.
|
||
GITNEXUS_SERVER_ANALYZE_HEAP_MB: process.env.GITNEXUS_SERVER_ANALYZE_HEAP_MB ?? '512',
|
||
GITNEXUS_WORKER_HEAP_MB: process.env.GITNEXUS_WORKER_HEAP_MB ?? '256',
|
||
// Ladybug FTS CREATE_FTS_INDEX SIGSEGVs on this host (CLI exit 139).
|
||
// Graph analyze still runs for real; keyword indexes are the only skip.
|
||
GITNEXUS_SKIP_FTS: process.env.GITNEXUS_SKIP_FTS ?? '1',
|
||
},
|
||
stdio: ['ignore', 'pipe', 'pipe'],
|
||
// Own process group so teardown also reaches the forked analyze worker.
|
||
detached: process.platform !== 'win32',
|
||
});
|
||
const backend: LiveBackend = {
|
||
url: `http://127.0.0.1:${port}`,
|
||
port,
|
||
home,
|
||
fixtures,
|
||
child,
|
||
log: '',
|
||
};
|
||
const captureLog = (chunk: Buffer) => {
|
||
backend.log = (backend.log + chunk.toString()).slice(-8_192);
|
||
};
|
||
child.stdout?.on('data', captureLog);
|
||
child.stderr?.on('data', captureLog);
|
||
|
||
let exited: number | null | undefined;
|
||
child.on('exit', (code) => {
|
||
exited = code;
|
||
});
|
||
|
||
const deadline = Date.now() + 45_000;
|
||
try {
|
||
for (;;) {
|
||
if (exited !== undefined) {
|
||
throw new Error(`live backend exited early (code ${exited}):\n${backend.log}`);
|
||
}
|
||
const ok = await fetch(`${backend.url}/api/health`, {
|
||
signal: AbortSignal.timeout(2_000),
|
||
})
|
||
.then((r) => r.ok)
|
||
.catch(() => false);
|
||
if (ok) return backend;
|
||
if (Date.now() > deadline) {
|
||
throw new Error(`live backend did not become ready on ${backend.url}:\n${backend.log}`);
|
||
}
|
||
await new Promise((r) => setTimeout(r, 250));
|
||
}
|
||
} catch (err) {
|
||
await stopLiveBackend(backend);
|
||
throw err;
|
||
}
|
||
}
|
||
|
||
export async function stopLiveBackend(backend: LiveBackend | undefined): Promise<void> {
|
||
if (!backend) return;
|
||
if (backend.child.exitCode === null && backend.child.signalCode === null) {
|
||
const exited = new Promise<void>((resolve) => backend.child.once('exit', () => resolve()));
|
||
const pid = backend.child.pid;
|
||
const signal = (sig: NodeJS.Signals) => {
|
||
if (pid !== undefined && process.platform !== 'win32') {
|
||
try {
|
||
process.kill(-pid, sig);
|
||
return;
|
||
} catch {
|
||
/* group gone or not a leader: fall back to the child */
|
||
}
|
||
}
|
||
backend.child.kill(sig);
|
||
};
|
||
signal('SIGTERM');
|
||
let timer: ReturnType<typeof setTimeout> | undefined;
|
||
try {
|
||
const exitedInTime = await Promise.race([
|
||
exited.then(() => true),
|
||
new Promise<boolean>((resolve) => {
|
||
timer = setTimeout(() => resolve(false), 5_000);
|
||
}),
|
||
]);
|
||
if (!exitedInTime) {
|
||
signal('SIGKILL');
|
||
await exited;
|
||
}
|
||
} finally {
|
||
if (timer !== undefined) clearTimeout(timer);
|
||
}
|
||
}
|
||
try {
|
||
fs.rmSync(backend.home, { recursive: true, force: true });
|
||
fs.rmSync(backend.fixtures, { recursive: true, force: true });
|
||
} catch {
|
||
/* best-effort */
|
||
}
|
||
}
|
||
|
||
export function writeTinyRepo(parent: string, name: string): string {
|
||
const dir = path.join(parent, name);
|
||
fs.mkdirSync(path.join(dir, 'src'), { recursive: true });
|
||
fs.writeFileSync(path.join(dir, 'README.md'), `# ${name}\n`);
|
||
fs.writeFileSync(path.join(dir, 'src', 'index.ts'), 'export const ready = true;\n');
|
||
const git = spawnSync('git', ['-C', dir, 'init', '-q', '-b', 'main'], { stdio: 'ignore' });
|
||
if (git.status === 0) {
|
||
spawnSync('git', ['-C', dir, 'config', 'user.email', 'e2e@gitnexus.test'], { stdio: 'ignore' });
|
||
spawnSync('git', ['-C', dir, 'config', 'user.name', 'e2e'], { stdio: 'ignore' });
|
||
spawnSync('git', ['-C', dir, 'add', '-A'], { stdio: 'ignore' });
|
||
spawnSync('git', ['-C', dir, 'commit', '-qm', 'init'], { stdio: 'ignore' });
|
||
}
|
||
return dir;
|
||
}
|
||
|
||
export interface AnalyzePostResult {
|
||
jobId: string;
|
||
status?: string;
|
||
error?: string;
|
||
http: number;
|
||
/** From the draft-7 `RateLimit` header; Infinity when absent. */
|
||
remaining: number;
|
||
resetMs: number;
|
||
}
|
||
|
||
/**
|
||
* POST /api/analyze; a 429 waits out the limiter window and retries, unless
|
||
* that wait would pass the caller's `deadline`.
|
||
*/
|
||
export async function postAnalyze(
|
||
backendUrl: string,
|
||
body: Record<string, unknown>,
|
||
deadline = Infinity,
|
||
): Promise<AnalyzePostResult> {
|
||
for (;;) {
|
||
const res = await fetch(`${backendUrl}/api/analyze`, {
|
||
method: 'POST',
|
||
headers: { 'Content-Type': 'application/json' },
|
||
body: JSON.stringify(body),
|
||
signal: AbortSignal.timeout(REQUEST_TIMEOUT_MS),
|
||
});
|
||
const rateLimit = res.headers.get('ratelimit') ?? '';
|
||
const resetMs = Number(/reset=(\d+)/.exec(rateLimit)?.[1] ?? 60) * 1000;
|
||
if (res.status === 429) {
|
||
await res.body?.cancel();
|
||
if (Date.now() + resetMs > deadline) {
|
||
throw new Error('analyze rate limit outlasts the caller deadline (HTTP 429)');
|
||
}
|
||
await sleep(resetMs + 250);
|
||
continue;
|
||
}
|
||
const json = (await res.json().catch(() => ({}))) as {
|
||
jobId?: string;
|
||
status?: string;
|
||
error?: string;
|
||
};
|
||
const remaining = /remaining=(\d+)/.exec(rateLimit)?.[1];
|
||
return {
|
||
jobId: json.jobId ?? '',
|
||
status: json.status,
|
||
error: json.error,
|
||
http: res.status,
|
||
remaining: remaining === undefined ? Infinity : Number(remaining),
|
||
resetMs,
|
||
};
|
||
}
|
||
}
|
||
|
||
/**
|
||
* Wait until the server will accept a new analyze, with at least `budget`
|
||
* POST /api/analyze calls left in the rate-limit window so the caller's own
|
||
* posts are not answered with 429.
|
||
*
|
||
* Probes with a clone that fails in-server before any worker fork: a `failed`
|
||
* probe leaves no child holding the slot. A local-path probe would fork a
|
||
* worker that outlives its own `failed` status and re-occupy the slot.
|
||
*/
|
||
export async function waitForAnalyzeSlotFree(
|
||
backendUrl: string,
|
||
timeoutMs = 90_000,
|
||
budget = 3,
|
||
): Promise<void> {
|
||
const deadline = Date.now() + timeoutMs;
|
||
for (;;) {
|
||
const probe = await postAnalyze(backendUrl, { url: MISSING_GITHUB }, deadline);
|
||
if (probe.http !== 409) {
|
||
if (probe.jobId) {
|
||
await waitForJob(backendUrl, probe.jobId, Math.max(0, deadline - Date.now()));
|
||
}
|
||
if (probe.remaining < budget) await sleep(probe.resetMs + 250);
|
||
return;
|
||
}
|
||
if (Date.now() > deadline) {
|
||
throw new Error(`analyze slot stayed busy: ${probe.error ?? 'HTTP 409'}`);
|
||
}
|
||
await sleep(SLOT_POLL_MS);
|
||
}
|
||
}
|
||
|
||
/** Single-slot: a failed job still occupies the slot until its child exits. */
|
||
export async function postAnalyzeWhenIdle(
|
||
backendUrl: string,
|
||
body: Record<string, unknown>,
|
||
timeoutMs = 60_000,
|
||
): Promise<AnalyzePostResult> {
|
||
const deadline = Date.now() + timeoutMs;
|
||
for (;;) {
|
||
const result = await postAnalyze(backendUrl, body, deadline);
|
||
if (result.http !== 409) return result;
|
||
if (Date.now() > deadline) {
|
||
throw new Error(`analyze slot stayed busy: ${result.error ?? 'HTTP 409'}`);
|
||
}
|
||
await sleep(SLOT_POLL_MS);
|
||
}
|
||
}
|
||
|
||
export async function waitForJob(
|
||
backendUrl: string,
|
||
jobId: string,
|
||
timeoutMs = 120_000,
|
||
): Promise<{ status: string; error?: string; repoName?: string }> {
|
||
const deadline = Date.now() + timeoutMs;
|
||
for (;;) {
|
||
const poll = await fetch(`${backendUrl}/api/analyze/${jobId}`, {
|
||
signal: AbortSignal.timeout(REQUEST_TIMEOUT_MS),
|
||
});
|
||
const job = (await poll.json()) as { status: string; error?: string; repoName?: string };
|
||
if (job.status === 'complete' || job.status === 'failed') {
|
||
return job;
|
||
}
|
||
if (Date.now() > deadline) throw new Error(`job ${jobId} timed out at ${job.status}`);
|
||
await sleep(400);
|
||
}
|
||
}
|
||
|
||
export async function fetchOps(backendUrl: string): Promise<Record<string, unknown>> {
|
||
const res = await fetch(`${backendUrl}/api/ops`, {
|
||
signal: AbortSignal.timeout(REQUEST_TIMEOUT_MS),
|
||
});
|
||
if (!res.ok) throw new Error(`GET /api/ops → HTTP ${res.status}`);
|
||
return (await res.json()) as Record<string, unknown>;
|
||
}
|
||
|
||
/** Point the app at this spec's live server before the first navigation. */
|
||
export async function bindBackend(page: Page, backendUrl: string): Promise<void> {
|
||
await page.addInitScript((url) => {
|
||
window.localStorage.setItem('gitnexus-backend-url', url);
|
||
}, backendUrl);
|
||
}
|
||
|
||
function frontendHref(base: string, pathAndQuery: string): string {
|
||
const normalized = base.endsWith('/') ? base : `${base}/`;
|
||
return new URL(pathAndQuery.replace(/^\//, ''), normalized).href;
|
||
}
|
||
|
||
const probeFrontend = (url: string) =>
|
||
fetch(url, { signal: AbortSignal.timeout(2_000) })
|
||
.then((r) => r.ok)
|
||
.catch(() => false);
|
||
|
||
/** Prefer an explicit FRONTEND_URL; otherwise the first listener CI or local Vite bound. */
|
||
async function resolveFrontendUrl(): Promise<string> {
|
||
if (process.env.FRONTEND_URL) return process.env.FRONTEND_URL;
|
||
for (const url of ['http://localhost:5173', 'http://127.0.0.1:5173']) {
|
||
if (await probeFrontend(url)) return url;
|
||
}
|
||
return FRONTEND_URL;
|
||
}
|
||
|
||
export async function openAnalyzeForm(page: Page): Promise<void> {
|
||
// Stay on the reachable frontend (localStorage already has the backend).
|
||
// `?server=` makes App auto-load the last graph and never show the form.
|
||
// DropZone on `/` shows onboarding (0 repos) or landing + analyze (N repos).
|
||
await page.goto(frontendHref(await resolveFrontendUrl(), '/'));
|
||
await expect(page.getByRole('tab', { name: 'GitHub URL' })).toBeVisible({ timeout: 30_000 });
|
||
}
|
||
|
||
export async function openOps(page: Page, backendUrl: string): Promise<void> {
|
||
await page.goto(
|
||
frontendHref(await resolveFrontendUrl(), `/?view=ops&server=${encodeURIComponent(backendUrl)}`),
|
||
);
|
||
await expect(page.locator('[data-testid="ops-dashboard"]')).toBeVisible({ timeout: 20_000 });
|
||
}
|
||
|
||
/** Empty string means go; otherwise a skip reason (or throw under E2E=1). */
|
||
export async function livePrereqSkipReason(): Promise<string> {
|
||
const frontendUp =
|
||
(await probeFrontend(FRONTEND_URL)) ||
|
||
(await probeFrontend('http://localhost:5173')) ||
|
||
(await probeFrontend('http://127.0.0.1:5173'));
|
||
const cliReady = fs.existsSync(TSX_BIN) || fs.existsSync(CLI_DIST);
|
||
if (process.env.E2E) {
|
||
if (!cliReady) throw new Error(`backend CLI missing (${CLI_TS} / ${CLI_DIST})`);
|
||
if (!frontendUp) throw new Error(`Vite dev server not available at ${FRONTEND_URL}`);
|
||
return '';
|
||
}
|
||
if (!frontendUp) return 'Vite dev server not available';
|
||
if (!cliReady) return 'backend CLI not available';
|
||
return '';
|
||
}
|
||
|
||
export async function capture(page: Page, testInfo: TestInfo, name: string): Promise<void> {
|
||
const out = testInfo.outputPath(`${name}.png`);
|
||
await page.screenshot({ path: out, fullPage: true });
|
||
fs.mkdirSync(GALLERY_DIR, { recursive: true });
|
||
const slug = testInfo.title
|
||
.toLowerCase()
|
||
.replace(/[^a-z0-9]+/g, '-')
|
||
.replace(/^-|-$/g, '')
|
||
.slice(0, 72);
|
||
fs.copyFileSync(out, path.join(GALLERY_DIR, `${slug}--${name}.png`));
|
||
}
|
||
|
||
export async function assertNoLeaks(page: Page, extra: string[] = []): Promise<void> {
|
||
const body = await page.locator('body').innerText();
|
||
for (const leak of [TOKEN_LEAK, 'ghs_secret', 'x-access-token', ...extra]) {
|
||
expect(body, `page must not show ${leak}`).not.toContain(leak);
|
||
}
|
||
expect(body).not.toMatch(/[A-Za-z]:\\Users\\/);
|
||
}
|