mirror of
https://github.com/abhigyanpatwari/GitNexus.git
synced 2026-11-04 07:27:20 +00:00
* fix(csharp): bind nullable field types for receiver resolution (#3498) A C# field written `User? repo;` got no type binding. Its type is a `nullable_type` node, and the field_declaration rules only matched identifier, generic_name and qualified_name types. Parameters, properties, method returns and foreach variables already have a nullable_type rule, so fields were the odd one out: the class scope had no binding for `repo`, and `this.repo.Save()` was dropped as receiver-unresolved. Add the missing field rule. interpretCsharpTypeBinding already strips the `?`, so the field binds `User`, as the property spelling does. Shape arm: csharp `decoratedFieldType` moves VISIBLE-GAP -> RESOLVES, with the edge on `User.Save`. No corpus fixture declares a nullable field, so the count arm and every other cell are unchanged, and the corpus edge (2838) and drop (192) sets match main exactly. Scope-capture fingerprints are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(csharp): preserve nullable field ownership * fix(csharp): refuse unowned nullable types * test(csharp): guard nullable-member fixture cleanup (#3664) Address nexus-check review on resolvers/csharp.test.ts:1471: skip the temp-root removal when mkdtempSync never ran, so a setup failure is not masked by a secondary rmSync(undefined) TypeError. Matches the guard in csharp-nullable-field-review.test.ts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(bench): scope nullable wrapper claim to what the code does (#3664) The ownership-controls note said the nullable-field marker preserves custom generic wrappers. Its only control, Custom.List<User>?, passes through the qualified-type refusal instead. State that unqualified wrappers keep the wrapper type (no native control yet) and that qualified spellings, custom wrappers included, stay unbound. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore: preserve C# integration notes * fix(csharp): preserve generic argument qualifiers Ignore comments when checking outer nullable-field qualification. Refs #3664 --------- Co-authored-by: Gergo Magyar <gergomagyar0@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
51 lines
1.8 KiB
TypeScript
51 lines
1.8 KiB
TypeScript
import { beforeAll, afterAll, describe, expect, it } from 'vitest';
|
|
import fs from 'node:fs';
|
|
import os from 'node:os';
|
|
import path from 'node:path';
|
|
import {
|
|
getRelationships,
|
|
runPipelineFromRepo,
|
|
writeFixtureRepo,
|
|
type PipelineResult,
|
|
} from './resolvers/helpers.js';
|
|
describe('nullable field receiver ownership', () => {
|
|
let root: string;
|
|
let result: PipelineResult;
|
|
beforeAll(async () => {
|
|
root = fs.mkdtempSync(path.join(os.tmpdir(), 'gn-csharp-nullable-'));
|
|
writeFixtureRepo(root, {
|
|
'Foreign.cs': `namespace ForeignCaller {
|
|
class User { public void Save() {} }
|
|
class Decoy { public void Save() {} }
|
|
class Host { External.User? repo; void ForeignCall(){this.repo.Save();} }
|
|
}`,
|
|
'Generic.cs': `namespace Custom { class List<T> {} }
|
|
namespace GenericCaller {
|
|
class User { public void Save() {} }
|
|
class Decoy { public void Save() {} }
|
|
class Host { Custom.List<User>? repo; void GenericCall(){this.repo.Save();} }
|
|
}`,
|
|
'Local.cs': `namespace LocalCaller {
|
|
class User { public void Save() {} }
|
|
class Host { User? repo; void LocalCall(){this.repo.Save();} }
|
|
}`,
|
|
});
|
|
result = await runPipelineFromRepo(root, () => {}, {});
|
|
}, 120000);
|
|
afterAll(() => {
|
|
if (root) fs.rmSync(root, { recursive: true, force: true });
|
|
});
|
|
const saves = (source: string) =>
|
|
getRelationships(result, 'CALLS')
|
|
.filter((e) => e.source === source && e.target === 'Save')
|
|
.map((e) => e.targetFilePath);
|
|
it('keeps a failed qualified nullable type unresolved', () => {
|
|
expect(saves('ForeignCall')).toEqual([]);
|
|
});
|
|
it('does not unwrap a nullable custom generic wrapper to its argument', () => {
|
|
expect(saves('GenericCall')).toEqual([]);
|
|
});
|
|
it('still binds the local nullable class field', () => {
|
|
expect(saves('LocalCall')).toEqual(['Local.cs']);
|
|
});
|
|
});
|