GitNexus/gitnexus/test/unit/group/python-workspace-extractor.test.ts
Christian C. Berclaz 7cce07b419
feat(group): workspace extractors for Node, Python, Go, Java, Elixir (#1260)
* feat(group): auto-discover Node/TS workspace cross-package contracts

Scan package.json dependencies and ES/CJS imports to find PascalCase
type exports crossing workspace package boundaries. Same pipeline as
Rust workspace extractor — emits GroupManifestLink[] with type:custom.

Supports: ES named imports, default imports, CommonJS destructured
require, scoped packages (@org/pkg), subpath imports, aliased imports.
Filters to PascalCase names only (types/classes, not functions).

* feat(group): auto-discover Python workspace cross-package contracts

Scan pyproject.toml/setup.py dependencies and `from <pkg> import`
statements to find PascalCase type exports crossing workspace package
boundaries. Handles hyphenated names (PEP 503 normalization),
submodule imports, aliased imports, and optional-dependencies.

* feat(group): auto-discover Go workspace cross-module contracts

Scan go.mod require/replace directives and Go source files for
exported PascalCase type usage (pkg.TypeName) crossing module
boundaries within a group. Handles block syntax, subpackage
imports, and local replace directives.

* refactor(group): extract workspace discovery orchestrator from sync

Move per-ecosystem workspace extractor calls into a single
discoverWorkspaceLinks() orchestrator. Reduces sync.ts from 295
to 264 lines and gives a clean extension point for adding
more ecosystem extractors.

* feat(group): auto-discover Java/Kotlin workspace cross-project contracts

Scan Maven pom.xml and Gradle build files for inter-project deps,
then match Java/Kotlin import statements against known group-internal
base packages. Supports Maven dependency blocks, Gradle coordinate
and project() dependencies, static imports, and Kotlin files.

* feat(group): auto-discover Elixir workspace cross-app contracts

Scan mix.exs deps and Elixir source files for alias directives and
direct module references crossing OTP app boundaries. Handles
umbrella deps (in_umbrella), git/path deps, grouped aliases
(alias MyApp.{ModA, ModB}), underscore-to-PascalCase app name
mapping, and collapses nested submodules to top-level contracts.

* fix(group): apply PR review fixes to all workspace extractors

Address review findings from PR #1256 across Node, Python, Go, Java,
and Elixir extractors:
- Replace hardcoded IGNORE sets with shared IgnoreService
  (shouldIgnorePath + loadIgnoreRules) to honor .gitnexusignore
- Qualify contract names with provider identifier to prevent
  contractId collisions across providers
- Warn and skip duplicate project/module/app names
- Update all test assertions for qualified contract format

* fix(workspace): address review findings and fix CI

- Fix prettier formatting on Rust workspace extractor files
- Fix double readRegistry() call in syncGroup (hoist to function scope)
- Fix console.warn spy leak in duplicate crate test (try/finally)
- Add sync-level integration tests: workspace_deps true/false gating,
  Rust and Node link discovery through syncGroup orchestrator (3 tests)

* style(workspace): fix Prettier formatting on all workspace extractors

* fix(workspace): strip qualified prefix in custom contract resolution, default workspace_deps to false

resolveSymbol for custom contracts now strips the "provider::" prefix
before querying graph nodes, so workspace-generated contracts like
"mathlex::Expression" correctly resolve to the "Expression" symbol.

Change workspace_deps default from true to false for safe rollout —
existing groups won't silently gain 6-ecosystem scans on upgrade.

* fix(workspace): address medium review findings from PR #1260

- Elixir: strip comment lines before direct module reference scan to
  prevent false positives from commented-out module references
- Go: use full module path for contract naming to avoid basename
  collisions between repos with identical last path segments
- Sync tests: replace toBeGreaterThanOrEqual with exact toHaveLength
  assertions per DoD §2.7
- Add workspace_deps: false to makeConfig helper for type correctness
- Add Elixir test proving comment-only references do not emit links

* fix(workspace): address second-round medium review findings

- Go: add test asserting aliased imports produce 0 links, guarding the
  V1 false-negative boundary at the assertion level
- Elixir: add code comment documenting that contracts use full module
  names without appName:: prefix and that resolveSymbol resolution
  depends on Elixir indexer storing fully-qualified names

* fix(workspace): eliminate regex backtracking in pyproject.toml parser

CodeQL flagged exponential backtracking in the [project] name regex.
Replace [^\[]*?\n (ambiguous lazy quantifier) with [^\n\[]*\n (atomic
per-line match that still stops at section boundaries).

* fix(test): use mkdtempSync for secure temp dir creation

CodeQL flagged insecure temporary file creation (High) in sync.test.ts.
Replace path.join(os.tmpdir(), predictable-name) + mkdirSync with
fs.mkdtempSync which creates temp dirs atomically with random suffix,
preventing symlink race conditions.
2026-05-04 09:43:21 +01:00

241 lines
8.2 KiB
TypeScript

import { describe, it, expect, beforeEach, afterEach } from 'vitest';
import fs from 'node:fs/promises';
import path from 'node:path';
import os from 'node:os';
import { extractPythonWorkspaceLinks } from '../../../src/core/group/extractors/python-workspace-extractor.js';
describe('PythonWorkspaceExtractor', () => {
let tmpDir: string;
beforeEach(async () => {
tmpDir = await fs.mkdtemp(path.join(os.tmpdir(), 'gitnexus-py-ws-'));
});
afterEach(async () => {
await fs.rm(tmpDir, { recursive: true, force: true });
});
async function writeFile(relPath: string, content: string) {
const absPath = path.join(tmpDir, relPath);
await fs.mkdir(path.dirname(absPath), { recursive: true });
await fs.writeFile(absPath, content, 'utf-8');
}
it('discovers cross-package imports via pyproject.toml', async () => {
await writeFile(
'models/pyproject.toml',
'[project]\nname = "shared-models"\nversion = "0.1.0"\ndependencies = []\n',
);
await writeFile('models/shared_models/__init__.py', 'class Schema: pass\n');
await writeFile(
'api/pyproject.toml',
'[project]\nname = "api-server"\nversion = "0.1.0"\ndependencies = [\n "shared-models>=0.1.0",\n]\n',
);
await writeFile('api/api_server/main.py', 'from shared_models import Schema\n');
const repos = { models: 'shared-models', api: 'api-server' };
const repoPaths = new Map([
['models', path.join(tmpDir, 'models')],
['api', path.join(tmpDir, 'api')],
]);
const result = await extractPythonWorkspaceLinks(repos, repoPaths);
expect(result.links).toHaveLength(1);
expect(result.links[0]).toEqual({
from: 'models',
to: 'api',
type: 'custom',
contract: 'shared-models::Schema',
role: 'provider',
});
});
it('discovers imports via setup.py', async () => {
await writeFile(
'core/setup.py',
"from setuptools import setup\nsetup(name='mycore', version='1.0', install_requires=[])\n",
);
await writeFile('core/mycore/__init__.py', 'class Engine: pass\n');
await writeFile(
'app/setup.py',
"from setuptools import setup\nsetup(name='myapp', version='1.0', install_requires=['mycore>=1.0'])\n",
);
await writeFile('app/myapp/run.py', 'from mycore import Engine\n');
const repos = { core: 'mycore', app: 'myapp' };
const repoPaths = new Map([
['core', path.join(tmpDir, 'core')],
['app', path.join(tmpDir, 'app')],
]);
const result = await extractPythonWorkspaceLinks(repos, repoPaths);
expect(result.links).toHaveLength(1);
expect(result.links[0].contract).toBe('mycore::Engine');
});
it('handles hyphenated package names (normalized to underscore in imports)', async () => {
await writeFile(
'lib/pyproject.toml',
'[project]\nname = "my-utils"\nversion = "0.1.0"\ndependencies = []\n',
);
await writeFile('lib/my_utils/__init__.py', 'class Helper: pass\n');
await writeFile(
'svc/pyproject.toml',
'[project]\nname = "my-service"\nversion = "0.1.0"\ndependencies = [\n "my-utils",\n]\n',
);
await writeFile('svc/my_service/main.py', 'from my_utils import Helper\n');
const repos = { lib: 'my-utils', svc: 'my-service' };
const repoPaths = new Map([
['lib', path.join(tmpDir, 'lib')],
['svc', path.join(tmpDir, 'svc')],
]);
const result = await extractPythonWorkspaceLinks(repos, repoPaths);
expect(result.links).toHaveLength(1);
expect(result.links[0].contract).toBe('my-utils::Helper');
});
it('handles submodule imports (from pkg.sub import Class)', async () => {
await writeFile(
'lib/pyproject.toml',
'[project]\nname = "datalib"\nversion = "0.1.0"\ndependencies = []\n',
);
await writeFile('lib/datalib/models.py', 'class Record: pass\n');
await writeFile(
'app/pyproject.toml',
'[project]\nname = "myapp"\nversion = "0.1.0"\ndependencies = [\n "datalib",\n]\n',
);
await writeFile('app/myapp/main.py', 'from datalib.models import Record\n');
const repos = { lib: 'datalib', app: 'myapp' };
const repoPaths = new Map([
['lib', path.join(tmpDir, 'lib')],
['app', path.join(tmpDir, 'app')],
]);
const result = await extractPythonWorkspaceLinks(repos, repoPaths);
expect(result.links).toHaveLength(1);
expect(result.links[0].contract).toBe('datalib::Record');
});
it('ignores snake_case imports (functions, not types)', async () => {
await writeFile(
'lib/pyproject.toml',
'[project]\nname = "utils"\nversion = "0.1.0"\ndependencies = []\n',
);
await writeFile('lib/utils/__init__.py', 'def helper(): pass\nclass Config: pass\n');
await writeFile(
'app/pyproject.toml',
'[project]\nname = "myapp"\nversion = "0.1.0"\ndependencies = [\n "utils",\n]\n',
);
await writeFile('app/myapp/main.py', 'from utils import helper, Config\n');
const repos = { lib: 'utils', app: 'myapp' };
const repoPaths = new Map([
['lib', path.join(tmpDir, 'lib')],
['app', path.join(tmpDir, 'app')],
]);
const result = await extractPythonWorkspaceLinks(repos, repoPaths);
expect(result.links).toHaveLength(1);
expect(result.links[0].contract).toBe('utils::Config');
});
it('skips repos without Python manifest', async () => {
await writeFile('js-app/package.json', '{"name": "js-app"}');
const repos = { app: 'js-app' };
const repoPaths = new Map([['app', path.join(tmpDir, 'js-app')]]);
const result = await extractPythonWorkspaceLinks(repos, repoPaths);
expect(result.links).toHaveLength(0);
expect(result.discoveredPackages.size).toBe(0);
});
it('deduplicates identical imports from multiple files', async () => {
await writeFile(
'lib/pyproject.toml',
'[project]\nname = "shared"\nversion = "0.1.0"\ndependencies = []\n',
);
await writeFile('lib/shared/__init__.py', 'class Config: pass\n');
await writeFile(
'app/pyproject.toml',
'[project]\nname = "myapp"\nversion = "0.1.0"\ndependencies = [\n "shared",\n]\n',
);
await writeFile('app/myapp/a.py', 'from shared import Config\n');
await writeFile('app/myapp/b.py', 'from shared import Config\n');
const repos = { lib: 'shared', app: 'myapp' };
const repoPaths = new Map([
['lib', path.join(tmpDir, 'lib')],
['app', path.join(tmpDir, 'app')],
]);
const result = await extractPythonWorkspaceLinks(repos, repoPaths);
expect(result.links).toHaveLength(1);
});
it('handles aliased imports (from pkg import Foo as Bar)', async () => {
await writeFile(
'lib/pyproject.toml',
'[project]\nname = "models"\nversion = "0.1.0"\ndependencies = []\n',
);
await writeFile('lib/models/__init__.py', 'class Entity: pass\n');
await writeFile(
'app/pyproject.toml',
'[project]\nname = "myapp"\nversion = "0.1.0"\ndependencies = [\n "models",\n]\n',
);
await writeFile('app/myapp/main.py', 'from models import Entity as BaseEntity\n');
const repos = { lib: 'models', app: 'myapp' };
const repoPaths = new Map([
['lib', path.join(tmpDir, 'lib')],
['app', path.join(tmpDir, 'app')],
]);
const result = await extractPythonWorkspaceLinks(repos, repoPaths);
expect(result.links).toHaveLength(1);
expect(result.links[0].contract).toBe('models::Entity');
});
it('reads optional-dependencies from pyproject.toml', async () => {
await writeFile(
'lib/pyproject.toml',
'[project]\nname = "extras"\nversion = "0.1.0"\ndependencies = []\n',
);
await writeFile('lib/extras/__init__.py', 'class Plugin: pass\n');
await writeFile(
'app/pyproject.toml',
'[project]\nname = "myapp"\nversion = "0.1.0"\ndependencies = []\n\n[project.optional-dependencies]\ndev = [\n "extras>=0.1",\n]\n',
);
await writeFile('app/myapp/main.py', 'from extras import Plugin\n');
const repos = { lib: 'extras', app: 'myapp' };
const repoPaths = new Map([
['lib', path.join(tmpDir, 'lib')],
['app', path.join(tmpDir, 'app')],
]);
const result = await extractPythonWorkspaceLinks(repos, repoPaths);
expect(result.links).toHaveLength(1);
expect(result.links[0].contract).toBe('extras::Plugin');
});
});