GitNexus/gitnexus/test/unit/group/node-workspace-extractor.test.ts
Christian C. Berclaz 7cce07b419
feat(group): workspace extractors for Node, Python, Go, Java, Elixir (#1260)
* feat(group): auto-discover Node/TS workspace cross-package contracts

Scan package.json dependencies and ES/CJS imports to find PascalCase
type exports crossing workspace package boundaries. Same pipeline as
Rust workspace extractor — emits GroupManifestLink[] with type:custom.

Supports: ES named imports, default imports, CommonJS destructured
require, scoped packages (@org/pkg), subpath imports, aliased imports.
Filters to PascalCase names only (types/classes, not functions).

* feat(group): auto-discover Python workspace cross-package contracts

Scan pyproject.toml/setup.py dependencies and `from <pkg> import`
statements to find PascalCase type exports crossing workspace package
boundaries. Handles hyphenated names (PEP 503 normalization),
submodule imports, aliased imports, and optional-dependencies.

* feat(group): auto-discover Go workspace cross-module contracts

Scan go.mod require/replace directives and Go source files for
exported PascalCase type usage (pkg.TypeName) crossing module
boundaries within a group. Handles block syntax, subpackage
imports, and local replace directives.

* refactor(group): extract workspace discovery orchestrator from sync

Move per-ecosystem workspace extractor calls into a single
discoverWorkspaceLinks() orchestrator. Reduces sync.ts from 295
to 264 lines and gives a clean extension point for adding
more ecosystem extractors.

* feat(group): auto-discover Java/Kotlin workspace cross-project contracts

Scan Maven pom.xml and Gradle build files for inter-project deps,
then match Java/Kotlin import statements against known group-internal
base packages. Supports Maven dependency blocks, Gradle coordinate
and project() dependencies, static imports, and Kotlin files.

* feat(group): auto-discover Elixir workspace cross-app contracts

Scan mix.exs deps and Elixir source files for alias directives and
direct module references crossing OTP app boundaries. Handles
umbrella deps (in_umbrella), git/path deps, grouped aliases
(alias MyApp.{ModA, ModB}), underscore-to-PascalCase app name
mapping, and collapses nested submodules to top-level contracts.

* fix(group): apply PR review fixes to all workspace extractors

Address review findings from PR #1256 across Node, Python, Go, Java,
and Elixir extractors:
- Replace hardcoded IGNORE sets with shared IgnoreService
  (shouldIgnorePath + loadIgnoreRules) to honor .gitnexusignore
- Qualify contract names with provider identifier to prevent
  contractId collisions across providers
- Warn and skip duplicate project/module/app names
- Update all test assertions for qualified contract format

* fix(workspace): address review findings and fix CI

- Fix prettier formatting on Rust workspace extractor files
- Fix double readRegistry() call in syncGroup (hoist to function scope)
- Fix console.warn spy leak in duplicate crate test (try/finally)
- Add sync-level integration tests: workspace_deps true/false gating,
  Rust and Node link discovery through syncGroup orchestrator (3 tests)

* style(workspace): fix Prettier formatting on all workspace extractors

* fix(workspace): strip qualified prefix in custom contract resolution, default workspace_deps to false

resolveSymbol for custom contracts now strips the "provider::" prefix
before querying graph nodes, so workspace-generated contracts like
"mathlex::Expression" correctly resolve to the "Expression" symbol.

Change workspace_deps default from true to false for safe rollout —
existing groups won't silently gain 6-ecosystem scans on upgrade.

* fix(workspace): address medium review findings from PR #1260

- Elixir: strip comment lines before direct module reference scan to
  prevent false positives from commented-out module references
- Go: use full module path for contract naming to avoid basename
  collisions between repos with identical last path segments
- Sync tests: replace toBeGreaterThanOrEqual with exact toHaveLength
  assertions per DoD §2.7
- Add workspace_deps: false to makeConfig helper for type correctness
- Add Elixir test proving comment-only references do not emit links

* fix(workspace): address second-round medium review findings

- Go: add test asserting aliased imports produce 0 links, guarding the
  V1 false-negative boundary at the assertion level
- Elixir: add code comment documenting that contracts use full module
  names without appName:: prefix and that resolveSymbol resolution
  depends on Elixir indexer storing fully-qualified names

* fix(workspace): eliminate regex backtracking in pyproject.toml parser

CodeQL flagged exponential backtracking in the [project] name regex.
Replace [^\[]*?\n (ambiguous lazy quantifier) with [^\n\[]*\n (atomic
per-line match that still stops at section boundaries).

* fix(test): use mkdtempSync for secure temp dir creation

CodeQL flagged insecure temporary file creation (High) in sync.test.ts.
Replace path.join(os.tmpdir(), predictable-name) + mkdirSync with
fs.mkdtempSync which creates temp dirs atomically with random suffix,
preventing symlink race conditions.
2026-05-04 09:43:21 +01:00

285 lines
9.1 KiB
TypeScript

import { describe, it, expect, beforeEach, afterEach } from 'vitest';
import fs from 'node:fs/promises';
import path from 'node:path';
import os from 'node:os';
import { extractNodeWorkspaceLinks } from '../../../src/core/group/extractors/node-workspace-extractor.js';
describe('NodeWorkspaceExtractor', () => {
let tmpDir: string;
beforeEach(async () => {
tmpDir = await fs.mkdtemp(path.join(os.tmpdir(), 'gitnexus-node-ws-'));
});
afterEach(async () => {
await fs.rm(tmpDir, { recursive: true, force: true });
});
async function writeFile(relPath: string, content: string) {
const absPath = path.join(tmpDir, relPath);
await fs.mkdir(path.dirname(absPath), { recursive: true });
await fs.writeFile(absPath, content, 'utf-8');
}
it('discovers cross-package ES imports', async () => {
await writeFile(
'pkg-a/package.json',
JSON.stringify({ name: '@myorg/shared', version: '1.0.0' }),
);
await writeFile('pkg-a/src/index.ts', 'export class Config {}\nexport class Logger {}\n');
await writeFile(
'pkg-b/package.json',
JSON.stringify({
name: '@myorg/api',
version: '1.0.0',
dependencies: { '@myorg/shared': 'workspace:*' },
}),
);
await writeFile(
'pkg-b/src/server.ts',
"import { Config } from '@myorg/shared';\nconst c = new Config();\n",
);
const repos = {
'libs/shared': '@myorg/shared',
'services/api': '@myorg/api',
};
const repoPaths = new Map([
['libs/shared', path.join(tmpDir, 'pkg-a')],
['services/api', path.join(tmpDir, 'pkg-b')],
]);
const result = await extractNodeWorkspaceLinks(repos, repoPaths);
expect(result.links).toHaveLength(1);
expect(result.links[0]).toEqual({
from: 'libs/shared',
to: 'services/api',
type: 'custom',
contract: '@myorg/shared::Config',
role: 'provider',
});
});
it('handles default imports (PascalCase)', async () => {
await writeFile(
'ui-lib/package.json',
JSON.stringify({ name: 'ui-components', version: '1.0.0' }),
);
await writeFile('ui-lib/src/index.ts', 'export default class Button {}\n');
await writeFile(
'app/package.json',
JSON.stringify({
name: 'web-app',
version: '1.0.0',
dependencies: { 'ui-components': '^1.0.0' },
}),
);
await writeFile(
'app/src/page.tsx',
"import Button from 'ui-components';\nexport default function Page() { return <Button />; }\n",
);
const repos = { 'libs/ui': 'ui-components', 'apps/web': 'web-app' };
const repoPaths = new Map([
['libs/ui', path.join(tmpDir, 'ui-lib')],
['apps/web', path.join(tmpDir, 'app')],
]);
const result = await extractNodeWorkspaceLinks(repos, repoPaths);
expect(result.links).toHaveLength(1);
expect(result.links[0].contract).toBe('ui-components::Button');
});
it('handles CommonJS destructured require', async () => {
await writeFile('lib/package.json', JSON.stringify({ name: 'auth-lib', version: '1.0.0' }));
await writeFile('lib/src/index.js', 'module.exports = { Authenticator: class {} };\n');
await writeFile(
'svc/package.json',
JSON.stringify({
name: 'api-svc',
version: '1.0.0',
dependencies: { 'auth-lib': 'workspace:*' },
}),
);
await writeFile('svc/src/handler.js', "const { Authenticator } = require('auth-lib');\n");
const repos = { lib: 'auth-lib', svc: 'api-svc' };
const repoPaths = new Map([
['lib', path.join(tmpDir, 'lib')],
['svc', path.join(tmpDir, 'svc')],
]);
const result = await extractNodeWorkspaceLinks(repos, repoPaths);
expect(result.links).toHaveLength(1);
expect(result.links[0].contract).toBe('auth-lib::Authenticator');
});
it('handles scoped package imports with subpaths', async () => {
await writeFile('core/package.json', JSON.stringify({ name: '@acme/core', version: '2.0.0' }));
await writeFile('core/src/models.ts', 'export class User {}\n');
await writeFile(
'web/package.json',
JSON.stringify({
name: '@acme/web',
version: '1.0.0',
dependencies: { '@acme/core': 'workspace:*' },
}),
);
await writeFile('web/src/routes.ts', "import { User } from '@acme/core/models';\n");
const repos = { core: '@acme/core', web: '@acme/web' };
const repoPaths = new Map([
['core', path.join(tmpDir, 'core')],
['web', path.join(tmpDir, 'web')],
]);
const result = await extractNodeWorkspaceLinks(repos, repoPaths);
expect(result.links).toHaveLength(1);
expect(result.links[0].contract).toBe('@acme/core::User');
});
it('ignores camelCase/snake_case imports (non-type exports)', async () => {
await writeFile('lib/package.json', JSON.stringify({ name: 'utils', version: '1.0.0' }));
await writeFile('lib/src/index.ts', 'export function helper() {}\nexport class Formatter {}\n');
await writeFile(
'app/package.json',
JSON.stringify({
name: 'myapp',
version: '1.0.0',
dependencies: { utils: 'workspace:*' },
}),
);
await writeFile('app/src/main.ts', "import { helper, Formatter } from 'utils';\n");
const repos = { lib: 'utils', app: 'myapp' };
const repoPaths = new Map([
['lib', path.join(tmpDir, 'lib')],
['app', path.join(tmpDir, 'app')],
]);
const result = await extractNodeWorkspaceLinks(repos, repoPaths);
expect(result.links).toHaveLength(1);
expect(result.links[0].contract).toBe('utils::Formatter');
});
it('skips repos without package.json', async () => {
await writeFile('rust-app/Cargo.toml', '[package]\nname = "rapp"\nversion = "0.1.0"\n');
await writeFile('rust-app/src/main.rs', 'fn main() {}\n');
const repos = { app: 'rapp' };
const repoPaths = new Map([['app', path.join(tmpDir, 'rust-app')]]);
const result = await extractNodeWorkspaceLinks(repos, repoPaths);
expect(result.links).toHaveLength(0);
expect(result.discoveredPackages.size).toBe(0);
});
it('deduplicates identical imports from multiple files', async () => {
await writeFile('lib/package.json', JSON.stringify({ name: 'shared', version: '1.0.0' }));
await writeFile('lib/src/index.ts', 'export class Config {}\n');
await writeFile(
'app/package.json',
JSON.stringify({
name: 'myapp',
version: '1.0.0',
dependencies: { shared: 'workspace:*' },
}),
);
await writeFile('app/src/a.ts', "import { Config } from 'shared';\n");
await writeFile('app/src/b.ts', "import { Config } from 'shared';\n");
const repos = { lib: 'shared', app: 'myapp' };
const repoPaths = new Map([
['lib', path.join(tmpDir, 'lib')],
['app', path.join(tmpDir, 'app')],
]);
const result = await extractNodeWorkspaceLinks(repos, repoPaths);
expect(result.links).toHaveLength(1);
});
it('handles aliased imports (import { Foo as Bar })', async () => {
await writeFile('lib/package.json', JSON.stringify({ name: 'models', version: '1.0.0' }));
await writeFile('lib/src/index.ts', 'export class Entity {}\n');
await writeFile(
'app/package.json',
JSON.stringify({
name: 'myapp',
version: '1.0.0',
dependencies: { models: 'workspace:*' },
}),
);
await writeFile('app/src/main.ts', "import { Entity as BaseEntity } from 'models';\n");
const repos = { lib: 'models', app: 'myapp' };
const repoPaths = new Map([
['lib', path.join(tmpDir, 'lib')],
['app', path.join(tmpDir, 'app')],
]);
const result = await extractNodeWorkspaceLinks(repos, repoPaths);
expect(result.links).toHaveLength(1);
expect(result.links[0].contract).toBe('models::Entity');
});
it('handles multiple packages importing from the same provider', async () => {
await writeFile(
'shared/package.json',
JSON.stringify({ name: '@org/shared', version: '1.0.0' }),
);
await writeFile('shared/src/index.ts', 'export class Schema {}\n');
await writeFile(
'api/package.json',
JSON.stringify({
name: '@org/api',
version: '1.0.0',
dependencies: { '@org/shared': 'workspace:*' },
}),
);
await writeFile('api/src/index.ts', "import { Schema } from '@org/shared';\n");
await writeFile(
'worker/package.json',
JSON.stringify({
name: '@org/worker',
version: '1.0.0',
dependencies: { '@org/shared': 'workspace:*' },
}),
);
await writeFile('worker/src/index.ts', "import { Schema } from '@org/shared';\n");
const repos = {
libs: '@org/shared',
api: '@org/api',
worker: '@org/worker',
};
const repoPaths = new Map([
['libs', path.join(tmpDir, 'shared')],
['api', path.join(tmpDir, 'api')],
['worker', path.join(tmpDir, 'worker')],
]);
const result = await extractNodeWorkspaceLinks(repos, repoPaths);
expect(result.links).toHaveLength(2);
const targets = result.links.map((l) => l.to).sort();
expect(targets).toEqual(['api', 'worker']);
expect(result.links.every((l) => l.contract === '@org/shared::Schema')).toBe(true);
});
});