mirror of
https://github.com/abhigyanpatwari/GitNexus.git
synced 2026-09-07 08:26:11 +00:00
`upsertGitNexusSection` in ai-context.ts uses `indexOf` to locate the
bounds of the GitNexus section in CLAUDE.md / AGENTS.md before
replacement. `indexOf` matches the first occurrence of the marker
anywhere in the file, including inline prose references in backtick-
quoted fragments mid-sentence.
The shipped CLAUDE.md contains exactly such a reference ("See the
`<!-- gitnexus:start --> … <!-- gitnexus:end -->` block in AGENTS.md
for the canonical MCP tools..."). Running `gitnexus analyze` on a
fresh install matches those inline markers as section delimiters and
replaces the prose between them with the full ~100-line injected
block, breaking the backtick and corrupting markdown for every user.
Fix: new private `findSectionMarkerIndex` helper that only matches
markers occupying their own line — preceded by `\n` or start-of-file,
followed by `\n` / `\r` (CRLF files) / end-of-file. `\r` is explicit
so CRLF-terminated sections on Windows (core.autocrlf = true) still
match. The generator always emits markers alone on their line, so
every legitimate section continues to update in place; only inline
prose references now fall through to the append branch, which leaves
existing content untouched.
Two new unit tests:
- #1041 regression — seed CLAUDE.md with the shipped inline prose
line, run analyze twice, assert inline prose preserved verbatim
and marker counts stay at 2/2 (1 inline + 1 section-position)
- CRLF handling — seed a CRLF file with inline prose + legitimate
section, run analyze, assert section replaced in place, inline
prose preserved, stale stub content removed
No destructive ops, no bypass flags, no new deps. Behaviour change
is strictly narrowing — files that previously updated correctly
still do; files that previously got corrupted now fall through to
the safer append branch.
Closes #1041.
346 lines
14 KiB
TypeScript
346 lines
14 KiB
TypeScript
/**
|
||
* AI Context Generator
|
||
*
|
||
* Creates AGENTS.md and CLAUDE.md with full inline GitNexus context.
|
||
* AGENTS.md is the standard read by Cursor, Windsurf, OpenCode, Codex, Cline, etc.
|
||
* CLAUDE.md is for Claude Code which only reads that file.
|
||
*/
|
||
|
||
import fs from 'fs/promises';
|
||
import path from 'path';
|
||
import { fileURLToPath } from 'url';
|
||
import { type GeneratedSkillInfo } from './skill-gen.js';
|
||
|
||
// ESM equivalent of __dirname
|
||
const __filename = fileURLToPath(import.meta.url);
|
||
const __dirname = path.dirname(__filename);
|
||
|
||
interface RepoStats {
|
||
files?: number;
|
||
nodes?: number;
|
||
edges?: number;
|
||
communities?: number;
|
||
clusters?: number; // Aggregated cluster count (what tools show)
|
||
processes?: number;
|
||
}
|
||
|
||
export interface AIContextOptions {
|
||
skipAgentsMd?: boolean;
|
||
noStats?: boolean;
|
||
}
|
||
|
||
const GITNEXUS_START_MARKER = '<!-- gitnexus:start -->';
|
||
const GITNEXUS_END_MARKER = '<!-- gitnexus:end -->';
|
||
|
||
/**
|
||
* Find the index of a section marker that occupies its own line.
|
||
* Unlike `indexOf`, this rejects inline prose references like
|
||
* `` See the `<!-- gitnexus:start -->` block `` that appear
|
||
* mid-sentence (#1041). A marker counts as section-position only when:
|
||
* - preceded by newline or start-of-file, AND
|
||
* - followed by newline, `\r` (CRLF files), or end-of-file.
|
||
* The generator always emits each marker alone on its line, so this
|
||
* matches every legitimate section and none of the inline mentions.
|
||
*
|
||
* `startFrom` lets the end-marker lookup start after the already-found
|
||
* start marker, avoiding a scan from 0 and guaranteeing we never pick
|
||
* up an end marker that appears earlier in the file than the start.
|
||
*/
|
||
function findSectionMarkerIndex(content: string, marker: string, startFrom = 0): number {
|
||
let idx = content.indexOf(marker, startFrom);
|
||
while (idx !== -1) {
|
||
const atLineStart = idx === 0 || content[idx - 1] === '\n';
|
||
const endPos = idx + marker.length;
|
||
const atLineEnd =
|
||
endPos === content.length || content[endPos] === '\n' || content[endPos] === '\r';
|
||
if (atLineStart && atLineEnd) return idx;
|
||
idx = content.indexOf(marker, idx + 1);
|
||
}
|
||
return -1;
|
||
}
|
||
|
||
/**
|
||
* Generate the full GitNexus context content.
|
||
*
|
||
* Design principles (learned from real agent behavior and industry research):
|
||
* - Inline critical workflows — skills are skipped 56% of the time (Vercel eval data)
|
||
* - Use RFC 2119 language (MUST, NEVER, ALWAYS) — models follow imperative rules
|
||
* - Three-tier boundaries (Always/When/Never) — proven to change model behavior
|
||
* - Keep under 120 lines — adherence degrades past 150 lines
|
||
* - Exact tool commands with parameters — vague directives get ignored
|
||
* - Self-review checklist — forces model to verify its own work
|
||
*/
|
||
async function findGroupsContainingRegistryName(registryName: string): Promise<string[]> {
|
||
const { listGroups, getDefaultGitnexusDir, getGroupDir } =
|
||
await import('../core/group/storage.js');
|
||
const { loadGroupConfig } = await import('../core/group/config-parser.js');
|
||
const names = await listGroups();
|
||
const hits: string[] = [];
|
||
for (const g of names) {
|
||
try {
|
||
const config = await loadGroupConfig(getGroupDir(getDefaultGitnexusDir(), g));
|
||
if (Object.values(config.repos).some((r) => r === registryName)) hits.push(config.name);
|
||
} catch {
|
||
// skip invalid or unreadable groups
|
||
}
|
||
}
|
||
return hits;
|
||
}
|
||
|
||
function generateGitNexusContent(
|
||
projectName: string,
|
||
stats: RepoStats,
|
||
generatedSkills?: GeneratedSkillInfo[],
|
||
groupNames?: string[],
|
||
noStats?: boolean,
|
||
): string {
|
||
const generatedRows =
|
||
generatedSkills && generatedSkills.length > 0
|
||
? generatedSkills
|
||
.map(
|
||
(s) =>
|
||
`| Work in the ${s.label} area (${s.symbolCount} symbols) | \`.claude/skills/generated/${s.name}/SKILL.md\` |`,
|
||
)
|
||
.join('\n')
|
||
: '';
|
||
|
||
const skillsTable = `| Task | Read this skill file |
|
||
|------|---------------------|
|
||
| Understand architecture / "How does X work?" | \`.claude/skills/gitnexus/gitnexus-exploring/SKILL.md\` |
|
||
| Blast radius / "What breaks if I change X?" | \`.claude/skills/gitnexus/gitnexus-impact-analysis/SKILL.md\` |
|
||
| Trace bugs / "Why is X failing?" | \`.claude/skills/gitnexus/gitnexus-debugging/SKILL.md\` |
|
||
| Rename / extract / split / refactor | \`.claude/skills/gitnexus/gitnexus-refactoring/SKILL.md\` |
|
||
| Tools, resources, schema reference | \`.claude/skills/gitnexus/gitnexus-guide/SKILL.md\` |
|
||
| Index, status, clean, wiki CLI commands | \`.claude/skills/gitnexus/gitnexus-cli/SKILL.md\` |${generatedRows ? '\n' + generatedRows : ''}`;
|
||
|
||
return `${GITNEXUS_START_MARKER}
|
||
# GitNexus — Code Intelligence
|
||
|
||
This project is indexed by GitNexus as **${projectName}**${noStats ? '' : ` (${stats.nodes || 0} symbols, ${stats.edges || 0} relationships, ${stats.processes || 0} execution flows)`}. Use the GitNexus MCP tools to understand code, assess impact, and navigate safely.
|
||
|
||
> If any GitNexus tool warns the index is stale, run \`npx gitnexus analyze\` in terminal first.
|
||
|
||
## Always Do
|
||
|
||
- **MUST run impact analysis before editing any symbol.** Before modifying a function, class, or method, run \`gitnexus_impact({target: "symbolName", direction: "upstream"})\` and report the blast radius (direct callers, affected processes, risk level) to the user.
|
||
- **MUST run \`gitnexus_detect_changes()\` before committing** to verify your changes only affect expected symbols and execution flows.
|
||
- **MUST warn the user** if impact analysis returns HIGH or CRITICAL risk before proceeding with edits.
|
||
- When exploring unfamiliar code, use \`gitnexus_query({query: "concept"})\` to find execution flows instead of grepping. It returns process-grouped results ranked by relevance.
|
||
- When you need full context on a specific symbol — callers, callees, which execution flows it participates in — use \`gitnexus_context({name: "symbolName"})\`.
|
||
|
||
## Never Do
|
||
|
||
- NEVER edit a function, class, or method without first running \`gitnexus_impact\` on it.
|
||
- NEVER ignore HIGH or CRITICAL risk warnings from impact analysis.
|
||
- NEVER rename symbols with find-and-replace — use \`gitnexus_rename\` which understands the call graph.
|
||
- NEVER commit changes without running \`gitnexus_detect_changes()\` to check affected scope.
|
||
|
||
## Resources
|
||
|
||
| Resource | Use for |
|
||
|----------|---------|
|
||
| \`gitnexus://repo/${projectName}/context\` | Codebase overview, check index freshness |
|
||
| \`gitnexus://repo/${projectName}/clusters\` | All functional areas |
|
||
| \`gitnexus://repo/${projectName}/processes\` | All execution flows |
|
||
| \`gitnexus://repo/${projectName}/process/{name}\` | Step-by-step execution trace |
|
||
|
||
${
|
||
groupNames && groupNames.length > 0
|
||
? `## Cross-Repo Groups
|
||
|
||
This repository is listed under GitNexus **group(s): ${groupNames.join(', ')}** (see \`~/.gitnexus/groups/\`). For cross-repo analysis, use MCP tools \`impact\`, \`query\`, and \`context\` with \`repo\` set to \`@<groupName>\` or \`@<groupName>/<memberPath>\` (paths match keys in that group’s \`group.yaml\`). Use \`group_list\` / \`group_sync\` for membership and sync. From the terminal: \`npx gitnexus group list\`, \`npx gitnexus group sync <name>\`, \`npx gitnexus group impact <name> --target <symbol> --repo <group-path>\`.
|
||
|
||
`
|
||
: ''
|
||
}## CLI
|
||
|
||
${skillsTable}
|
||
|
||
${GITNEXUS_END_MARKER}`;
|
||
}
|
||
|
||
/**
|
||
* Check if a file exists
|
||
*/
|
||
async function fileExists(filePath: string): Promise<boolean> {
|
||
try {
|
||
await fs.access(filePath);
|
||
return true;
|
||
} catch {
|
||
return false;
|
||
}
|
||
}
|
||
|
||
/**
|
||
* Create or update GitNexus section in a file
|
||
* - If file doesn't exist: create with GitNexus content
|
||
* - If file exists without GitNexus section: append
|
||
* - If file exists with GitNexus section: replace that section
|
||
*/
|
||
async function upsertGitNexusSection(
|
||
filePath: string,
|
||
content: string,
|
||
): Promise<'created' | 'updated' | 'appended'> {
|
||
const exists = await fileExists(filePath);
|
||
|
||
if (!exists) {
|
||
await fs.writeFile(filePath, content, 'utf-8');
|
||
return 'created';
|
||
}
|
||
|
||
const existingContent = await fs.readFile(filePath, 'utf-8');
|
||
|
||
// Check if GitNexus section already exists. Matching is restricted
|
||
// to markers that occupy their own line so that inline prose
|
||
// references (e.g. `` See the `<!-- gitnexus:start -->` block `` in
|
||
// the shipped CLAUDE.md) are NOT treated as section delimiters
|
||
// (#1041). The end-marker scan starts after the start-marker so it
|
||
// can never pick up an earlier end in the file.
|
||
const startIdx = findSectionMarkerIndex(existingContent, GITNEXUS_START_MARKER);
|
||
const endIdx = findSectionMarkerIndex(
|
||
existingContent,
|
||
GITNEXUS_END_MARKER,
|
||
startIdx === -1 ? 0 : startIdx,
|
||
);
|
||
|
||
if (startIdx !== -1 && endIdx !== -1 && endIdx > startIdx) {
|
||
// Replace existing section
|
||
const before = existingContent.substring(0, startIdx);
|
||
const after = existingContent.substring(endIdx + GITNEXUS_END_MARKER.length);
|
||
const newContent = before + content + after;
|
||
await fs.writeFile(filePath, newContent.trim() + '\n', 'utf-8');
|
||
return 'updated';
|
||
}
|
||
|
||
// Append new section
|
||
const newContent = existingContent.trim() + '\n\n' + content + '\n';
|
||
await fs.writeFile(filePath, newContent, 'utf-8');
|
||
return 'appended';
|
||
}
|
||
|
||
/**
|
||
* Install GitNexus skills to .claude/skills/gitnexus/
|
||
* Works natively with Claude Code, Cursor, and GitHub Copilot
|
||
*/
|
||
async function installSkills(repoPath: string): Promise<string[]> {
|
||
const skillsDir = path.join(repoPath, '.claude', 'skills', 'gitnexus');
|
||
const installedSkills: string[] = [];
|
||
|
||
// Skill definitions bundled with the package
|
||
const skills = [
|
||
{
|
||
name: 'gitnexus-exploring',
|
||
description:
|
||
'Use when the user asks how code works, wants to understand architecture, trace execution flows, or explore unfamiliar parts of the codebase. Examples: "How does X work?", "What calls this function?", "Show me the auth flow"',
|
||
},
|
||
{
|
||
name: 'gitnexus-debugging',
|
||
description:
|
||
'Use when the user is debugging a bug, tracing an error, or asking why something fails. Examples: "Why is X failing?", "Where does this error come from?", "Trace this bug"',
|
||
},
|
||
{
|
||
name: 'gitnexus-impact-analysis',
|
||
description:
|
||
'Use when the user wants to know what will break if they change something, or needs safety analysis before editing code. Examples: "Is it safe to change X?", "What depends on this?", "What will break?"',
|
||
},
|
||
{
|
||
name: 'gitnexus-refactoring',
|
||
description:
|
||
'Use when the user wants to rename, extract, split, move, or restructure code safely. Examples: "Rename this function", "Extract this into a module", "Refactor this class", "Move this to a separate file"',
|
||
},
|
||
{
|
||
name: 'gitnexus-guide',
|
||
description:
|
||
'Use when the user asks about GitNexus itself — available tools, how to query the knowledge graph, MCP resources, graph schema, or workflow reference. Examples: "What GitNexus tools are available?", "How do I use GitNexus?"',
|
||
},
|
||
{
|
||
name: 'gitnexus-cli',
|
||
description:
|
||
'Use when the user needs to run GitNexus CLI commands like analyze/index a repo, check status, clean the index, generate a wiki, or list indexed repos. Examples: "Index this repo", "Reanalyze the codebase", "Generate a wiki"',
|
||
},
|
||
];
|
||
|
||
for (const skill of skills) {
|
||
const skillDir = path.join(skillsDir, skill.name);
|
||
const skillPath = path.join(skillDir, 'SKILL.md');
|
||
|
||
try {
|
||
// Create skill directory
|
||
await fs.mkdir(skillDir, { recursive: true });
|
||
|
||
// Try to read from package skills directory
|
||
const packageSkillPath = path.join(__dirname, '..', '..', 'skills', `${skill.name}.md`);
|
||
let skillContent: string;
|
||
|
||
try {
|
||
skillContent = await fs.readFile(packageSkillPath, 'utf-8');
|
||
} catch {
|
||
// Fallback: generate minimal skill content
|
||
skillContent = `---
|
||
name: ${skill.name}
|
||
description: ${skill.description}
|
||
---
|
||
|
||
# ${skill.name.charAt(0).toUpperCase() + skill.name.slice(1)}
|
||
|
||
${skill.description}
|
||
|
||
Use GitNexus tools to accomplish this task.
|
||
`;
|
||
}
|
||
|
||
await fs.writeFile(skillPath, skillContent, 'utf-8');
|
||
installedSkills.push(skill.name);
|
||
} catch (err) {
|
||
// Skip on error, don't fail the whole process
|
||
console.warn(`Warning: Could not install skill ${skill.name}:`, err);
|
||
}
|
||
}
|
||
|
||
return installedSkills;
|
||
}
|
||
|
||
/**
|
||
* Generate AI context files after indexing
|
||
*/
|
||
export async function generateAIContextFiles(
|
||
repoPath: string,
|
||
_storagePath: string,
|
||
projectName: string,
|
||
stats: RepoStats,
|
||
generatedSkills?: GeneratedSkillInfo[],
|
||
options?: AIContextOptions,
|
||
): Promise<{ files: string[] }> {
|
||
const groupNames = await findGroupsContainingRegistryName(projectName);
|
||
const content = generateGitNexusContent(
|
||
projectName,
|
||
stats,
|
||
generatedSkills,
|
||
groupNames,
|
||
options?.noStats,
|
||
);
|
||
const createdFiles: string[] = [];
|
||
|
||
if (!options?.skipAgentsMd) {
|
||
// Create AGENTS.md (standard for Cursor, Windsurf, OpenCode, Cline, etc.)
|
||
const agentsPath = path.join(repoPath, 'AGENTS.md');
|
||
const agentsResult = await upsertGitNexusSection(agentsPath, content);
|
||
createdFiles.push(`AGENTS.md (${agentsResult})`);
|
||
|
||
// Create CLAUDE.md (for Claude Code)
|
||
const claudePath = path.join(repoPath, 'CLAUDE.md');
|
||
const claudeResult = await upsertGitNexusSection(claudePath, content);
|
||
createdFiles.push(`CLAUDE.md (${claudeResult})`);
|
||
} else {
|
||
createdFiles.push('AGENTS.md (skipped via --skip-agents-md)');
|
||
createdFiles.push('CLAUDE.md (skipped via --skip-agents-md)');
|
||
}
|
||
|
||
// Install skills to .claude/skills/gitnexus/
|
||
const installedSkills = await installSkills(repoPath);
|
||
if (installedSkills.length > 0) {
|
||
createdFiles.push(`.claude/skills/gitnexus/ (${installedSkills.length} skills)`);
|
||
}
|
||
|
||
return { files: createdFiles };
|
||
}
|