mirror of
https://github.com/abhigyanpatwari/GitNexus.git
synced 2026-08-28 05:25:25 +00:00
6f1cfffdd7
* Initial plan * chore(security): harden workflow permissions and pin Docker base image digests Agent-Logs-Url: https://github.com/abhigyanpatwari/GitNexus/sessions/2ddc8f2b-7355-48cf-9a0b-c06df66c3f47 * fix(security): restore permissions: {} on publish + release-candidate workflows These two release-publishing workflows had permissions: {} (the strictest valid form) before PR #1454, which replaced it with permissions: read-all. Every job in both files already declares its own permissions block, so the workflow-level default is only the safety net for future jobs added without one — read-all weakens that net for no benefit. Restore {} and the explanatory comment. Scorecard's TokenPermissions check accepts both forms, so this preserves U9 compliance. * fix(security): narrow permissions: read-all to contents: read on 13 workflows PR #1454 added permissions: read-all to 13 workflows that previously had no top-level permissions block. read-all is Scorecard-compliant but unnecessarily broad — every job in scope only needs contents:read at the workflow level (job-level blocks already grant the writes that any job actually performs). Snapshot of every job in the 13 workflows confirms contents:read is sufficient: - ci.yml: quality/tests/scope-parity have explicit contents:read job blocks; save-pr-meta uses upload-artifact only (no token scopes needed); ci-status is pure shell. - ci-e2e.yml, ci-quality.yml, ci-scope-parity.yml, ci-tests.yml: all jobs do checkout + npm + tsc/vitest/playwright/upload-artifact only; no API token scopes required. - claude.yml, codeql.yml, dependency-review.yml, docker.yml, gitleaks.yml, pr-labeler.yml, trivy.yml, workflow-lint.yml: all jobs already declare their own job-level blocks (security-events:write, pull-requests:write, packages:write, etc.) so the workflow-level default does not gate them. zizmor (--min-severity high) is clean on the resulting tree. Pre-existing medium findings (secrets-inherit, artipacked) are in unrelated workflows and untouched by this commit. scorecard.yml also uses read-all but pre-existed PR #1454 and is deferred to a follow-up PR per the plan's scope boundary. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Gergő Magyar <gergomagyar@icloud.com>
94 lines
2.9 KiB
YAML
94 lines
2.9 KiB
YAML
name: E2E Tests
|
|
|
|
on:
|
|
workflow_call:
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
jobs:
|
|
check-changes:
|
|
name: Check web module changes
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 5
|
|
outputs:
|
|
web_changed: ${{ steps.filter.outputs.web }}
|
|
steps:
|
|
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
|
|
- uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v3
|
|
id: filter
|
|
with:
|
|
filters: |
|
|
web:
|
|
- 'gitnexus-web/**'
|
|
|
|
e2e:
|
|
name: e2e (chromium)
|
|
needs: check-changes
|
|
if: needs.check-changes.result == 'success' && needs.check-changes.outputs.web_changed == 'true'
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 20
|
|
steps:
|
|
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
|
|
|
|
- name: Configure e2e GitNexus home
|
|
run: echo "GITNEXUS_HOME=${RUNNER_TEMP}/gitnexus-home" >> "$GITHUB_ENV"
|
|
|
|
- uses: ./.github/actions/setup-gitnexus-web
|
|
|
|
- name: Install Playwright browsers
|
|
run: npx playwright install --with-deps chromium
|
|
working-directory: gitnexus-web
|
|
|
|
- name: Install backend dependencies
|
|
run: npm ci
|
|
working-directory: gitnexus
|
|
|
|
- name: Build backend
|
|
run: npm run build
|
|
working-directory: gitnexus
|
|
|
|
- name: Analyze repository (index for backend)
|
|
run: |
|
|
E2E_REPO="${RUNNER_TEMP}/gitnexus-e2e-repo"
|
|
rm -rf "${E2E_REPO}"
|
|
mkdir -p "${E2E_REPO}"
|
|
cp -R gitnexus/test/fixtures/mini-repo/src "${E2E_REPO}/src"
|
|
printf '%s\n' '{"name":"e2e-mini-repo","version":"0.0.0","private":true}' > "${E2E_REPO}/package.json"
|
|
node gitnexus/dist/cli/index.js analyze "${E2E_REPO}" --skip-git --skip-agents-md --name e2e-mini-repo
|
|
if [ ! -d "${E2E_REPO}/.gitnexus" ]; then
|
|
echo "::error::No fixture .gitnexus index created"
|
|
exit 1
|
|
fi
|
|
|
|
- name: Start backend server
|
|
run: node dist/cli/index.js serve &
|
|
working-directory: gitnexus
|
|
|
|
- name: Wait for backend readiness
|
|
run: npx wait-on http://localhost:4747/api/repos --timeout 30000
|
|
working-directory: gitnexus-web
|
|
|
|
- name: Start Vite dev server
|
|
run: npm run dev &
|
|
working-directory: gitnexus-web
|
|
|
|
- name: Wait for Vite dev server
|
|
run: npx wait-on http://localhost:5173 --timeout 30000
|
|
working-directory: gitnexus-web
|
|
|
|
- name: Run E2E tests
|
|
run: npx playwright test
|
|
working-directory: gitnexus-web
|
|
env:
|
|
E2E: '1'
|
|
|
|
- name: Upload test results
|
|
if: always()
|
|
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
|
|
with:
|
|
name: e2e-results
|
|
path: |
|
|
gitnexus-web/test-results/
|
|
gitnexus-web/playwright-report/
|
|
retention-days: 5
|