import { describe, it, expect, beforeEach, afterEach } from 'vitest'; import { JobManager, isTerminalJobStatus, type AnalyzeJobPartialOutcome, } from '../../src/server/analyze-job.js'; describe('JobManager', () => { let manager: JobManager; beforeEach(() => { manager = new JobManager(); }); afterEach(() => { manager.dispose(); }); it('creates a job with queued status', () => { const job = manager.createJob({ repoUrl: 'https://github.com/user/repo' }); expect(job.id).toBeTruthy(); expect(job.status).toBe('queued'); expect(job.repoUrl).toBe('https://github.com/user/repo'); }); it('retrieves a job by id', () => { const created = manager.createJob({ repoUrl: 'https://github.com/user/repo' }); const retrieved = manager.getJob(created.id); expect(retrieved).toEqual(created); }); it('returns undefined for unknown job id', () => { expect(manager.getJob('nonexistent')).toBeUndefined(); }); it('enforces single-slot concurrency', () => { const job1 = manager.createJob({ repoUrl: 'https://github.com/user/repo1' }); manager.updateJob(job1.id, { status: 'analyzing' }); expect(() => manager.createJob({ repoUrl: 'https://github.com/user/repo2' })).toThrow( /already in progress/, ); }); it('allows new job after previous completes', () => { const job1 = manager.createJob({ repoUrl: 'https://github.com/user/repo1' }); manager.updateJob(job1.id, { status: 'analyzing' }); manager.updateJob(job1.id, { status: 'complete' }); const job2 = manager.createJob({ repoUrl: 'https://github.com/user/repo2' }); expect(job2.status).toBe('queued'); }); it('returns existing job for same repoUrl when active', () => { const job1 = manager.createJob({ repoUrl: 'https://github.com/user/repo' }); manager.updateJob(job1.id, { status: 'analyzing' }); const job2 = manager.createJob({ repoUrl: 'https://github.com/user/repo' }); expect(job2.id).toBe(job1.id); }); it('updates job progress', () => { const job = manager.createJob({ repoUrl: 'https://github.com/user/repo' }); manager.updateJob(job.id, { status: 'analyzing', progress: { phase: 'parsing', percent: 30, message: 'Parsing code' }, }); const updated = manager.getJob(job.id)!; expect(updated.status).toBe('analyzing'); expect(updated.progress.percent).toBe(30); }); it('emits progress events', () => { const job = manager.createJob({ repoUrl: 'https://github.com/user/repo' }); const events: any[] = []; manager.onProgress(job.id, (data) => events.push(data)); manager.updateJob(job.id, { progress: { phase: 'parsing', percent: 50, message: 'Parsing code' }, }); expect(events).toHaveLength(1); expect(events[0].percent).toBe(50); }); it('emits terminal event on complete', () => { const job = manager.createJob({ repoUrl: 'https://github.com/user/repo' }); const events: any[] = []; manager.onProgress(job.id, (data) => events.push(data)); manager.updateJob(job.id, { status: 'complete', repoName: 'repo' }); expect(events).toHaveLength(1); expect(events[0].phase).toBe('complete'); expect(events[0].percent).toBe(100); }); it('sets completedAt on terminal status', () => { const job = manager.createJob({ repoUrl: 'https://github.com/user/repo' }); manager.updateJob(job.id, { status: 'complete' }); expect(manager.getJob(job.id)!.completedAt).toBeDefined(); }); it('unsubscribe stops events', () => { const job = manager.createJob({ repoUrl: 'https://github.com/user/repo' }); const events: any[] = []; const unsub = manager.onProgress(job.id, (data) => events.push(data)); manager.updateJob(job.id, { progress: { phase: 'p1', percent: 10, message: 'm1' }, }); unsub(); manager.updateJob(job.id, { progress: { phase: 'p2', percent: 20, message: 'm2' }, }); expect(events).toHaveLength(1); }); it('cancelJob sets status to failed with reason', () => { const job = manager.createJob({ repoUrl: 'https://github.com/user/repo' }); manager.updateJob(job.id, { status: 'analyzing' }); const cancelled = manager.cancelJob(job.id, 'Cancelled by user'); expect(cancelled).toBe(true); expect(manager.getJob(job.id)!.status).toBe('failed'); expect(manager.getJob(job.id)!.error).toBe('Cancelled by user'); }); it('cancelJob aborts registered in-process work', () => { const job = manager.createJob({ repoPath: '/tmp/repo' }); manager.updateJob(job.id, { status: 'analyzing' }); const controller = new AbortController(); manager.registerAbortController(job.id, controller); manager.cancelJob(job.id, 'Cancelled by user'); expect(controller.signal.aborted).toBe(true); }); it('cancelJob returns false for terminal jobs', () => { const job = manager.createJob({ repoUrl: 'https://github.com/user/repo' }); manager.updateJob(job.id, { status: 'complete' }); expect(manager.cancelJob(job.id)).toBe(false); }); it('cancelJob returns false for unknown job', () => { expect(manager.cancelJob('nonexistent')).toBe(false); }); // #2264 P3: a job's terminal outcome is immutable, so a late worker message (a // SIGTERM-driven `error` after `complete`, or vice versa) cannot flip it. describe('terminal-state immutability (#2264 P3)', () => { it('keeps complete when a later failed update arrives', () => { const job = manager.createJob({ repoUrl: 'https://github.com/user/repo' }); manager.updateJob(job.id, { status: 'analyzing' }); manager.updateJob(job.id, { status: 'complete', repoName: 'repo' }); manager.updateJob(job.id, { status: 'failed', error: 'Analysis cancelled' }); expect(manager.getJob(job.id)!.status).toBe('complete'); }); it('keeps failed when a later complete update arrives', () => { const job = manager.createJob({ repoUrl: 'https://github.com/user/repo' }); manager.updateJob(job.id, { status: 'analyzing' }); manager.updateJob(job.id, { status: 'failed', error: 'Analysis cancelled' }); manager.updateJob(job.id, { status: 'complete', repoName: 'repo' }); const after = manager.getJob(job.id)!; expect(after.status).toBe('failed'); expect(after.error).toBe('Analysis cancelled'); }); it('emits no further event for a post-terminal update', () => { const job = manager.createJob({ repoUrl: 'https://github.com/user/repo' }); const events: Array<{ phase: string }> = []; manager.onProgress(job.id, (data) => events.push(data)); manager.updateJob(job.id, { status: 'complete', repoName: 'repo' }); manager.updateJob(job.id, { status: 'failed', error: 'late' }); expect(events).toHaveLength(1); expect(events[0].phase).toBe('complete'); }); }); /** * #2790: terminality is a property of the job's STATUS, and a terminal * `failed` job may still have persisted usable work. The SSE relay reads both * — `isTerminalJobStatus` to decide the stream is over, `partial` to tell a * client "retry these N nodes" apart from "nothing worked". */ describe('terminal status and partial outcomes (#2790)', () => { it('recognizes exactly the two settled statuses', () => { expect({ queued: isTerminalJobStatus('queued'), cloning: isTerminalJobStatus('cloning'), analyzing: isTerminalJobStatus('analyzing'), loading: isTerminalJobStatus('loading'), complete: isTerminalJobStatus('complete'), failed: isTerminalJobStatus('failed'), }).toEqual({ queued: false, cloning: false, analyzing: false, loading: false, complete: true, failed: true, }); }); const partial: AnalyzeJobPartialOutcome = { kind: 'embedding-partial', pendingNodeCount: 2, nodesProcessed: 10, }; it('records a partial outcome on a failed job without changing its status', () => { const job = manager.createJob({ repoPath: '/tmp/embed-partial' }); manager.updateJob(job.id, { status: 'analyzing' }); manager.updateJob(job.id, { status: 'failed', error: 'Embedding generation finished partially: 2 node(s) lost their embeddings.', partial, }); expect(manager.getJob(job.id)).toMatchObject({ status: 'failed', error: expect.stringContaining('finished partially'), partial: { kind: 'embedding-partial', pendingNodeCount: 2, nodesProcessed: 10 }, }); }); it('leaves a clean job with no partial marker at all', () => { const job = manager.createJob({ repoPath: '/tmp/embed-clean' }); manager.updateJob(job.id, { status: 'analyzing' }); manager.updateJob(job.id, { status: 'complete' }); // Absent, not `null`/`false` — JSON.stringify omits it, so the wire shape // of every non-partial job is unchanged. expect(manager.getJob(job.id)).toMatchObject({ status: 'complete' }); expect(manager.getJob(job.id)?.partial).toBeUndefined(); }); it('still emits exactly one terminal event when a partial outcome is attached', () => { const job = manager.createJob({ repoPath: '/tmp/embed-partial' }); const events: Array<{ phase: string; message: string }> = []; manager.updateJob(job.id, { status: 'analyzing' }); manager.onProgress(job.id, (data) => events.push(data)); manager.updateJob(job.id, { status: 'failed', error: 'Embedding generation finished partially: 2 node(s) lost their embeddings.', partial, progress: { phase: 'failed', percent: 100, message: 'partial' }, }); expect(events).toEqual([ { phase: 'failed', percent: 100, message: expect.stringContaining('finished partially') }, ]); }); }); });