/** * JavaScript: self/this resolution, parent resolution, super resolution */ import { describe, it, expect, beforeAll } from 'vitest'; import path from 'path'; import { FIXTURES, CROSS_FILE_FIXTURES, getRelationships, getNodesByLabel, getNodesByLabelFull, edgeSet, runPipelineFromRepo, type PipelineResult, } from './helpers.js'; // --------------------------------------------------------------------------- // Qualified (namespaced) base (#1951): `extends ns.Base` parses as a // class_heritage holding a member_expression (object: `ns`, property: `Base`). // An earlier synth (synthesizeJsInheritanceReferences) dropped member_expression // bases, emitting only for a direct identifier base, so production silently // omitted this EXTENDS edge. It is now resolved by the base's trailing // property_identifier (`Base`), matching the documented per-shape reduction. // `Plain extends Base` is the bare control (its simple-base handling is // unchanged). Scope-resolution owns these edges since #942. // --------------------------------------------------------------------------- describe('JavaScript qualified-base heritage resolution (#1951)', () => { let result: PipelineResult; beforeAll(async () => { result = await runPipelineFromRepo(path.join(FIXTURES, 'javascript-qualified-base'), () => {}); }, 60000); it('emits EXTENDS for the qualified base (ns.Base) and the bare control (Base)', () => { const extends_ = getRelationships(result, 'EXTENDS'); expect(edgeSet(extends_)).toEqual(['Plain → Base', 'Service → Base']); }); }); // --------------------------------------------------------------------------- // skipGraphPhases: verify pipeline works correctly when graph phases are skipped // --------------------------------------------------------------------------- describe('Pipeline skipGraphPhases option', () => { let result: PipelineResult; beforeAll(async () => { result = await runPipelineFromRepo( path.join(FIXTURES, 'javascript-self-this-resolution'), () => {}, { skipGraphPhases: true }, ); }, 60000); it('produces graph nodes without community/process phases', () => { expect(getNodesByLabel(result, 'Class').length).toBeGreaterThan(0); }); it('still resolves CALLS edges correctly', () => { const calls = getRelationships(result, 'CALLS'); expect(calls.length).toBeGreaterThan(0); }); it('omits communityResult when skipGraphPhases is true', () => { expect(result.communityResult).toBeUndefined(); }); it('omits processResult when skipGraphPhases is true', () => { expect(result.processResult).toBeUndefined(); }); }); // --------------------------------------------------------------------------- // this.save() resolves to enclosing class's own save method // --------------------------------------------------------------------------- describe('JavaScript this resolution', () => { let result: PipelineResult; beforeAll(async () => { result = await runPipelineFromRepo( path.join(FIXTURES, 'javascript-self-this-resolution'), () => {}, ); }, 60000); it('detects User and Repo classes, each with a save method', () => { expect(getNodesByLabel(result, 'Class')).toEqual(['Repo', 'User']); const saveMethods = getNodesByLabel(result, 'Method').filter((m) => m === 'save'); expect(saveMethods.length).toBe(2); }); it('resolves this.save() inside User.process to User.save, not Repo.save', () => { const calls = getRelationships(result, 'CALLS'); const saveCall = calls.find((c) => c.target === 'save' && c.source === 'process'); expect(saveCall).toBeDefined(); expect(saveCall!.targetFilePath).toBe('src/models/User.js'); }); }); // --------------------------------------------------------------------------- // Parent class resolution: EXTENDS edge // --------------------------------------------------------------------------- describe('JavaScript parent resolution', () => { let result: PipelineResult; beforeAll(async () => { result = await runPipelineFromRepo( path.join(FIXTURES, 'javascript-parent-resolution'), () => {}, ); }, 60000); it('detects BaseModel and User classes', () => { expect(getNodesByLabel(result, 'Class')).toEqual(['BaseModel', 'User']); }); it('emits EXTENDS edge: User → BaseModel', () => { const extends_ = getRelationships(result, 'EXTENDS'); expect(extends_.length).toBe(1); expect(extends_[0].source).toBe('User'); expect(extends_[0].target).toBe('BaseModel'); }); it('EXTENDS edge points to real graph node', () => { const extends_ = getRelationships(result, 'EXTENDS'); const target = result.graph.getNode(extends_[0].rel.targetId); expect(target).toBeDefined(); expect(target!.properties.name).toBe('BaseModel'); }); }); // --------------------------------------------------------------------------- // Nullable receiver: JSDoc @param {User | null} strips nullable via TypeEnv // --------------------------------------------------------------------------- describe('JavaScript nullable receiver resolution', () => { let result: PipelineResult; beforeAll(async () => { result = await runPipelineFromRepo(path.join(FIXTURES, 'js-nullable-receiver'), () => {}); }, 60000); it('detects User and Repo classes, both with save methods', () => { expect(getNodesByLabel(result, 'Class')).toEqual(['Repo', 'User']); const saveMethods = getNodesByLabel(result, 'Method').filter((m) => m === 'save'); expect(saveMethods.length).toBe(2); }); it('resolves user.save() to src/user.js via nullable-stripped JSDoc type', () => { const calls = getRelationships(result, 'CALLS'); const userSave = calls.find( (c) => c.target === 'save' && c.source === 'processEntities' && c.targetFilePath === 'src/user.js', ); expect(userSave).toBeDefined(); }); it('resolves repo.save() to src/repo.js via nullable-stripped JSDoc type', () => { const calls = getRelationships(result, 'CALLS'); const repoSave = calls.find( (c) => c.target === 'save' && c.source === 'processEntities' && c.targetFilePath === 'src/repo.js', ); expect(repoSave).toBeDefined(); }); it('emits exactly 2 save() CALLS edges (one per receiver type)', () => { const calls = getRelationships(result, 'CALLS'); const saveCalls = calls.filter((c) => c.target === 'save'); expect(saveCalls.length).toBe(2); }); it('each save() call resolves to a distinct file (no duplicates)', () => { const calls = getRelationships(result, 'CALLS'); const saveCalls = calls.filter((c) => c.target === 'save' && c.source === 'processEntities'); const files = saveCalls.map((c) => c.targetFilePath).sort(); expect(files).toEqual(['src/repo.js', 'src/user.js']); }); }); // --------------------------------------------------------------------------- // super.save() resolves to parent class's save method // --------------------------------------------------------------------------- describe('JavaScript super resolution', () => { let result: PipelineResult; beforeAll(async () => { result = await runPipelineFromRepo( path.join(FIXTURES, 'javascript-super-resolution'), () => {}, ); }, 60000); it('detects BaseModel, User, and Repo classes, each with a save method', () => { expect(getNodesByLabel(result, 'Class')).toEqual(['BaseModel', 'Repo', 'User']); const saveMethods = getNodesByLabel(result, 'Method').filter((m) => m === 'save'); expect(saveMethods.length).toBe(3); }); it('emits EXTENDS edge: User → BaseModel', () => { const extends_ = getRelationships(result, 'EXTENDS'); expect(extends_.length).toBe(1); expect(extends_[0].source).toBe('User'); expect(extends_[0].target).toBe('BaseModel'); }); it('resolves super.save() inside User to BaseModel.save, not Repo.save', () => { const calls = getRelationships(result, 'CALLS'); const superSave = calls.find( (c) => c.source === 'save' && c.target === 'save' && c.targetFilePath === 'src/models/Base.js', ); expect(superSave).toBeDefined(); const repoSave = calls.find( (c) => c.target === 'save' && c.targetFilePath === 'src/models/Repo.js', ); expect(repoSave).toBeUndefined(); }); }); // --------------------------------------------------------------------------- // Chained method calls: svc.getUser().save() // Tests that JavaScript chain call resolution correctly infers the intermediate // receiver type from getUser()'s JSDoc @returns {User} and resolves save(). // --------------------------------------------------------------------------- describe('JavaScript chained method call resolution', () => { let result: PipelineResult; beforeAll(async () => { result = await runPipelineFromRepo(path.join(FIXTURES, 'javascript-chain-call'), () => {}); }, 60000); it('detects User and Repo classes, and UserService', () => { const classes = getNodesByLabel(result, 'Class'); expect(classes).toContain('User'); expect(classes).toContain('Repo'); expect(classes).toContain('UserService'); }); it('detects getUser and save methods', () => { const methods = getNodesByLabel(result, 'Method'); expect(methods).toContain('getUser'); expect(methods).toContain('save'); }); it('resolves svc.getUser().save() to User#save via chain resolution', () => { const calls = getRelationships(result, 'CALLS'); const userSave = calls.find( (c) => c.target === 'save' && c.source === 'processUser' && c.targetFilePath?.includes('user.js'), ); expect(userSave).toBeDefined(); }); it('does NOT resolve svc.getUser().save() to Repo#save', () => { const calls = getRelationships(result, 'CALLS'); const repoSave = calls.find( (c) => c.target === 'save' && c.source === 'processUser' && c.targetFilePath?.includes('repo.js'), ); expect(repoSave).toBeUndefined(); }); }); // --------------------------------------------------------------------------- // Phase 8: Field/property type resolution — class field_definition capture // --------------------------------------------------------------------------- describe('Field type resolution (JavaScript)', () => { let result: PipelineResult; beforeAll(async () => { result = await runPipelineFromRepo(path.join(FIXTURES, 'js-field-types'), () => {}); }, 60000); it('detects classes: Address, Config, User', () => { expect(getNodesByLabel(result, 'Class')).toEqual(['Address', 'Config', 'User']); }); it('detects Property nodes for JS class fields', () => { const properties = getNodesByLabel(result, 'Property'); expect(properties).toContain('address'); expect(properties).toContain('name'); expect(properties).toContain('city'); }); it('emits HAS_PROPERTY edges linking fields to classes', () => { const propEdges = getRelationships(result, 'HAS_PROPERTY'); expect(propEdges.length).toBe(4); expect(edgeSet(propEdges)).toContain('User → address'); expect(edgeSet(propEdges)).toContain('User → name'); expect(edgeSet(propEdges)).toContain('Address → city'); expect(edgeSet(propEdges)).toContain('Config → DEFAULT'); }); it('populates field metadata (visibility, isStatic, isReadonly) on Property nodes', () => { const properties = getNodesByLabelFull(result, 'Property'); const city = properties.find((p) => p.name === 'city'); expect(city).toBeDefined(); expect(city!.properties.visibility).toBe('public'); expect(city!.properties.isStatic).toBe(false); expect(city!.properties.isReadonly).toBe(false); const addr = properties.find((p) => p.name === 'address'); expect(addr).toBeDefined(); expect(addr!.properties.visibility).toBe('public'); expect(addr!.properties.isStatic).toBe(false); expect(addr!.properties.isReadonly).toBe(false); }); it('marks Config.DEFAULT as static', () => { const properties = getNodesByLabelFull(result, 'Property'); const def = properties.find((p) => p.name === 'DEFAULT'); expect(def).toBeDefined(); expect(def!.properties.isStatic).toBe(true); expect(def!.properties.visibility).toBe('public'); }); }); // ACCESSES write edges from assignment expressions // --------------------------------------------------------------------------- describe('Write access tracking (JavaScript)', () => { let result: PipelineResult; beforeAll(async () => { result = await runPipelineFromRepo(path.join(FIXTURES, 'js-write-access'), () => {}); }, 60000); it('emits ACCESSES write edges for field assignments', () => { const accesses = getRelationships(result, 'ACCESSES'); const writes = accesses.filter((e) => e.rel.reason === 'write'); expect(writes.length).toBe(2); const fieldNames = writes.map((e) => e.target); expect(fieldNames).toContain('name'); expect(fieldNames).toContain('address'); const sources = writes.map((e) => e.source); expect(sources).toContain('updateUser'); }); it('write ACCESSES edges have confidence 1.0', () => { const accesses = getRelationships(result, 'ACCESSES'); const writes = accesses.filter((e) => e.rel.reason === 'write'); for (const edge of writes) { expect(edge.rel.confidence).toBe(1.0); } }); }); // --------------------------------------------------------------------------- // Phase A: JS object destructuring — const { field } = receiver → fieldAccess PendingAssignment // --------------------------------------------------------------------------- describe('JavaScript object destructuring resolution (Phase A)', () => { let result: PipelineResult; beforeAll(async () => { result = await runPipelineFromRepo(path.join(FIXTURES, 'js-object-destructuring'), () => {}); }, 60000); it('detects User, Address classes', () => { const classes = getNodesByLabel(result, 'Class'); expect(classes).toContain('User'); expect(classes).toContain('Address'); }); it('resolves address.save() to Address#save via object destructuring', () => { const calls = getRelationships(result, 'CALLS'); const saveCall = calls.find((c) => c.target === 'save' && c.targetFilePath.includes('models')); expect(saveCall).toBeDefined(); }); }); // --------------------------------------------------------------------------- // Phase A: Post-fixpoint for-loop replay — iterable resolved via callResult fixpoint // --------------------------------------------------------------------------- describe('JavaScript post-fixpoint for-loop replay (Phase A ex-9B)', () => { let result: PipelineResult; beforeAll(async () => { result = await runPipelineFromRepo(path.join(FIXTURES, 'js-fixpoint-for-loop'), () => {}); }, 60000); it('resolves u.save() to User#save via post-fixpoint for-loop replay', () => { const calls = getRelationships(result, 'CALLS'); const saveCall = calls.find( (c) => c.target === 'save' && c.source === 'process' && c.targetFilePath.includes('models'), ); expect(saveCall).toBeDefined(); }); }); // --------------------------------------------------------------------------- // Phase 14: Cross-file binding propagation // models.js exports getUser() returning User // app.js imports getUser, calls const u = getUser(); u.save(); u.getName() // → u is typed User via cross-file return type propagation // --------------------------------------------------------------------------- describe('JavaScript cross-file binding propagation', () => { let result: PipelineResult; beforeAll(async () => { result = await runPipelineFromRepo(path.join(CROSS_FILE_FIXTURES, 'js-cross-file'), () => {}); }, 60000); it('detects User class with save and getName methods', () => { expect(getNodesByLabel(result, 'Class')).toContain('User'); expect(getNodesByLabel(result, 'Method')).toContain('save'); expect(getNodesByLabel(result, 'Method')).toContain('getName'); }); it('detects getUser and run functions', () => { expect(getNodesByLabel(result, 'Function')).toContain('getUser'); expect(getNodesByLabel(result, 'Function')).toContain('run'); }); it('emits IMPORTS edge from app.js to models.js', () => { const imports = getRelationships(result, 'IMPORTS'); const edge = imports.find( (e) => e.sourceFilePath.includes('app') && e.targetFilePath.includes('models'), ); expect(edge).toBeDefined(); }); it('resolves u.save() in run() to User#save via cross-file return type propagation', () => { const calls = getRelationships(result, 'CALLS'); const saveCall = calls.find( (c) => c.target === 'save' && c.source === 'run' && c.targetFilePath.includes('models'), ); expect(saveCall).toBeDefined(); }); it('resolves u.getName() in run() to User#getName via cross-file return type propagation', () => { const calls = getRelationships(result, 'CALLS'); const getNameCall = calls.find( (c) => c.target === 'getName' && c.source === 'run' && c.targetFilePath.includes('models'), ); expect(getNameCall).toBeDefined(); }); it('emits HAS_METHOD edges linking save and getName to User', () => { const hasMethod = getRelationships(result, 'HAS_METHOD'); const saveEdge = hasMethod.find((e) => e.source === 'User' && e.target === 'save'); const getNameEdge = hasMethod.find((e) => e.source === 'User' && e.target === 'getName'); expect(saveEdge).toBeDefined(); expect(getNameEdge).toBeDefined(); }); }); // --------------------------------------------------------------------------- // Method enrichment: static, parameterTypes (no abstract in JS) // --------------------------------------------------------------------------- describe('JavaScript method enrichment', () => { let result: PipelineResult; beforeAll(async () => { result = await runPipelineFromRepo( path.join(FIXTURES, 'javascript-method-enrichment'), () => {}, ); }, 60000); it('detects Animal and Dog classes', () => { const classes = getNodesByLabel(result, 'Class'); expect(classes).toContain('Animal'); expect(classes).toContain('Dog'); }); it('emits HAS_METHOD edges for Animal methods', () => { const hasMethod = getRelationships(result, 'HAS_METHOD'); const animalMethods = hasMethod .filter((e) => e.source === 'Animal') .map((e) => e.target) .sort(); expect(animalMethods).toContain('speak'); expect(animalMethods).toContain('classify'); expect(animalMethods).toContain('breathe'); }); it('emits HAS_METHOD edge for Dog.speak', () => { const hasMethod = getRelationships(result, 'HAS_METHOD'); const dogSpeak = hasMethod.find((e) => e.source === 'Dog' && e.target === 'speak'); expect(dogSpeak).toBeDefined(); }); it('emits EXTENDS edge Dog -> Animal', () => { const extends_ = getRelationships(result, 'EXTENDS'); const dogExtends = extends_.find((e) => e.source === 'Dog' && e.target === 'Animal'); expect(dogExtends).toBeDefined(); }); it('marks classify as isStatic (conditional)', () => { const methods = getNodesByLabelFull(result, 'Function'); const classify = methods.find((n) => n.name === 'classify'); if (classify?.properties.isStatic !== undefined) { expect(classify.properties.isStatic).toBe(true); } }); it('marks breathe as NOT isStatic (conditional)', () => { const methods = getNodesByLabelFull(result, 'Function'); const breathe = methods.find((n) => n.name === 'breathe'); if (breathe?.properties.isStatic !== undefined) { expect(breathe.properties.isStatic).toBe(false); } }); it('resolves dog.speak() CALLS edge', () => { const calls = getRelationships(result, 'CALLS'); const speakCall = calls.find( (c) => c.target === 'speak' && c.sourceFilePath.includes('app.js'), ); expect(speakCall).toBeDefined(); }); it('resolves Animal.classify("dog") static CALLS edge', () => { const calls = getRelationships(result, 'CALLS'); const classifyCall = calls.find( (c) => c.target === 'classify' && c.sourceFilePath.includes('app.js'), ); expect(classifyCall).toBeDefined(); }); }); // --------------------------------------------------------------------------- // SM-9: inherited method resolution — child.parentMethod() via first-wins walk // --------------------------------------------------------------------------- describe('JavaScript Child extends Parent — inherited method resolution (SM-9)', () => { let result: PipelineResult; beforeAll(async () => { result = await runPipelineFromRepo( path.join(FIXTURES, 'javascript-child-extends-parent'), () => {}, ); }, 60000); it('detects Parent and Child classes', () => { const classes = getNodesByLabel(result, 'Class'); expect(classes).toContain('Parent'); expect(classes).toContain('Child'); }); it('emits EXTENDS edge: Child → Parent', () => { const extends_ = getRelationships(result, 'EXTENDS'); expect(edgeSet(extends_)).toContain('Child → Parent'); }); it('resolves c.parentMethod() to Parent.parentMethod via first-wins MRO walk', () => { const calls = getRelationships(result, 'CALLS'); const parentMethodCall = calls.find( (c) => c.target === 'parentMethod' && c.targetFilePath.includes('Parent.js'), ); expect(parentMethodCall).toBeDefined(); expect(parentMethodCall!.source).toBe('run'); }); }); // --------------------------------------------------------------------------- // Issue #1358: class-instance singleton (`export const x = new C()`) // PR #1718 closed the object-literal-shorthand sub-case; this fixture covers // the class-instance sub-case for JavaScript. Same resolution chain as TS but // the receiver type comes from the `new ClassName()` initializer (no JSDoc // annotation needed — the @type-binding.constructor capture handles it). // --------------------------------------------------------------------------- describe('JavaScript class-instance singleton resolution (issue #1358 sub-case)', () => { let result: PipelineResult; beforeAll(async () => { result = await runPipelineFromRepo( path.join(FIXTURES, 'javascript-class-instance-singleton'), () => {}, { skipGraphPhases: true }, ); }, 60000); it('detects FooService class, getUser method, caller function, fooService Const', () => { expect(getNodesByLabel(result, 'Class')).toContain('FooService'); expect(getNodesByLabel(result, 'Method')).toContain('getUser'); expect(getNodesByLabel(result, 'Function')).toContain('caller'); expect(getNodesByLabel(result, 'Const')).toContain('fooService'); }); it('emits HAS_METHOD edge from FooService to getUser', () => { const hasMethod = getRelationships(result, 'HAS_METHOD'); const fromClass = hasMethod.filter((e) => e.source === 'FooService').map((e) => e.target); expect(fromClass).toEqual(['getUser']); }); it('resolves caller.fooService.getUser() to FooService.getUser via constructor-inferred typeBinding', () => { const calls = getRelationships(result, 'CALLS'); const projected = calls .filter((e) => e.source === 'caller' && e.target === 'getUser') .map((e) => ({ targetFilePath: e.targetFilePath, reason: e.rel.reason, confidence: e.rel.confidence, })); expect(projected).toEqual([ { targetFilePath: 'src/service.js', reason: 'import-resolved', confidence: 0.85, }, ]); }); }); // --------------------------------------------------------------------------- // Issue #1358: factory-pattern singleton (`export const x = makeC()`) // Tests the @type-binding.alias chain-follow for JS — fooService aliases the // return of makeFooService(), whose JSDoc @returns {FooService} ties the chain // back to the class. Resolution propagates cross-file via // propagateImportedReturnTypes followChainPostFinalize. // --------------------------------------------------------------------------- describe('JavaScript factory-pattern singleton resolution (issue #1358 sub-case)', () => { let result: PipelineResult; beforeAll(async () => { result = await runPipelineFromRepo( path.join(FIXTURES, 'javascript-factory-singleton'), () => {}, { skipGraphPhases: true }, ); }, 60000); it('detects FooService class, makeFooService function, fooService Const, caller function', () => { expect(getNodesByLabel(result, 'Class')).toContain('FooService'); expect(getNodesByLabel(result, 'Function')).toContain('makeFooService'); expect(getNodesByLabel(result, 'Function')).toContain('caller'); expect(getNodesByLabel(result, 'Const')).toContain('fooService'); }); it('resolves caller.fooService.getUser() through the factory chain to FooService.getUser', () => { const calls = getRelationships(result, 'CALLS'); const projected = calls .filter((e) => e.source === 'caller' && e.target === 'getUser') .map((e) => ({ targetFilePath: e.targetFilePath, reason: e.rel.reason, confidence: e.rel.confidence, })); expect(projected).toEqual([ { targetFilePath: 'src/service.js', reason: 'import-resolved', confidence: 0.85, }, ]); }); });