import { afterAll, beforeAll, describe, it, expect } from 'vitest'; import { extractRepoName, getCloneDir, validateGitUrl, cloneOrPull, buildCloneArgs, normalizeGitUrlForCompare, assertRemoteMatchesRequestedUrl, } from '../../src/server/git-clone.js'; import path from 'node:path'; import os from 'node:os'; import fs from 'node:fs/promises'; import { spawn } from 'node:child_process'; import { getRemoteOriginUrl } from '../../src/storage/git.js'; describe('git-clone', () => { describe('extractRepoName', () => { it('extracts name from HTTPS URL', () => { expect(extractRepoName('https://github.com/user/my-repo.git')).toBe('my-repo'); }); it('extracts name from HTTPS URL without .git suffix', () => { expect(extractRepoName('https://github.com/user/my-repo')).toBe('my-repo'); }); it('extracts name from SSH URL', () => { expect(extractRepoName('git@github.com:user/my-repo.git')).toBe('my-repo'); }); it('handles trailing slashes', () => { expect(extractRepoName('https://github.com/user/my-repo/')).toBe('my-repo'); }); it('handles nested paths', () => { expect(extractRepoName('https://gitlab.com/group/subgroup/repo.git')).toBe('repo'); }); it('rejects URLs whose last segment is "..": prevents getCloneDir traversal escape', () => { // Without the safe-name pattern, a URL ending in `/..` would yield // `getCloneDir('..')` = `~/.gitnexus/repos/..` = `~/.gitnexus/`, breaking // out of the intended clone root. expect(() => extractRepoName('https://github.com/owner/repo:..')).toThrow( 'valid repository name', ); expect(() => extractRepoName('https://example.com/foo:..')).toThrow('valid repository name'); }); it('rejects URLs that yield a single dot', () => { expect(() => extractRepoName('https://example.com/foo:.')).toThrow('valid repository name'); }); it('rejects empty input', () => { expect(() => extractRepoName('')).toThrow('valid repository name'); }); it('handles many trailing slashes without polynomial-time blowup', () => { // Pathological input the previous /\\/+$/ regex was flagged for // (CodeQL js/polynomial-redos). The string-loop replacement is O(n). const url = 'https://example.com/repo' + '/'.repeat(10000); const start = performance.now(); expect(extractRepoName(url)).toBe('repo'); const elapsedMs = performance.now() - start; // Threshold of 500ms is intentionally loose to absorb slow CI runners // while still catching a true polynomial regression (which would take // multiple seconds on 10k slashes). expect(elapsedMs).toBeLessThan(500); }); it('strips leading dashes to prevent argument injection', () => { expect(extractRepoName('https://github.com/user/--upload-pack=payload.git')).toBe( 'upload-pack_payload', ); expect(extractRepoName('https://github.com/user/-repo')).toBe('repo'); }); it('sanitizes unsafe directory characters', () => { // sanitizeRepoName turns into _tag_ expect(extractRepoName('https://github.com/user/repo.git')).toBe('repo_tag_'); }); it('sanitizes shell metacharacters in URL segments', () => { // The split on /[/:]/ does not split on backslashes or other shell chars, // so a name like `repo;rm -rf /` would slip through without the pattern. // After fix/sanitize-repo-name, these are sanitized to underscores. expect(extractRepoName('https://example.com/foo:repo;rm')).toBe('repo_rm'); expect(extractRepoName('https://example.com/foo:repo$x')).toBe('repo_x'); }); it('sanitizes whitespace and backslashes', () => { expect(extractRepoName('https://example.com/foo:repo name')).toBe('repo_name'); expect(extractRepoName('https://example.com/foo:repo\\name')).toBe('repo_name'); }); }); describe('getCloneDir', () => { it('returns path under ~/.gitnexus/repos/', () => { const dir = getCloneDir('my-repo'); expect(dir).toContain('.gitnexus'); expect(dir).toMatch(/repos/); expect(dir).toContain('my-repo'); }); it('rejects ".." to prevent path-traversal escape from the clone root', () => { expect(() => getCloneDir('..')).toThrow('Invalid repository name'); expect(() => getCloneDir('.')).toThrow('Invalid repository name'); expect(() => getCloneDir('')).toThrow('Invalid repository name'); }); it('rejects names containing path separators', () => { expect(() => getCloneDir('foo/bar')).toThrow('Invalid repository name'); expect(() => getCloneDir('foo\\bar')).toThrow('Invalid repository name'); }); it('returned path is always a direct child of the clone root', () => { const cloneRoot = path.resolve(path.join(os.homedir(), '.gitnexus', 'repos')); const dir = getCloneDir('my-repo'); const rel = path.relative(cloneRoot, path.resolve(dir)); // path.relative from the parent to the child must be just the child name — // no .. and no path separators inside. expect(rel).toBe('my-repo'); }); }); describe('validateGitUrl', () => { it('allows valid HTTPS GitHub URLs', () => { expect(() => validateGitUrl('https://github.com/user/repo.git')).not.toThrow(); expect(() => validateGitUrl('https://github.com/user/repo')).not.toThrow(); }); it('allows valid HTTP URLs', () => { expect(() => validateGitUrl('http://gitlab.com/user/repo.git')).not.toThrow(); }); it('blocks SSH protocol', () => { expect(() => validateGitUrl('ssh://git@github.com/user/repo.git')).toThrow( 'Only https:// and http://', ); }); it('blocks file:// protocol', () => { expect(() => validateGitUrl('file:///etc/passwd')).toThrow('Only https:// and http://'); }); it('blocks IPv4 loopback', () => { expect(() => validateGitUrl('http://127.0.0.1/repo.git')).toThrow('private/internal'); expect(() => validateGitUrl('http://127.255.0.1/repo.git')).toThrow('private/internal'); }); it('blocks IPv6 loopback ::1', () => { // Node URL parser strips brackets: hostname is "::1" not "[::1]" expect(() => validateGitUrl('http://[::1]/repo.git')).toThrow('private/internal'); }); it('blocks IPv4 private ranges (10.x, 172.16-31.x, 192.168.x)', () => { expect(() => validateGitUrl('http://10.0.0.1/repo.git')).toThrow('private/internal'); expect(() => validateGitUrl('http://172.16.0.1/repo.git')).toThrow('private/internal'); expect(() => validateGitUrl('http://172.31.255.255/repo.git')).toThrow('private/internal'); expect(() => validateGitUrl('http://192.168.1.1/repo.git')).toThrow('private/internal'); }); it('blocks link-local addresses', () => { expect(() => validateGitUrl('http://169.254.1.1/repo.git')).toThrow('private/internal'); }); it('blocks cloud metadata hostname', () => { expect(() => validateGitUrl('http://metadata.google.internal/repo')).toThrow( 'private/internal', ); expect(() => validateGitUrl('http://metadata.azure.com/repo')).toThrow('private/internal'); }); it('blocks IPv6 ULA (fc/fd)', () => { expect(() => validateGitUrl('http://[fc00::1]/repo.git')).toThrow('private/internal'); expect(() => validateGitUrl('http://[fd12::1]/repo.git')).toThrow('private/internal'); }); it('blocks IPv6 link-local (fe80)', () => { expect(() => validateGitUrl('http://[fe80::1]/repo.git')).toThrow('private/internal'); }); it('blocks IPv4-mapped IPv6', () => { expect(() => validateGitUrl('http://[::ffff:127.0.0.1]/repo.git')).toThrow( 'private/internal', ); }); it('blocks IPv4-compatible IPv6 (RFC 4291 deprecated, ::w.x.y.z)', () => { // Node's URL parser collapses ::127.0.0.1 to ::7f00:1 — no ::ffff: marker, // but still routable to 127.0.0.1 on most stacks. expect(() => validateGitUrl('http://[::127.0.0.1]/repo.git')).toThrow('private/internal'); expect(() => validateGitUrl('http://[::7f00:1]/repo.git')).toThrow('private/internal'); // 169.254.169.254 (cloud metadata) embedded as IPv4-compatible expect(() => validateGitUrl('http://[::a9fe:a9fe]/repo.git')).toThrow('private/internal'); }); it('blocks IPv4-compatible IPv6 in expanded / zero-padded forms', () => { // The compressed-form check above relies on the WHATWG URL parser // normalising fully-expanded inputs to ::xxxx[:yyyy]. These cases pin // that assumption: if a future Node release stops collapsing them, a // bypass would silently re-open without these tests catching it. expect(() => validateGitUrl('http://[0:0:0:0:0:0:7f00:1]/repo.git')).toThrow( 'private/internal', ); expect(() => validateGitUrl('http://[0000:0000:0000:0000:0000:0000:7f00:0001]/repo.git'), ).toThrow('private/internal'); // Mixed notation: trailing IPv4 quad in an otherwise expanded address. expect(() => validateGitUrl('http://[0:0:0:0:0:0:127.0.0.1]/repo.git')).toThrow( 'private/internal', ); }); it('blocks NAT64 well-known prefix (64:ff9b::/96)', () => { // 64:ff9b::7f00:1 → 127.0.0.1 via NAT64 translation expect(() => validateGitUrl('http://[64:ff9b::7f00:1]/repo.git')).toThrow('private/internal'); expect(() => validateGitUrl('http://[64:ff9b::a9fe:a9fe]/repo.git')).toThrow( 'private/internal', ); // RFC 8215 local NAT64 prefix expect(() => validateGitUrl('http://[64:ff9b:1::1]/repo.git')).toThrow('private/internal'); }); it('blocks NAT64 with embedded RFC1918 addresses', () => { // The startsWith('64:ff9b:') check covers any embedded IPv4. These // explicit RFC1918 architectures document SSRF coverage for the full private // IPv4 surface — not just loopback and cloud metadata. expect(() => validateGitUrl('http://[64:ff9b::a00:1]/repo.git')).toThrow('private/internal'); // 10.0.0.1 expect(() => validateGitUrl('http://[64:ff9b::ac10:1]/repo.git')).toThrow('private/internal'); // 172.16.0.1 expect(() => validateGitUrl('http://[64:ff9b::c0a8:101]/repo.git')).toThrow( 'private/internal', ); // 192.168.1.1 }); it('blocks 6to4 prefix (2002::/16, RFC 3056)', () => { // 6to4 encodes an IPv4 address in bits 17-48, so 2002:WWXX:YYZZ::* // routes to W.X.Y.Z on 6to4-capable stacks. The protocol is deprecated // (RFC 7526), so the entire 2002::/16 block is defensively rejected. expect(() => validateGitUrl('http://[2002:7f00:1::1]/repo.git')).toThrow('private/internal'); // 127.0.0.1 expect(() => validateGitUrl('http://[2002:a9fe:a9fe::1]/repo.git')).toThrow( 'private/internal', ); // 169.254.169.254 expect(() => validateGitUrl('http://[2002:c0a8:101::1]/repo.git')).toThrow( 'private/internal', ); // 192.168.1.1 }); it('does not block valid public IPs (IPv4 and IPv6)', () => { expect(() => validateGitUrl('https://140.82.121.4/repo.git')).not.toThrow(); // Regression guard against over-blocking legitimate public IPv6. // Cloudflare DNS (2606:4700::/32) and Google DNS (2001:4860::/32) — // chosen because their prefixes don't collide with any block above. expect(() => validateGitUrl('https://[2606:4700:4700::1111]/repo.git')).not.toThrow(); expect(() => validateGitUrl('https://[2001:4860:4860::8888]/repo.git')).not.toThrow(); }); it('blocks CGN range (100.64.0.0/10)', () => { expect(() => validateGitUrl('http://100.64.0.1/repo.git')).toThrow('private/internal'); expect(() => validateGitUrl('http://100.127.255.255/repo.git')).toThrow('private/internal'); }); it('blocks benchmarking range (198.18.0.0/15)', () => { expect(() => validateGitUrl('http://198.18.0.1/repo.git')).toThrow('private/internal'); expect(() => validateGitUrl('http://198.19.255.255/repo.git')).toThrow('private/internal'); }); it('blocks numeric decimal IP encoding', () => { expect(() => validateGitUrl('http://2130706433/repo.git')).toThrow('private/internal'); }); it('blocks hex IP encoding', () => { expect(() => validateGitUrl('http://0x7f000001/repo.git')).toThrow('private/internal'); }); it('blocks 0.0.0.0', () => { expect(() => validateGitUrl('http://0.0.0.0/repo.git')).toThrow('private/internal'); }); }); describe('buildCloneArgs', () => { // Closes the test-coverage gap that PR #1325 review (HIGH finding 1) // identified for CodeQL js/second-order-command-line-injection alerts // #166/#167. The barrier these tests guard is the `--` separator that // prevents an option-like URL from being parsed by git as a flag. it('places `--` before the URL', () => { const args = buildCloneArgs('https://github.com/owner/repo.git', '/safe/target'); const dashDashIdx = args.indexOf('--'); const urlIdx = args.indexOf('https://github.com/owner/repo.git'); expect(dashDashIdx).toBeGreaterThan(-1); expect(urlIdx).toBeGreaterThan(dashDashIdx); }); it('treats an option-like URL as a positional argument, not a flag', () => { // The exact mitigation for second-order-command-line-injection: a URL // beginning with `--` must appear after the `--` separator so git // refuses to interpret it as `--upload-pack=evil`. const args = buildCloneArgs('--upload-pack=evil', '/safe/target'); const dashDashIdx = args.indexOf('--'); const urlIdx = args.indexOf('--upload-pack=evil'); expect(dashDashIdx).toBeGreaterThan(-1); expect(urlIdx).toBeGreaterThan(dashDashIdx); // And targetDir comes after URL, also positional. expect(args.indexOf('/safe/target')).toBeGreaterThan(urlIdx); }); it('preserves --depth 1 for shallow clones', () => { const args = buildCloneArgs('https://github.com/owner/repo.git', '/safe/target'); const depthIdx = args.indexOf('--depth'); expect(depthIdx).toBeGreaterThan(-1); expect(args[depthIdx + 1]).toBe('1'); // --depth must be before the `--` separator (it's an option, not a positional). expect(depthIdx).toBeLessThan(args.indexOf('--')); }); }); describe('cloneOrPull — containment barrier', () => { // Closes the test-coverage gap that PR #1325 review (HIGH finding 1) // identified for CodeQL js/path-injection alerts #176/#177/#178. The // barrier these tests guard is the path.relative containment check at // the entry of cloneOrPull, which must reject any targetDir not strictly // inside CLONE_ROOT before any filesystem or subprocess sink. // // These tests do NOT mock spawn — the barrier throws synchronously // before git is invoked, so the rejection is observable directly. const cloneRoot = path.resolve(path.join(os.homedir(), '.gitnexus', 'repos')); it('rejects an absolute target outside CLONE_ROOT', async () => { await expect(cloneOrPull('https://github.com/a/b.git', '/etc/passwd')).rejects.toThrow( 'Clone target must be a subdirectory', ); }); it('rejects CLONE_ROOT itself (the rel === "" branch)', async () => { await expect(cloneOrPull('https://github.com/a/b.git', cloneRoot)).rejects.toThrow( 'Clone target must be a subdirectory', ); }); it('rejects a parent-directory traversal attempt', async () => { await expect( cloneOrPull('https://github.com/a/b.git', path.join(cloneRoot, '..', 'escape')), ).rejects.toThrow('Clone target must be a subdirectory'); }); it('rejects a sibling directory with a common prefix (CLONE_ROOT-evil)', async () => { // Classic startsWith(root + sep) pitfall: '/x/repos' does not catch // '/x/repos-evil/...'. The path.relative idiom does, and the test // documents that property at the cloneOrPull boundary. await expect(cloneOrPull('https://github.com/a/b.git', cloneRoot + '-evil')).rejects.toThrow( 'Clone target must be a subdirectory', ); }); // Closes the SSRF-bypass vector that Codex's adversarial review on // PR #1325 surfaced: validateGitUrl was only called in the clone // branch. An attacker URL that shared a basename with an existing // clone would skip the SSRF check entirely on the pull path. // // The barrier-pass-but-validateGitUrl-throw case here works because // cloneOrPull validates the URL after the containment check and before // the existence probe, so the rejection fires regardless of whether // the target dir exists on disk. it('rejects URLs that fail validateGitUrl even when the target shape is valid', async () => { const fakeTarget = path.join(cloneRoot, 'name-that-does-not-exist'); await expect(cloneOrPull('http://127.0.0.1/repo.git', fakeTarget)).rejects.toThrow( 'private/internal', ); await expect(cloneOrPull('http://localhost/repo.git', fakeTarget)).rejects.toThrow( 'private/internal', ); await expect(cloneOrPull('file:///etc/passwd', fakeTarget)).rejects.toThrow( 'Only https:// and http://', ); }); }); describe('normalizeGitUrlForCompare', () => { it('strips trailing .git', () => { expect(normalizeGitUrlForCompare('https://github.com/owner/repo.git')).toBe( normalizeGitUrlForCompare('https://github.com/owner/repo'), ); }); it('strips trailing slashes', () => { expect(normalizeGitUrlForCompare('https://github.com/owner/repo/')).toBe( normalizeGitUrlForCompare('https://github.com/owner/repo'), ); expect(normalizeGitUrlForCompare('https://github.com/owner/repo///')).toBe( normalizeGitUrlForCompare('https://github.com/owner/repo'), ); }); it('lowercases the hostname but preserves path case', () => { expect(normalizeGitUrlForCompare('https://GitHub.com/owner/Repo.git')).toBe( normalizeGitUrlForCompare('https://github.com/owner/Repo'), ); // Different path case → distinct repos (hosts treat path as case-sensitive on the wire) expect(normalizeGitUrlForCompare('https://github.com/owner/repo')).not.toBe( normalizeGitUrlForCompare('https://github.com/owner/REPO'), ); }); it('strips default ports', () => { expect(normalizeGitUrlForCompare('https://github.com:443/owner/repo')).toBe( normalizeGitUrlForCompare('https://github.com/owner/repo'), ); expect(normalizeGitUrlForCompare('http://github.com:80/owner/repo')).toBe( normalizeGitUrlForCompare('http://github.com/owner/repo'), ); }); it('preserves non-default ports', () => { expect(normalizeGitUrlForCompare('https://git.corp:8443/owner/repo')).not.toBe( normalizeGitUrlForCompare('https://git.corp/owner/repo'), ); }); it('strips userinfo (basic auth) so equivalent URLs compare equal', () => { expect(normalizeGitUrlForCompare('https://user:pass@github.com/owner/repo.git')).toBe( normalizeGitUrlForCompare('https://github.com/owner/repo'), ); }); it('treats different hosts as distinct', () => { expect(normalizeGitUrlForCompare('https://github.com/owner/repo')).not.toBe( normalizeGitUrlForCompare('https://gitlab.com/owner/repo'), ); }); it('treats different paths on the same host as distinct', () => { expect(normalizeGitUrlForCompare('https://github.com/owner/repo')).not.toBe( normalizeGitUrlForCompare('https://github.com/attacker/repo'), ); }); }); describe('assertRemoteMatchesRequestedUrl', () => { // Closes the wrong-repo silent-analysis vector that Codex's adversarial // review on PR #1325 surfaced. Tests use a tmpdir-based fixture // (anywhere on disk — independent of CLONE_ROOT) so the helper can be // exercised without polluting the user's actual clone root. let fixtureDir: string; beforeAll(async () => { fixtureDir = await fs.mkdtemp(path.join(os.tmpdir(), 'gitnexus-remote-match-')); // git init + set remote.origin.url. We can't call git init via runGit // since it's private; spawn directly. await new Promise((resolve, reject) => { const proc = spawn('git', ['init', '--quiet'], { cwd: fixtureDir, stdio: 'ignore' }); proc.on('close', (code) => code === 0 ? resolve() : reject(new Error(`git init exit ${code}`)), ); proc.on('error', reject); }); await new Promise((resolve, reject) => { const proc = spawn( 'git', ['config', 'remote.origin.url', 'https://github.com/legitorg/myproject.git'], { cwd: fixtureDir, stdio: 'ignore' }, ); proc.on('close', (code) => code === 0 ? resolve() : reject(new Error(`git config exit ${code}`)), ); proc.on('error', reject); }); }); afterAll(async () => { await fs.rm(fixtureDir, { recursive: true, force: true }); }); it('accepts the requested URL when it matches the configured remote', async () => { await expect( assertRemoteMatchesRequestedUrl(fixtureDir, 'https://github.com/legitorg/myproject.git'), ).resolves.toBeUndefined(); }); it('accepts equivalent forms (with/without .git, trailing slash, default port)', async () => { await expect( assertRemoteMatchesRequestedUrl(fixtureDir, 'https://github.com/legitorg/myproject'), ).resolves.toBeUndefined(); await expect( assertRemoteMatchesRequestedUrl(fixtureDir, 'https://github.com/legitorg/myproject/'), ).resolves.toBeUndefined(); await expect( assertRemoteMatchesRequestedUrl( fixtureDir, 'https://github.com:443/legitorg/myproject.git', ), ).resolves.toBeUndefined(); }); // The exact wrong-repo vector from Codex's review: // existing clone → github.com/legitorg/myproject // request URL → gitlab.example/attacker/myproject // Both share the basename 'myproject'. Without this check, the pull // would succeed and analysis would return wrong-repo data. it('rejects a different host with the same basename', async () => { await expect( assertRemoteMatchesRequestedUrl( fixtureDir, 'https://gitlab.example/attacker/myproject.git', ), ).rejects.toThrow('not the requested URL'); }); it('rejects a different owner on the same host', async () => { await expect( assertRemoteMatchesRequestedUrl(fixtureDir, 'https://github.com/attacker/myproject.git'), ).rejects.toThrow('not the requested URL'); }); it('rejects when the directory has no remote.origin', async () => { const noRemoteDir = await fs.mkdtemp(path.join(os.tmpdir(), 'gitnexus-no-remote-')); try { await new Promise((resolve, reject) => { const proc = spawn('git', ['init', '--quiet'], { cwd: noRemoteDir, stdio: 'ignore' }); proc.on('close', (code) => code === 0 ? resolve() : reject(new Error(`git init exit ${code}`)), ); proc.on('error', reject); }); await expect( assertRemoteMatchesRequestedUrl(noRemoteDir, 'https://github.com/owner/repo.git'), ).rejects.toThrow('no remote.origin'); } finally { await fs.rm(noRemoteDir, { recursive: true, force: true }); } }); }); describe('getRemoteOriginUrl', () => { it('returns null for a directory that is not a git repository', async () => { const tmp = await fs.mkdtemp(path.join(os.tmpdir(), 'gitnexus-not-git-')); try { const result = await getRemoteOriginUrl(tmp); expect(result).toBeNull(); } finally { await fs.rm(tmp, { recursive: true, force: true }); } }); }); });