From f93c6df7d6780717c05c8ccde8ae05f7809e5d8d Mon Sep 17 00:00:00 2001 From: Mick Cooney Date: Sat, 17 Oct 2026 15:03:29 +0100 Subject: [PATCH] docs(r): name the one other backtick normaliser in the bare-name header The header said every comparison of a definition spelling with a symbol goes through rBareName. The NAMESPACE export check in import-resolvers/r.ts compares through its own stripBackticks, which removes every leading and trailing backtick, not one pair. Say so. Comment only. --- gitnexus/src/core/ingestion/languages/r/bare-name.ts | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/gitnexus/src/core/ingestion/languages/r/bare-name.ts b/gitnexus/src/core/ingestion/languages/r/bare-name.ts index ce23c7244..a15299497 100644 --- a/gitnexus/src/core/ingestion/languages/r/bare-name.ts +++ b/gitnexus/src/core/ingestion/languages/r/bare-name.ts @@ -2,9 +2,13 @@ * R lets any name be written in backticks (`` `%+%` ``, `` `my fn` ``, * `` `helper` ``); the symbol is the text between them. The graph and the scope * model keep a definition's name exactly as written, while NAMESPACE entries, - * roxygen tags and rename requests carry the symbol. Every place that compares - * the two spellings goes through {@link rBareName}, so there is one definition of - * "the same name". + * roxygen tags and rename requests carry the symbol. The scope, qualified-call, + * post-parse, rename and type code compare the two spellings through + * {@link rBareName}, so there is one definition of "the same name" there. The one + * other normaliser is `stripBackticks` in `import-resolvers/r.ts`, which removes + * every leading and trailing backtick from a NAMESPACE entry (a quoted + * `` "`x`" `` entry keeps its backticks after `normaliseArg`) before comparing it + * with a symbol. * * One pair of surrounding backticks is removed, in constant time. An escaped * backtick inside the name stays as written, as `normaliseArg` in