From ddc31ba72ef4b287023a0c2cd59b63763324e950 Mon Sep 17 00:00:00 2001 From: Gergo Magyar Date: Wed, 3 Jun 2026 02:44:41 +0000 Subject: [PATCH] test(ingestion): scope #1978 resolver tests to registry-primary leg; fix lint MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - helpers.ts: exclude the new #1978 C++/Ruby resolver tests from the legacy parity leg (LEGACY_RESOLVER_PARITY_EXPECTED_FAILURES). They PASS on legacy too — the fix lives in the SHARED structure phase, not the legacy resolution path — so this is a deliberate registry-primary-only scoping (not a legacy gap), keeping the legacy path untouched and uncoupled from the new node-identity behavior. - rust.test.ts: drop the `eslint-disable vitest/no-disabled-tests` directive. That rule isn't configured in this repo, so eslint errored "Definition for rule 'vitest/no-disabled-tests' was not found" and failed `quality / lint`. The describe.skip needs no disable directive. Co-Authored-By: Claude Opus 4.8 (1M context) --- .../test/integration/resolvers/helpers.ts | 22 +++++++++++++++++-- .../test/integration/resolvers/rust.test.ts | 3 ++- 2 files changed, 22 insertions(+), 3 deletions(-) diff --git a/gitnexus/test/integration/resolvers/helpers.ts b/gitnexus/test/integration/resolvers/helpers.ts index b45de25e8..b351846ec 100644 --- a/gitnexus/test/integration/resolvers/helpers.ts +++ b/gitnexus/test/integration/resolvers/helpers.ts @@ -255,8 +255,15 @@ const LEGACY_RESOLVER_PARITY_EXPECTED_FAILURES: Readonly([ // Ruby scope-resolution currently achieves 89/127 parity. // Tests listed here are scope-resolver-only correctness wins - // (pass under registry-primary, fail under legacy). Currently - // empty — all 127 tests pass under legacy mode. + // (pass under registry-primary, fail under legacy). + // + // #1978 qualified nested-type node identity. NOTE: these PASS under the + // legacy leg too — the fix is in the SHARED structure phase, not the legacy + // resolution path. They are excluded here by policy to keep the #1978 + // assertions registry-primary-only and avoid coupling the legacy parity leg + // to the new node-identity behavior. + 'owns from_outer / from_other through distinct Outer.Inner / Other.Inner nodes (R7)', + 'owns radius (attr_accessor) under the qualified Shapes.Circle node, no dangling (R7)', ]), swift: new Set([ // Swift scope-resolution achieves 77/77 baseline parity. The tests @@ -481,6 +488,17 @@ const LEGACY_RESOLVER_PARITY_EXPECTED_FAILURES: Readonly { let result: PipelineResult;