From d32ed0bf061f2c816ffbfe985b4a6edc50a1cc47 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gerg=C5=91=20Magyar?= Date: Sat, 31 Oct 2026 14:25:33 +0000 Subject: [PATCH] test: consolidate covered integration cases (#3792) Remove ten cases covered by stronger assertions on the same fixtures. Preserve three detector recall pairs and the unique COBOL source-value guard. Co-authored-by: Gergo Magyar --- .../resolvers/cobol-parsing-coverage.test.ts | 8 -------- gitnexus/test/integration/resolvers/dart.test.ts | 7 ------- gitnexus/test/integration/resolvers/go.test.ts | 8 -------- gitnexus/test/integration/resolvers/kotlin.test.ts | 8 -------- .../integration/resolvers/parameter-producer.test.ts | 6 ------ gitnexus/test/integration/resolvers/php.test.ts | 8 -------- gitnexus/test/integration/resolvers/ruby.test.ts | 8 -------- .../resolvers/typescript-hoc-wrapped.test.ts | 11 ----------- gitnexus/test/integration/resolvers/zig.test.ts | 4 ---- 9 files changed, 68 deletions(-) diff --git a/gitnexus/test/integration/resolvers/cobol-parsing-coverage.test.ts b/gitnexus/test/integration/resolvers/cobol-parsing-coverage.test.ts index 7b17c711a..a3a71e543 100644 --- a/gitnexus/test/integration/resolvers/cobol-parsing-coverage.test.ts +++ b/gitnexus/test/integration/resolvers/cobol-parsing-coverage.test.ts @@ -189,14 +189,6 @@ describe('COBOL parsing coverage (F17-F23)', () => { // F23: PERFORM TIMES + THRU on digit-leading targets // ===================================================================== describe('F23 — PERFORM TIMES and THRU', () => { - it('PERFORM 2000-PROCESS THRU 2100-CLEANUP resolves THRU target', () => { - const perfThruEdges = getRelationships(result, 'CALLS').filter( - (e) => e.rel.reason === 'cobol-perform-thru', - ); - const thruTargets = perfThruEdges.map((e) => e.target); - expect(thruTargets).toContain('2100-CLEANUP'); - }); - it('PERFORM with VARYING does NOT create spurious CALLS edge', () => { // PERFTIMS has PERFORM VARYING WS-COUNT FROM 1 BY 1... // VARYING is in PERFORM_KEYWORD_SKIP, so it should be skipped. diff --git a/gitnexus/test/integration/resolvers/dart.test.ts b/gitnexus/test/integration/resolvers/dart.test.ts index 3c4017a89..b17758457 100644 --- a/gitnexus/test/integration/resolvers/dart.test.ts +++ b/gitnexus/test/integration/resolvers/dart.test.ts @@ -290,13 +290,6 @@ describe.skipIf(!dartAvailable)('Dart method enrichment', () => { expect(speak!.properties.isAbstract).toBe(true); }); - it('marks breathe as NOT isAbstract', () => { - const methods = getNodesByLabelFull(result, 'Method'); - const breathe = methods.find((n) => n.name === 'breathe'); - expect(breathe).toBeDefined(); - expect(breathe!.properties.isAbstract).toBe(false); - }); - it('marks classify as isStatic', () => { const methods = getNodesByLabelFull(result, 'Method'); const classify = methods.find((n) => n.name === 'classify'); diff --git a/gitnexus/test/integration/resolvers/go.test.ts b/gitnexus/test/integration/resolvers/go.test.ts index 46c96e0b9..6606a5557 100644 --- a/gitnexus/test/integration/resolvers/go.test.ts +++ b/gitnexus/test/integration/resolvers/go.test.ts @@ -1705,17 +1705,9 @@ describe('Go pointer-receiver field chains (#2766)', () => { expect(calls()).toContain('RunLocal → DoWork'); }); - it('keeps resolving a value receiver', () => { - expect(calls()).toContain('RunFromValueReceiver → DoWork'); - }); - // U8: the same-package field receiver that previously produced an ACCESSES // edge to the method and no CALLS edge. Typing the base is what emits CALLS; // the ACCESSES now correctly targets the PROPERTY being read instead. - it('emits CALLS for a same-package field receiver, not ACCESSES alone', () => { - expect(calls()).toContain('RunSamePackage → Work'); - }); - it('retargets the field ACCESSES to the property, not the method', () => { // Unlabeled on purpose: the negative must reject `→ Work` under ANY target // kind, which the kind-qualified rows below cannot express. diff --git a/gitnexus/test/integration/resolvers/kotlin.test.ts b/gitnexus/test/integration/resolvers/kotlin.test.ts index f6a187420..1e42480aa 100644 --- a/gitnexus/test/integration/resolvers/kotlin.test.ts +++ b/gitnexus/test/integration/resolvers/kotlin.test.ts @@ -1511,14 +1511,6 @@ describe('Write access tracking (Kotlin)', () => { expect(scoreWrite!.source).toBe('updateUser'); }); - it('emits ACCESSES write edge for compound assignment (+=)', () => { - const accesses = getRelationships(result, 'ACCESSES'); - const writes = accesses.filter((e) => e.rel.reason === 'write'); - const scoreWrite = writes.find((e) => e.target === 'score'); - expect(scoreWrite).toBeDefined(); - expect(scoreWrite!.source).toBe('updateUser'); - }); - it('write ACCESSES edges have confidence 1.0', () => { const accesses = getRelationships(result, 'ACCESSES'); const writes = accesses.filter((e) => e.rel.reason === 'write'); diff --git a/gitnexus/test/integration/resolvers/parameter-producer.test.ts b/gitnexus/test/integration/resolvers/parameter-producer.test.ts index 662a65d01..2e2715438 100644 --- a/gitnexus/test/integration/resolvers/parameter-producer.test.ts +++ b/gitnexus/test/integration/resolvers/parameter-producer.test.ts @@ -52,12 +52,6 @@ describe('caller-derived parameter types (W2-2)', () => { ) .map((e) => e.rel.targetId); - it('types a bare parameter from its single caller', () => { - const targets = preciseTargetsOf('readSpike', 'consumer.js'); - expect(targets).toHaveLength(1); - expect(targets[0]).toContain('makeSpike.wickRatio'); - }); - it('does not reach the OTHER producer of the same field name', () => { // `makeCandle.wickRatio` exists and is a candidate for any name-based join. expect(preciseTargetsOf('readSpike', 'consumer.js')[0]).not.toContain('makeCandle'); diff --git a/gitnexus/test/integration/resolvers/php.test.ts b/gitnexus/test/integration/resolvers/php.test.ts index 0c6793b0f..da830a069 100644 --- a/gitnexus/test/integration/resolvers/php.test.ts +++ b/gitnexus/test/integration/resolvers/php.test.ts @@ -1493,14 +1493,6 @@ describe('Write access tracking (PHP)', () => { expect(countWrite!.source).toBe('updateUser'); }); - it('emits ACCESSES write edge for static property assignment', () => { - const accesses = getRelationships(result, 'ACCESSES'); - const writes = accesses.filter((e) => e.rel.reason === 'write'); - const countWrite = writes.find((e) => e.target === 'count'); - expect(countWrite).toBeDefined(); - expect(countWrite!.source).toBe('updateUser'); - }); - it('write ACCESSES edges have confidence 1.0', () => { const accesses = getRelationships(result, 'ACCESSES'); const writes = accesses.filter((e) => e.rel.reason === 'write'); diff --git a/gitnexus/test/integration/resolvers/ruby.test.ts b/gitnexus/test/integration/resolvers/ruby.test.ts index a5d36cc6e..8941a0793 100644 --- a/gitnexus/test/integration/resolvers/ruby.test.ts +++ b/gitnexus/test/integration/resolvers/ruby.test.ts @@ -1024,14 +1024,6 @@ describe('Write access tracking (Ruby)', () => { expect(scoreWrite!.source).toBe('update_user'); }); - it('emits ACCESSES write edge for compound assignment (operator_assignment)', () => { - const accesses = getRelationships(result, 'ACCESSES'); - const writes = accesses.filter((e) => e.rel.reason === 'write'); - const scoreWrite = writes.find((e) => e.target === 'score'); - expect(scoreWrite).toBeDefined(); - expect(scoreWrite!.source).toBe('update_user'); - }); - it('write ACCESSES edges have confidence 1.0', () => { const accesses = getRelationships(result, 'ACCESSES'); const writes = accesses.filter((e) => e.rel.reason === 'write'); diff --git a/gitnexus/test/integration/resolvers/typescript-hoc-wrapped.test.ts b/gitnexus/test/integration/resolvers/typescript-hoc-wrapped.test.ts index f5b86ec2d..da1cf4937 100644 --- a/gitnexus/test/integration/resolvers/typescript-hoc-wrapped.test.ts +++ b/gitnexus/test/integration/resolvers/typescript-hoc-wrapped.test.ts @@ -93,17 +93,6 @@ describe('TypeScript HOC-wrapped variable declarations', () => { expect(targets).toContain('fmt'); }); - it('useCallback: handleSubmit → doStuff (sibling const, separate caller)', () => { - // Two useCallback consts in the same file — each must be its own - // caller anchor (no leakage to the first sibling, the analogue of - // the multi-action-store regression in PR #1175). - const calls = getRelationships(result, 'CALLS').filter( - (c) => c.sourceFilePath === 'src/use-callback.ts' && c.target === 'doStuff', - ); - const fromHandleSubmit = calls.filter((c) => c.source === 'handleSubmit'); - expect(fromHandleSubmit.length, 'handleSubmit must call doStuff').toBeGreaterThan(0); - }); - it('useMemo: computed → doStuff (returns-a-value variant)', () => { // `const computed = useMemo(() => { return doStuff(42); }, [])`. // The arrow's body has a `return` statement — irrelevant to call diff --git a/gitnexus/test/integration/resolvers/zig.test.ts b/gitnexus/test/integration/resolvers/zig.test.ts index 4f796b731..08f739dc9 100644 --- a/gitnexus/test/integration/resolvers/zig.test.ts +++ b/gitnexus/test/integration/resolvers/zig.test.ts @@ -422,10 +422,6 @@ describe.skipIf(!zigAvailable)('Zig idioms (zig-idioms fixture)', () => { ]); }); - it('applies the callable gate through a HUB too', () => { - expect(valueRefs).not.toContain('JsApi → DEFAULT_NS'); - }); - it('applies the callable gate to a MODULE owner too', () => { // `dom_utils.DEFAULT_NS` is a module-scope constant. Widening the owner // channel must not widen what counts as a registration, or every