From b620773b1a3be87a1a91429d51140a2a44e18cb8 Mon Sep 17 00:00:00 2001 From: Gergo Magyar Date: Sun, 2 Aug 2026 11:50:25 +0000 Subject: [PATCH] fix(bench): escape the NUL separator so measure.mjs stays a text file MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The fingerprint key separator was written as a literal NUL byte instead of the `\u0000` escape. Git classifies any file containing a NUL as binary, so the whole bench showed as `Bin` with no diff on GitHub and could not be reviewed — the same defect this branch already fixed once before the tri-review. Escaping it is byte-for-byte equivalent at runtime (both produce U+0000), so the committed fingerprint is unchanged and `--check` still passes. Co-Authored-By: Claude Opus 5 (1M context) --- gitnexus/bench/cpp-qualified-ns/measure.mjs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gitnexus/bench/cpp-qualified-ns/measure.mjs b/gitnexus/bench/cpp-qualified-ns/measure.mjs index 06b6baee8..3354068d1 100644 --- a/gitnexus/bench/cpp-qualified-ns/measure.mjs +++ b/gitnexus/bench/cpp-qualified-ns/measure.mjs @@ -397,7 +397,7 @@ function outcomesOf(parsedFiles, sites) { callsite, ); outcomes.add( - `${siteKey(receiver, member, callsite)}${hit === undefined ? '' : hit === 'ambiguous' ? '' : hit.nodeId}`, + `${siteKey(receiver, member, callsite)}\u0000${hit === undefined ? '' : hit === 'ambiguous' ? '' : hit.nodeId}`, ); } return outcomes;