scriptoriumadmin/GitNexus
1
0
Fork 0
mirror of https://github.com/abhigyanpatwari/GitNexus.git synced 2026-09-23 00:41:36 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

fix(validation): Simplify keyGenerator function in createRouteLimiter

Browse source
This commit is contained in:
Sparsh 2026-05-16 10:54:40 +05:30
parent 67e14821f7
commit aa36869e7d
2 changed files with 2 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

BIN
gitnexus-desktop/build/icon.png
View file

Binary file not shown.
Side by side Swipe Overlay

Before

Width:  |  Height:  |  Size: 435 KiB

After

Width:  |  Height:  |  Size: 30 KiB

10
gitnexus/src/server/validation.ts
View file

@ -19,7 +19,7 @@
*/ */
import path from 'node:path'; import path from 'node:path';
import rateLimit, { type RateLimitRequestHandler, ipKeyGenerator } from 'express-rate-limit'; import rateLimit, { ipKeyGenerator, type RateLimitRequestHandler } from 'express-rate-limit';
import type { Request } from 'express'; import type { Request } from 'express';
/** /**
@ -138,9 +138,6 @@ export interface RouteLimiterOverrides {
* - keyGenerator: req.ip with a socket.remoteAddress fallback so abruptly * - keyGenerator: req.ip with a socket.remoteAddress fallback so abruptly
* closed connections do not trigger ERR_ERL_UNDEFINED_IP_ADDRESS * closed connections do not trigger ERR_ERL_UNDEFINED_IP_ADDRESS
* (which would 500 the request via Express's default error handler). * (which would 500 the request via Express's default error handler).
* The IP is passed through `ipKeyGenerator` so IPv6 addresses are
* normalised to their /56 subnet — without this, each IPv6 address
* gets its own counter and the limit is trivially bypassed (#1360).
* Caller must wire `app.set('trust proxy', ...)` correctly — see * Caller must wire `app.set('trust proxy', ...)` correctly — see
* createServer in api.ts. * createServer in api.ts.
* *
@ -154,10 +151,7 @@ export function createRouteLimiter(opts?: RouteLimiterOverrides): RateLimitReque
standardHeaders: 'draft-7', standardHeaders: 'draft-7',
legacyHeaders: false, legacyHeaders: false,
passOnStoreError: true, passOnStoreError: true,
keyGenerator: (req: Request) => { keyGenerator: (req: Request) => ipKeyGenerator(req.ip ?? req.socket?.remoteAddress ?? ''),
const ip = req.ip ?? req.socket?.remoteAddress;
return ip ? ipKeyGenerator(ip) : 'unknown';
},
message: { error: 'Too many requests, please try again later.' }, message: { error: 'Too many requests, please try again later.' },
...opts, ...opts,
}); });