From 9c6bb62adaeacb07ddb3ec209b0dfd3ffb0f9e6b Mon Sep 17 00:00:00 2001
From: azizur100389 <azizur100389@gmail.com>
Date: Thu, 7 May 2026 20:47:24 +0100
Subject: [PATCH] fix(test): update BM25 and calltool-dispatch mocks for
 FTSSearchResponse
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Align test mocks and assertions with the new FTSSearchResponse return
type from searchFTSFromLbug — destructure { results, ftsAvailable }
instead of treating the return value as a plain array.
---
 gitnexus/test/unit/bm25-search.test.ts       | 26 +++++++++++---------
 gitnexus/test/unit/calltool-dispatch.test.ts |  2 +-
 2 files changed, 16 insertions(+), 12 deletions(-)

diff --git a/gitnexus/test/unit/bm25-search.test.ts b/gitnexus/test/unit/bm25-search.test.ts
index 9b232688fe..03a5915998 100644
--- a/gitnexus/test/unit/bm25-search.test.ts
+++ b/gitnexus/test/unit/bm25-search.test.ts
@@ -42,20 +42,24 @@ describe('BM25 search', () => {
   });
 
   describe('searchFTSFromLbug', () => {
-    it('returns empty array when LadybugDB is not initialized', async () => {
-      // Without LadybugDB init, search should return empty (not crash)
-      const results = await searchFTSFromLbug('test query');
+    it('returns empty results when LadybugDB is not initialized', async () => {
+      // Simulate an uninitialized DB: queryFTS throws instead of returning rows
+      const { queryFTS } = await import('../../src/core/lbug/lbug-adapter.js');
+      vi.mocked(queryFTS).mockRejectedValue(new Error('DB not initialized'));
+
+      const { results, ftsAvailable } = await searchFTSFromLbug('test query');
       expect(Array.isArray(results)).toBe(true);
       expect(results).toHaveLength(0);
+      expect(ftsAvailable).toBe(false);
     });
 
     it('handles empty query', async () => {
-      const results = await searchFTSFromLbug('');
+      const { results } = await searchFTSFromLbug('');
       expect(Array.isArray(results)).toBe(true);
     });
 
     it('accepts custom limit parameter', async () => {
-      const results = await searchFTSFromLbug('test', 5);
+      const { results } = await searchFTSFromLbug('test', 5);
       expect(Array.isArray(results)).toBe(true);
     });
   });
@@ -105,7 +109,7 @@ describe('BM25 search', () => {
         .mockResolvedValueOnce([]) // Method
         .mockResolvedValueOnce([]); // Interface
 
-      const results = await searchFTSFromLbug('queryset');
+      const { results } = await searchFTSFromLbug('queryset');
 
       expect(results).toHaveLength(1);
       expect(results[0].filePath).toBe('src/views.py');
@@ -127,7 +131,7 @@ describe('BM25 search', () => {
         .mockResolvedValueOnce([]) // Method
         .mockResolvedValueOnce([]); // Interface
 
-      const results = await searchFTSFromLbug('model');
+      const { results } = await searchFTSFromLbug('model');
 
       expect(results).toHaveLength(1);
       expect(results[0].score).toBe(8); // 5+3
@@ -147,7 +151,7 @@ describe('BM25 search', () => {
         .mockResolvedValueOnce([]) // Method
         .mockResolvedValueOnce([]); // Interface
 
-      const results = await searchFTSFromLbug('util');
+      const { results } = await searchFTSFromLbug('util');
 
       expect(results).toHaveLength(1);
       expect(results[0].nodeIds).toEqual([]);
@@ -171,7 +175,7 @@ describe('BM25 search', () => {
         .mockResolvedValueOnce([]) // Method
         .mockResolvedValueOnce([]); // Interface
 
-      const results = await searchFTSFromLbug('auth');
+      const { results } = await searchFTSFromLbug('auth');
 
       expect(results).toHaveLength(1);
       // All 3 hits (scores 9+7+4=20) — each from a different table, all top-3
@@ -192,7 +196,7 @@ describe('BM25 search', () => {
         .mockResolvedValueOnce([]) // Method
         .mockResolvedValueOnce([]); // Interface
 
-      const results = await searchFTSFromLbug('fn');
+      const { results } = await searchFTSFromLbug('fn');
 
       expect(results[0].filePath).toBe('src/high.py');
       expect(results[1].filePath).toBe('src/low.py');
@@ -220,7 +224,7 @@ describe('BM25 search', () => {
         return [];
       });
 
-      const results = await searchFTSFromLbug('login', 5, REPO);
+      const { results } = await searchFTSFromLbug('login', 5, REPO);
 
       expect(results).toEqual([
         { filePath: 'src/auth.ts', score: 8, rank: 1, nodeIds: ['func:login'] },
diff --git a/gitnexus/test/unit/calltool-dispatch.test.ts b/gitnexus/test/unit/calltool-dispatch.test.ts
index aa422327be..ee18a81c87 100644
--- a/gitnexus/test/unit/calltool-dispatch.test.ts
+++ b/gitnexus/test/unit/calltool-dispatch.test.ts
@@ -61,7 +61,7 @@ vi.mock('../../src/core/platform/capabilities.js', async (importOriginal) => {
 
 // Also mock the search modules to avoid loading onnxruntime
 vi.mock('../../src/core/search/bm25-index.js', () => ({
-  searchFTSFromLbug: vi.fn().mockResolvedValue([]),
+  searchFTSFromLbug: vi.fn().mockResolvedValue({ results: [], ftsAvailable: true }),
 }));
 
 vi.mock('../../src/mcp/core/embedder.js', () => ({