scriptoriumadmin/GitNexus
1
0
Fork 0
mirror of https://github.com/abhigyanpatwari/GitNexus.git synced 2026-10-06 02:49:56 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

refactor(impact): narrow PdgImpactResult instead of as any for slice fields

Browse source 
The dispatch read reachableBlocks/seedBlocks and the composer read pdgEvidence
via `(pdgResult as any)`. Replace both with a discriminated-union narrow: the
slice fields live only on the success/empty results, so narrowing with the same
`'error' in / 'pdgLayer' in` guard the composer already uses yields the typed
string[] / PdgImpactEvidenceSummary without a cast. No `as any` remain on
pdgResult; behaviour is unchanged.

Addresses PR #2227 tri-review finding (maintainability) and the strict-typing
requirement.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Gergo Magyar 2026-06-18 16:06:28 +00:00
parent 909a4401d6
commit 7955a534e2
1 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
gitnexus/src/mcp/local/local-backend.ts
View file

@ -4798,8 +4798,13 @@ export class LocalBackend {
// yet `reachableBlocks` excludes the seed by the seed-minus-reachable
// convention. Upstream seeds carry no discriminating slice, so the bridge
// falls back to preserving callgraph reach.
const reachableBlocks = ((pdgResult as any).reachableBlocks ?? []) as string[];
const seedBlocks = ((pdgResult as any).seedBlocks ?? []) as string[];
// `_runImpactPDG` returns the PdgImpactResult union; only the success/empty
// slice results carry reachableBlocks/seedBlocks (degraded and error results
// do not). Narrow via the same discriminant the composer uses, then read the
// typed string[] slices — no `as any`.
const sliceResult = 'error' in pdgResult || 'pdgLayer' in pdgResult ? null : pdgResult;
const reachableBlocks: string[] = sliceResult?.reachableBlocks ?? [];
const seedBlocks: string[] = sliceResult?.seedBlocks ?? [];
const sliceBlocks = [...seedBlocks, ...reachableBlocks];
const sliceCalleeNames =
direction === 'downstream' && sliceBlocks.length > 0
@ -5042,7 +5047,10 @@ export class LocalBackend {
: {}),
...(errorMessage ? { interproceduralError: errorMessage } : {}),
pdgEvidence: {
...((pdgResult as any).pdgEvidence ?? {}),
// pdgResult is narrowed to the success/empty slice result by the
// `'error' in / 'pdgLayer' in` guard at the top of this method, so
// `pdgEvidence` is typed (optional) — no `as any`.
...(pdgResult.pdgEvidence ?? {}),
...(interproceduralEvidence ? { interprocedural: interproceduralEvidence } : {}),
interproceduralEvidenceCounts,
},