scriptoriumadmin/GitNexus
1
0
Fork 0
mirror of https://github.com/abhigyanpatwari/GitNexus.git synced 2026-09-24 00:51:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

fix(hooks): distinguish EPERM from ESRCH in PID liveness check

Browse source 
Cursor Bugbot caught a contradiction with the stated design: the bare
`catch` after `process.kill(owner, 0)` was treating EPERM (process exists
but owned by another user) the same as ESRCH (process gone), which would
evict a live slot whenever the lock dir straddled user boundaries.

Inspect the error code: ESRCH → dead, evict; EPERM → still alive, keep
the slot; anything else → assume alive (be conservative under unexpected
failure rather than over-evict).

Applied to all three hook variants.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
abhigyantrumio 2026-05-12 20:00:51 +05:30
parent e11077b35b
commit 5bacf5a4b6
3 changed files with 27 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
gitnexus-claude-plugin/hooks/gitnexus-hook.js
View file

@ -248,8 +248,15 @@ function acquireHookSlot(gitNexusDir) {
try {
process.kill(owner, 0);
isLive = true;
} catch {
/* ESRCH (or EPERM under cross-user) — treat as dead */
} catch (e) {
// ESRCH = process gone → treat as dead. EPERM = process exists
// but owned by another user (cross-user lock dir) → still alive,
// keep the slot. Anything else: be conservative, assume alive.
if (e && e.code === 'ESRCH') {
isLive = false;
} else {
isLive = true;
}
}
}
}

11
gitnexus-cursor-integration/hooks/gitnexus-hook.cjs
View file

@ -278,8 +278,15 @@ function acquireHookSlot(gitNexusDir) {
try {
process.kill(owner, 0);
isLive = true;
} catch {
/* ESRCH (or EPERM under cross-user) — treat as dead */
} catch (e) {
// ESRCH = process gone → treat as dead. EPERM = process exists
// but owned by another user (cross-user lock dir) → still alive,
// keep the slot. Anything else: be conservative, assume alive.
if (e && e.code === 'ESRCH') {
isLive = false;
} else {
isLive = true;
}
}
}
}

11
gitnexus/hooks/claude/gitnexus-hook.cjs
View file

@ -248,8 +248,15 @@ function acquireHookSlot(gitNexusDir) {
try {
process.kill(owner, 0);
isLive = true;
} catch {
/* ESRCH (or EPERM under cross-user) — treat as dead */
} catch (e) {
// ESRCH = process gone → treat as dead. EPERM = process exists
// but owned by another user (cross-user lock dir) → still alive,
// keep the slot. Anything else: be conservative, assume alive.
if (e && e.code === 'ESRCH') {
isLive = false;
} else {
isLive = true;
}
}
}
}