scriptoriumadmin/GitNexus
1
0
Fork 0
mirror of https://github.com/abhigyanpatwari/GitNexus.git synced 2026-10-04 02:31:36 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

fix: replace spread-push with loop to prevent stack overflow on large repos

Browse source 
`array.push(...largeArray)` spreads every element as a function argument,
which exceeds V8's call-stack limit when the chunk contains tens of
thousands of call/heritage/assignment records. This consistently crashes
`gitnexus analyze` on large codebases.

Replace all 11 spread-push instances in the pipeline's chunk-accumulation
loop with a `safePushAll()` helper that pushes one element at a time,
avoiding stack overflow regardless of array size.
This commit is contained in:
Hardik Jain 2026-04-05 21:21:01 +05:30
parent 10f8815639
commit 58885c1187
1 changed files with 26 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

38
gitnexus/src/core/ingestion/pipeline.ts
View file

@ -72,6 +72,18 @@ import { fileURLToPath, pathToFileURL } from 'node:url';
const isDev = process.env.NODE_ENV === 'development';
/**
* Append all elements from `source` into `target` without using the spread
* operator. `target.push(...source)` converts every element into a function
* argument which exceeds V8's call-stack limit when `source` has more than
* ~65 000 entries (common in large Ruby/Rails monoliths).
*/
function safePushAll<T>(target: T[], source: readonly T[]): void {
for (let i = 0; i < source.length; i++) {
target.push(source[i]);
}
}
const EXPO_NAV_PATTERNS = [
/router\.(push|replace|navigate)\(\s*['"`]([^'"`]+)['"`]/g,
/<Link\s+[^>]*href=\s*['"`]([^'"`]+)['"`]/g,
@ -879,12 +891,14 @@ async function runChunkedParseAndResolve(
);
}
}
for (const _item of chunkWorkerData.calls) deferredWorkerCalls.push(_item);
for (const _item of chunkWorkerData.heritage) deferredWorkerHeritage.push(_item);
for (const _item of chunkWorkerData.constructorBindings)
deferredConstructorBindings.push(_item);
// Use safe array concatenation to avoid stack overflow on large repos.
// `push(...arr)` spreads every element as a function argument, which
// exceeds V8's call-stack limit when `arr` has tens of thousands of entries.
safePushAll(deferredWorkerCalls, chunkWorkerData.calls);
safePushAll(deferredWorkerHeritage, chunkWorkerData.heritage);
safePushAll(deferredConstructorBindings, chunkWorkerData.constructorBindings);
if (chunkWorkerData.assignments?.length) {
for (const _item of chunkWorkerData.assignments) deferredAssignments.push(_item);
safePushAll(deferredAssignments, chunkWorkerData.assignments);
}
// Heritage + Routes — calls deferred until all chunks have contributed heritage
@ -919,23 +933,23 @@ async function runChunkedParseAndResolve(
]);
// Collect TypeEnv file-scope bindings for exported type enrichment
if (chunkWorkerData.typeEnvBindings?.length) {
for (const _item of chunkWorkerData.typeEnvBindings) workerTypeEnvBindings.push(_item);
safePushAll(workerTypeEnvBindings, chunkWorkerData.typeEnvBindings);
}
// Collect fetch() calls for Next.js route matching
if (chunkWorkerData.fetchCalls?.length) {
for (const _item of chunkWorkerData.fetchCalls) allFetchCalls.push(_item);
safePushAll(allFetchCalls, chunkWorkerData.fetchCalls);
}
if (chunkWorkerData.routes?.length) {
for (const _item of chunkWorkerData.routes) allExtractedRoutes.push(_item);
safePushAll(allExtractedRoutes, chunkWorkerData.routes);
}
if (chunkWorkerData.decoratorRoutes?.length) {
for (const _item of chunkWorkerData.decoratorRoutes) allDecoratorRoutes.push(_item);
safePushAll(allDecoratorRoutes, chunkWorkerData.decoratorRoutes);
}
if (chunkWorkerData.toolDefs?.length) {
for (const _item of chunkWorkerData.toolDefs) allToolDefs.push(_item);
safePushAll(allToolDefs, chunkWorkerData.toolDefs);
}
if (chunkWorkerData.ormQueries?.length) {
for (const _item of chunkWorkerData.ormQueries) allORMQueries.push(_item);
safePushAll(allORMQueries, chunkWorkerData.ormQueries);
}
} else {
await processImports(graph, chunkFiles, astCache, ctx, undefined, repoPath, allPaths);
@ -1024,7 +1038,7 @@ async function runChunkedParseAndResolve(
// Extract fetch() calls for Next.js route matching (sequential path)
const chunkFetchCalls = await extractFetchCallsFromFiles(chunkFiles, astCache);
if (chunkFetchCalls.length > 0) {
for (const _item of chunkFetchCalls) allFetchCalls.push(_item);
safePushAll(allFetchCalls, chunkFetchCalls);
}
// Extract ORM queries (sequential path)
for (const f of chunkFiles) {